coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/brya/var/vell: Change AMP driver setting
by Robert Chen (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Kevin Chiu, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Angel Pons, Nick Vaccaro, Shon Wang, Name of user not set #1004174. Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 ) Change subject: mb/google/brya/var/vell: Change AMP driver setting ...................................................................... Patch Set 34: (1 comment) File src/mainboard/google/brya/variants/vell/overridetree.cb: https://review.coreboot.org/c/coreboot/+/60331/comment/2cfe6f6a_5b144e1d PS32, Line 177: register "boost_peak_milliamp" = "4500" : register "boost_ind_nanohenry" = "BOOST_IND_1000_NH" : register "boost_cap_microfarad" = "24" > We tried this makes i2c cannot get signal We tried remove this makes i2c cannot get signal -- To view, visit https://review.coreboot.org/c/coreboot/+/60331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c Gerrit-Change-Number: 60331 Gerrit-PatchSet: 34 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Name of user not set #1004174 Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Name of user not set #1004174 Gerrit-Comment-Date: Fri, 04 Mar 2022 07:57:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Name of user not set #1004174 Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Change AMP driver setting
by Robert Chen (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Kevin Chiu, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Angel Pons, Nick Vaccaro, Shon Wang, Name of user not set #1004174. Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 ) Change subject: mb/google/brya/var/vell: Change AMP driver setting ...................................................................... Patch Set 34: (1 comment) File src/mainboard/google/brya/variants/vell/overridetree.cb: https://review.coreboot.org/c/coreboot/+/60331/comment/fbe2a581_7336ccea PS32, Line 177: register "boost_peak_milliamp" = "4500" : register "boost_ind_nanohenry" = "BOOST_IND_1000_NH" : register "boost_cap_microfarad" = "24" > Done We tried this makes i2c cannot get signal -- To view, visit https://review.coreboot.org/c/coreboot/+/60331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c Gerrit-Change-Number: 60331 Gerrit-PatchSet: 34 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Name of user not set #1004174 Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Name of user not set #1004174 Gerrit-Comment-Date: Fri, 04 Mar 2022 07:55:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Name of user not set #1004174 Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Include Meteorlake device IDs
by Subrata Banik (Code Review) 04 Mar '22

04 Mar '22

1 0

Change in coreboot[master]: soc/intel/common: Include Meteorlake device IDs
by Subrata Banik (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Jamie Ryu, Wonkyu Kim, Ethan Tsao, Ravishankar Sarawadi, Rizwan Qureshi, Tim Wawrzynczak, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62581 ) Change subject: soc/intel/common: Include Meteorlake device IDs ...................................................................... Patch Set 1: (17 comments) File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/62581/comment/ea87e1c5_b3574058 PS1, Line 3078: PCI_DEVICE_ID_INTEL_MTL_ESPI_0 This is what EDS is saying, do we need to add all of these eSPI Controller 0 / 31 / 0 7E00h - 7E1Fh https://review.coreboot.org/c/coreboot/+/62581/comment/ae4657fb_22849005 PS1, Line 3431: #define PCI_DEVICE_ID_INTEL_MTL_PCIE_RP9 0x7e4d : #define PCI_DEVICE_ID_INTEL_MTL_PCIE_RP10 0x7eca : #define PCI_DEVICE_ID_INTEL_MTL_PCIE_RP11 0x7ecb : #define PCI_DEVICE_ID_INTEL_MTL_PCIE_RP12 0x7ecc I have some confusion here 1. EDS only mentioned about RPs between (0 / 28 / 0) - (0 / 28 / 7) 2. Unlike, ADL (as below), I'm unable to find D29/Fx RPs in the EDS. D28/F0 = Port1 D28/F1 = Port2 D28/F2 = Port3 D28/F3 = Port4 D28/F4 = Port5 D28/F5 = Port6 D28/F6 = Port7 D28/F7 = Port8 D29/F0 = Port9 D29/F1 = Port10 D29/F2 = Port11 D29/F3 = Port12 3. Finally, 0x7e4d is not PCH RP, rather it's CPU RP (PEG 1 and 0/6/x), Typically, we try to use CPU name (example: PCI_DEVICE_ID_INTEL_ADL_P_PCIE_RPx for CPU RPs) and PCH name (example: PCI_DEVICE_ID_INTEL_ADP_P_PCIE_RPx for PCH RPs). I can understand for MTL, we don't have PCH die hence, you can use SoC die name which is replacement of PCH in similar manner. I'm seeing this PCIe RP DIDs as /* CPU RPs */ #define PCI_DEVICE_ID_INTEL_MTL_PCIE_RP1 0x7e4d #define PCI_DEVICE_ID_INTEL_MTL_PCIE_RP2 0x7eca #define PCI_DEVICE_ID_INTEL_MTL_PCIE_RP3 0x7ecb #define PCI_DEVICE_ID_INTEL_MTL_PCIE_RP4 0x7ecc /* SoC RPs */ #define PCI_DEVICE_ID_INTEL_MTP_PCIE_RP1 0x7e38 #define PCI_DEVICE_ID_INTEL_MTP_PCIE_RP2 0x7e39 #define PCI_DEVICE_ID_INTEL_MTP_PCIE_RP3 0x7e3a #define PCI_DEVICE_ID_INTEL_MTP_PCIE_RP4 0x7e3b #define PCI_DEVICE_ID_INTEL_MTP_PCIE_RP5 0x7e3c #define PCI_DEVICE_ID_INTEL_MTP_PCIE_RP6 0x7e3d #define PCI_DEVICE_ID_INTEL_MTP_PCIE_RP7 0x7e3e #define PCI_DEVICE_ID_INTEL_MTP_PCIE_RP8 0x7e3f <Missing RPs are RP9-RP12> or with MTL, we are reducing the RPs from 16 (12 PCH and 4 CPU) to 12 (alone). I would still prefer to have the clean split between RPs at north and south (although this line doesn't exist today) https://review.coreboot.org/c/coreboot/+/62581/comment/5330d4aa_3779b29b PS1, Line 3508: #define PCI_DEVICE_ID_INTEL_MTL_SATA_2 0x7e67 : #define PCI_DEVICE_ID_INTEL_MTL_SATA_3 0x282a you don't need these DID as for RAID mode. AHCI is enough https://review.coreboot.org/c/coreboot/+/62581/comment/4550edbd_a63d6f6a PS1, Line 3531: PCI_DEVICE_ID_INTEL_MTL_PMC meaningful would be have different name macro #define PCI_DEVICE_ID_INTEL_MTL_SOC_PMC 0x7e21 https://review.coreboot.org/c/coreboot/+/62581/comment/05737427_d3b2bd10 PS1, Line 3532: PCI_DEVICE_ID_INTEL_MTL_M_PMC nit: PCI_DEVICE_ID_INTEL_MTL_M_IOE_PMC https://review.coreboot.org/c/coreboot/+/62581/comment/42526c7b_4c6d02e5 PS1, Line 3533: PCI_DEVICE_ID_INTEL_MTL_P_PMC nit: PCI_DEVICE_ID_INTEL_MTL_P_IOE_PMC https://review.coreboot.org/c/coreboot/+/62581/comment/fc7142ab_fca256ac PS1, Line 3807: PCI_DEVICE_ID_INTEL_MTL_SPI0 suggestion: maintain the similar naming convention with previous generation #define PCI_DEVICE_ID_INTEL_MTL_HWSEQ_SPI 0x7e23 https://review.coreboot.org/c/coreboot/+/62581/comment/510f3620_0b5cfd96 PS1, Line 3962: #define PCI_DEVICE_ID_INTEL_SIMICS_GT0 0xffff u don't need this. no probing is done for 0xFFFF DID device. https://review.coreboot.org/c/coreboot/+/62581/comment/460f4c6b_84513c67 PS1, Line 4140: PCI_DEVICE_ID_INTEL_MTL_M_XHCI PCI_DEVICE_ID_INTEL_MTL_M_TCSS_XHCI https://review.coreboot.org/c/coreboot/+/62581/comment/84a90f7d_498fd0ba PS1, Line 4141: PCI_DEVICE_ID_INTEL_MTL_P_XHCI same https://review.coreboot.org/c/coreboot/+/62581/comment/f315af2f_fa4eb426 PS1, Line 4163: PCI_DEVICE_ID_INTEL_MTL_P2SB please follow the same suggestion as PMC DID and split between SOC and IOE https://review.coreboot.org/c/coreboot/+/62581/comment/4da13c52_88c2b977 PS1, Line 4178: PCI_DEVICE_ID_INTEL_MTL_SRAM same as above https://review.coreboot.org/c/coreboot/+/62581/comment/43460e60_0dc61630 PS1, Line 4269: #define PCI_DEVICE_ID_INTEL_MTL_CSE1 0x7e71 : #define PCI_DEVICE_ID_INTEL_MTL_CSE2 0x7e74 : #define PCI_DEVICE_ID_INTEL_MTL_CSE3 0x7e75 wondering, if we really need these HECI devices, we are keeping HECI1 alone enable. PCI: 00:16.0 10 <- [0x00807db000 - 0x00807dbfff] size 0x00001000 gran 0x0c mem64 https://review.coreboot.org/c/coreboot/+/62581/comment/54147bdb_25dffb1d PS1, Line 4292: PCI_DEVICE_ID_INTEL_MTL_M_XDCI Please add _TCSS_ in between https://review.coreboot.org/c/coreboot/+/62581/comment/9d50888b_1b782879 PS1, Line 4416: can you please add CNVI Ids as well? https://review.coreboot.org/c/coreboot/+/62581/comment/5a987e39_f96cf35f PS1, Line 4424: can you please add Crashlog ID as well? File src/soc/intel/common/block/cpu/mp_init.c: https://review.coreboot.org/c/coreboot/+/62581/comment/febbeb6b_84a07d18 PS1, Line 31: CPUID_METEORLAKE_1_A0 suggestion: CPUID_METEORLAKE_A0_1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie71abb70b88db0acec8a320c3e2c20c54bbb4a8a Gerrit-Change-Number: 62581 Gerrit-PatchSet: 1 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Ethan Tsao <ethan.tsao(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ethan Tsao <ethan.tsao(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 04 Mar 2022 07:52:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/lantis: Add ELAN touchscreen driver
by Robert Chen (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Tony Huang, Tim Wawrzynczak. Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62002 ) Change subject: mb/google/dedede/var/lantis: Add ELAN touchscreen driver ...................................................................... Patch Set 11: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/62002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23d3de5e45aa2876c1590a1e09679d652a3f2906 Gerrit-Change-Number: 62002 Gerrit-PatchSet: 11 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Fri, 04 Mar 2022 07:48:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/kinox: update overridetree
by Dtrain Hsu (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee. Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62553 to look at the new patch set (#6). Change subject: mb/google/brya/var/kinox: update overridetree ...................................................................... mb/google/brya/var/kinox: update overridetree 1. Update override devicetree based on schematics. 2. ALC5682I-VS is for audio codec. 3. Update 15W SOC default PL2/PL4(39W/100W). 4. Update DPTF table. 5. Enable Bayhub LV2 driver BUG=b:218786363, b:212183045, b:213417026, b:221180425 TEST=emerge-brya coreboot Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Change-Id: I08a1c2f784175b208ccdc562668041f432618dfc --- M src/mainboard/google/brya/Kconfig.name M src/mainboard/google/brya/variants/kinox/Makefile.inc M src/mainboard/google/brya/variants/kinox/gpio.c M src/mainboard/google/brya/variants/kinox/overridetree.cb A src/mainboard/google/brya/variants/kinox/ramstage.c 5 files changed, 418 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/62553/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/62553 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08a1c2f784175b208ccdc562668041f432618dfc Gerrit-Change-Number: 62553 Gerrit-PatchSet: 6 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Change AMP driver setting
by Shon Wang (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Kevin Chiu, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Angel Pons, Nick Vaccaro, Name of user not set #1004174. Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 ) Change subject: mb/google/brya/var/vell: Change AMP driver setting ...................................................................... Patch Set 34: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c Gerrit-Change-Number: 60331 Gerrit-PatchSet: 34 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Name of user not set #1004174 Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Name of user not set #1004174 Gerrit-Comment-Date: Fri, 04 Mar 2022 07:17:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Change AMP driver setting
by Shon Wang (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Kevin Chiu, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Angel Pons, Nick Vaccaro, Name of user not set #1004174, Shon Wang. Hello build bot (Jenkins), Kevin Chiu, YH Lin, Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, Name of user not set #1004174, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60331 to look at the new patch set (#34). Change subject: mb/google/brya/var/vell: Change AMP driver setting ...................................................................... mb/google/brya/var/vell: Change AMP driver setting 1.Change I2S GPP_Sx (S0-S3) Native PAD Configuration from NF2 to NF4 2.Select CS35l53 AMP driver for Vell variant. Signed-off-by: Shon.Wang <shon.wang(a)quanta.corp-partner.google.com> Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c --- M src/mainboard/google/brya/Kconfig.name M src/mainboard/google/brya/variants/vell/gpio.c M src/mainboard/google/brya/variants/vell/overridetree.cb 3 files changed, 52 insertions(+), 31 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/60331/34 -- To view, visit https://review.coreboot.org/c/coreboot/+/60331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c Gerrit-Change-Number: 60331 Gerrit-PatchSet: 34 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Name of user not set #1004174 Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Name of user not set #1004174 Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/kinox: update overridetree
by Dtrain Hsu (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee. Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62553 to look at the new patch set (#5). Change subject: mb/google/brya/var/kinox: update overridetree ...................................................................... mb/google/brya/var/kinox: update overridetree 1. Update override devicetree based on schematics. 2. ALC5682I-VS is for audio codec. 3. Update 15W SOC default PL2/PL4(39W/100W). 4. Update DPTF table. 5. Enable Bayhub LV2 driver BUG=b:218786363, b:212183045, b:213417026, b:221180425 TEST=emerge-brya coreboot Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Change-Id: I08a1c2f784175b208ccdc562668041f432618dfc --- M src/mainboard/google/brya/Kconfig.name M src/mainboard/google/brya/variants/kinox/Makefile.inc M src/mainboard/google/brya/variants/kinox/gpio.c M src/mainboard/google/brya/variants/kinox/overridetree.cb A src/mainboard/google/brya/variants/kinox/ramstage.c 5 files changed, 418 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/62553/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/62553 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08a1c2f784175b208ccdc562668041f432618dfc Gerrit-Change-Number: 62553 Gerrit-PatchSet: 5 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common: Retry MEI CSE DISABLE command
by Sridhar Siricilla (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Patrick Rudolph. Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62560 to look at the new patch set (#3). Change subject: soc/intel/common: Retry MEI CSE DISABLE command ...................................................................... soc/intel/common: Retry MEI CSE DISABLE command The patch retries MEI CSE DISABLE command if cse doesn't respond or sends the garbled response. It retries the command additionally 2 more times. TEST=build and boot the Brya board Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: Id38a172d670a0cd44643744f27b85ca7e368ccdb --- M src/soc/intel/common/block/cse/cse_eop.c 1 file changed, 44 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/62560/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id38a172d670a0cd44643744f27b85ca7e368ccdb Gerrit-Change-Number: 62560 Gerrit-PatchSet: 3 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022