Attention is currently required from: Patrick Rudolph.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62723 )
Change subject: soc/intel/common: Configure TCSS access through IOE P2SB
......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/62723/comment/36bfea5b_db265d88
PS1, Line 372: const struct typec_aux_bias_pads *pads)
> code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/62723/comment/c60f6d5a_072d8a82
PS1, Line 372: const struct typec_aux_bias_pads *pads)
> please, no spaces at the start of a line
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62723
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3302aabfb5f540c41da6359f11376b4202c6310b
Gerrit-Change-Number: 62723
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 10 Mar 2022 02:11:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Johnny Li, Zhuohao Lee, Raihow Shi, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62321 )
Change subject: mb/google/brask/variants/moli: init overridetree for moli
......................................................................
Patch Set 24: Code-Review+1
(2 comments)
File src/mainboard/google/brya/variants/moli/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62321/comment/de5fb449_61a2acfc
PS9, Line 58: device ref pcie_rp7 on
: chip drivers/net
: register "wake" = "GPE0_DW0_07"
: register "led_feature" = "0xe0"
: register "customized_led0" = "0x23f"
: register "customized_led2" = "0x028"
: device pci 00.0 on end
: end
: end # RTL8125 Ethernet NIC
> i modify it, but i add register "PcieRpSlotImplemented[7]" = "1" this line in setting of RTL8111, it build fail, so i remove it
Yes, we've been pretty much ignoring that UPD for ADL... the default value is 1 for ADL so it hasn't caused us any trouble, but it we should probably program it correctly.
File src/mainboard/google/brya/variants/moli/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62321/comment/0803bad2_cb425dec
PS24, Line 80: register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B3)"
FYI, other projects have ended up also adding the `enable_gpio` for the eMMC controller here for RTD3 support to get to a true D3cold state, so I suspect you will want to do the same.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62321
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8829d4b39d48ae574eeccbfc62e79b671211ae2d
Gerrit-Change-Number: 62321
Gerrit-PatchSet: 24
Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Johnny Li <johnny_li(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com>
Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Johnny Li <johnny_li(a)wistron.corp-partner.google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 10 Mar 2022 02:10:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com>
Comment-In-Reply-To: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph.
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62723
to look at the new patch set (#2).
Change subject: soc/intel/common: Configure TCSS access through IOE P2SB
......................................................................
soc/intel/common: Configure TCSS access through IOE P2SB
This change abstracts the TCSS access through IOE P2SB on Meteor Lake.
BUG=b:213574324
TEST=Build platforms coreboot images successfully.
Change-Id: I3302aabfb5f540c41da6359f11376b4202c6310b
Signed-off-by: John <john.zhao(a)intel.com>
---
M src/soc/intel/common/block/tcss/tcss.c
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/62723/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62723
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3302aabfb5f540c41da6359f11376b4202c6310b
Gerrit-Change-Number: 62723
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nick Vaccaro, Zhuohao Lee.
Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62627
to look at the new patch set (#4).
Change subject: mb/google/brya/var/kinox: Modify 15W SOC PL2/PL4 default setting
......................................................................
mb/google/brya/var/kinox: Modify 15W SOC PL2/PL4 default setting
Modify 15W SOC PL2/PL4 default setting to 39W/100W for Kinox.
BUG=b:213417026
TEST=emerge-brask coreboot
Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Change-Id: I2956705f7d26929c7cf2dd4e852fc61b619a83e5
---
M src/mainboard/google/brya/variants/kinox/Makefile.inc
A src/mainboard/google/brya/variants/kinox/ramstage.c
2 files changed, 69 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/62627/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/62627
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2956705f7d26929c7cf2dd4e852fc61b619a83e5
Gerrit-Change-Number: 62627
Gerrit-PatchSet: 4
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62723 )
Change subject: soc/intel/common: Configure TCSS access through IOE P2SB
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/common/block/tcss/tcss.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143683):
https://review.coreboot.org/c/coreboot/+/62723/comment/dda4199b_c2cee9b2
PS1, Line 372: const struct typec_aux_bias_pads *pads)
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143683):
https://review.coreboot.org/c/coreboot/+/62723/comment/6dbce3ba_a25967ab
PS1, Line 372: const struct typec_aux_bias_pads *pads)
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/62723
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3302aabfb5f540c41da6359f11376b4202c6310b
Gerrit-Change-Number: 62723
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 10 Mar 2022 02:05:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Robert Chen.
Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61847 )
Change subject: mb/google/brya/var/vell: Add 5G WWAN ACPI support for vell
......................................................................
Patch Set 18:
(1 comment)
File src/mainboard/google/brya/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/61847/comment/44e1a156_c9919579
PS16, Line 160: HAVE_WWAN_POWER_SEQUENCE
> Regarding this, we have moved to doing this in the SSDT instead, please see CB:61887 for reference
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/61847
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6d3f965b8f6b6753446f55a8bd47d3b0c1ae7be
Gerrit-Change-Number: 61847
Gerrit-PatchSet: 18
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 02:05:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Casper Chang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62703 )
Change subject: mb/google/brya/var/primus{4es}: add eMMC enable pin in ramstage
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62703/comment/5fce7f4a_a126b790
PS3, Line 9: baseboad
`baseboard`
Patchset:
PS3:
Also if you rebase on master (just hit the rebase button) the build error should go away 👍
--
To view, visit https://review.coreboot.org/c/coreboot/+/62703
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b6f164cc326bd368addb1e143ad2cbd449bb08d
Gerrit-Change-Number: 62703
Gerrit-PatchSet: 3
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-CC: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 02:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Shon Wang.
Shon Wang has uploaded a new patch set (#18) to the change originally created by Robert Chen. ( https://review.coreboot.org/c/coreboot/+/61847 )
Change subject: mb/google/brya/var/vell: Add 5G WWAN ACPI support for vell
......................................................................
mb/google/brya/var/vell: Add 5G WWAN ACPI support for vell
Add FM350GL 5G WWAN support using drivers/wwan/fm and addtional PM
features from RTD3.
BUG=b:220084872
TEST=emerge-brya coreboot
Change-Id: If6d3f965b8f6b6753446f55a8bd47d3b0c1ae7be
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/brya/variants/vell/gpio.c
M src/mainboard/google/brya/variants/vell/include/variant/gpio.h
M src/mainboard/google/brya/variants/vell/overridetree.cb
4 files changed, 33 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/61847/18
--
To view, visit https://review.coreboot.org/c/coreboot/+/61847
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6d3f965b8f6b6753446f55a8bd47d3b0c1ae7be
Gerrit-Change-Number: 61847
Gerrit-PatchSet: 18
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset