coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: ec/chromeec/ec/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 15 Mar '22

15 Mar '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60381 ) Change subject: ec/chromeec/ec/acpi: Use Printf() for debug prints ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60381/comment/d90090c3_d17e0416 PS4, Line 9: and coreboot.rom remains identical > Sorry, forgot to add that. I wrote the commit message first and tested it later. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b06f74be155e0c4053a38a1c5fd30ff6715111e Gerrit-Change-Number: 60381 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 11:31:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Enable SPI flash caching before payload is loaded
by Werner Zeh (Code Review) 15 Mar '22

15 Mar '22

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62825 ) Change subject: soc/intel/elkhartlake: Enable SPI flash caching before payload is loaded ...................................................................... soc/intel/elkhartlake: Enable SPI flash caching before payload is loaded This patch enables SPI flash caching temporary before the payload is loaded. This speeds up payload loading and measuring a lot on Elkhart Lake. Change-Id: I37e554b5c32dca00e74af6af4a93ed2c07d71c5f Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/soc/intel/elkhartlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/62825/1 diff --git a/src/soc/intel/elkhartlake/Kconfig b/src/soc/intel/elkhartlake/Kconfig index a1f7794..362c24b 100644 --- a/src/soc/intel/elkhartlake/Kconfig +++ b/src/soc/intel/elkhartlake/Kconfig @@ -26,6 +26,7 @@ select INTEL_DESCRIPTOR_MODE_CAPABLE select INTEL_GMA_ACPI select INTEL_GMA_ADD_VBT if RUN_FSP_GOP + select SOC_INTEL_ENABLE_FLASH_CACHING select MP_SERVICES_PPI_V1 select MRC_SETTINGS_PROTECT select PARALLEL_MP_AP_WORK -- To view, visit https://review.coreboot.org/c/coreboot/+/62825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I37e554b5c32dca00e74af6af4a93ed2c07d71c5f Gerrit-Change-Number: 62825 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: init overridetree for moli
by Zhuohao Lee (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: YH Lin, Johnny Li, Raihow Shi, Felix Held. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62321 ) Change subject: mb/google/brask/variants/moli: init overridetree for moli ...................................................................... Patch Set 26: (1 comment) File src/mainboard/google/brya/variants/moli/overridetree.cb: https://review.coreboot.org/c/coreboot/+/62321/comment/6e7e774f_db3f83f8 PS26, Line 2: 4 6 Should be 4 5? From the b/215806030, you only allocate 2 bit for the DB. -- To view, visit https://review.coreboot.org/c/coreboot/+/62321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8829d4b39d48ae574eeccbfc62e79b671211ae2d Gerrit-Change-Number: 62321 Gerrit-PatchSet: 26 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Johnny Li <johnny_li(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Johnny Li <johnny_li(a)wistron.corp-partner.google.com> Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 15 Mar 2022 11:21:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/tutorial/part1.md: Add Fedora package `patch`
by Felix Singer (Code Review) 15 Mar '22

15 Mar '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62765 ) Change subject: Documentation/tutorial/part1.md: Add Fedora package `patch` ...................................................................... Documentation/tutorial/part1.md: Add Fedora package `patch` It is necessary to build crossgcc. Change-Id: I32f6507b4d8346bf94aaccd3eef4f22697c33965 Signed-off-by: Eloy Degen <degeneloy(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62765 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M Documentation/tutorial/part1.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/Documentation/tutorial/part1.md b/Documentation/tutorial/part1.md index 8702488..84b77af 100644 --- a/Documentation/tutorial/part1.md +++ b/Documentation/tutorial/part1.md @@ -12,7 +12,7 @@ ### Step 1 - Install tools and libraries needed for coreboot $ sudo apt-get install -y bison build-essential curl flex git gnat libncurses5-dev m4 zlib1g-dev $ sudo pacman -S base-devel curl git gcc-ada ncurses zlib - $ sudo dnf install git make gcc-gnat flex bison xz bzip2 gcc g++ ncurses-devel wget zlib-devel + $ sudo dnf install git make gcc-gnat flex bison xz bzip2 gcc g++ ncurses-devel wget zlib-devel patch ### Step 2 - Download coreboot source tree $ git clone https://review.coreboot.org/coreboot -- To view, visit https://review.coreboot.org/c/coreboot/+/62765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32f6507b4d8346bf94aaccd3eef4f22697c33965 Gerrit-Change-Number: 62765 Gerrit-PatchSet: 4 Gerrit-Owner: Eloy Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: Documentation/tutorial/part1.md: Add Fedora package `patch`
by Felix Singer (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Eloy. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62765 ) Change subject: Documentation/tutorial/part1.md: Add Fedora package `patch` ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62765/comment/d8006529_3b0afd61 PS2, Line 8: > I imagine this is needed to build crossgcc. I'd mention so in the commit message: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32f6507b4d8346bf94aaccd3eef4f22697c33965 Gerrit-Change-Number: 62765 Gerrit-PatchSet: 3 Gerrit-Owner: Eloy Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eloy Gerrit-Comment-Date: Tue, 15 Mar 2022 11:18:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google/chromeec: Change loglevel prefix
by Chen Wisley (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Tim Wawrzynczak, Wisley Chen. Hello Wisley Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/62823 to review the following change. Change subject: ec/google/chromeec: Change loglevel prefix ...................................................................... ec/google/chromeec: Change loglevel prefix In most boards, it doesn't write OEM_NAME in CBI to override the manufacturer name of smbios. It' better use the "BIOS_INFO" than "BIOS_ERR" BUG=b:222038287 BRANCH=firmware-brya-14505.B TEST=emerge-brya coreboot Change-Id: I52eb1e6926eaac30b1dbee13ab750ef15b466d89 Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> --- M src/ec/google/chromeec/ec_smbios.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/62823/1 diff --git a/src/ec/google/chromeec/ec_smbios.c b/src/ec/google/chromeec/ec_smbios.c index 1ee7283..d62a0a0 100644 --- a/src/ec/google/chromeec/ec_smbios.c +++ b/src/ec/google/chromeec/ec_smbios.c @@ -29,7 +29,7 @@ if (google_chromeec_cbi_get_oem_name(&oem_name[0], ARRAY_SIZE(oem_name)) < 0) { - printk(BIOS_ERR, "Couldn't obtain OEM name from CBI\n"); + printk(BIOS_INFO, "Couldn't obtain OEM name from CBI\n"); manuf = CONFIG_MAINBOARD_SMBIOS_MANUFACTURER; } else { manuf = &oem_name[0]; -- To view, visit https://review.coreboot.org/c/coreboot/+/62823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52eb1e6926eaac30b1dbee13ab750ef15b466d89 Gerrit-Change-Number: 62823 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: driver/intel/usb4/retimer: Change loglevel prefix
by Chen Wisley (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Wisley Chen. Hello Wisley Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/62822 to review the following change. Change subject: driver/intel/usb4/retimer: Change loglevel prefix ...................................................................... driver/intel/usb4/retimer: Change loglevel prefix In usb4_retimer_fill_ssdt(), it search all dpf ports and shows message in not support dpf ports. It's not error and changes the loglevel prefix to BIOS_INFO. BUG=b:222038287 BRANCH=firmware-brya-14505.B TEST=emerge-brya coreboot Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Change-Id: I508ec7662e078893f944edb3d68364c57d5c5a73 --- M src/drivers/intel/usb4/retimer/retimer.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/62822/1 diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 0c027eb..58ef2a8 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -358,7 +358,7 @@ for (dfp_port = 0; dfp_port < DFP_NUM_MAX; dfp_port++) { if (!config->dfp[dfp_port].power_gpio.pin_count) { - printk(BIOS_ERR, "%s: No DFP%1d power GPIO for %s\n", + printk(BIOS_INFO, "%s: No DFP%1d power GPIO for %s\n", __func__, dfp_port, dev_path(dev)); continue; } -- To view, visit https://review.coreboot.org/c/coreboot/+/62822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I508ec7662e078893f944edb3d68364c57d5c5a73 Gerrit-Change-Number: 62822 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/alderlake/retimer: Change loglevel prefix
by Chen Wisley (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Tim Wawrzynczak, Wisley Chen. Hello Wisley Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/62821 to review the following change. Change subject: soc/intel/alderlake/retimer: Change loglevel prefix ...................................................................... soc/intel/alderlake/retimer: Change loglevel prefix It shows the ec mapped port, so change the loglevel to BIOS_INFO. BUG=b:222038287 BRANCH=firmware-brya-14505.B TEST=emerge-brya coreboot Change-Id: I9dc852a0cd30f95506c205f161a05e8a8c44fcd5 Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> --- M src/soc/intel/alderlake/retimer.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/62821/1 diff --git a/src/soc/intel/alderlake/retimer.c b/src/soc/intel/alderlake/retimer.c index 09bf112..3fd9c2d 100644 --- a/src/soc/intel/alderlake/retimer.c +++ b/src/soc/intel/alderlake/retimer.c @@ -18,7 +18,7 @@ for (uint8_t i = 0; i < MAX_TYPE_C_PORTS; i++) { if (i == typec_port) { - printk(BIOS_ERR, "USB Type-C %d mapped to EC port %d\n", typec_port, + printk(BIOS_INFO, "USB Type-C %d mapped to EC port %d\n", typec_port, ec_port); return ec_port; } -- To view, visit https://review.coreboot.org/c/coreboot/+/62821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dc852a0cd30f95506c205f161a05e8a8c44fcd5 Gerrit-Change-Number: 62821 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/common/block/cse: Change logleve prefix to WARNING
by Chen Wisley (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Wisley Chen. Hello Wisley Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/62820 to review the following change. Change subject: soc/intel/common/block/cse: Change logleve prefix to WARNING ...................................................................... soc/intel/common/block/cse: Change logleve prefix to WARNING In do_send_end_of_post(), it checks whether send eop or not. So, it's better to use "BIOS_WARNING" than "BIOS_ERR" BUG=b:222038287 BRANCH=firmware-brya-14505.B TEST=build Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Change-Id: I57a34334007a6a7443302c2f25de3d5c87c85573 --- M src/soc/intel/common/block/cse/cse_eop.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/62820/1 diff --git a/src/soc/intel/common/block/cse/cse_eop.c b/src/soc/intel/common/block/cse/cse_eop.c index bc6d837..1d64ecc 100644 --- a/src/soc/intel/common/block/cse/cse_eop.c +++ b/src/soc/intel/common/block/cse/cse_eop.c @@ -172,7 +172,7 @@ static bool eop_sent = false; if (eop_sent) { - printk(BIOS_ERR, "EOP already sent\n"); + printk(BIOS_WARNING, "EOP already sent\n"); return; } -- To view, visit https://review.coreboot.org/c/coreboot/+/62820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57a34334007a6a7443302c2f25de3d5c87c85573 Gerrit-Change-Number: 62820 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: hp/z220_series: Convert z220_sff_workstation into variant
by Felix Singer (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Damien Zammit, Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62808 ) Change subject: hp/z220_series: Convert z220_sff_workstation into variant ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62808/comment/e844f291_8177e9b7 PS1, Line 7: hp/z220_series: Convert z220_sff_workstation into variant mb/hp/z220_series: ... https://review.coreboot.org/c/coreboot/+/62808/comment/519fb83b_d9472835 PS1, Line 11: $ diff static.c ~/static.c.orig Please build with BUILD_TIMELESS=1 and with `INCLUDE_CONFIG_FILE` (General setup -> Include the coreboot .config file ...) disabled. Compare the coreboot.rom binary before and after this patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/62808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6aaac75216b2d7c8bb48801454ce616ace3b1422 Gerrit-Change-Number: 62808 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Damien Zammit Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 11:00:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022