coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: soc/intel/common/fast_spi: support caching `ext_bios` in ramstage
by Werner Zeh (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Eric Lai. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62837 ) Change subject: soc/intel/common/fast_spi: support caching `ext_bios` in ramstage ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62837/comment/f80e5da3_dca4c5bb PS1, Line 9: stage stages -- To view, visit https://review.coreboot.org/c/coreboot/+/62837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87139a9ed7eb9ed43164a5199aa436dd1219145c Gerrit-Change-Number: 62837 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 15 Mar 2022 14:35:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block/cpu: Enable ROM caching in ramstage
by Werner Zeh (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62838 ) Change subject: soc/intel/common/block/cpu: Enable ROM caching in ramstage ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Works for me, payload loading is faster now. Thanks Subrata. -- To view, visit https://review.coreboot.org/c/coreboot/+/62838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02b80eefbb3b19331698a205251a0c4d17be534c Gerrit-Change-Number: 62838 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 15 Mar 2022 14:34:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: x86/smbios_defaults: Set default system manufacturer for ChromeOS dev...
by Matt DeVillier (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Felix Singer, Martin Roth, Paul Menzel, Tim Wawrzynczak. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62796 ) Change subject: x86/smbios_defaults: Set default system manufacturer for ChromeOS devices ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62796/comment/4b7411c2_a7970602 PS1, Line 9: Currently, many Linux drivers use DMI quirks to identify ChromeOS devices and : handle them accordingly: namely they look for the SMBIOS system manufactuer : to be "GOOGLE" or "Google", and the bios-vendor to be coreboot. Historically : this was consistently the case, but recent model ChromeOS devices allow the : OEM to set the mainboard manufacturer, which is also the default system : manufacturer. This breaks many DMI quirks, notably ones used by SOF (sound : open firmware) for audio. > Please reflow for 72 characters per line. Done https://review.coreboot.org/c/coreboot/+/62796/comment/5479c639_20835a6e PS1, Line 14: This breaks many DMI quirks, notably ones used by SOF (sound : open firmware) for audio. > Do you know of the Chromium OS Linux kernel commit making this work for Chromium OS? there is none, as the SoF code backported to the ChromeOS kernel doesn't rely on DMI quirks File src/arch/x86/smbios_defaults.c: https://review.coreboot.org/c/coreboot/+/62796/comment/2e27ef46_4eb8e4d3 PS1, Line 119: return "Google"; > I would like to avoid vendor specific configurations in common code. […] I think that will work, will give it a look https://review.coreboot.org/c/coreboot/+/62796/comment/ae45f9ff_e721dbe3 PS1, Line 121: return smbios_mainboard_manufacturer(); > You could you the ternary operator, use the if statement, and also add a log message, that it’s over […] I'm unclear what exactly you're looking for here -- To view, visit https://review.coreboot.org/c/coreboot/+/62796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9de17fa12689ab4e627b995818aa3d2653102b04 Gerrit-Change-Number: 62796 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 14:32:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/efi: Clean up efi_datatype.h file
by Angel Pons (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Nick Vaccaro. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62787 ) Change subject: include/efi: Clean up efi_datatype.h file ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62787 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9177814fcf41e5950ace94050356f0273f765c5 Gerrit-Change-Number: 62787 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 15 Mar 2022 14:27:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: x86/smbios_defaults: Set default system manufacturer for ChromeOS dev...
by Matt DeVillier (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Martin Roth, Matt DeVillier, Tim Wawrzynczak. Hello build bot (Jenkins), Martin Roth, Paul Menzel, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62796 to look at the new patch set (#2). Change subject: x86/smbios_defaults: Set default system manufacturer for ChromeOS devices ...................................................................... x86/smbios_defaults: Set default system manufacturer for ChromeOS devices Currently, many Linux drivers use DMI quirks to identify ChromeOS devices and handle them accordingly: namely they look for the SMBIOS system manufactuer to be "GOOGLE" or "Google", and the bios-vendor to be coreboot. Historically this was consistently the case, but recent model ChromeOS devices allow the OEM to set the mainboard manufacturer, which is also the default system manufacturer. This breaks many DMI quirks, notably ones used by SOF (sound open firmware) for audio. To fix this, set the default system manufactuer for ChromeOS devices to "Google" conditional on CONFIG_MAINBOARD_HAS_CHROMEOS, leaving the OEM customization in place for the mainboard manufacturer. Test: build/boot google/bloog with Linux 5.16, verify SOF drivers correctly detect device as a Chromebook and load the appropriate audio firmware. Change-Id: I9de17fa12689ab4e627b995818aa3d2653102b04 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/arch/x86/smbios_defaults.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/62796/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9de17fa12689ab4e627b995818aa3d2653102b04 Gerrit-Change-Number: 62796 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/block/cpu: Enable ROM caching in ramstage
by Arthur Heymans (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Werner Zeh. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62838 ) Change subject: soc/intel/common/block/cpu: Enable ROM caching in ramstage ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: It looks like this is already done on the APL platform -- To view, visit https://review.coreboot.org/c/coreboot/+/62838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02b80eefbb3b19331698a205251a0c4d17be534c Gerrit-Change-Number: 62838 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 15 Mar 2022 14:17:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/fast_spi: support caching `ext_bios` in ramstage
by Arthur Heymans (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Eric Lai, Werner Zeh. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62837 ) Change subject: soc/intel/common/fast_spi: support caching `ext_bios` in ramstage ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87139a9ed7eb9ed43164a5199aa436dd1219145c Gerrit-Change-Number: 62837 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 15 Mar 2022 14:16:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/apollolake: Create components required for IFWI stitching
by Sean Rhodes (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Sean Rhodes, Nico Huber, Martin Roth, Arthur Heymans, Andrey Petrov, Patrick Rudolph. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61872 ) Change subject: soc/apollolake: Create components required for IFWI stitching ...................................................................... Patch Set 16: (2 comments) File Makefile.inc: https://review.coreboot.org/c/coreboot/+/61872/comment/4135ab4f_8ee221b3 PS14, Line 1311: # IFWI Stitching > Can this SOC specific code be moved out of the main makefile. […] Done https://review.coreboot.org/c/coreboot/+/61872/comment/04a589e7_3f1dec41 PS14, Line 1321: $(objcbfs)/ibbm.rom: : # Size is calculate as: : # IBBP-Sub-Partition - IBBL - Manifest - BPM.met - Padding : python -c "import struct; fp = open ('$@', 'wb'); \ : fp.write (b'\xFF' * \ : $(shell echo $$((32768 - \ : $(shell stat -Lc %s $(objcbfs)/ibbl.rom) \ : - 748 - 180 - 3168)))); fp.close();" : printf "\nBuilt $@ (0x%x)\n" `stat -c "%s" $@` > Does this need a dependency? Also inline python inside makefiles is a bad idea. […] I did not know dd could do that, magic! -- To view, visit https://review.coreboot.org/c/coreboot/+/61872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a64e602b8e0d53e1a51b2fbce583c40dfb68c79 Gerrit-Change-Number: 61872 Gerrit-PatchSet: 16 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 14:15:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/apollolake: Create components required for IFWI stitching
by Sean Rhodes (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Sean Rhodes, Nico Huber, Martin Roth, Andrey Petrov, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Martin Roth, Andrey Petrov, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61872 to look at the new patch set (#15). Change subject: soc/apollolake: Create components required for IFWI stitching ...................................................................... soc/apollolake: Create components required for IFWI stitching Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I2a64e602b8e0d53e1a51b2fbce583c40dfb68c79 --- M Makefile.inc M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/Makefile.inc A src/soc/intel/apollolake/sample.fmd M src/southbridge/intel/common/firmware/Makefile.inc 5 files changed, 151 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/61872/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/61872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a64e602b8e0d53e1a51b2fbce583c40dfb68c79 Gerrit-Change-Number: 61872 Gerrit-PatchSet: 15 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/apollolake: Add support for creating IFWI images
by Arthur Heymans (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Sean Rhodes, Martin Roth, Andrey Petrov, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61922 ) Change subject: soc/apollolake: Add support for creating IFWI images ...................................................................... Patch Set 9: Code-Review-1 (1 comment) Patchset: PS9: You should probably have a discussion on the ML about integrating closed tooling. I personally don't think it's good idea to have in the master branch. I proposed something similar some time ago: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/F4T… . It's a somewhat different problem in the sense that there was an NDA blocking the release of code that was intended to be opened from the beginning. The upshot of that discussion was that's frowned upon by some/many in the community and also is technically problematic to maintain and even use. -- To view, visit https://review.coreboot.org/c/coreboot/+/61922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24c220be925182cf2159aed5b76375c3fc4508d8 Gerrit-Change-Number: 61922 Gerrit-PatchSet: 9 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 14:11:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022