Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak, Nick Vaccaro.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62330 )
Change subject: mb/google/brya: Remove Pcie Generic driver for WWAN
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62330/comment/5f8d4fc2_ab1f8d94
PS10, Line 213: rp6_wwan
> The recent merged changes for dmaProperty create _DSD, while the changes in this code review and htt […]
The last patchset removes PCIe generic driver and use recent _DSD support from the FM driver. The commit messages also changed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f
Gerrit-Change-Number: 62330
Gerrit-PatchSet: 11
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 23:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak, Nick Vaccaro.
Hello Bora Guvendik, build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Nick Vaccaro, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62330
to look at the new patch set (#13).
Change subject: mb/google/brya: Remove Pcie Generic driver for WWAN
......................................................................
mb/google/brya: Remove Pcie Generic driver for WWAN
This was to merge PCIe ACPI code to WWAN device. But, now use recent
_DSD generation changes in FM driver instead. PCie generic driver is
not used for WWAN at this time.
Also, RTD3 devices are moved to overridetree.cb where WWAN is
present.
BUG=b:221250331
BRANCH=firmware-brya-14505.B
TEST=
Check that _DSD is added to WWAN device in SSDT for the variants.
Check that RTD3 is added to WWAN device in SSDT for the variants.
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
M src/mainboard/google/brya/variants/brya0/overridetree.cb
M src/mainboard/google/brya/variants/brya4es/overridetree.cb
M src/mainboard/google/brya/variants/redrix/overridetree.cb
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
6 files changed, 76 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/62330/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/62330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f
Gerrit-Change-Number: 62330
Gerrit-PatchSet: 13
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak, Nick Vaccaro.
Hello Bora Guvendik, build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Nick Vaccaro, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62330
to look at the new patch set (#12).
Change subject: mb/google/brya: Changes for WWAN latest _DSD generation
......................................................................
mb/google/brya: Changes for WWAN latest _DSD generation
This was to merge PCIe ACPI code to WWAN device. But, now use recent
_DSD generation changes in FM driver instead. PCie generic driver is
not used for WWAN at this time.
Also, RTD3 devices are moved to overridetree.cb where WWAN is
present.
BUG=b:221250331
BRANCH=firmware-brya-14505.B
TEST=
Check that _DSD is added to WWAN device in SSDT for the variants.
Check that RTD3 is added to WWAN device in SSDT for the variants.
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
M src/mainboard/google/brya/variants/brya0/overridetree.cb
M src/mainboard/google/brya/variants/brya4es/overridetree.cb
M src/mainboard/google/brya/variants/redrix/overridetree.cb
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
6 files changed, 76 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/62330/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/62330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f
Gerrit-Change-Number: 62330
Gerrit-PatchSet: 12
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak, Nick Vaccaro.
Hello Bora Guvendik, build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Nick Vaccaro, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62330
to look at the new patch set (#11).
Change subject: mb/google/brya: Changes for WWAN latest _DSD generation
......................................................................
mb/google/brya: Changes for WWAN latest _DSD generation
This was to merge PCIe ACPI code to WWAN device. But, now use recent
_DSD generation changes in FM driver instead. PCie generic driver is
not used for WWAN at this time.
Also, PCI and RTD3 devices are moved to overridetree.cb where WWAN is
present.
BUG=b:221250331
BRANCH=firmware-brya-14505.B
TEST=
Check that _DSD is added to WWAN device in SSDT for the variants.
Check that RTD3 is added to WWAN device in SSDT for the variants.
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
M src/mainboard/google/brya/variants/brya0/overridetree.cb
M src/mainboard/google/brya/variants/brya4es/overridetree.cb
M src/mainboard/google/brya/variants/redrix/overridetree.cb
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
6 files changed, 76 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/62330/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/62330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f
Gerrit-Change-Number: 62330
Gerrit-PatchSet: 11
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Furquan Shaikh, Arthur Heymans, Prasad Malisetty.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57615 )
Change subject: libpayload: Add support for PCI MMIO CONFIG access.
......................................................................
Patch Set 37:
(6 comments)
File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/57615/comment/1be1e517_95211701
PS29, Line 285: onfig MMCONF_SUPPORT
: bool "MMCONF support for drivers"
: depends on SERIAL_CONSOLE
: default n
:
: config QC_MMCONF_SUPPORT
: bool "QC MMCONF support for drivers"
: depends on SERIAL_CONSOLE
: default n
:
> Please use MMIO instead of MMCONF as this can get confused with ECAM per the discussion in https://r […]
This is still an issue
File payloads/libpayload/drivers/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/57615/comment/dd29b936_afb3ec57
PS37, Line 34: ifeq ($(CONFIG_LP_MMCONF_SUPPORT),y)
: libc-$(CONFIG_LP_MMCONF_SUPPORT) += pci_mmio_ops.c
: libc-$(CONFIG_LP_QC_MMCONF_SUPPORT) += qc_pci_mmio_ops.c
These Kconfigs should all be MMIO and not MMCONF right?
File payloads/libpayload/drivers/pci_io_ops.c:
https://review.coreboot.org/c/coreboot/+/57615/comment/5c29dbe5_b64ff217
PS29, Line 70: pcidev_t *dev)
> Can we get rid of all the space changes in this file so that we just see the functional changes? My […]
This is still not fixed.
File payloads/libpayload/drivers/pci_mmio_ops.c:
https://review.coreboot.org/c/coreboot/+/57615/comment/d28a514d_eb4af08a
PS29, Line 74: pcidev_t *dev)
> Please get rid of the extra line changes in this file (from here down). […]
still an issue.
File payloads/libpayload/drivers/qc_pci_mmio_ops.c:
https://review.coreboot.org/c/coreboot/+/57615/comment/a3db92a1_7f8e9f75
PS37, Line 107: cfg_address = (void*) pci_mmio_info->config_base;
> "(void*)" should be "(void *)"
Please fix.
File payloads/libpayload/include/qc_pci.h:
https://review.coreboot.org/c/coreboot/+/57615/comment/e3727a00_71e76683
PS37, Line 70: #endif
> trailing whitespace
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57615
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d1217502cbd7d4d0cdd298919ae82435630d61c
Gerrit-Change-Number: 57615
Gerrit-PatchSet: 37
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 22:46:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen <shchen(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Raul Rangel, Marshall Dawson, Rob Barnes, Karthik Ramasubramanian.
Hello build bot (Jenkins), Bao Zheng, Raul Rangel, Marshall Dawson, Rob Barnes, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62795
to look at the new patch set (#7).
Change subject: util: Add amdfwread utility
......................................................................
util: Add amdfwread utility
Amdfwtool creates AMD firmware images however there is currently no way
to get information from an existing image. This commit adds amdfwread to
support that functionality. At the moment only reading PSP soft fuse
flags is supported.
BUG=b:202397678
TEST=Ran amdfwread and verified that it correctly read the soft fuse
bits
Signed-off-by: Robert Zieba <robertzieba(a)google.com>
Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850
---
A util/amdfwread/Makefile
A util/amdfwread/README.md
A util/amdfwread/amdfwread.c
M util/amdfwtool/amdfwtool.h
M util/testing/Makefile.inc
5 files changed, 283 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/62795/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/62795
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850
Gerrit-Change-Number: 62795
Gerrit-PatchSet: 7
Gerrit-Owner: Robert Zieba <robertzieba(a)google.com>
Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Peers <epeers(a)google.com>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Subrata Banik, Paul Menzel, Eric Lai, Angel Pons, Patrick Rudolph, EricR Lai.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62723 )
Change subject: soc/intel/common: Configure TCSS access through IOE P2SB
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/62723/comment/f3de226a_941f0ec3
PS3, Line 389: else if (CONFIG(SOC_INTEL_COMMON_BLOCK_TCSS_REG_ACCESS_SBI)) {
: if (CONFIG(SOC_INTEL_COMMON_BLOCK_IOE_P2SB))
> > Yes, I am working on future platform beyond the MTL which falls into 'else if (CONFIG(SOC_INTEL_CO […]
A bit update to tcss_valid_tbt_auth function which avoids the "control reaches end of non-void function".
--
To view, visit https://review.coreboot.org/c/coreboot/+/62723
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3302aabfb5f540c41da6359f11376b4202c6310b
Gerrit-Change-Number: 62723
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 22:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: John Zhao <john.zhao(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: John Zhao, Paul Menzel, Eric Lai, Angel Pons, Patrick Rudolph, EricR Lai.
Hello build bot (Jenkins), Subrata Banik, Wonkyu Kim, Eric Lai, Angel Pons, Patrick Rudolph, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62723
to look at the new patch set (#4).
Change subject: soc/intel/common: Configure TCSS access through IOE P2SB
......................................................................
soc/intel/common: Configure TCSS access through IOE P2SB
This change abstracts the TCSS access through IOE P2SB on Meteor Lake.
BUG=b:213574324
TEST=Build platforms coreboot images successfully.
Change-Id: I3302aabfb5f540c41da6359f11376b4202c6310b
Signed-off-by: John Zhao <john.zhao(a)intel.com>
---
M src/soc/intel/common/block/tcss/tcss.c
1 file changed, 25 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/62723/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/62723
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3302aabfb5f540c41da6359f11376b4202c6310b
Gerrit-Change-Number: 62723
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset