coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/skyrim: Add counter initializers
by Jon Murphy (Code Review) 16 Mar '22

16 Mar '22

Jon Murphy has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62864 ) Change subject: mb/google/skyrim: Add counter initializers ...................................................................... Abandoned OBE, resolved at SOC level -- To view, visit https://review.coreboot.org/c/coreboot/+/62864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69ad46a3c717bd6dee0f5d9daa5cf65696046be9 Gerrit-Change-Number: 62864 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/amd/common/block: Add mainboard_handle_smi
by Felix Held (Code Review) 16 Mar '22

16 Mar '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62598 ) Change subject: soc/amd/common/block: Add mainboard_handle_smi ...................................................................... soc/amd/common/block: Add mainboard_handle_smi The current SMM framework only allows the mainboard code to handle GPEs. i.e., Events 0 - 23. This change allows the mainboard code to handle any SMI events not handled by the SoC code. This will allow the mainboard code to handle `SMITYPE_ESPI_SMI`. BUG=b:222694093 TEST=Build guybrush Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I81943e8cb31e998f29cc60b565d3ca0a8dfe9cb2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62598 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/soc/amd/common/block/cpu/smm/smi_handler.c M src/soc/amd/common/block/include/amdblocks/smm.h 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved diff --git a/src/soc/amd/common/block/cpu/smm/smi_handler.c b/src/soc/amd/common/block/cpu/smm/smi_handler.c index e535cb0..ee8423a 100644 --- a/src/soc/amd/common/block/cpu/smm/smi_handler.c +++ b/src/soc/amd/common/block/cpu/smm/smi_handler.c @@ -7,6 +7,11 @@ #include <cpu/x86/smm.h> #include <soc/smi.h> +__weak void mainboard_handle_smi(int event) +{ + printk(BIOS_WARNING, "SMI event %d is missing handler\n", event); +} + static void process_smi_sources(uint32_t reg) { const uint32_t status = smi_read32(reg); @@ -19,6 +24,8 @@ source_handler = get_smi_source_handler(i + bit_zero); if (source_handler) source_handler(); + else if (reg != SMI_REG_SMISTS0 || (status & GEVENT_MASK) == 0) + mainboard_handle_smi(i + bit_zero); } } diff --git a/src/soc/amd/common/block/include/amdblocks/smm.h b/src/soc/amd/common/block/include/amdblocks/smm.h index 187eddf..46008fa 100644 --- a/src/soc/amd/common/block/include/amdblocks/smm.h +++ b/src/soc/amd/common/block/include/amdblocks/smm.h @@ -14,3 +14,5 @@ void handle_smi_gsmi(void); void handle_smi_store(void); void clear_tvalid(void); +/* See SMITYPE_* for list possible of events. GEVENTS are handled with mainboard_smi_gpi. */ +void mainboard_handle_smi(int event); -- To view, visit https://review.coreboot.org/c/coreboot/+/62598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81943e8cb31e998f29cc60b565d3ca0a8dfe9cb2 Gerrit-Change-Number: 62598 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/amd/common/block: Add mainboard_handle_smi
by Felix Held (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62598 ) Change subject: soc/amd/common/block: Add mainboard_handle_smi ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/soc/amd/common/block/cpu/smm/smi_handler.c: https://review.coreboot.org/c/coreboot/+/62598/comment/a3d7e389_60b20a96 PS2, Line 10: int i would use an unsigned int here. since this will require making the parameters of other functions and local variables unsigned int too, that's something for another patch though -- To view, visit https://review.coreboot.org/c/coreboot/+/62598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81943e8cb31e998f29cc60b565d3ca0a8dfe9cb2 Gerrit-Change-Number: 62598 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Wed, 16 Mar 2022 16:33:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Introduce v4.6 resource allocator
by Arthur Heymans (Code Review) 16 Mar '22

16 Mar '22

Hello Nico Huber, Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62865 to look at the new patch set (#2). Change subject: device: Introduce v4.6 resource allocator ...................................................................... device: Introduce v4.6 resource allocator This is not a complete rewrite, more an adaptation of the v4 allocator. For the moment, I suggest this for experiments, until we have a better understanding what we require from the resource allocator. It differs mostly in pass 2. Instead of searching memranges for every bridge, we only do that for the top level and finish the calculations of pass 1 at the bridge level. And we don't handle above-4G resources separately. This implies that we need a top-down allocation at the top level to place things above 4G, which will be added in a later commit. Detailed list of functional differences in v4.5 -------------------------------------------- Pass 1: * Completely ignore resources with 0 limit. * Don't propagate above-4G flag. Propagation makes it harder to effectively opt-out from 4G, e.g. for boot graphics / network devices. OTOH, this way resources can only be placed above 4G if all resources downstream of a bridge allow it. * Store the calculated `base` offset in the resources (like v3 did). This allows us to skip the largest_resource() walk at the bridge level in pass 2. Pass 2: * No separate handling for above-4G resources. They'll need a top-down mode. * No memranges at the bridge-level. Instead we simply add the offset that was pre-calculated in pass 1 to the allocated `base` of the bridge resource. This lowers the computational complexity of pass 2. But there's likely no measurable impact for our usual, shallow device trees. Beside that, there is some heavy refactoring: All the resource printing is factored out into separate functions. This results in one-liners in the actual program code which hopefully will distract less during reading. Some thin functions are manually inlined where it seems to improve readability, and comments are adapted and re-flown to 72 columns (counting from indentation level). V4.6 ---- * Allow for multiple domain resources. TEST=Works fine on OCP deltalake using multiple domains Change-Id: I462b384860b7e183b51118490417fb9106f0c7a1 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/device/Kconfig M src/device/Makefile.inc M src/northbridge/amd/agesa/family14/Kconfig M src/northbridge/amd/agesa/family15tn/Kconfig M src/northbridge/amd/agesa/family16kb/Kconfig M src/northbridge/amd/pi/00730F01/Kconfig 6 files changed, 25 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/62865/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I462b384860b7e183b51118490417fb9106f0c7a1 Gerrit-Change-Number: 62865 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: device: Introduce v4.6 resource allocator
by build bot (Jenkins) (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Nico Huber, Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62865 ) Change subject: device: Introduce v4.6 resource allocator ...................................................................... Patch Set 1: (1 comment) File src/device/resource_allocator_v4.5.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144128): https://review.coreboot.org/c/coreboot/+/62865/comment/05d30878_4ed84ac7 PS1, Line 419: void assign_resource_cb(void *param, struct device *dev, struct resource *res) open brace '{' following function definitions go on the next line -- To view, visit https://review.coreboot.org/c/coreboot/+/62865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I462b384860b7e183b51118490417fb9106f0c7a1 Gerrit-Change-Number: 62865 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 16 Mar 2022 16:21:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Introduce v4.6 resource allocator
by Arthur Heymans (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Nico Huber, Arthur Heymans. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62865 ) Change subject: device: Introduce v4.6 resource allocator ...................................................................... Patch Set 1: (1 comment) File src/device/Makefile.inc: https://review.coreboot.org/c/coreboot/+/62865/comment/0c9d96e6_cb688414 PS1, Line 64: ramstage-$(CONFIG_RESOURCE_ALLOCATOR_V4_5) += resource_allocator_v4.5.c that won't fly ^^ -- To view, visit https://review.coreboot.org/c/coreboot/+/62865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I462b384860b7e183b51118490417fb9106f0c7a1 Gerrit-Change-Number: 62865 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 16 Mar 2022 16:21:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Add counter initializers
by Felix Held (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62864 ) Change subject: mb/google/skyrim: Add counter initializers ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > You can probably abandon this patch. fixing this at soc level should be sufficient -- To view, visit https://review.coreboot.org/c/coreboot/+/62864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69ad46a3c717bd6dee0f5d9daa5cf65696046be9 Gerrit-Change-Number: 62864 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 16 Mar 2022 16:12:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/sabrina: Add counter initializers
by Felix Held (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Jason Glenesk, Marshall Dawson, Jon Murphy. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62863 ) Change subject: soc/amd/sabrina: Add counter initializers ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Patchset: PS6: please also fix this for the earlier socs. i'm ok with either doing that in this patch or in follow-up patches -- To view, visit https://review.coreboot.org/c/coreboot/+/62863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d4f5b1124d4017b04bcaf7044216fd696dce63d Gerrit-Change-Number: 62863 Gerrit-PatchSet: 6 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Comment-Date: Wed, 16 Mar 2022 16:09:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/hp/snb_ivb_laptops: Move selects from Kconfig.name to Kconfig
by Paul Menzel (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Felix Singer, Angel Pons, Michael Niewöhner. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62816 ) Change subject: mb/hp/snb_ivb_laptops: Move selects from Kconfig.name to Kconfig ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62816/comment/1565ccae_ef81b8b9 PS2, Line 10: at > Um, are you sure? I think "at" is correct here. https://www.reddit.com/r/grammar/comments/cogcz6/deleted_by_user/ -- To view, visit https://review.coreboot.org/c/coreboot/+/62816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I500f6422c1f8975de8b0bcc8b95cba2bcd4ebe27 Gerrit-Change-Number: 62816 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Wed, 16 Mar 2022 16:09:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/xeon_sp: Remove the allocator workaround
by build bot (Jenkins) (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Patrick Rudolph, Tim Chu. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62353 ) Change subject: soc/intel/xeon_sp: Remove the allocator workaround ...................................................................... Patch Set 5: Verified+1 (1 comment) File src/soc/intel/xeon_sp/chip_common.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144125): https://review.coreboot.org/c/coreboot/+/62353/comment/eba76435_3856f513 PS5, Line 63: res->flags = IORESOURCE_IO | IORESOURCE_SUBTRACTIVE | IORESOURCE_ASSIGNED; line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/62353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iedca35cca8350eb53b5be04c42474d2b4c9d347f Gerrit-Change-Number: 62353 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 16 Mar 2022 16:08:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022