coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: vendorcode/intel/edk2/edk2-stable202111: Use fixed size struct elements
by Subrata Banik (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Anil Kumar K, Wonkyu Kim, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62847 ) Change subject: vendorcode/intel/edk2/edk2-stable202111: Use fixed size struct elements ...................................................................... Patch Set 1: (1 comment) File src/vendorcode/intel/edk2/edk2-stable202111/IntelFsp2Pkg/Include/FspEas/FspApi.h: https://review.coreboot.org/c/coreboot/+/62847/comment/4d0fa0f0_6a9fe118 PS1, Line 147: UINT32 > I swear I brought this up to Nate before, that we should use fixed-size elements for ABIs, never `void *`... :) understood Tim, I have added this bug into intel<->google sync meeting and let's follow up there. -- To view, visit https://review.coreboot.org/c/coreboot/+/62847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f33db43f7932cf6d165d0c70a0e2922dad00a09 Gerrit-Change-Number: 62847 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Wonkyu Kim Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Patrick Rudolph Gerrit-Comment-Date: Thu, 17 Mar 2022 05:30:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks
by Usha P (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Kangheui Won, Reka Norman, Paul Menzel, Tim Wawrzynczak, Usha P. Hello build bot (Jenkins), Kangheui Won, Tim Wawrzynczak, Reka Norman, Deepti Deshatty, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62731 to look at the new patch set (#3). Change subject: mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks ...................................................................... mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks Enable SBU orientation handling by SoC for both USBC port0 and USBC port1. Nivviks USBC port0 do not have retimer, USBC port1 has redriver, but that do not flip the data lines. Hence we need to set bits for both the USBC ports. BRANCH:None TEST=emerge-nissa coreboot chromeos-bootimage Signed-off-by: Usha P <usha.p(a)intel.com> Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937 --- M src/mainboard/google/brya/variants/nivviks/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/62731/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62731 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937 Gerrit-Change-Number: 62731 Gerrit-PatchSet: 3 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: harsha.b.r(a)intel.com Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/adl: Remove IOM Mctp command from TCSS ASL
by Maulik V Vaghela (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Shobhit Srivastava, Subrata Banik, Kane Chen, Tim Wawrzynczak, Sridhar Siricilla. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62861 ) Change subject: soc/intel/adl: Remove IOM Mctp command from TCSS ASL ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62861/comment/be2c79fd_3db04a8b PS2, Line 14: Due to change in hardware sequence > maybe mention like […] Done https://review.coreboot.org/c/coreboot/+/62861/comment/188391bf_23b99d04 PS2, Line 26: MAULIK V VAGHELA > is your name in git config still set to all caps? 😄 Sorry, this was pushed from my another machine. Corrected now across all machines :) File src/soc/intel/alderlake/acpi/tcss.asl: https://review.coreboot.org/c/coreboot/+/62861/comment/646fb26f_82b98c01 PS2, Line 694: /* : * If the TCSS Deven is cleared by BIOS Mailbox request, then : * restore to previously saved value of TCSS DEVNE. : */ : Local0 = 0 : While (\_SB.PCI0.TXHC.VDID == 0xFFFFFFFF) { : If (DSGS () == 1) { : DSCR (0) : } : Local0++ : If (Local0 == 5) { : Printf("pCode mailbox command failed.") : Break : } : } > Is this part still necessary too? I don't see the reference code doing this. Ack https://review.coreboot.org/c/coreboot/+/62861/comment/9fcb7704_b545594f PS2, Line 725: /* : * If the TCSS Deven in normal state, then Save current TCSS DEVEN value and : * clear it. : */ : Local0 = 0 : While (\_SB.PCI0.TXHC.VDID != 0xFFFFFFFF) { : If (DSGS () == 0) { : DSCR (1) : } : Local0++ : If (Local0 == 5) { : Printf("pCode mailbox command failed.") : Break : } : } > Which means DSGS and DSCR are also unused now too I think Ack. Agreed Tim..I have removed Mailbox communication part -- To view, visit https://review.coreboot.org/c/coreboot/+/62861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f066bcc4a8f475a15ddd12ef5ed87d7298312bb Gerrit-Change-Number: 62861 Gerrit-PatchSet: 2 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Shobhit Srivastava <shobhit.srivastava(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shobhit Srivastava <shobhit.srivastava(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Comment-Date: Thu, 17 Mar 2022 05:26:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl: Remove IOM Mctp command from TCSS ASL
by Maulik V Vaghela (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Shobhit Srivastava, Subrata Banik, Maulik V Vaghela, Kane Chen, Sridhar Siricilla. Hello build bot (Jenkins), Shobhit Srivastava, Subrata Banik, Tim Wawrzynczak, Sridhar Siricilla, Kane Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62861 to look at the new patch set (#3). Change subject: soc/intel/adl: Remove IOM Mctp command from TCSS ASL ...................................................................... soc/intel/adl: Remove IOM Mctp command from TCSS ASL TCSS ASL code was carried forward from TGL and it used to follow the same sequence. Recently as part of s0ix hang issue, it was found that sending IOM MCTP command as part of TCSS D3 Cold enter-exit sequence created an issue. We discovered that due to change in hardware sequence, ADL should not set/reset IOM MCTP during D3 cold entry or exit. This patch removes the bit setting from ASL file to prevent hang in the system. This patch also removes obsolete Pcode mailbox communication which is no longer required for ADL. BUG=b:220796339 BRANCH=firmware-brya-14505.B TEST=Check if hang issue is resolved with the CL and no other regression observed Change-Id: I2f066bcc4a8f475a15ddd12ef5ed87d7298312bb Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Signed-off-by: Kane Chen <kane.chen(a)intel.com> --- M src/soc/intel/alderlake/acpi/tcss.asl 1 file changed, 1 insertion(+), 142 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/62861/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f066bcc4a8f475a15ddd12ef5ed87d7298312bb Gerrit-Change-Number: 62861 Gerrit-PatchSet: 3 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Shobhit Srivastava <shobhit.srivastava(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shobhit Srivastava <shobhit.srivastava(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: update overridetree
by Raihow Shi (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: YH Lin, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Zhuohao Lee, EricR Lai, Felix Held. Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62852 ) Change subject: mb/google/brask/variants/moli: update overridetree ...................................................................... Patch Set 32: (1 comment) Patchset: PS32: > Is there a reason this can't be squashed into CB:62321 ? Ok, The reason is CB:62321 based on the schematic adl-rfq_mb_20220216.pdf and this CL based on the schematic adl-rfq_mb_20220310.pdf, so i think it should have another CL. -- To view, visit https://review.coreboot.org/c/coreboot/+/62852 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If878362fe8b2e1d3397ca099477bb85bd4dee926 Gerrit-Change-Number: 62852 Gerrit-PatchSet: 32 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 17 Mar 2022 05:23:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/hp/z220_series: Convert z220_sff_workstation into variant
by Damien Zammit (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons. Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62808 ) Change subject: mb/hp/z220_series: Convert z220_sff_workstation into variant ...................................................................... Patch Set 2: (3 comments) File src/mainboard/hp/z220_series/Kconfig: https://review.coreboot.org/c/coreboot/+/62808/comment/3894327a_d08f8c67 PS2, Line 1: ## SPDX-License-Identifier: GPL-2.0-only > Hmmm, this license header wasn't there before Happy to remove it if you prefer. File src/mainboard/hp/z220_series/Kconfig.name: https://review.coreboot.org/c/coreboot/+/62808/comment/8f559d6e_6caa6d71 PS2, Line 1: ## SPDX-License-Identifier: GPL-2.0-only > Hmmm, this license header wasn't there before Ditto File src/mainboard/hp/z220_series/variants/z220_sff_workstation/overridetree.cb: https://review.coreboot.org/c/coreboot/+/62808/comment/379f1e24_2edbd5de PS2, Line 5: subsystemid 0x103c 0x1791 inherit > Is it necessary to specify the subsystemid here? It's in the devicetree already. Yes, without this line, the overridetree stops the devicetree from inheriting it because of it being missing. -- To view, visit https://review.coreboot.org/c/coreboot/+/62808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6aaac75216b2d7c8bb48801454ce616ace3b1422 Gerrit-Change-Number: 62808 Gerrit-PatchSet: 2 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 17 Mar 2022 05:21:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/banshee: Update DPTF parameters
by Sumeet R Pawnikar (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Frank Wu, John Su, YH Lin, Dtrain Hsu, Paul Menzel, Ricky Chang. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62807 ) Change subject: mb/google/brya/var/banshee: Update DPTF parameters ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62807/comment/058abf49_0c0bd506 PS1, Line 11: 223492897 Please add me in this bug to go through the design suggestions. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/62807 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5da776e7ae3368ce00cd29ec0ccdb5b7a725ff88 Gerrit-Change-Number: 62807 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Thu, 17 Mar 2022 05:14:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/wifi/generic: Fix properties in generic-under-PCI device case
by Tim Wawrzynczak (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Varshit B Pandya, Subrata Banik, Paul Menzel, Nick Vaccaro, Eric Lai. Hello Varshit B Pandya, build bot (Jenkins), Subrata Banik, Nick Vaccaro, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62746 to look at the new patch set (#4). Change subject: drivers/wifi/generic: Fix properties in generic-under-PCI device case ...................................................................... drivers/wifi/generic: Fix properties in generic-under-PCI device case In the devicetree case where a generic device underneath the Intel PCI CNVi device carries the device properties, the incorrect device was passed to wifi_ssdt_write_properties. Also while here, update the UUID for `DmaProperty` to match what Microsoft defined here: https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-… BUG=b:215424986, b:220639445 TEST=dump SSDT and see that _PRW for CNVi device is no longer garbage, but contains the value from the devicetree (GPE0_PME_B0). Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: Iafd86458d2f65ccb7e74d1308d37fd3ebbf7f520 --- M src/drivers/wifi/generic/acpi.c M src/drivers/wifi/generic/generic.c 2 files changed, 29 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/62746/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafd86458d2f65ccb7e74d1308d37fd3ebbf7f520 Gerrit-Change-Number: 62746 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/wifi/generic: Fix properties in generic-under-PCI device case
by Tim Wawrzynczak (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Varshit B Pandya, Subrata Banik, Paul Menzel, Nick Vaccaro, Eric Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62746 ) Change subject: drivers/wifi/generic: Fix properties in generic-under-PCI device case ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: strict IO/MMU won't work on wifi without this CL I don't think this is getting urgent -- To view, visit https://review.coreboot.org/c/coreboot/+/62746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafd86458d2f65ccb7e74d1308d37fd3ebbf7f520 Gerrit-Change-Number: 62746 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 17 Mar 2022 05:13:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/wifi/generic: Fix properties in generic-under-PCI device case
by Tim Wawrzynczak (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Varshit B Pandya, Subrata Banik, Paul Menzel, Nick Vaccaro. Hello Varshit B Pandya, build bot (Jenkins), Subrata Banik, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62746 to look at the new patch set (#3). Change subject: drivers/wifi/generic: Fix properties in generic-under-PCI device case ...................................................................... drivers/wifi/generic: Fix properties in generic-under-PCI device case In the devicetree case where a generic device underneath the Intel PCI CNVi device carries the device properties, the incorrect device was passed to wifi_ssdt_write_properties. Also while here, update the UUID for `DmaProperty` to match what Microsoft defined here: https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-… BUG=b:215424986, b:220639445 TEST=dump SSDT and see that _PRW for CNVi device is no longer garbage, but contains the value from the devicetree (GPE0_PME_B0). Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: Iafd86458d2f65ccb7e74d1308d37fd3ebbf7f520 --- M src/drivers/wifi/generic/acpi.c M src/drivers/wifi/generic/generic.c 2 files changed, 30 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/62746/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafd86458d2f65ccb7e74d1308d37fd3ebbf7f520 Gerrit-Change-Number: 62746 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022