coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/corsola: Revise power-on sequence of PS8640
by Rex-BC Chen (Code Review) 17 Mar '22

17 Mar '22

Rex-BC Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62893 ) Change subject: mb/google/corsola: Revise power-on sequence of PS8640 ...................................................................... mb/google/corsola: Revise power-on sequence of PS8640 The PS8640 vendor (Parade) suggests that the power-on sequence should trigger GPIO_EDPBRDG_RST_L twice. BUG=b:222650141 TEST=show fw display normally in krabby. Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I7706c56dc7fc13ac84c0d52a6e534bc0988e8fd3 --- M src/mainboard/google/corsola/display.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/62893/1 diff --git a/src/mainboard/google/corsola/display.c b/src/mainboard/google/corsola/display.c index fd269ec..1e1af64 100644 --- a/src/mainboard/google/corsola/display.c +++ b/src/mainboard/google/corsola/display.c @@ -29,6 +29,10 @@ gpio_output(GPIO_EDPBRDG_RST_L, 0); mdelay(2); gpio_output(GPIO_EDPBRDG_RST_L, 1); + mdelay(55); + gpio_output(GPIO_EDPBRDG_RST_L, 0); + mdelay(55); + gpio_output(GPIO_EDPBRDG_RST_L, 1); } static int bridge_ps8640_get_edid(u8 i2c_bus, struct edid *edid) -- To view, visit https://review.coreboot.org/c/coreboot/+/62893 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7706c56dc7fc13ac84c0d52a6e534bc0988e8fd3 Gerrit-Change-Number: 62893 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Disable spm_thermal which is not used
by Rex-BC Chen (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Hung-Te Lin. Hello Hung-Te Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62890 to look at the new patch set (#2). Change subject: soc/mediatek/mt8186: Disable spm_thermal which is not used ...................................................................... soc/mediatek/mt8186: Disable spm_thermal which is not used In MT8186, we need to disable spm_thermal to prevent it to influence other wdt status. For hardware path from thermal to wdt, there is another path directly from thermal to wdt. This bit is a flexibility for software control, and the hardware designer suggests that we can disable it if we don't use it. BUG=none TEST=build pass Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I0ffde6bad3000a64e3b5782edaa72c62da034302 --- M src/soc/mediatek/common/include/soc/wdt.h M src/soc/mediatek/mt8186/bootblock.c M src/soc/mediatek/mt8186/wdt.c 3 files changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/62890/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ffde6bad3000a64e3b5782edaa72c62da034302 Gerrit-Change-Number: 62890 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/apollolake: Correct enum for PrimaryVideoAdaptor FSP parameter
by Mario Scheithauer (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Nico Huber, Maxim Polyakov, Angel Pons, Werner Zeh, Andrey Petrov. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62889 ) Change subject: soc/intel/apollolake: Correct enum for PrimaryVideoAdaptor FSP parameter ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Change was tested on siemens/mc_apl1 with older Linux gfx driver and works with it again. -- To view, visit https://review.coreboot.org/c/coreboot/+/62889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iedbc144fa809f6d4587f5223b235ee95579c48f7 Gerrit-Change-Number: 62889 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Thu, 17 Mar 2022 08:10:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Disable spm_thermal which is not used
by Rex-BC Chen (Code Review) 17 Mar '22

17 Mar '22

Rex-BC Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62890 ) Change subject: soc/mediatek/mt8186: Disable spm_thermal which is not used ...................................................................... soc/mediatek/mt8186: Disable spm_thermal which is not used In MT8186, we need to disable spm_thermal to prevent it to influence other wdt status. For hardware path from thermal to wdt, there is another path directly from thermal to wdt. This bit is a flexibility for software control, and the hardware designer suggests that we can disable it if we don't use it. BUG=none TEST=build pass Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I0ffde6bad3000a64e3b5782edaa72c62da034302 --- M src/soc/mediatek/common/include/soc/wdt.h M src/soc/mediatek/mt8186/bootblock.c M src/soc/mediatek/mt8186/wdt.c 3 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/62890/1 diff --git a/src/soc/mediatek/common/include/soc/wdt.h b/src/soc/mediatek/common/include/soc/wdt.h index cd43134..157bed3 100644 --- a/src/soc/mediatek/common/include/soc/wdt.h +++ b/src/soc/mediatek/common/include/soc/wdt.h @@ -14,9 +14,12 @@ u32 wdt_interval; u32 wdt_swrst; u32 wdt_swsysrst; - u32 reserved[9]; + u32 reserved0[5]; + u32 wdt_req_mode; + u32 reserved1[3]; u32 wdt_debug_ctrl; }; +check_member(mtk_wdt_regs, wdt_debug_ctrl, 0x40); /* WDT_MODE */ enum { @@ -38,6 +41,7 @@ static struct mtk_wdt_regs *const mtk_wdt = (void *)RGU_BASE; +void mtk_wdt_preinit(void); int mtk_wdt_init(void); void mtk_wdt_clr_status(void); diff --git a/src/soc/mediatek/mt8186/bootblock.c b/src/soc/mediatek/mt8186/bootblock.c index e5d1e73..29de7fb 100644 --- a/src/soc/mediatek/mt8186/bootblock.c +++ b/src/soc/mediatek/mt8186/bootblock.c @@ -12,6 +12,7 @@ { mtk_mmu_init(); bustracker_init(); + mtk_wdt_preinit(); mtk_wdt_init(); mt_pll_init(); unmask_eint_event_mask(); diff --git a/src/soc/mediatek/mt8186/wdt.c b/src/soc/mediatek/mt8186/wdt.c index fbc9bb9..ff93129 100644 --- a/src/soc/mediatek/mt8186/wdt.c +++ b/src/soc/mediatek/mt8186/wdt.c @@ -10,9 +10,16 @@ #include <soc/wdt.h> #define MTK_WDT_CLR_STATUS_VAL 0x22 +#define MTK_WDT_REQ_MOD_KEY 0x33000000 +#define MTK_WDT_SPM_THERMAL_EN BIT(0) DEFINE_BITFIELD(MTK_WDT_CLR_STATUS, 31, 24) +void mtk_wdt_preinit(void) +{ + clrsetbits32(&mtk_wdt->wdt_req_mode, MTK_WDT_SPM_THERMAL_EN, MTK_WDT_REQ_MOD_KEY); +} + void mtk_wdt_clr_status(void) { SET32_BITFIELDS(&mtk_wdt->wdt_mode, -- To view, visit https://review.coreboot.org/c/coreboot/+/62890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ffde6bad3000a64e3b5782edaa72c62da034302 Gerrit-Change-Number: 62890 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/apollolake: Correct enum for PrimaryVideoAdaptor FSP parameter
by Werner Zeh (Code Review) 17 Mar '22

17 Mar '22

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62889 ) Change subject: soc/intel/apollolake: Correct enum for PrimaryVideoAdaptor FSP parameter ...................................................................... soc/intel/apollolake: Correct enum for PrimaryVideoAdaptor FSP parameter Commit 1a4496e79f21 (soc/{apl,glk}: Allow to select the primary graphics device) adds code to set the FSP parameter 'PrimaryVideoAdaptor' based on the enum description of the FspmUpd.h for Apollo Lake. Unfortunately, the comment in the header file does not match the implementation in the FSP and hence setting PrimaryVideoAdaptor to 'GPU_PRIMARY_IGD' will be treated as if the selection was 'GPU_PRIMARY_PCI'. This in turn leads to Linux gfx driver issues for earlier driver implementations. This commit corrects the enum values for the FSP parameter to match the implementation. Change-Id: Iedbc144fa809f6d4587f5223b235ee95579c48f7 Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/soc/intel/apollolake/romstage.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/62889/1 diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c index 08543b1..1d8752f 100644 --- a/src/soc/intel/apollolake/romstage.c +++ b/src/soc/intel/apollolake/romstage.c @@ -232,8 +232,8 @@ static void soc_gpu_init_params(FSPM_UPD *mupd) { enum { - GPU_PRIMARY_IGD = 2, - GPU_PRIMARY_PCI = 3, + GPU_PRIMARY_IGD = 0, + GPU_PRIMARY_PCI = 1, }; /* Select primary GPU device */ if (CONFIG(ONBOARD_VGA_IS_PRIMARY) && is_devfn_enabled(SA_DEVFN_IGD)) -- To view, visit https://review.coreboot.org/c/coreboot/+/62889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iedbc144fa809f6d4587f5223b235ee95579c48f7 Gerrit-Change-Number: 62889 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: vendorcode: Add VariableFormat.h
by Patrick Rudolph (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Angel Pons, Patrick Rudolph. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61959 ) Change subject: vendorcode: Add VariableFormat.h ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Is there a way to avoid the UDK2017 dependency? If this is the only edk2 header needed to implement […] It needs multiple headers, not only this one. Not sure why multiple UDK versions exists as we don't build FSP, just wrapper code. -- To view, visit https://review.coreboot.org/c/coreboot/+/61959 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe44925555a7d1d2361dd48c0325b840bd68e0ca Gerrit-Change-Number: 61959 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 17 Mar 2022 07:38:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/efi: Add EFI variable store option support
by Patrick Rudolph (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Sean Rhodes, Martin Roth, Jakub Czapiga, Matt DeVillier, Angel Pons, Arthur Heymans, Patrick Rudolph. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52564 ) Change subject: drivers/efi: Add EFI variable store option support ...................................................................... Patch Set 10: (5 comments) File src/drivers/efi/Kconfig: https://review.coreboot.org/c/coreboot/+/52564/comment/780bbf4d_9d7e8a55 PS10, Line 1: DRIVERS_EFI_VARIABLE_STORE > If it only needs the headers, why not include them directly? I'd avoid binding to a specific edk2 ve […] yes, it needs to bind against UDK as the Makefile.inc sets the header include directory. Are there conflicts if I select multiple UDK at the same time? File src/drivers/efi/efivars.c: https://review.coreboot.org/c/coreboot/+/52564/comment/9e2432fe_2be390d5 PS10, Line 75: WA > ? W=WCHAR A=ASCII typically used on windows. Any better idea? https://review.coreboot.org/c/coreboot/+/52564/comment/c257150c_49752c74 PS10, Line 83: while (1) > I'd prefer a for-loop to avoid going past the end of `msg` As long as both strings are NULL termintated I don't see an issue. https://review.coreboot.org/c/coreboot/+/52564/comment/3b204f4f_6c0d7cdb PS10, Line 86: (r = (c - msg[i])) > Is it necessary to do this assignment in the condition? I just copied this code from src/lib. https://review.coreboot.org/c/coreboot/+/52564/comment/3f25ac60_cfc1f317 PS10, Line 271: void * > Why is this a void pointer? The third argument of walk_variables has the function prototype: ``` cb_err_t (*walker)(struct region_device *rdev, VARIABLE_HEADER *hdr, size_t hdr_size, void *arg, bool *stop) ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/52564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb Gerrit-Change-Number: 52564 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Patrick Rudolph Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 17 Mar 2022 07:36:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Make sure the level is an legal value
by Bao Zheng (Code Review) 17 Mar '22

17 Mar '22

Bao Zheng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62487 ) Change subject: amdfwtool: Make sure the level is an legal value ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie058d2ad48acbf9c3f219c472632cddceddfb825 Gerrit-Change-Number: 62487 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: amd/*/Makefile.inc: Remove the useless dependency of FW files
by Bao Zheng (Code Review) 17 Mar '22

17 Mar '22

Bao Zheng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/61970 ) Change subject: amd/*/Makefile.inc: Remove the useless dependency of FW files ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/61970 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8baa55576d81d9607d86a62cd70dfaa9b028de88 Gerrit-Change-Number: 61970 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks
by Eric Lai (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Kangheui Won, Paul Menzel, Tim Wawrzynczak, Usha P, Deepti Deshatty. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62731 ) Change subject: mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62731 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937 Gerrit-Change-Number: 62731 Gerrit-PatchSet: 7 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: harsha.b.r(a)intel.com Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Comment-Date: Thu, 17 Mar 2022 07:18:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022