Attention is currently required from: Kangheui Won, Paul Menzel, Tim Wawrzynczak, Usha P, Deepti Deshatty.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62731 )
Change subject: mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62731
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937
Gerrit-Change-Number: 62731
Gerrit-PatchSet: 9
Gerrit-Owner: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: harsha.b.r(a)intel.com
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Comment-Date: Thu, 17 Mar 2022 09:37:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kangheui Won, Rizwan Qureshi, Paul Menzel, Tim Wawrzynczak, Deepti Deshatty.
Hello build bot (Jenkins), Kangheui Won, Rizwan Qureshi, Reka Norman, Tim Wawrzynczak, Eric Lai, Deepti Deshatty,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62731
to look at the new patch set (#9).
Change subject: mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks
......................................................................
mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks
Enable SBU orientation handling by SoC for both USBC port0 and USBC
port1. Nivviks USBC port0 do not have retimer, USBC port1 has redriver,
but that do not flip the data lines. Hence we need to set bits for both
the USBC ports.
BRANCH:None
TEST=emerge-nissa coreboot chromeos-bootimage. Flash the image on
nivviks board and verified USBC display is working on both the ports in
normal and inverted connections.
Signed-off-by: Usha P <usha.p(a)intel.com>
Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937
---
M src/mainboard/google/brya/variants/nivviks/overridetree.cb
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/62731/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/62731
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937
Gerrit-Change-Number: 62731
Gerrit-PatchSet: 9
Gerrit-Owner: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: harsha.b.r(a)intel.com
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kangheui Won, Rizwan Qureshi, Paul Menzel, Tim Wawrzynczak, Deepti Deshatty.
Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62731 )
Change subject: mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62731/comment/4af1d576_cf08eae2
PS7, Line 15: TEST
> How did you verify this change is working?
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/62731
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937
Gerrit-Change-Number: 62731
Gerrit-PatchSet: 8
Gerrit-Owner: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: harsha.b.r(a)intel.com
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Comment-Date: Thu, 17 Mar 2022 09:31:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Kangheui Won, Paul Menzel, Tim Wawrzynczak, Usha P, Deepti Deshatty.
Hello build bot (Jenkins), Kangheui Won, Rizwan Qureshi, Reka Norman, Tim Wawrzynczak, Eric Lai, Deepti Deshatty,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62731
to look at the new patch set (#8).
Change subject: mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks
......................................................................
mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks
Enable SBU orientation handling by SoC for both USBC port0 and USBC
port1. Nivviks USBC port0 do not have retimer, USBC port1 has redriver,
but that do not flip the data lines. Hence we need to set bits for both
the USBC ports.
BRANCH:None
TEST=emerge-nissa coreboot chromeos-bootimage. Flash the image on nivviks
board and verified USBC display is working on both the ports in normal
and inverted connections.
Signed-off-by: Usha P <usha.p(a)intel.com>
Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937
---
M src/mainboard/google/brya/variants/nivviks/overridetree.cb
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/62731/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/62731
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937
Gerrit-Change-Number: 62731
Gerrit-PatchSet: 8
Gerrit-Owner: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: harsha.b.r(a)intel.com
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kangheui Won, Paul Menzel, Tim Wawrzynczak, Usha P, Deepti Deshatty.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62731 )
Change subject: mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62731/comment/37ea3602_1a42bd6d
PS7, Line 15: TEST
How did you verify this change is working?
--
To view, visit https://review.coreboot.org/c/coreboot/+/62731
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937
Gerrit-Change-Number: 62731
Gerrit-PatchSet: 7
Gerrit-Owner: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: harsha.b.r(a)intel.com
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Comment-Date: Thu, 17 Mar 2022 09:17:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kangheui Won, Paul Menzel, Tim Wawrzynczak, Usha P, Deepti Deshatty.
Rizwan Qureshi has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/62731 )
Change subject: mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks
......................................................................
Removed Code-Review+2 by Rizwan Qureshi <rizwan.qureshi(a)intel.com>
--
To view, visit https://review.coreboot.org/c/coreboot/+/62731
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937
Gerrit-Change-Number: 62731
Gerrit-PatchSet: 7
Gerrit-Owner: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: harsha.b.r(a)intel.com
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-MessageType: deleteVote
Attention is currently required from: Kangheui Won, Paul Menzel, Tim Wawrzynczak, Usha P, Deepti Deshatty.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62731 )
Change subject: mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62731
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937
Gerrit-Change-Number: 62731
Gerrit-PatchSet: 7
Gerrit-Owner: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: harsha.b.r(a)intel.com
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Comment-Date: Thu, 17 Mar 2022 09:15:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62890
to look at the new patch set (#3).
Change subject: soc/mediatek/mt8186: Disable spm_thermal which is not used
......................................................................
soc/mediatek/mt8186: Disable spm_thermal which is not used
In MT8186, we need to disable spm_thermal to prevent it to influence
other wdt status. For hardware path from thermal to wdt, there is
another path directly from thermal to wdt.
This bit is a flexibility for software control, and the hardware
designer suggests that we can disable it if we don't use it.
BUG=none
TEST=build pass
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I0ffde6bad3000a64e3b5782edaa72c62da034302
---
M src/soc/mediatek/common/include/soc/wdt.h
M src/soc/mediatek/mt8186/bootblock.c
M src/soc/mediatek/mt8186/wdt.c
3 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/62890/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/62890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ffde6bad3000a64e3b5782edaa72c62da034302
Gerrit-Change-Number: 62890
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Rex-BC Chen, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62893 )
Change subject: mb/google/corsola: Revise power-on sequence of PS8640
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
can they provide a reference, for example the name of the datasheet and the section that described that?
--
To view, visit https://review.coreboot.org/c/coreboot/+/62893
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7706c56dc7fc13ac84c0d52a6e534bc0988e8fd3
Gerrit-Change-Number: 62893
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 17 Mar 2022 08:44:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment