coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: driver/wifi: Add _DSM method for DDRRFIM
by Tim Wawrzynczak (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Varshit B Pandya, Subrata Banik, Maulik V Vaghela, Paul Menzel, Sugnan Prabhu S, Tim Wawrzynczak. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61020 ) Change subject: driver/wifi: Add _DSM method for DDRRFIM ...................................................................... Patch Set 24: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I217b736df3d4224a6732d1941a160abcddbd8f37 Gerrit-Change-Number: 61020 Gerrit-PatchSet: 24 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Wed, 23 Mar 2022 17:19:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/lint/checkpatch: Warn on period at the end of commit subject
by Marc Jones (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Martin Roth. Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63032 ) Change subject: util/lint/checkpatch: Warn on period at the end of commit subject ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If95bef3ba01e0ac13ce18045928081040abef4fd Gerrit-Change-Number: 63032 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 23 Mar 2022 17:07:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/lint/checkpatch: Warn on period at the end of commit subject
by Paul Menzel (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Martin Roth. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63032 ) Change subject: util/lint/checkpatch: Warn on period at the end of commit subject ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: Awesome. You put me out of work. ;-) File util/lint/checkpatch.pl: https://review.coreboot.org/c/coreboot/+/63032/comment/90a01764_19ddf92d PS1, Line 2682: WARN("COMMIT_LOG_LONG_LINE", : "Possible long commit subject (prefer a maximum 65 characters)\n" . $herecurr); Squash this hunk into the commit introducing this? -- To view, visit https://review.coreboot.org/c/coreboot/+/63032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If95bef3ba01e0ac13ce18045928081040abef4fd Gerrit-Change-Number: 63032 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 23 Mar 2022 17:06:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/lint/checkpatch: Update commit message & subject line limits
by Paul Menzel (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Martin Roth. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63029 ) Change subject: util/lint/checkpatch: Update commit message & subject line limits ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ef131a65254e2b184b05e0215969aef97e12712 Gerrit-Change-Number: 63029 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 23 Mar 2022 17:04:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/usb/ehci_debug.c: Fix building with clang
by Paul Menzel (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61891 ) Change subject: drivers/usb/ehci_debug.c: Fix building with clang ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/61891/comment/da318614_c8538491 PS3, Line 7: drivers/usb/ehci_debug.c: Fix building with clang Maybe: > drivers/usb/ehci_debug: Fix unused variable warning or > drivers/usb/ehci_debug: Convert #if to C code https://review.coreboot.org/c/coreboot/+/61891/comment/590ff83c_38916e1f PS3, Line 9: Clang What version? -- To view, visit https://review.coreboot.org/c/coreboot/+/61891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf5fd69fbf54b0d40bfdb17d1396d77dcb0a6060 Gerrit-Change-Number: 61891 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 23 Mar 2022 17:02:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/tpm: Add workaround for Ti50
by Paul Menzel (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Tim Wawrzynczak, Christian Walter, Eric Lai. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63011 ) Change subject: drivers/i2c/tpm: Add workaround for Ti50 ...................................................................... Patch Set 4: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63011/comment/09927e57_f8ed88b2 PS4, Line 7: drivers/i2c/tpm: Add workaround for Ti50 Maybe: > Work around missing board_cfg in Ti50 FW 0.15 https://review.coreboot.org/c/coreboot/+/63011/comment/a66ac3d2_f7c1bbbb PS4, Line 9: is not support board cfg I do not understand the problem. Can you please elaborate. Do you mean “dropped support for board_cfg”? https://review.coreboot.org/c/coreboot/+/63011/comment/06a25aae_3c1668d7 PS4, Line 11: What is with the firmware versions inbetween? File src/drivers/i2c/tpm/Kconfig: https://review.coreboot.org/c/coreboot/+/63011/comment/73732329_01a40de0 PS4, Line 31: which with? https://review.coreboot.org/c/coreboot/+/63011/comment/dec6ce99_c6c85ce6 PS4, Line 31: Board has a Ti50 I2C workaround which Ti50 FW under 0.15 Please elaborate. File src/drivers/i2c/tpm/cr50.c: https://review.coreboot.org/c/coreboot/+/63011/comment/4ab22856_36eb4fe2 PS4, Line 503: /* Ti50 FW version under 0.15 doesn't support board cfg … anymore? https://review.coreboot.org/c/coreboot/+/63011/comment/bd0f19f6_5ec7d646 PS4, Line 505: */ Belongs on the line above. -- To view, visit https://review.coreboot.org/c/coreboot/+/63011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d Gerrit-Change-Number: 63011 Gerrit-PatchSet: 4 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 23 Mar 2022 16:57:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/lint/checkpatch: Warn on period at the end of commit subject
by Martin Roth (Code Review) 23 Mar '22

23 Mar '22

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63032 ) Change subject: util/lint/checkpatch: Warn on period at the end of commit subject ...................................................................... util/lint/checkpatch: Warn on period at the end of commit subject This gives a warning when there's a period at the end of the commit subject line. Change-Id: If95bef3ba01e0ac13ce18045928081040abef4fd Signed-off-by: Martin Roth <martin(a)coreboot.org> --- M util/lint/checkpatch.pl 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/63032/1 diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 9355186..b3a501c 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -2673,14 +2673,18 @@ # coreboot: The line subject limit is 65 # Check for line lengths > 65 in commit subject +# Check for a period at the end of the subject line if ($in_header_lines && $line =~ /^Subject: /) { $line = $line.$rawlines[$linenr]; $line =~ s/^Subject: \[PATCH\] //; if (length($line) > 65) { - WARN("COMMIT_LOG_LONG_LINE", - "Possible long commit subject (prefer a maximum 65 characters)\n" . $herecurr); + WARN("COMMIT_LOG_LONG_LINE", + "Possible long commit subject (prefer a maximum 65 characters)\n" . $herecurr); } + if ($line =~ /\.$/) { + WARN("SUBJECT_HAS_FULL_STOP", + "Subject line should not end with a period.\n" . $herecurr); } # Reset possible stack dump if a blank line is found -- To view, visit https://review.coreboot.org/c/coreboot/+/63032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If95bef3ba01e0ac13ce18045928081040abef4fd Gerrit-Change-Number: 63032 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/lint: Add commit message parsing to checkpatch_json script
by Martin Roth (Code Review) 23 Mar '22

23 Mar '22

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63031 ) Change subject: util/lint: Add commit message parsing to checkpatch_json script ...................................................................... util/lint: Add commit message parsing to checkpatch_json script The commit message wasn't being parsed because there's no filename associated with it in the patch output. This change adds the filename for the commit message in Gerrit for any errors that have a line number but no filename. Change-Id: Ie7a2ef06419c7090c8e44b3b734b1edf966597cc Signed-off-by: Martin Roth <martin(a)coreboot.org> --- M util/lint/checkpatch_json.py 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/63031/1 diff --git a/util/lint/checkpatch_json.py b/util/lint/checkpatch_json.py index 81946ca..2915052 100755 --- a/util/lint/checkpatch_json.py +++ b/util/lint/checkpatch_json.py @@ -10,6 +10,7 @@ import os import sys import json +import re data = {} data['comments'] = [] @@ -38,6 +39,10 @@ file_path = temp[1].split(":")[0] line_number = temp[1].split(":")[1] update_struct( file_path.strip(), msg_output, str(line_number) ) + elif re.search("^\d+:\Z",line) != "None": + file_path="COMMIT_MESSAGE" + line_number = line.split(":") + update_struct( file_path.strip(), msg_output, str(line_number) ) else: continue fp.close() -- To view, visit https://review.coreboot.org/c/coreboot/+/63031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie7a2ef06419c7090c8e44b3b734b1edf966597cc Gerrit-Change-Number: 63031 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/skyrim: Add DXIO descriptors
by Karthik Ramasubramanian (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Raul Rangel, Jon Murphy, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62903 ) Change subject: mb/google/skyrim: Add DXIO descriptors ...................................................................... Patch Set 10: (1 comment) File src/mainboard/google/skyrim/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/62903/comment/3d676259_7eee6e05 PS10, Line 20: .gpio_group_id = GPIO_7, Remove the AUX Reset GPIO for now since FSP is not happy restoring more than 2 GPIOs. -- To view, visit https://review.coreboot.org/c/coreboot/+/62903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib68cf3d64641b006e0f2c4805af22b44a505a0d1 Gerrit-Change-Number: 62903 Gerrit-PatchSet: 10 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 23 Mar 2022 16:54:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: checkpatch.conf: Disable gerrit change ID for coreboot
by Martin Roth (Code Review) 23 Mar '22

23 Mar '22

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63030 ) Change subject: checkpatch.conf: Disable gerrit change ID for coreboot ...................................................................... checkpatch.conf: Disable gerrit change ID for coreboot The GERRIT_CHANGE_ID Error is useful for the linux flow, but since coreboot uses gerrit, giving an error on the ID doesn't make sense. Change-Id: I7f6efb5559027ed9497ee85497bb4b4e786f9901 Signed-off-by: Martin Roth <martin(a)coreboot.org> --- M .checkpatch.conf 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/63030/1 diff --git a/.checkpatch.conf b/.checkpatch.conf index 95019d1..dbb1aaa 100644 --- a/.checkpatch.conf +++ b/.checkpatch.conf @@ -22,6 +22,7 @@ --ignore PRINTK_WITHOUT_KERN_LEVEL --ignore ASSIGN_IN_IF --ignore UNNECESSARY_ELSE +--ignore GERRIT_CHANGE_ID # FILE_PATH_CHANGES seems to not be working correctly. It will # choke on added / deleted files even if the MAINTAINERS file -- To view, visit https://review.coreboot.org/c/coreboot/+/63030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f6efb5559027ed9497ee85497bb4b4e786f9901 Gerrit-Change-Number: 63030 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022