Attention is currently required from: Martin Roth, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63030 )
Change subject: checkpatch.conf: Disable gerrit change ID for coreboot
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/63030
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f6efb5559027ed9497ee85497bb4b4e786f9901
Gerrit-Change-Number: 63030
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 23 Mar 2022 18:23:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63029 )
Change subject: util/lint/checkpatch: Update commit message & subject line limits
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/63029
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ef131a65254e2b184b05e0215969aef97e12712
Gerrit-Change-Number: 63029
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 18:22:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Paul Menzel.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63030 )
Change subject: checkpatch.conf: Disable gerrit change ID for coreboot
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/63030
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f6efb5559027ed9497ee85497bb4b4e786f9901
Gerrit-Change-Number: 63030
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 23 Mar 2022 18:15:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63029 )
Change subject: util/lint/checkpatch: Update commit message & subject line limits
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63029
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ef131a65254e2b184b05e0215969aef97e12712
Gerrit-Change-Number: 63029
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 18:13:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Hello Arthur Heymans,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/63034
to review the following change.
Change subject: Docs/project_ideas: Make coreboot ARM BBR compliant
......................................................................
Docs/project_ideas: Make coreboot ARM BBR compliant
Change-Id: I0f5f1f0a613ed0ed3f8ecdf3c1330a0d78efe399
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M Documentation/contributing/project_ideas.md
1 file changed, 31 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/63034/1
diff --git a/Documentation/contributing/project_ideas.md b/Documentation/contributing/project_ideas.md
index 75c78ca..5d7b4496 100644
--- a/Documentation/contributing/project_ideas.md
+++ b/Documentation/contributing/project_ideas.md
@@ -228,3 +228,34 @@
### Mentors
* Patrick Rudolph <patrick.rudolph(a)9elements.com>
* Christian Walter <christian.walter(a)9elements.com>
+
+## Make coreboot ARM (L)BBR compliant
+The ARM [BBR](https://developer.arm.com/documentation/den0044/f/), Base Boot
+Requirements is a firmware specification describing how ARM64 servers and
+hyperscalers should load an operating system. The main purpose of this
+specification is to boot Operating systems like Linux without
+[devicetree](https://www.kernel.org/doc/html/latest/devicetree/usage-model.html)
+but using SMBIOS, ACPI and UEFI runtime services.
+
+Currently coreboot has no support for SMBIOS or ACPI.
+coreboot also does not support runtime services by design.
+The mandated UEFI runtime services seem only useful to provide Linux both
+SMBIOS & ACPI.
+
+So the scope of this project would be:
+* Port the QEMU aarch64 sbsa-ref machine to coreboot
+* Implement SMBIOS on ARM64
+* Implement ACPI on ARM64
+* Investigate how to provide minimal UEFI runtime services, e.g. in a payload
+ or better find an (upstreamable) way in Linux on how to pass ACPI & SMBIOS without
+ UEFI runtime services
+
+### Requirements
+* Hardware knowledge: Nothing (target is emulated)
+* coreboot knowledge: Know how tables are generated/injected and passed to
+ Payloads
+* Linux knowledge: Being able to compile and debug it. Some knowledge on the
+ boot process is certainly helpful.
+
+### Mentors
+* Arthur Heymans <arthur.heymans(a)9elements.com>
--
To view, visit https://review.coreboot.org/c/coreboot/+/63034
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f5f1f0a613ed0ed3f8ecdf3c1330a0d78efe399
Gerrit-Change-Number: 63034
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63025 )
Change subject: soc/amd/cezanne/cpu.c: Skip SMMINFO init in S3 resume
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63025/comment/6a68b255_1abcc5ce
PS1, Line 9: setup
> The verb is spelled with a space: set up.
Done
File src/soc/amd/cezanne/cpu.c:
https://review.coreboot.org/c/coreboot/+/63025/comment/29364fb9_637a143e
PS1, Line 41: setup
> set up
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30ee6d7006ddac4dbdae9825bd4fa6eac7fd48cb
Gerrit-Change-Number: 63025
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 23 Mar 2022 18:02:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63025
to look at the new patch set (#2).
Change subject: soc/amd/cezanne/cpu.c: Skip SMMINFO init in S3 resume
......................................................................
soc/amd/cezanne/cpu.c: Skip SMMINFO init in S3 resume
SMMINFO is already set up in S5, so it should be skipped in S3 resume
BUG=b:194990818
TEST=Build guybrush
Change-Id: I30ee6d7006ddac4dbdae9825bd4fa6eac7fd48cb
Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com>
---
M src/soc/amd/cezanne/cpu.c
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/63025/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30ee6d7006ddac4dbdae9825bd4fa6eac7fd48cb
Gerrit-Change-Number: 63025
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset