coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/intel/adlrvp: Set half_populated true for ADL-N
by Reka Norman (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: V Sowmya, Rizwan Qureshi, Balaji Manigandan, Krishna P Bhat D, Usha P. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62913 ) Change subject: mb/intel/adlrvp: Set half_populated true for ADL-N ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: When you did this for nissa, Tim made a comment which I agree with: this feels like a hack, and it would be better to generalise the structures in meminit.h to handle this case properly. It doesn't have to be done now, but I think we should at least file a bug to clean this up at some point. -- To view, visit https://review.coreboot.org/c/coreboot/+/62913 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ecc3018a1ab039990ba47898ff0e0e2ede695cc Gerrit-Change-Number: 62913 Gerrit-PatchSet: 3 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kangheui Won <khwon(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Sun, 27 Mar 2022 23:06:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/tgl-u: add new board L14xMU
by build bot (Jenkins) (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Felix Singer, Paul Menzel, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 ) Change subject: mb/clevo/tgl-u: add new board L14xMU ...................................................................... Patch Set 13: (6 comments) File src/mainboard/clevo/tgl-u/variants/l140mu/gpio.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144812): https://review.coreboot.org/c/coreboot/+/59548/comment/3afa195a_9b7bda3a PS13, Line 94: PAD_CFG_NF(GPP_C18, NONE, DEEP, NF1), /* I2C1_SDA / PCH_I2C_SDA (retimer rom) */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144812): https://review.coreboot.org/c/coreboot/+/59548/comment/fb6ec064_bc0a6862 PS13, Line 95: PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1), /* I2C1_SCL / PCH_I2C_SCL (retimer rom) */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144812): https://review.coreboot.org/c/coreboot/+/59548/comment/59822148_95349945 PS13, Line 99: PAD_NC(GPP_C23, UP_20K), /* GPP_C23 / PCH_GPP_C23 (WLAN_WAKEUP#) */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144812): https://review.coreboot.org/c/coreboot/+/59548/comment/f10bd961_ba4b376e PS13, Line 104: PAD_NC(GPP_D2, NONE), /* LEDKB_DET# (unused; not sold w/o KBLED) */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144812): https://review.coreboot.org/c/coreboot/+/59548/comment/9e1e38c6_22fb71e9 PS13, Line 107: PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* SRCCLKREQ0# / SSD1_CLKREQ# (for SSD2!) */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144812): https://review.coreboot.org/c/coreboot/+/59548/comment/1d9ade38_6622d11c PS13, Line 110: PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), /* SRCCLKREQ3# / SSD2_CLKREQ# (for SSD1!) */ line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/59548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c4bef3827da10241e9b01e12ecc4276e131a620 Gerrit-Change-Number: 59548 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Sun, 27 Mar 2022 22:14:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/tgl-u: add new board L14xMU
by Michael Niewöhner (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Felix Singer, Paul Menzel, Tim Wawrzynczak. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 ) Change subject: mb/clevo/tgl-u: add new board L14xMU ...................................................................... Patch Set 13: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59548/comment/de119df2_bace8c3d PS8, Line 56: > Too make it crystal clear, maybe mention “vendor firmware”. Done Commit Message: https://review.coreboot.org/c/coreboot/+/59548/comment/c517ca15_45e2f3ce PS12, Line 7: mb: add new board clevo/tgl-u/l140mu > Why not our usual scheme? Suggestion: […] "our"? CB:45624 ;) Done, I don't care File src/mainboard/clevo/tgl-u/Kconfig: https://review.coreboot.org/c/coreboot/+/59548/comment/b400c0a5_c7dc8672 PS12, Line 48: config VGA_BIOS_ID : default "8086,9b41" > This is only needed when an option rom is used. It's not the case here, so remove it. true, thanks https://review.coreboot.org/c/coreboot/+/59548/comment/32dc48d8_7a65a573 PS12, Line 51: config TPM_PIRQ : default 0x77 if BOARD_CLEVO_L140MU # GPP_C9_IRQ > I would move this to the other options on the top, so that the variant specific options are not scat […] I don't agree on this one; it doesn't really matter. also, l140cu is the same ;) https://review.coreboot.org/c/coreboot/+/59548/comment/37d597cf_679b6a70 PS12, Line 57: config VARIANT_DIR : default "l140mu" if BOARD_CLEVO_L140MU > Same here. this file is mostly a copy of l140cu^^ I agree that it fits better near the mainboard dir, though. -> Done File src/mainboard/clevo/tgl-u/Kconfig.name: https://review.coreboot.org/c/coreboot/+/59548/comment/c2bdd78f_f84f2152 PS12, Line 4: bool "L140MU / L141MU / L142MU" > What are the differences between these variants? just the color, same as for L140CU File src/mainboard/clevo/tgl-u/variants/l140mu/gpio_early.c: https://review.coreboot.org/c/coreboot/+/59548/comment/18aa2367_4389dc0e PS12, Line 10: PAD_NC(GPP_C22, UP_20K), : PA > Not needed here. Please remove. first, it's the same as l140cu here. also, the default is rts/cts, so it makes sense to set them to NC. if you really insist on removing them, reopen please -- To view, visit https://review.coreboot.org/c/coreboot/+/59548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c4bef3827da10241e9b01e12ecc4276e131a620 Gerrit-Change-Number: 59548 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Sun, 27 Mar 2022 22:14:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/tgl-u: add new board L14xMU
by Michael Niewöhner (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Felix Singer, Paul Menzel, Tim Wawrzynczak. Hello Felix Singer, build bot (Jenkins), Paul Menzel, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59548 to look at the new patch set (#13). Change subject: mb/clevo/tgl-u: add new board L14xMU ...................................................................... mb/clevo/tgl-u: add new board L14xMU Add new board Clevo L14xMU (TGL). GPIOs were configured based on schematics. Tested and working: - On-board RAM (M471A1G44AB0-CWE) - DIMM slot (tested Crucial CT16G4SFD8266.16FJ1 / MTA16ATF2G64HZ-2G6J1) - Graphics (GOP driver), including HDMI - Keyboard - I2C touchpad (including interrupt) - TPM (with interrupt on Windows, only polling on Linux [1]) - microSD Card reader - both NVME ports - Speakers - Microphone - Camera - WLAN/BT (CNVi) - All USB2/3 ports including Type-C - Thunderbolt detects my work laptop in TB Control Center (I couldn't test anything more due to security policy.) - TianoCore - internal flashing with flashrom on vendor firmware Note on TPM: The vendor sets Intel PTT to default-on in newer CSME images, which conflicts with the dTPM. Currently, there are two ways to make it work: 1) Boot vendor firmware once to let it disable PTT via CSME firmware feature override. 2) Use Intel Flash Image Tool (FIT) to set "initial power-up state" to disabled. Boots fine: - Debian testing, unstable (Linux 5.16.14, 5.17.0-rc6) - Windows 10 21H2 (Build 19044.1586) Untested: - Thunderbolt (see above) - Type-C DisplayPort - S-ATA - 3G/LTE - 3G/LTE depends on mising EC driver - tested board is non-LTE version with a second NVME port instead - LTE version has a USB-only M.2 slot (supported by this port) Doesn't work: - TPM interrupt on Linux [1] - WLAN/BT (PCIe) - gets detected but can't be enabled - All EC related functions - EC driver is WIP - Fn-Keys - S0ix - UCSI - Fan control - Battery info [1] https://lkml.org/lkml/2021/5/1/103 Change-Id: I4c4bef3827da10241e9b01e12ecc4276e131a620 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/clevo/cml-u/Kconfig A src/mainboard/clevo/tgl-u/Kconfig A src/mainboard/clevo/tgl-u/Kconfig.name A src/mainboard/clevo/tgl-u/Makefile.inc A src/mainboard/clevo/tgl-u/board_info.txt A src/mainboard/clevo/tgl-u/bootblock.c A src/mainboard/clevo/tgl-u/cmos.default A src/mainboard/clevo/tgl-u/cmos.layout A src/mainboard/clevo/tgl-u/dsdt.asl A src/mainboard/clevo/tgl-u/include/variant/gpio.h A src/mainboard/clevo/tgl-u/include/variant/ramstage.h A src/mainboard/clevo/tgl-u/include/variant/romstage.h A src/mainboard/clevo/tgl-u/ramstage.c A src/mainboard/clevo/tgl-u/romstage.c A src/mainboard/clevo/tgl-u/spd/samsung-M471A1G44AB0-CWE.spd.hex A src/mainboard/clevo/tgl-u/variants/l140mu/Makefile.inc A src/mainboard/clevo/tgl-u/variants/l140mu/board_info.txt A src/mainboard/clevo/tgl-u/variants/l140mu/data.vbt A src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb A src/mainboard/clevo/tgl-u/variants/l140mu/gpio.c A src/mainboard/clevo/tgl-u/variants/l140mu/gpio_early.c A src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c A src/mainboard/clevo/tgl-u/variants/l140mu/ramstage.c A src/mainboard/clevo/tgl-u/variants/l140mu/romstage.c 24 files changed, 901 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/59548/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/59548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c4bef3827da10241e9b01e12ecc4276e131a620 Gerrit-Change-Number: 59548 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb: add new board clevo/tgl-u/l140mu
by Felix Singer (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Tim Wawrzynczak, Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 ) Change subject: mb: add new board clevo/tgl-u/l140mu ...................................................................... Patch Set 12: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59548/comment/332edfef_13e8fa0d PS12, Line 7: mb: add new board clevo/tgl-u/l140mu Why not our usual scheme? Suggestion: mb/clevo/tgl-u/l140mu: Add new mainboard File src/mainboard/clevo/tgl-u/Kconfig: https://review.coreboot.org/c/coreboot/+/59548/comment/8a10c6fa_4de668bf PS12, Line 48: config VGA_BIOS_ID : default "8086,9b41" This is only needed when an option rom is used. It's not the case here, so remove it. https://review.coreboot.org/c/coreboot/+/59548/comment/b897a4f8_7108780f PS12, Line 51: config TPM_PIRQ : default 0x77 if BOARD_CLEVO_L140MU # GPP_C9_IRQ I would move this to the other options on the top, so that the variant specific options are not scattered over the file too much. https://review.coreboot.org/c/coreboot/+/59548/comment/343d819a_441effec PS12, Line 57: config VARIANT_DIR : default "l140mu" if BOARD_CLEVO_L140MU Same here. File src/mainboard/clevo/tgl-u/Kconfig.name: https://review.coreboot.org/c/coreboot/+/59548/comment/68d0cd1e_00000fc0 PS12, Line 4: bool "L140MU / L141MU / L142MU" What are the differences between these variants? File src/mainboard/clevo/tgl-u/variants/l140mu/gpio_early.c: https://review.coreboot.org/c/coreboot/+/59548/comment/8221229e_debc82e6 PS12, Line 10: PAD_NC(GPP_C22, UP_20K), : PA Not needed here. Please remove. -- To view, visit https://review.coreboot.org/c/coreboot/+/59548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c4bef3827da10241e9b01e12ecc4276e131a620 Gerrit-Change-Number: 59548 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sun, 27 Mar 2022 21:32:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Set pciexp_hotplug_dummy_ops.set_resources as no-op
by Tim Wawrzynczak (Code Review) 27 Mar '22

27 Mar '22

Attention is currently required from: John Su, Felix Held. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63101 ) Change subject: mb/google/brya: Set pciexp_hotplug_dummy_ops.set_resources as no-op ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63101/comment/2e170313_3232d0c2 PS1, Line 7: mb/google/brya > this isn't a change in mb/gogle/brya, but in device/pciexp_device, so the prefix should be device/pc […] Oops good catch 😄 -- To view, visit https://review.coreboot.org/c/coreboot/+/63101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifee7479c69cf16025dbd4e3924056ed7f8e253cf Gerrit-Change-Number: 63101 Gerrit-PatchSet: 1 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 27 Mar 2022 20:48:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Add DXIO descriptors
by 9elements QA (Code Review) 27 Mar '22

27 Mar '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62903 ) Change subject: mb/google/skyrim: Add DXIO descriptors ...................................................................... Patch Set 14: Automatic boot test returned (PASS/FAIL/TOTAL): 11 / 1 / 12 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/97504 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/97503 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/97502 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/97501 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/97500 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/97499 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/97498 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/97497 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/97496 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/97495 FAIL: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/97494 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/97493 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/62903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib68cf3d64641b006e0f2c4805af22b44a505a0d1 Gerrit-Change-Number: 62903 Gerrit-PatchSet: 14 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 27 Mar 2022 20:09:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: gpio: Update table as per coreboot guidelines
by Michael Niewöhner (Code Review) 27 Mar '22

27 Mar '22

Attention is currently required from: Subrata Banik, Angel Pons, Eric Lai, Felix Held. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63126 ) Change subject: Documentation: gpio: Update table as per coreboot guidelines ...................................................................... Patch Set 1: (2 comments) File Documentation/getting_started/gpio.md: https://review.coreboot.org/c/coreboot/+/63126/comment/6696cd39_d12ecfc6 PS1, Line 177: (GPP: RSMRST, this won't work - just tested this locally. You have to prefix the lines to make the cell become a multiline cell: ``` +------------------------+----------------+-------------+-------------+ | | 00 - Power Good | Warm Reset | N | N | | | (GPP: RSMRST, +----------------+-------------+-------------+ | | GPD: DSW_PWROK) | Cold Reset | N | N | +------------------------+----------------+-------------+-------------+ ``` https://review.coreboot.org/c/coreboot/+/63126/comment/79805243_7d9bf281 PS1, Line 212: 11 - Resume Reset | Warm Reset | - | N | : | (GPP: Reserved, +----------------+-------------+-------------+ : | GPD: prefix | needed as above -- To view, visit https://review.coreboot.org/c/coreboot/+/63126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4f27f46a9d219098612d8b7747ae26116506fce Gerrit-Change-Number: 63126 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 27 Mar 2022 18:21:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: gpio: Update table as per coreboot guidelines
by Michael Niewöhner (Code Review) 27 Mar '22

27 Mar '22

Attention is currently required from: Subrata Banik, Angel Pons, Eric Lai, Felix Held. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63126 ) Change subject: Documentation: gpio: Update table as per coreboot guidelines ...................................................................... Patch Set 1: (1 comment) File Documentation/getting_started/gpio.md: https://review.coreboot.org/c/coreboot/+/63126/comment/d0a88c24_0e2a1a30 PS1, Line 175: +------------------------+----------------+-------------+-------------+ =====, since it's a header -- To view, visit https://review.coreboot.org/c/coreboot/+/63126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4f27f46a9d219098612d8b7747ae26116506fce Gerrit-Change-Number: 63126 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 27 Mar 2022 18:00:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/acpi/acpigen_usb.c: Fix Memory leak error
by vaibhav (Code Review) 27 Mar '22

27 Mar '22

vaibhav has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62968 ) Change subject: src/acpi/acpigen_usb.c: Fix Memory leak error ...................................................................... Patch Set 1: (1 comment) File src/acpi/acpigen_usb.c: https://review.coreboot.org/c/coreboot/+/62968/comment/a3048c49_fe519877 PS1, Line 89: free(fresh); > Yes, please abandon. Maybe you find a way how to make scan-build ignore this error. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifed611bd0b9c1da3678386bff33bca3eac0311b4 Gerrit-Change-Number: 62968 Gerrit-PatchSet: 1 Gerrit-Owner: vaibhav <vrockz747(a)gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 27 Mar 2022 16:53:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: vaibhav <vrockz747(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022