coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: vendorcode/intel: Remove UDK2015 headers
by build bot (Jenkins) (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62992 ) Change subject: vendorcode/intel: Remove UDK2015 headers ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62992 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibfaa3029ddc614935481ce736c9d971bf4831b5d Gerrit-Change-Number: 62992 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 10:02:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/fsp1_1: Fix more strict-aliasing rules errors
by Arthur Heymans (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Patrick Rudolph, Lee Leahy. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63017 ) Change subject: drivers/fsp1_1: Fix more strict-aliasing rules errors ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If774ae6338dbb1ee2778d8c93cbb1868c61b1874 Gerrit-Change-Number: 63017 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 09:57:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/denverton_ns: Resolve macro conflicts with UDK2017 headers
by Patrick Rudolph (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Jeff Daly, Mariusz Szafrański, Paul Menzel, Suresh Bellampalli, Vanessa Eusebio. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62985 ) Change subject: soc/intel/denverton_ns: Resolve macro conflicts with UDK2017 headers ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62985/comment/0f66c2de_be2c8c87 PS3, Line 7: Replace EDK2 code > Sounds strange. ;-) […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62985 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f205f663be9c9c31cf384ca89370afa48ca1e15 Gerrit-Change-Number: 62985 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 09:52:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: TEST: Drop UEFI_2_4_BINDING
by Patrick Rudolph (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Lee Leahy. Hello Lee Leahy, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62993 to look at the new patch set (#4). Change subject: TEST: Drop UEFI_2_4_BINDING ...................................................................... TEST: Drop UEFI_2_4_BINDING See what breaks. Change-Id: Iedc4b082e850a31242208360a69b910d0df3191e Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/drivers/intel/fsp1_1/Kconfig M src/drivers/intel/fsp1_1/hob.c 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/62993/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iedc4b082e850a31242208360a69b910d0df3191e Gerrit-Change-Number: 62993 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/fsp1_1: Fix more strict-aliasing rules errors
by Patrick Rudolph (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Lee Leahy. Hello build bot (Jenkins), Lee Leahy, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63017 to look at the new patch set (#2). Change subject: drivers/fsp1_1: Fix more strict-aliasing rules errors ...................................................................... drivers/fsp1_1: Fix more strict-aliasing rules errors Change-Id: If774ae6338dbb1ee2778d8c93cbb1868c61b1874 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/drivers/intel/fsp1_1/hob.c 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/63017/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If774ae6338dbb1ee2778d8c93cbb1868c61b1874 Gerrit-Change-Number: 63017 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/fsp1_1: Fix code not working with strict-aliasing rules
by Patrick Rudolph (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Erik van den Bogaert, Frans Hendriks, Lee Leahy. Hello Erik van den Bogaert, build bot (Jenkins), Frans Hendriks, Lee Leahy, Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62995 to look at the new patch set (#2). Change subject: drivers/intel/fsp1_1: Fix code not working with strict-aliasing rules ...................................................................... drivers/intel/fsp1_1: Fix code not working with strict-aliasing rules Change-Id: Ifc95a093cf86c834d63825bf76312ed21ec68215 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/drivers/intel/fsp1_1/hob.c 1 file changed, 5 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/62995/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62995 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc95a093cf86c834d63825bf76312ed21ec68215 Gerrit-Change-Number: 62995 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vendorcode/intel: Remove UDK2015 headers
by Patrick Rudolph (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Patrick Rudolph. Hello build bot (Jenkins), Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62992 to look at the new patch set (#2). Change subject: vendorcode/intel: Remove UDK2015 headers ...................................................................... vendorcode/intel: Remove UDK2015 headers The headers are now unused, drop them. Change-Id: Ibfaa3029ddc614935481ce736c9d971bf4831b5d Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/vendorcode/intel/Kconfig M src/vendorcode/intel/Makefile.inc D src/vendorcode/intel/edk2/UDK2015/IntelFsp2Pkg/Include/FspDataTable.h D src/vendorcode/intel/edk2/UDK2015/IntelFsp2Pkg/Include/FspEas.h D src/vendorcode/intel/edk2/UDK2015/IntelFsp2Pkg/Include/FspEas/FspApi.h D src/vendorcode/intel/edk2/UDK2015/IntelFsp2Pkg/Include/FspGlobalData.h D src/vendorcode/intel/edk2/UDK2015/IntelFsp2Pkg/Include/FspMeasurePointId.h D src/vendorcode/intel/edk2/UDK2015/IntelFsp2Pkg/Include/FspStatusCode.h D src/vendorcode/intel/edk2/UDK2015/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h D src/vendorcode/intel/edk2/UDK2015/IntelFsp2Pkg/Include/Guid/GuidHobFspEas.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Base.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Guid/FirmwareFileSystem2.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Guid/HiiFormMapMethodGuid.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Guid/PcAnsi.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Guid/WinCertificate.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Ia32/ProcessorBind.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/IndustryStandard/Acpi.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/IndustryStandard/Acpi10.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/IndustryStandard/Acpi20.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/IndustryStandard/Acpi30.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/IndustryStandard/Acpi40.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/IndustryStandard/Acpi50.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/IndustryStandard/Acpi51.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/IndustryStandard/Acpi60.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/IndustryStandard/AcpiAml.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/IndustryStandard/Bluetooth.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/IndustryStandard/PeImage.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Library/HobLib.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Pi/PiBootMode.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Pi/PiFirmwareFile.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Pi/PiFirmwareVolume.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Pi/PiHob.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Protocol/DevicePath.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Protocol/GraphicsOutput.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Protocol/SimpleTextIn.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Protocol/SimpleTextInEx.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Protocol/SimpleTextOut.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Uefi.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Uefi/UefiBaseType.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Uefi/UefiGpt.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Uefi/UefiMultiPhase.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Uefi/UefiPxe.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/Uefi/UefiSpec.h D src/vendorcode/intel/edk2/UDK2015/MdePkg/Include/X64/ProcessorBind.h 45 files changed, 0 insertions(+), 24,574 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/62992/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62992 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibfaa3029ddc614935481ce736c9d971bf4831b5d Gerrit-Change-Number: 62992 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Kconfig: Select UDK2017
by Patrick Rudolph (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Jeff Daly, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Andrey Petrov. Hello build bot (Jenkins), Jeff Daly, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Arthur Heymans, Andrey Petrov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62984 to look at the new patch set (#7). Change subject: Kconfig: Select UDK2017 ...................................................................... Kconfig: Select UDK2017 On platforms using UDK2015 select UDK2017 instead. This allows to drop UDK2015 headers. Tested using timeless builds: The produced binaries are identical. Change-Id: Ia6032c6520ec889cd63655db982d9bfa476dc24d Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/mainboard/intel/galileo/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/denverton_ns/Kconfig M src/soc/intel/skylake/Kconfig 4 files changed, 4 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/62984/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/62984 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6032c6520ec889cd63655db982d9bfa476dc24d Gerrit-Change-Number: 62984 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/denverton_ns: Resolve macro conflicts with UDK2017 headers
by Patrick Rudolph (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Jeff Daly, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio. Hello build bot (Jenkins), Jeff Daly, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62985 to look at the new patch set (#4). Change subject: soc/intel/denverton_ns: Resolve macro conflicts with UDK2017 headers ...................................................................... soc/intel/denverton_ns: Resolve macro conflicts with UDK2017 headers Replace LShiftU64 and RShiftU64 as the defined macro conflicts with UDK2017 headers. Tested using timeless builds: The produced binaries are identical. Change-Id: I8f205f663be9c9c31cf384ca89370afa48ca1e15 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/soc/intel/denverton_ns/gpio_dnv.c M src/soc/intel/denverton_ns/include/soc/gpio_dnv.h 2 files changed, 13 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/62985/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62985 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f205f663be9c9c31cf384ca89370afa48ca1e15 Gerrit-Change-Number: 62985 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/primus{4es}: Decrease touchscreen T3 timing to 200ms
by Casper Chang (Code Review) 30 Mar '22

30 Mar '22

Casper Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63201 ) Change subject: mb/google/brya/var/primus{4es}: Decrease touchscreen T3 timing to 200ms ...................................................................... mb/google/brya/var/primus{4es}: Decrease touchscreen T3 timing to 200ms We set T3 as 300ms to meet Elan's spec, but the resume/suspend times are greater than 500ms, which is the spec for Chromebooks. The actual kernel timing has been measured, and given the ACPI delay after deasserting reset in addition to the delay until the kernel driver accesses the device, delaying only 200ms in the ACPI method is also sufficient to meet the 300ms requirement. BUG=b:223936777 BRANCH=none TEST=build and test touchscreen function on DUT. TEST=suspend, wake DUT and check touchscreen function. Change-Id: I6b04cf6392d924aed01ca36b720f889b88d92311 Signed-off-by: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> --- M src/mainboard/google/brya/variants/primus/overridetree.cb M src/mainboard/google/brya/variants/primus4es/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/63201/1 diff --git a/src/mainboard/google/brya/variants/primus/overridetree.cb b/src/mainboard/google/brya/variants/primus/overridetree.cb index 8832381..55853bf 100644 --- a/src/mainboard/google/brya/variants/primus/overridetree.cb +++ b/src/mainboard/google/brya/variants/primus/overridetree.cb @@ -219,7 +219,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" - register "generic.reset_delay_ms" = "300" + register "generic.reset_delay_ms" = "200" register "generic.reset_off_delay_ms" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" diff --git a/src/mainboard/google/brya/variants/primus4es/overridetree.cb b/src/mainboard/google/brya/variants/primus4es/overridetree.cb index 940c63f..cbd5ee3 100644 --- a/src/mainboard/google/brya/variants/primus4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/primus4es/overridetree.cb @@ -206,7 +206,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" - register "generic.reset_delay_ms" = "300" + register "generic.reset_delay_ms" = "200" register "generic.reset_off_delay_ms" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" -- To view, visit https://review.coreboot.org/c/coreboot/+/63201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b04cf6392d924aed01ca36b720f889b88d92311 Gerrit-Change-Number: 63201 Gerrit-PatchSet: 1 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022