Attention is currently required from: Arthur Heymans, MrChromebox.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61563 )
Change subject: mb/google/octopus,reef: Align SMMSTORE region in default.fmd
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
> yeah should be `0x200000` if I did my math right
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/61563
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d4f71f80c3219ac2c7000e1fa95fd04100d9cfe
Gerrit-Change-Number: 61563
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: MrChromebox <mrchromebox(a)gmail.com>
Gerrit-Comment-Date: Mon, 07 Feb 2022 19:29:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61683 )
Change subject: mb/google/reef/coral: Sync mainboard.c with Chromium fork
......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/reef/variants/coral/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140202):
https://review.coreboot.org/c/coreboot/+/61683/comment/1bf0bb8b_d2cd04d8
PS1, Line 140: break;
break is not useful after a goto or return
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140202):
https://review.coreboot.org/c/coreboot/+/61683/comment/2ccc2ff2_efb53b7c
PS1, Line 144: break;
break is not useful after a goto or return
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140202):
https://review.coreboot.org/c/coreboot/+/61683/comment/9c2e0ece_3057811f
PS1, Line 148: break;
break is not useful after a goto or return
--
To view, visit https://review.coreboot.org/c/coreboot/+/61683
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf2a53a351138aff310385f4026197d74ab6848b
Gerrit-Change-Number: 61683
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 07 Feb 2022 19:26:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61684 )
Change subject: mb/google/reef/coral/mainboard.c: Drop break after return inside switch
......................................................................
mb/google/reef/coral/mainboard.c: Drop break after return inside switch
Drop unnecessary switch break after return, to alleviate linter warnings.
Change-Id: I7cc49caaeafb490cb62b75ec5c3ca4822573464b
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/reef/variants/coral/mainboard.c
1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/61684/1
diff --git a/src/mainboard/google/reef/variants/coral/mainboard.c b/src/mainboard/google/reef/variants/coral/mainboard.c
index c950a01..cb21e34 100644
--- a/src/mainboard/google/reef/variants/coral/mainboard.c
+++ b/src/mainboard/google/reef/variants/coral/mainboard.c
@@ -124,28 +124,22 @@
case SKU_0_ASTRONAUT:
case SKU_1_ASTRONAUT:
return "vbt-astronaut.bin";
- break;
case SKU_2_SANTA:
case SKU_3_SANTA:
return "vbt-santa.bin";
- break;
case SKU_13_EPAULETTE:
case SKU_14_EPAULETTE:
case SKU_15_EPAULETTE:
case SKU_16_EPAULETTE:
return "vbt-epaulette.bin";
- break;
case SKU_28_RABBID_RUGGED:
return "vbt-rabbid_rugged.bin";
- break;
case SKU_30_BABYTIGER:
case SKU_33_BABYTIGER:
return "vbt-babytiger.bin";
- break;
case SKU_52_BABYMEGA:
case SKU_53_BABYMEGA:
return "vbt-babymega.bin";
- break;
case SKU_160_NASHER:
case SKU_161_NASHER:
case SKU_162_NASHER:
@@ -154,10 +148,8 @@
case SKU_165_NASHER360:
case SKU_166_NASHER360:
return "vbt-nasher.bin";
- break;
default:
return "vbt.bin";
- break;
}
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/61684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cc49caaeafb490cb62b75ec5c3ca4822573464b
Gerrit-Change-Number: 61684
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Subrata Banik, Nick Vaccaro, Benson Leung, Prashant Malani.
Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, Benson Leung, Prashant Malani,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61571
to look at the new patch set (#6).
Change subject: mb/google/brya: Add custom PLD fields to devicetree for brya variants
......................................................................
mb/google/brya: Add custom PLD fields to devicetree for brya variants
BUG=b:216490477
TEST=emerge-brya coreboot
Signed-off-by: Won Chung <wonchung(a)google.com>
Change-Id: If610e6b3c849d982345ed1b8607ffd2af105dc51
---
M src/mainboard/google/brya/variants/anahera/overridetree.cb
M src/mainboard/google/brya/variants/anahera4es/overridetree.cb
M src/mainboard/google/brya/variants/felwinter/overridetree.cb
M src/mainboard/google/brya/variants/gimble/overridetree.cb
M src/mainboard/google/brya/variants/gimble4es/overridetree.cb
M src/mainboard/google/brya/variants/kano/overridetree.cb
M src/mainboard/google/brya/variants/primus/overridetree.cb
M src/mainboard/google/brya/variants/primus4es/overridetree.cb
M src/mainboard/google/brya/variants/redrix/overridetree.cb
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
M src/mainboard/google/brya/variants/taeko/overridetree.cb
M src/mainboard/google/brya/variants/taeko4es/overridetree.cb
12 files changed, 560 insertions(+), 80 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/61571/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/61571
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If610e6b3c849d982345ed1b8607ffd2af105dc51
Gerrit-Change-Number: 61571
Gerrit-PatchSet: 6
Gerrit-Owner: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: Benson Leung <bleung(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Benson Leung <bleung(a)chromium.org>
Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Rasheed Hsueh, YH Lin, Joey Peng, Paul Menzel, Nick Vaccaro.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61412 )
Change subject: mb/google/brya/var/taeko: Add new FW_CONFIG option for DB_USB
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/taeko/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/61412/comment/fc288135_b180be16
PS4, Line 497: ROUP(5, 1)"
Since line 497 abnd line 524 represent the same port (right?) then the GROUP number should be the same; this is how the kernel knows they represent the same physical port.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61412
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a43c256757f3fc4b53ba1f794587d6a00ba0aa5
Gerrit-Change-Number: 61412
Gerrit-PatchSet: 4
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Mon, 07 Feb 2022 19:15:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chang, YH Lin.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61665 )
Change subject: mb/google/brya/var/taeko: Add WiFi SAR table for taeko
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61665
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I061dc798ae7177d05bc50648cfda46a3eec2c912
Gerrit-Change-Number: 61665
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Mon, 07 Feb 2022 19:12:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Name of user not set #1004133, Zheng Bao.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61445 )
Change subject: mb/google/guybrush: Add the fw SPL to amdfw.cfg
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
> make[1]: *** No rule to make target '3rdparty/amd_blobs/cezanne/PSP/TypeId0x55_SplTable_Prod_CZN_Chrome.sbin', needed by '/cb-build/coreboot-gerrit.0/default/GOOGLE_GUYBRUSH/amdfw.rom'. Stop.
We need to push the SPL table to amd_blobs. Ideally this would be in blobs/mb/google/guybrush/ since it seems to be a chromeos specific blob.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61445
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I268a92c9916b261fbc899ebb72f75f7a3f12c441
Gerrit-Change-Number: 61445
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Avinash Alevoor
Gerrit-Reviewer: Mohan Viswanathan
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-CC: Name of user not set #1004133
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rob Barnes <robbarnes(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Name of user not set #1004133
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Mon, 07 Feb 2022 18:40:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment