Attention is currently required from: Ethan Tsao, Ravishankar Sarawadi, Stefan Reinauer, Tim Wawrzynczak, Patrick Rudolph.
Hello build bot (Jenkins), Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, Stefan Reinauer, Tim Wawrzynczak, Edward O'Callaghan, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61576
to look at the new patch set (#7).
Change subject: util/ifdtool: add generic `PLATFORM_IFD2` for early SoC development
......................................................................
util/ifdtool: add generic `PLATFORM_IFD2` for early SoC development
`PLATFORM_IFD2` macro is more generic tag that can be associated with
early next SoC platform development which using IFDv2.
The current assumption is that newer SoC platform still uses the same
SPI/eSPI frequency definition being used for latest platform(TGL, ADL)
and if the frequency definition is updated later, `PLATFORM_IFD2' will
use latest frequency definition for early next SoC development.
And once upstream is allowed for new platform, platform name will be
added in tool later.
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22
---
M util/ifdtool/ifdtool.c
M util/ifdtool/ifdtool.h
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/61576/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/61576
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22
Gerrit-Change-Number: 61576
Gerrit-PatchSet: 7
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Wonkyu Kim, Ethan Tsao, Ravishankar Sarawadi, Stefan Reinauer, Tim Wawrzynczak, Patrick Rudolph.
Hello build bot (Jenkins), Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, Stefan Reinauer, Tim Wawrzynczak, Edward O'Callaghan, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61576
to look at the new patch set (#6).
Change subject: util/ifdtool: add generic `PLATFORM_IFD2` for early SoC development
......................................................................
util/ifdtool: add generic `PLATFORM_IFD2` for early SoC development
`PLATFORM_IFD2` macro is more generic tag that can be associated with
early next SoC platform development which using IFDv2.
The current assumption is that newer SoC platform still uses the same
SPI/eSPI frequency definition being used for latest platform(TGL, ADL)
and if the frequency definition is updated later, `PLATFORM_IFD2' will
use latest frequency definition for early next SoC development.
And once upstream is allowed in new platform, platform name will be
added in tool later.
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22
---
M util/ifdtool/ifdtool.c
M util/ifdtool/ifdtool.h
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/61576/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/61576
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22
Gerrit-Change-Number: 61576
Gerrit-PatchSet: 6
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak.
Mac Chiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61404 )
Change subject: mb/google/brya/variants/brask: Enable Bluetooth offload support
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61404/comment/fe601caf_f1b43549
PS1, Line 16:
> Missing `Signed-off-by` tag
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/61404
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2
Gerrit-Change-Number: 61404
Gerrit-PatchSet: 2
Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 08 Feb 2022 06:59:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
Mac Chiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61404 )
Change subject: mb/google/brya/variants/brask: Enable Bluetooth offload support
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/brask/fw_config.c:
https://review.coreboot.org/c/coreboot/+/61404/comment/4c3febbd_772f73ce
PS1, Line 32: if (!fw_config_is_provisioned() || fw_config_probe(FW_CONFIG(AUDIO, AUDIO_UNKNOWN))) {
> > braces {} are not necessary for single statement blocks […]
Thanks! Done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61404
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2
Gerrit-Change-Number: 61404
Gerrit-PatchSet: 2
Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 08 Feb 2022 06:59:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Mac Chiang.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61404
to look at the new patch set (#2).
Change subject: mb/google/brya/variants/brask: Enable Bluetooth offload support
......................................................................
mb/google/brya/variants/brask: Enable Bluetooth offload support
Add fw_config NAU88L25B_I2S field, I2S2 configuration and
enabling CnviBtAudioOffload UPD bit.
BUG=none
TEST=temerge-brask coreboot
Signed-off-by: Mac Chiang <mac.chiang(a)intel.com>
Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2
---
M src/mainboard/google/brya/variants/brask/Makefile.inc
A src/mainboard/google/brya/variants/brask/fw_config.c
M src/mainboard/google/brya/variants/brask/overridetree.cb
A src/mainboard/google/brya/variants/brask/variant.c
4 files changed, 64 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/61404/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61404
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2
Gerrit-Change-Number: 61404
Gerrit-PatchSet: 2
Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Wonkyu Kim, Ethan Tsao, Ravishankar Sarawadi, Stefan Reinauer, Tim Wawrzynczak, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61576 )
Change subject: util/ifdtool: add PLATFORM_IFD2 to reduce common ifd tool change
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61576/comment/9563982a_a51fcad5
PS5, Line 7: util/ifdtool: add PLATFORM_IFD2 to reduce common ifd tool change
consider rewriting the commit msg
util/ifdtool: Add generic `PLATFORM_IFD2` for early SoC development
`PLATFORM_IFD2` macro is more generic tag that can be associated with
early SoC platform development.
The current assumption is that newer SoC platform still uses the same
SPI/eSPI frequency layout being used for TGL, ADL platform.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61576
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22
Gerrit-Change-Number: 61576
Gerrit-PatchSet: 5
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 08 Feb 2022 06:53:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Wonkyu Kim, Ethan Tsao, Ravishankar Sarawadi, Stefan Reinauer, Tim Wawrzynczak, Patrick Rudolph.
Hello build bot (Jenkins), Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, Stefan Reinauer, Tim Wawrzynczak, Edward O'Callaghan, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61576
to look at the new patch set (#5).
Change subject: util/ifdtool: add PLATFORM_IFD2 to reduce common ifd tool change
......................................................................
util/ifdtool: add PLATFORM_IFD2 to reduce common ifd tool change
TGL, ADL have same ifd tool and future platforms may also use same tool.
As TGL, ADL use own names for enabling ifd tool, we need to update ifd
tool code for new platforms even if ifd tool is not changed.
For avoid unnessary change, use generic platform name(PLATFORM_IFD2) for
support future platforms without tool changes.
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22
---
M util/ifdtool/ifdtool.c
M util/ifdtool/ifdtool.h
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/61576/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/61576
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22
Gerrit-Change-Number: 61576
Gerrit-PatchSet: 5
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61655 )
Change subject: soc/intel/common/gpio: Add PAD_NC_LOCK and PAD_CFG_GPI_SCI_LOCK macro
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61655
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie44d72f4152b55183d900228df3e3670358f7518
Gerrit-Change-Number: 61655
Gerrit-PatchSet: 7
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 08 Feb 2022 06:40:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment