Attention is currently required from: Ravi kumar, Sudheer Amrabadi, Julius Werner, mturney mturney.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50586 )
Change subject: drivers: spi_flash: Addressing mode change for SPI NOR
......................................................................
Patch Set 113:
(5 comments)
File src/drivers/spi/Kconfig:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140396):
https://review.coreboot.org/c/coreboot/+/50586/comment/0aee853d_2adf826e
PS113, Line 169: This will send an Exit 4-Byte Address Mode (E9h) command before the first
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140396):
https://review.coreboot.org/c/coreboot/+/50586/comment/3b43fcab_44c3cf00
PS113, Line 170: access to the SPI flash. On some platforms with SPI flashes larger than 32MB,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140396):
https://review.coreboot.org/c/coreboot/+/50586/comment/988ce7f3_fc37f804
PS113, Line 171: the SPI flash may power up in 4-byte addressing mode and this command needs
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140396):
https://review.coreboot.org/c/coreboot/+/50586/comment/7b6b81b8_10ac45de
PS113, Line 172: to be sent before coreboot's 3-byte address commands can be interpreted correctly.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140396):
https://review.coreboot.org/c/coreboot/+/50586/comment/c544b570_b779ed68
PS113, Line 173: On flashes that don't support 4-byte addressing mode or where it is already
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/50586
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied5b647d0fcc8e3effff3bb7c8680ed5a0c1f3d4
Gerrit-Change-Number: 50586
Gerrit-PatchSet: 113
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Sajida Bhanu <quic_c_sbhanu(a)quicinc.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shelley Chen <shchen(a)google.com>
Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 10:01:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ravi kumar, Sudheer Amrabadi, Julius Werner, mturney mturney.
Sudheer Amrabadi has uploaded a new patch set (#113) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/50586 )
Change subject: drivers: spi_flash: Addressing mode change for SPI NOR
......................................................................
drivers: spi_flash: Addressing mode change for SPI NOR
As 4-byte addressing mode is not support in coreboot, change the
addressing mode of SPI nor from 4-bytes to 3-bytes.
BUG=b:215605946
TEST=Validated on qualcomm sc7280 development board
Signed-off-by: Veerabhadrarao Badiganti <quic_vbadigan(a)quicinc.com>
Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu(a)quicinc.com>
Change-Id: Ied5b647d0fcc8e3effff3bb7c8680ed5a0c1f3d4
---
M src/drivers/spi/Kconfig
M src/drivers/spi/spi_flash.c
M src/drivers/spi/spi_flash_internal.h
3 files changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/50586/113
--
To view, visit https://review.coreboot.org/c/coreboot/+/50586
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied5b647d0fcc8e3effff3bb7c8680ed5a0c1f3d4
Gerrit-Change-Number: 50586
Gerrit-PatchSet: 113
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Sajida Bhanu <quic_c_sbhanu(a)quicinc.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shelley Chen <shchen(a)google.com>
Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Wonkyu Kim, Benjamin Doron, Ravishankar Sarawadi, Stefan Reinauer, Angel Pons, Michael Niewöhner.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 )
Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs
......................................................................
Patch Set 4:
(5 comments)
Patchset:
PS4:
> weeeeell....... https://github. […]
Right, I may use OpenBoardPackage
File util/inteltool/gpio_names/tigerlake.h:
PS4:
> I think the other headers were split off some C file in the past. […]
If the other files also lack the license, I would put a separate patch to fill all missing license headers
https://review.coreboot.org/c/coreboot/+/56171/comment/4a7c8983_2731d59d
PS4, Line 361: };
> you can add these as well - all with NF1: […]
These are GPD12+??
https://review.coreboot.org/c/coreboot/+/56171/comment/69481e4c_9dfd31c6
PS4, Line 901: tigerlake_pch_h_communities
> tigerlake_pch_h_community_3 is missing.
Will check with other sources. This patch was entirely based on the Intel GPIO spreadhseet
File util/inteltool/pcr.c:
https://review.coreboot.org/c/coreboot/+/56171/comment/b9c05358_e49dcdb5
PS4, Line 108: case PCI_DEVICE_ID_INTEL_Q570:
: case PCI_DEVICE_ID_INTEL_Z590:
: case PCI_DEVICE_ID_INTEL_H570:
: case PCI_DEVICE_ID_INTEL_B560:
: case PCI_DEVICE_ID_INTEL_H510:
: case PCI_DEVICE_ID_INTEL_WM590:
: case PCI_DEVICE_ID_INTEL_QM580:
: case PCI_DEVICE_ID_INTEL_HM570:
: case PCI_DEVICE_ID_INTEL_C252:
: case PCI_DEVICE_ID_INTEL_C256:
: case PCI_DEVICE_ID_INTEL_W580:
> I agree (found via testing). […]
Okay. We may pray that nobody changes the default sideband BAR...
--
To view, visit https://review.coreboot.org/c/coreboot/+/56171
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6071a999be9e8a372997db0369218f297e579d08
Gerrit-Change-Number: 56171
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Wed, 09 Feb 2022 09:53:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Wonkyu Kim, Benjamin Doron, Ravishankar Sarawadi, Stefan Reinauer, Angel Pons.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 )
Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
A bunch of comments landed and I didn't even notice. Let me rebase and address them
--
To view, visit https://review.coreboot.org/c/coreboot/+/56171
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6071a999be9e8a372997db0369218f297e579d08
Gerrit-Change-Number: 56171
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 09:46:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61761
to look at the new patch set (#2).
Change subject: mb/google/brya/var/vell: Add Wifi SAR for vell
......................................................................
mb/google/brya/var/vell: Add Wifi SAR for vell
Add wifi sar for vell
BUG=b:
TEST=emerge-brya coreboot-private-files-baseboard-brya coreboot chromeos-bootimage
Change-Id: I74fddd1dbcb7019fd5fe394da291f125f0d4960f
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/brya/variants/vell/Makefile.inc
A src/mainboard/google/brya/variants/vell/variant.c
3 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/61761/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61761
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74fddd1dbcb7019fd5fe394da291f125f0d4960f
Gerrit-Change-Number: 61761
Gerrit-PatchSet: 2
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Evan Green, Tyler Wang, Paul Fagerburg, Felix Held.
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61438 )
Change subject: mb/google/dedede/var/magolor: Add custom Wifi SAR for magneto
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61438
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77f141372ba8e7b8f5849b00e115ad8bb1e7ca00
Gerrit-Change-Number: 61438
Gerrit-PatchSet: 2
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Evan Green <evgreen(a)chromium.org>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 09 Feb 2022 09:24:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Joey Peng, Kevin Chang, Tim Wawrzynczak.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61702 )
Change subject: mb/google/var/taeko4es: Add gpios to lock
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61702/comment/2ce90ea6_18dfdb77
PS2, Line 14: taeko
> taeko4es
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/61702
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82bdf8a1bfe2df0fc1d50d154def8742714321ad
Gerrit-Change-Number: 61702
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 09 Feb 2022 09:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Joey Peng, Kevin Chang, Tim Wawrzynczak, EricR Lai.
Hello build bot (Jenkins), Joey Peng, Kevin Chang, Subrata Banik, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61702
to look at the new patch set (#3).
Change subject: mb/google/var/taeko4es: Add gpios to lock
......................................................................
mb/google/var/taeko4es: Add gpios to lock
Variant should honor locked gpios from baseboard, but not the last.
Variant can add more gpios to lock if needed.
BUG=b:216583542
TEST='emerge-brya coreboot chromeos-bootimage', flash and verify that
taeko4es boots successfully to kernel.
Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com>
Change-Id: I82bdf8a1bfe2df0fc1d50d154def8742714321ad
---
M src/mainboard/google/brya/variants/taeko4es/gpio.c
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/61702/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/61702
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82bdf8a1bfe2df0fc1d50d154def8742714321ad
Gerrit-Change-Number: 61702
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset