coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: mb/google/hatch: Add variant finalize support for hatch devices
by Tarun Tuli (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Eran Mitrani, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68821 ) Change subject: mb/google/hatch: Add variant finalize support for hatch devices ...................................................................... Patch Set 14: (1 comment) File src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h: https://review.coreboot.org/c/coreboot/+/68821/comment/63662d03_6e402442 PS13, Line 31: variant_finalize_gpio_table > Sounds good, thanks. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9253ed4be1b08d0c7f65526c9b26dbcd00ffccc7 Gerrit-Change-Number: 68821 Gerrit-PatchSet: 14 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 20:10:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/hatch: Add variant finalize support for hatch devices
by Nick Vaccaro (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Eran Mitrani. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68821 ) Change subject: mb/google/hatch: Add variant finalize support for hatch devices ...................................................................... Patch Set 13: (1 comment) File src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h: https://review.coreboot.org/c/coreboot/+/68821/comment/133dc445_002c132f PS13, Line 31: variant_finalize_gpio_table > I agree this is confusing. […] Sounds good, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/68821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9253ed4be1b08d0c7f65526c9b26dbcd00ffccc7 Gerrit-Change-Number: 68821 Gerrit-PatchSet: 13 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 19:53:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [WIP] mb/prodrive/hermes: Add libgfxinit support
by Angel Pons (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Christian Walter. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62648 ) Change subject: [WIP] mb/prodrive/hermes: Add libgfxinit support ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62648/comment/cfee42e8_b9fbb021 PS4, Line 8: > > Possible unwrapped commit description (prefer a maximum 72 chars per line) […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib71d06e1d83cd26b0fef37acc64f699c452c13dc Gerrit-Change-Number: 62648 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 01 Nov 2022 19:31:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/hatch: Add variant finalize support for hatch devices
by Tarun Tuli (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Eran Mitrani, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68821 ) Change subject: mb/google/hatch: Add variant finalize support for hatch devices ...................................................................... Patch Set 13: (1 comment) File src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h: https://review.coreboot.org/c/coreboot/+/68821/comment/f1aa4aee_150db63a PS13, Line 31: variant_finalize_gpio_table > I found it. […] I agree this is confusing. I think what we can do to get the intended flexibility is to move the programming of the pins into into the mainboard_final and define a weak implementation of variant_finalize_gpio_table in the baseboard/gpio.c -- To view, visit https://review.coreboot.org/c/coreboot/+/68821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9253ed4be1b08d0c7f65526c9b26dbcd00ffccc7 Gerrit-Change-Number: 68821 Gerrit-PatchSet: 13 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 19:27:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: vc/intel/fsp:Update JSL FSP headers from v2385.04 to v4155.00
by Saurabh Mishra (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Saurabh Mishra. Hello build bot (Jenkins), Saurabh Mishra, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69107 to look at the new patch set (#3). Change subject: vc/intel/fsp:Update JSL FSP headers from v2385.04 to v4155.00 ...................................................................... vc/intel/fsp:Update JSL FSP headers from v2385.04 to v4155.00 The headers added are generated as per FSP v4155.00. Previous FSP version was v2385.04 Changes Include: FspsUpd.h: Change in header offset. {FspmUpd.h,FspUpd.h}: Copyright year update. MemInfoHob.h: Add HOB_GUID_TYPE, HOB_GENERIC_HEADER Struct. BUG=b:TBD BRANCH=firmware-dedede-13606.B TEST=Build and boot JSLRVP Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com> Change-Id: Ic4fae89d8d7fbbcb0448222d39dd829bc3f99644 --- M src/vendorcode/intel/fsp/fsp2_0/jasperlake/FspUpd.h M src/vendorcode/intel/fsp/fsp2_0/jasperlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/jasperlake/FspsUpd.h M src/vendorcode/intel/fsp/fsp2_0/jasperlake/MemInfoHob.h 4 files changed, 337 insertions(+), 280 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/69107/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4fae89d8d7fbbcb0448222d39dd829bc3f99644 Gerrit-Change-Number: 69107 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: cpu/x86/mp_init.c: Keep track of initial lapic ID inside device_path
by Angel Pons (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Arthur Heymans, Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64342 ) Change subject: cpu/x86/mp_init.c: Keep track of initial lapic ID inside device_path ...................................................................... Patch Set 8: Code-Review+1 (5 comments) File src/arch/x86/cpu.c: https://review.coreboot.org/c/coreboot/+/64342/comment/61c20097_fe5ebd1a PS5, Line 224: return NULL; Given the usage below, maybe it's best to die instead of returning NULL? How important is the CPU cluster device? https://review.coreboot.org/c/coreboot/+/64342/comment/5e6dfbf7_073733d9 PS5, Line 233: cpu_cluster() Can return NULL https://review.coreboot.org/c/coreboot/+/64342/comment/c3c06e62_97912162 PS5, Line 254: return dev->path.apic.initial_lapicid; When there are `N` CPU devices (`0` to `N - 1`) and one calls this function with `N` as `logical_cpu`, `dev` would be NULL. File src/cpu/x86/lapic/lapic_cpu_init.c: https://review.coreboot.org/c/coreboot/+/64342/comment/111c47f5_dd4ce2e5 PS8, Line 255: cpu_add_map_entry(info->index); Where is `initial_lapicid` set? https://review.coreboot.org/c/coreboot/+/64342/comment/24fa51a4_0561677e PS8, Line 396: cpu_add_map_entry(info->index); Where is `initial_lapicid` set? -- To view, visit https://review.coreboot.org/c/coreboot/+/64342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d9f8d23c0b0e5c142f6907593428d8509e4e7bb Gerrit-Change-Number: 64342 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 19:22:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: vc/intel/fsp:Update JSL FSP headers from v2385.04 to v4155.00
by Saurabh Mishra (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Saurabh Mishra. Hello build bot (Jenkins), Saurabh Mishra, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69107 to look at the new patch set (#2). Change subject: vc/intel/fsp:Update JSL FSP headers from v2385.04 to v4155.00 ...................................................................... vc/intel/fsp:Update JSL FSP headers from v2385.04 to v4155.00 The headers added are generated as per FSP v4155.00. Previous FSP version was v2385.04 Changes Include: FspsUpd.h: Change in header offset. {FspmUpd.h,FspUpd.h & FirmwareVersionInfo.h}: Copyright year update. MemInfoHob.h: Add HOB_GUID_TYPE, HOB_GENERIC_HEADER Struct. BUG=b:TBD BRANCH=firmware-dedede-13606.B TEST=Build and boot JSLRVP Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com> Change-Id: Ic4fae89d8d7fbbcb0448222d39dd829bc3f99644 --- M src/vendorcode/intel/fsp/fsp2_0/jasperlake/FspUpd.h M src/vendorcode/intel/fsp/fsp2_0/jasperlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/jasperlake/FspsUpd.h M src/vendorcode/intel/fsp/fsp2_0/jasperlake/MemInfoHob.h 4 files changed, 337 insertions(+), 280 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/69107/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4fae89d8d7fbbcb0448222d39dd829bc3f99644 Gerrit-Change-Number: 69107 Gerrit-PatchSet: 2 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: cpu/x86/mp_init.c: Handle failed init_bsp()
by build bot (Jenkins) (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69109 ) Change subject: cpu/x86/mp_init.c: Handle failed init_bsp() ...................................................................... Patch Set 1: (1 comment) File src/cpu/x86/mp_init.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161910): https://review.coreboot.org/c/coreboot/+/69109/comment/20d82bfe_cd270593 PS1, Line 590: if (init_bsp(cpu_bus) != CB_SUCCESS ) { space prohibited before that close parenthesis ')' -- To view, visit https://review.coreboot.org/c/coreboot/+/69109 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7be5d6c32458ba98f4f8c5c9340790ff989c91e7 Gerrit-Change-Number: 69109 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 19:09:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: [WIP]cpu/mp_init: Detect the number of CPUs are runtime
by build bot (Jenkins) (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Kyösti Mälkki. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68893 ) Change subject: [WIP]cpu/mp_init: Detect the number of CPUs are runtime ...................................................................... Patch Set 4: Verified+1 (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161909): https://review.coreboot.org/c/coreboot/+/68893/comment/da4cde91_3689388b PS4, Line 8: Possible repeated word: 'are' File src/cpu/x86/mp_init.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161909): https://review.coreboot.org/c/coreboot/+/68893/comment/4f37a710_19e06471 PS4, Line 489: if (!cpu->enabled) { braces {} are not necessary for any arm of this statement -- To view, visit https://review.coreboot.org/c/coreboot/+/68893 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafe9d3d4838dad46cd0c7b6d30b905cbd258f17f Gerrit-Change-Number: 68893 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 19:09:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/x86/mp_init.c: Keep track of initial lapic ID inside device_path
by Arthur Heymans (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Arthur Heymans, Kyösti Mälkki. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64342 ) Change subject: cpu/x86/mp_init.c: Keep track of initial lapic ID inside device_path ...................................................................... Patch Set 8: (1 comment) File src/cpu/x86/lapic/lapic_cpu_init.c: https://review.coreboot.org/c/coreboot/+/64342/comment/28914ef5_0cba7b52 PS2, Line 395: info->cpu = alloc_find_dev(cpu_bus, &cpu_path); > > Looks like a candidate for add_cpu_device. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/64342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d9f8d23c0b0e5c142f6907593428d8509e4e7bb Gerrit-Change-Number: 64342 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 19:09:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022