Attention is currently required from: Jonathan Zhang, Johnny Lin, Jingle Hsu, Shuming Chu (Shuming).
Hello build bot (Jenkins), Jonathan Zhang, Johnny Lin, Jingle Hsu, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69106
to look at the new patch set (#2).
Change subject: inc/dev: Add some PCIe DPC/AER definitions
......................................................................
inc/dev: Add some PCIe DPC/AER definitions
* Add DPC related definitions which are defined in 7.9.14 of PCIe
6.0 spec.
* Add AER related definitions which are defined in 7.8.4 of PCIe
6.0 spec.
Signed-off-by: Tim Chu <Tim.Chu(a)quantatw.com>
Change-Id: Ifb6722c326ef69ef1bf3b1c2c1d5bc0cb29d7c12
---
M src/include/device/pci_def.h
1 file changed, 34 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/69106/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb6722c326ef69ef1bf3b1c2c1d5bc0cb29d7c12
Gerrit-Change-Number: 69106
Gerrit-PatchSet: 2
Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Ofer Fried, Tim Wawrzynczak, Nick Vaccaro.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68917 )
Change subject: mb/google/brya/variants/volmar: Add firmware config field for FP_MCU
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68917/comment/0e7e7809_ed4b91ed
PS2, Line 10: FP_MCU_MASK
> Should be "FPMCU_MASK"
fixed.
File src/mainboard/google/brya/variants/volmar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68917/comment/0c6ff70c_036f64e7
PS2, Line 23: option FPMCU_ENABLED 0
> OK, I thought it might be for a reason like that, just wanted to make sure.
Yes. backward compatible! The volmar fw_config field bit10 is zero.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68917
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I867771904811459697056662d5e29c545a1a9474
Gerrit-Change-Number: 68917
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ofer Fried <oferfried(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paz Zcharya <pazz(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Ofer Fried <oferfried(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 01:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Ofer Fried, Ren Kuo, Tim Wawrzynczak.
Hello build bot (Jenkins), David Wu, Tarun Tuli, Ofer Fried, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68917
to look at the new patch set (#3).
Change subject: mb/google/brya/variants/volmar: Add firmware config field for FP_MCU
......................................................................
mb/google/brya/variants/volmar: Add firmware config field for FP_MCU
The fingerprint(FP) feature is only for volmar,and it's not for zavala.
Add FPMCU_MASK field in fw_config to disable the FP function for
zavala, and reserve FP function for shipped volmar.
Define the value as following:
field FPMCU_MASK 10
option FPMCU_ENABLED 0
option FPMCU_DISABLED 1
end
BUG=b:250807253
TEST=build firmware and verify the fp function in volmar DUT.
write `disable=1` and 'enable=0' in FPCMU_MASK field.
check the fp function and run `ectool --name cros_fp version`
It works as expected.
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Change-Id: I867771904811459697056662d5e29c545a1a9474
---
M src/mainboard/google/brya/variants/volmar/overridetree.cb
M src/mainboard/google/brya/variants/volmar/variant.c
2 files changed, 37 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/68917/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/68917
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I867771904811459697056662d5e29c545a1a9474
Gerrit-Change-Number: 68917
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ofer Fried <oferfried(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paz Zcharya <pazz(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Ofer Fried <oferfried(a)google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Nien, Isaac Lee, Jon Murphy, Martin Roth, Amanda Hwang.
Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69087 )
Change subject: mb/google/skyrim: Select GOOGLE_SMBIOS_MAINBOARD_VERSION
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97295083dbca1c285ef7359d86abac7315c654c9
Gerrit-Change-Number: 69087
Gerrit-PatchSet: 2
Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-CC: Nelson Ye <nelson_ye(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 00:58:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69094 )
Change subject: mb/google/brask/variants/moli: remove fan setting
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> > > Hi Subrata. Just +2'd so we should have x3 now. […]
Hi Subrata, yes, this CL need to be landed into firmware-brya-14505.B, too. Thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69094
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8851800d30ebf4d948d6eaadda2387c8afe52d8
Gerrit-Change-Number: 69094
Gerrit-PatchSet: 3
Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 00:43:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-MessageType: comment
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69077
to look at the new patch set (#2).
Change subject: nb/intel/gm45: Make polling loops more explicit
......................................................................
nb/intel/gm45: Make polling loops more explicit
Replace `while (...);` with `do {} while (...);` so that it's easier to
distinguish polling loops from something else, like function calls. The
`{}` can be understood as "nothing", so that the construct is naturally
read as "do nothing while (...)".
Another reason to prefer this method is that Jenkins does not complain.
Change-Id: Ifbf3cf072f8b817b2fdeece4ef89bae0822bb6e6
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/northbridge/intel/gm45/pcie.c
1 file changed, 20 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/69077/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbf3cf072f8b817b2fdeece4ef89bae0822bb6e6
Gerrit-Change-Number: 69077
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Arthur Heymans, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
......................................................................
Patch Set 6:
(7 comments)
File src/ec/clevo/it5570e/commands.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/1c40b227_d49b7c63
PS4, Line 41: while (recv_ec_data() != '$');
> check the previous push. jenkins complained about unneeded braces and probably will complain with your approach, too.
Hmmm, let's see if CB:69077 makes Jenkins angry.
> Actually, I don't really see the problem here
Granted, it's not *that* much of a problem, but Jenkins complaining about it is annoying.
https://review.coreboot.org/c/coreboot/+/68791/comment/e5e8f5c2_bbf7ec35
PS4, Line 45: *buf = '\0';
> rewritten, can you check again, please?
Seems to be fine
https://review.coreboot.org/c/coreboot/+/68791/comment/aa886992_9781ad67
PS4, Line 119: else if (start > 100 || stop > 100) {
> this was done for better readability. […]
Hmmm, let's find a loophole in the coding style. How about:
```
if (!state) {
start = 0xff;
stop = 0xff;
} else if (start > 100 || stop > 100) {
printk(BIOS_ERR, "EC: invalid flexicharger settings: start/stop > 100%%\n");
} else if (start >= stop) {
printk(BIOS_ERR, "EC: invalid flexicharger settings: start >= stop\n");
}
```
The braces make Jenkins happy, but the spacing is preserved.
https://review.coreboot.org/c/coreboot/+/68791/comment/bf84cf4a_973acd62
PS4, Line 122: else if (start >= stop) {
> > else should follow close brace '}' […]
See above
https://review.coreboot.org/c/coreboot/+/68791/comment/264d046b_09f0de54
PS4, Line 134: if (state > 3) {
> 3 should have been 2 \o/ […]
It looks much cleaner, thank you!
File src/ec/clevo/it5570e/commands.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/f5b2e0a6_239f7ca4
PS6, Line 120: printk(BIOS_ERR, "EC: invalid flexicharger settings: start/stop > 100%%\n");
Should the parameters be sanitized?
File src/ec/clevo/it5570e/ssdt.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/4d0d10e2_1bff3622
PS4, Line 119: goto pop;
> We *want* to write the function in any case bc it's always called. […]
The idea is basically moving the if-block contents to a helper function:
```
static void ec_custom_fan_curve(const ec_config_t *config, int fan_cnt)
{
int curve_cnt = 0;
/* Check curve count against fan count from EC */
for (int i = 0; i < IT5570E_MAX_FAN_CNT; i++) {
if (*config->fan_curves[i].speed && *config->fan_curves[i].temperature)
curve_cnt++;
}
if (curve_cnt != fan_cnt) {
printk(BIOS_WARNING,
"EC: Fan curve count (%d) does not match fan count (%d). "
"Check your devicetree!\n", curve_cnt, fan_cnt);
return;
}
/*
* Check all curves.
* Custom mode can only be enabled for all fans or none. Thus, all
* custom curves must be valid before custom mode can be enabled.
*/
for (int i = 0; i < fan_cnt; i++) {
if (!is_curve_valid(config->fan_curves[i])) {
printk(BIOS_ERR, "EC: Fan %d curve invalid. Check your devicetree!\n", i);
return;
}
}
acpigen_write_debug_string("EC: Apply custom fan curve");
for (int i = 0; i < fan_cnt; i++) {
write_fan_curve(config->fan_curves[i], i);
}
/* Enable custom fan mode */
acpigen_write_store_int_to_namestr(0x04, "FDAT");
acpigen_emit_namestring("SFCC");
acpigen_write_integer(0xd7);
}
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/68791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0
Gerrit-Change-Number: 68791
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Wed, 02 Nov 2022 00:24:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment