coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: drivers/ocp: add VPD processing framework
by Arthur Heymans (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Marc Jones, Jonathan Zhang, Johnny Lin, Paul Menzel, Angel Pons, Johnny Li, Shuming Chu (Shuming), Tim Chu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68784 ) Change subject: drivers/ocp: add VPD processing framework ...................................................................... Patch Set 4: (1 comment) File src/drivers/ocp/vpd/Makefile.inc: https://review.coreboot.org/c/coreboot/+/68784/comment/611dfab9_50640a14 PS2, Line 3: smm-$(C > Config VPD_SMM_SUPPORT is uploaded to CB:67092 for VPD access in SMM. It's a bad idea if you just want boot time configuration. I suggest passing the configuration once, just like how it's done for passing the cbmemc buffer. -- To view, visit https://review.coreboot.org/c/coreboot/+/68784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I705bea348b1611f25ccbd798b77cfee22ec30f0f Gerrit-Change-Number: 68784 Gerrit-PatchSet: 4 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Johnny Li <johnny_li(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Johnny Li <johnny_li(a)wistron.corp-partner.google.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 10:27:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/vpd, cpu/x86/smm: Add VPD support for SMM
by Arthur Heymans (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Arthur Heymans, Marc Jones, Subrata Banik, Johnny Lin, Ed Sharma, Christian Walter, Shuming Chu (Shuming), Michael Niewöhner, Kyösti Mälkki. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67092 ) Change subject: drivers/vpd, cpu/x86/smm: Add VPD support for SMM ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/67092/comment/7b700590_d9ccc1ed PS4, Line 9: The main purpose is to be able to dynamically configure system during : SMM boot time via VPD. It does way more than fulfill that purpose. The os could in principle also update the memory of that CBMEM region. Do you trust the SMM code enough that it will properly handle malformed input? It's not a safe thing to do so if your goal is to only have some boot time configuration, then you want a different mechanism than bloating the runtime. I suggest passing your configuration just like you pass the cbmemc buffer. -- To view, visit https://review.coreboot.org/c/coreboot/+/67092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I418568ef53b6de46db9b02846543e592930effd3 Gerrit-Change-Number: 67092 Gerrit-PatchSet: 4 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 10:26:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: packeteer 6500
by Angel Pons (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Martin L Roth, Sorin Pop. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69493 ) Change subject: packeteer 6500 ...................................................................... Patch Set 1: (10 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/69493/comment/574a262e_f7ad56c6 PS1, Line 7: packeteer 6500 > At coreboot, we prefer to start the subject line with a path, and to make sure we have a verb in the […] It's a good idea to list what is tested and works, what does not work, and what is not tested. https://review.coreboot.org/c/coreboot/+/69493/comment/b79052cc_3eb1e629 PS1, Line 8: > Needs a developer's certificate of origin sign-off saying that this is code that you have the rights […] You can amend the sign-off into your commit: `git commit -s --amend` Patchset: PS1: > Hey, welcome to coreboot! You might want to look through some of the documentation: https://corebo […] Welcome! File src/arch/x86/pirq_routing.c: https://review.coreboot.org/c/coreboot/+/69493/comment/4e3afdf3_76e19b4a PS1, Line 143: if (link > 0x5f) { : link -= 0x5f; : } > Split this int a separate patch and explain why its needed please. +1 File src/cpu/intel/Kconfig: https://review.coreboot.org/c/coreboot/+/69493/comment/640f823b_a956252e PS1, Line 19: source "src/cpu/intel/socket_FC_PGA370/Kconfig" > Please split all of the cpu/intel files into a separate commit. Adding the socket can be its own commit File src/mainboard/packeteer/6500/dsdt.asl: https://review.coreboot.org/c/coreboot/+/69493/comment/ea751cfc_1bcf7c76 PS1, Line 35: #include <acpi/dsdt_top.asl> This should probably be the first include https://review.coreboot.org/c/coreboot/+/69493/comment/4ce6082e_9f319f76 PS1, Line 89: Method(OSFL, 0){ : : if(LNotEqual(OSVR, Ones)) {Return(OSVR)} /* OS version was already detected */ : : if(CondRefOf(\_OSI)) : { : Store(1, OSVR) /* Assume some form of XP */ : if (\_OSI("Windows 2006")) /* Vista */ : { : Store(2, OSVR) : } : } else { : If(WCMP(\_OS,"Linux")) { : Store(3, OSVR) /* Linux */ : } Else { : Store(4, OSVR) /* Gotta be WinCE */ : } : } : Return(OSVR) : } Please use tabs for indentation. Also, do you think some of this could be factored out? It seems like some of this is common with asus/p2b File src/mainboard/packeteer/6500/dsdt.asl2: PS1: Is this used? File src/mainboard/packeteer/6500/irq_tables.c: https://review.coreboot.org/c/coreboot/+/69493/comment/4ff9e3f9_4c166edf PS1, Line 27: PIRQ_SIGNATURE, /* u32 signature */ > code indent should use tabs where possible Please fix. File src/mainboard/packeteer/6500/superio.asl: https://review.coreboot.org/c/coreboot/+/69493/comment/9b254287_206d9065 PS1, Line 5: * expose the W83977TF/EF SuperIO and some of its functionality. Is this correct? The mainboard seems to have a SMSC Super I/O -- To view, visit https://review.coreboot.org/c/coreboot/+/69493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie36fe8a4e0eaf13418af5a1fe8bd5b63f2265096 Gerrit-Change-Number: 69493 Gerrit-PatchSet: 1 Gerrit-Owner: Sorin Pop <alexsorinpop(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Sorin Pop <alexsorinpop(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 10:24:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: superio/acpi/pnp_generic.asl: Add _PRS for each device
by Arthur Heymans (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Nico Huber, Martin L Roth, Tristan Corrick, Angel Pons, Felix Held. Hello build bot (Jenkins), Nico Huber, Martin L Roth, Tristan Corrick, Angel Pons, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64218 to look at the new patch set (#5). Change subject: superio/acpi/pnp_generic.asl: Add _PRS for each device ...................................................................... superio/acpi/pnp_generic.asl: Add _PRS for each device Simply return the current resource settings in the _PRS method. This means that coreboot has to correctly set up the resources on the device. This won't result in any regression as without _PRS the ACPI OS would not know what resources settings are valid, so it would never use _SRS. Change-Id: I2726714cbe076fc7c772c06883d8551400ff2baa Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile.inc M src/mainboard/acer/g43t-am3/Kconfig M src/mainboard/asrock/h81m-hds/Kconfig M src/mainboard/asus/h61-series/Kconfig M src/mainboard/asus/p5qpl-am/Kconfig M src/mainboard/foxconn/d41s/Kconfig M src/mainboard/foxconn/g41s-k/Kconfig M src/mainboard/gigabyte/ga-d510ud/Kconfig M src/mainboard/intel/dcp847ske/Kconfig M src/mainboard/intel/dg41wv/Kconfig M src/mainboard/intel/dg43gt/Kconfig M src/mainboard/intel/emeraldlake2/Kconfig M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x9scl/Kconfig M src/superio/acpi/pnp_generic.asl 15 files changed, 24 insertions(+), 56 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/64218/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/64218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2726714cbe076fc7c772c06883d8551400ff2baa Gerrit-Change-Number: 64218 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: IASL: Ignore IASL's "Missing dependency" warning
by Arthur Heymans (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Michał Żygowski, Michał Kopeć, Elyes Haouas. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68936 ) Change subject: IASL: Ignore IASL's "Missing dependency" warning ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: Instead of working around warnings it's best to fix them: CB:64218 -- To view, visit https://review.coreboot.org/c/coreboot/+/68936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17d4f7ad4e3a9cb7d94263080d9d14fe6c9380d9 Gerrit-Change-Number: 68936 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 13 Nov 2022 09:52:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/ocp: add VPD processing framework
by Johnny Lin (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Marc Jones, Jonathan Zhang, Paul Menzel, Angel Pons, Johnny Li, Arthur Heymans, Shuming Chu (Shuming), Tim Chu. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68784 ) Change subject: drivers/ocp: add VPD processing framework ...................................................................... Patch Set 4: (1 comment) File src/drivers/ocp/vpd/Makefile.inc: https://review.coreboot.org/c/coreboot/+/68784/comment/b93bb3b9_eb3b3fd5 PS2, Line 3: smm-$(C > > Arthur, didn't you have some patches to allow passing runtime-configurable settings to the SMI han […] Config VPD_SMM_SUPPORT is uploaded to CB:67092 for VPD access in SMM. -- To view, visit https://review.coreboot.org/c/coreboot/+/68784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I705bea348b1611f25ccbd798b77cfee22ec30f0f Gerrit-Change-Number: 68784 Gerrit-PatchSet: 4 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Johnny Li <johnny_li(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Johnny Li <johnny_li(a)wistron.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 09:36:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/emulation/qemu: Move packed attribute
by Arthur Heymans (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Martin L Roth. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69494 ) Change subject: mb/emulation/qemu: Move packed attribute ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69494 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8faa24239505d808d09c00d825344edc7c4b7d9 Gerrit-Change-Number: 69494 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 09:24:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/supermicro/x11: fix cmos layout and add a default config
by Michael Niewöhner (Code Review) 13 Nov '22

13 Nov '22

Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35526 ) Change subject: mb/supermicro/x11: fix cmos layout and add a default config ...................................................................... mb/supermicro/x11: fix cmos layout and add a default config This fixes the error that power_on_after_fail could not be found, adds the missing nmi option and adds a default config. Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35526/1 diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig b/src/mainboard/supermicro/x11-lga1151-series/Kconfig index 3aaf1d3..68a3c94 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/Kconfig +++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig @@ -4,6 +4,7 @@ select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE + select HAVE_CMOS_DEFAULT select SOC_INTEL_KABYLAKE select SKYLAKE_SOC_PCH_H select MAINBOARD_HAS_LPC_TPM diff --git a/src/mainboard/supermicro/x11-lga1151-series/cmos.default b/src/mainboard/supermicro/x11-lga1151-series/cmos.default new file mode 100644 index 0000000..45a860b --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/cmos.default @@ -0,0 +1,4 @@ +boot_option=Fallback +debug_level=Debug +power_on_after_fail=Enable +nmi=Enable diff --git a/src/mainboard/supermicro/x11-lga1151-series/cmos.layout b/src/mainboard/supermicro/x11-lga1151-series/cmos.layout index 201ca33..e1c6aed 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/cmos.layout +++ b/src/mainboard/supermicro/x11-lga1151-series/cmos.layout @@ -30,6 +30,10 @@ 395 4 e 6 debug_level 448 128 r 0 vbnv +# coreboot config options: southbridge +408 1 e 1 nmi +409 2 e 7 power_on_after_fail + # coreboot config options: check sums 984 16 h 0 check_sum -- To view, visit https://review.coreboot.org/c/coreboot/+/35526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Gerrit-Change-Number: 35526 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-MessageType: newchange

6 25

[S] Change in coreboot[master]: lib/device_tree.c: Change log level message for FDT version
by Elyes Haouas (Code Review) 13 Nov '22

13 Nov '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69498 ) Change subject: lib/device_tree.c: Change log level message for FDT version ...................................................................... lib/device_tree.c: Change log level message for FDT version Change-Id: If92c1ccb5b10a4b29a5006a41ebd0855294f354e Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/lib/device_tree.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/69498/1 diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c index b846c25..352f254 100644 --- a/src/lib/device_tree.c +++ b/src/lib/device_tree.c @@ -256,8 +256,7 @@ return NULL; } if (version > FDT_SUPPORTED_VERSION) - printk(BIOS_DEBUG, - "NOTE: FDT version %u too new, should add support!\n", + printk(BIOS_NOTICE, "FDT version %u too new, should add support!\n", version); uint32_t struct_offset = be32toh(header->structure_offset); -- To view, visit https://review.coreboot.org/c/coreboot/+/69498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If92c1ccb5b10a4b29a5006a41ebd0855294f354e Gerrit-Change-Number: 69498 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: arch/{arm64,riscv}: Remove "CRIT: " from log messages
by Elyes Haouas (Code Review) 13 Nov '22

13 Nov '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69497 ) Change subject: arch/{arm64,riscv}: Remove "CRIT: " from log messages ...................................................................... arch/{arm64,riscv}: Remove "CRIT: " from log messages is no longer necessary to explicitly add "CRIT: " in front of BIOS_CRIT message. Change-Id: I506c1d278960c91d1283e9b1936c9c1678a10e17 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/arch/arm64/fit_payload.c M src/arch/riscv/fit_payload.c 2 files changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/69497/1 diff --git a/src/arch/arm64/fit_payload.c b/src/arch/arm64/fit_payload.c index 7f1c8f8..f8ae16a 100644 --- a/src/arch/arm64/fit_payload.c +++ b/src/arch/arm64/fit_payload.c @@ -169,7 +169,7 @@ void *arg = NULL; if (!decompress_kernel_header(config->kernel)) { - printk(BIOS_CRIT, "CRIT: Payload doesn't look like an ARM64" + printk(BIOS_CRIT, "Payload doesn't look like an ARM64" " kernel Image.\n"); return false; } diff --git a/src/arch/riscv/fit_payload.c b/src/arch/riscv/fit_payload.c index f7f4106..bfa0c98 100644 --- a/src/arch/riscv/fit_payload.c +++ b/src/arch/riscv/fit_payload.c @@ -67,7 +67,7 @@ void *arg = NULL; if (!config->fdt || !fdt) { - printk(BIOS_CRIT, "CRIT: Providing a valid FDT is mandatory to " + printk(BIOS_CRIT, "Providing a valid FDT is mandatory to " "boot a RISC-V kernel!\n"); return false; /* TODO: Fall back to the ROM FDT? */ -- To view, visit https://review.coreboot.org/c/coreboot/+/69497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I506c1d278960c91d1283e9b1936c9c1678a10e17 Gerrit-Change-Number: 69497 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022