coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: mb/google: Fix log messages
by Elyes Haouas (Code Review) 13 Nov '22

13 Nov '22

Elyes Haouas has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/69496 ) Change subject: mb/google: Fix log messages ...................................................................... mb/google: Fix log messages Change 'printk(BIOS_DEBUG, "ERROR:' to printk(BIOS_ERR, "'. Change-Id: Id31c25f5b8686f951ab4f331682b82ff327d5e78 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/auron/variants/buddy/variant.c M src/mainboard/google/beltino/lan.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/jecht/lan.c M src/mainboard/google/rambi/variants/ninja/lan.c M src/mainboard/google/rambi/variants/sumo/lan.c 6 files changed, 25 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/69496/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id31c25f5b8686f951ab4f331682b82ff327d5e78 Gerrit-Change-Number: 69496 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: [wip]mb/google/butterfly: Fix log messages
by Elyes Haouas (Code Review) 13 Nov '22

13 Nov '22

Elyes Haouas has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/69496 ) Change subject: [wip]mb/google/butterfly: Fix log messages ...................................................................... [wip]mb/google/butterfly: Fix log messages Change 'printk(BIOS_DEBUG, "ERROR:' to printk(BIOS_ERR, "'. Change-Id: Id31c25f5b8686f951ab4f331682b82ff327d5e78 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/butterfly/mainboard.c 1 file changed, 15 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/69496/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id31c25f5b8686f951ab4f331682b82ff327d5e78 Gerrit-Change-Number: 69496 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/butterfly: Fix log messages
by Elyes Haouas (Code Review) 13 Nov '22

13 Nov '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69496 ) Change subject: mb/google/butterfly: Fix log messages ...................................................................... mb/google/butterfly: Fix log messages Change 'printk(BIOS_DEBUG, "ERROR:' to printk(BIOS_ERR, "'. Change-Id: Id31c25f5b8686f951ab4f331682b82ff327d5e78 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/butterfly/mainboard.c 1 file changed, 15 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/69496/1 diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c index f428e69..67f371c 100644 --- a/src/mainboard/google/butterfly/mainboard.c +++ b/src/mainboard/google/butterfly/mainboard.c @@ -40,7 +40,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, (unsigned char)*offset); retval = 0; } @@ -58,8 +58,7 @@ offset = search(key, (char *)search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); @@ -149,7 +148,7 @@ kbd_type = EC_KBD_JP; } } else { - printk(BIOS_DEBUG, "Error: Could not locate VPD area\n"); + printk(BIOS_ERR, "Could not locate VPD area\n"); } printk(BIOS_DEBUG, "Setting Keyboard type in EC to "); -- To view, visit https://review.coreboot.org/c/coreboot/+/69496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id31c25f5b8686f951ab4f331682b82ff327d5e78 Gerrit-Change-Number: 69496 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/testing: Allow jenkins builders to skip clang testing
by Elyes Haouas (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69495 ) Change subject: util/testing: Allow jenkins builders to skip clang testing ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f8ac68c1bc8f8ff9be62d80db850355e742ee74 Gerrit-Change-Number: 69495 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 05:45:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/cpu.h: Change the function signature
by Elyes Haouas (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Arthur Heymans, Kyösti Mälkki. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69504 ) Change subject: cpu/cpu.h: Change the function signature ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad8e3cb318e6520ac5877118dbf43597dedb75b9 Gerrit-Change-Number: 69504 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 05:43:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/cpu.h: Remove unused functions
by Elyes Haouas (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Arthur Heymans, Kyösti Mälkki. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69503 ) Change subject: cpu/cpu.h: Remove unused functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69503 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecaf9ba3d31d22311557b885b31e98a0edd74d96 Gerrit-Change-Number: 69503 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 05:41:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/testing: Allow jenkins builders to skip clang testing
by Martin L Roth (Code Review) 13 Nov '22

13 Nov '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69495 ) Change subject: util/testing: Allow jenkins builders to skip clang testing ...................................................................... util/testing: Allow jenkins builders to skip clang testing The coverity builds are going to skip the clang build, so add a flag to make it possible. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I0f8ac68c1bc8f8ff9be62d80db850355e742ee74 --- M util/testing/Makefile.inc 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/69495/1 diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index ad01ac1..afc4b11 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -97,8 +97,10 @@ cd util/goswid ; go mod vendor util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/chromeos $(ABUILD_OPTIONS) -x -X $(top)/abuild-chromeos.xml util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/default $(ABUILD_OPTIONS) +ifneq ($(JENKINS_SKIP_CLANG_TESTS),y) util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/chromeos_clang $(ABUILD_OPTIONS) -x -X $(top)/abuild-chromeos_clang.xml -L util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/default_clang $(ABUILD_OPTIONS) -L +endif $(foreach tool, $(TOOLLIST), $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR="util/$(tool)" BLD="$(tool)" MFLAGS= MAKEFLAGS= MAKETARGET= junit.xml; ) unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/nvramcui BLD=nvramcui MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/coreinfo BLD=coreinfo MFLAGS= MAKEFLAGS= MAKETARGET=defaultbuild junit.xml -- To view, visit https://review.coreboot.org/c/coreboot/+/69495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f8ac68c1bc8f8ff9be62d80db850355e742ee74 Gerrit-Change-Number: 69495 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: device/Kconfig: Don't allow native mode in x86_64
by Martin L Roth (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Arthur Heymans. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69506 ) Change subject: device/Kconfig: Don't allow native mode in x86_64 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69506 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I910162756a567289b2484a5445360a3197ae848c Gerrit-Change-Number: 69506 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 13 Nov 2022 04:17:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: arch/x86/Kconfig: Move AMD stages arch to common code
by Martin L Roth (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Arthur Heymans, Fred Reitberger, Felix Held. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69505 ) Change subject: arch/x86/Kconfig: Move AMD stages arch to common code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I126801a1f6f523435935bb300f3e2807db347f63 Gerrit-Change-Number: 69505 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 13 Nov 2022 04:17:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/emulation/qemu: Move packed attribute
by Martin L Roth (Code Review) 13 Nov '22

13 Nov '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69494 ) Change subject: mb/emulation/qemu: Move packed attribute ...................................................................... mb/emulation/qemu: Move packed attribute The jenkins build complains about this now that clang has been added. src/mainboard/emulation/qemu-q35/cpu.c:37:1: error: attribute '__packed__' is ignored, place it after "union" to apply attribute to type declaration [-Werror,-Wignored-attributes] __packed union save_state { Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Id8faa24239505d808d09c00d825344edc7c4b7d9 --- M src/mainboard/emulation/qemu-q35/cpu.c 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/69494/1 diff --git a/src/mainboard/emulation/qemu-q35/cpu.c b/src/mainboard/emulation/qemu-q35/cpu.c index 2a2707a..698cd9c 100644 --- a/src/mainboard/emulation/qemu-q35/cpu.c +++ b/src/mainboard/emulation/qemu-q35/cpu.c @@ -34,7 +34,7 @@ * SMRAM entry point to here. */ -__packed union save_state { +union __packed save_state { amd64_smm_state_save_area_t amd64; struct { char _reserved[sizeof(amd64_smm_state_save_area_t) -- To view, visit https://review.coreboot.org/c/coreboot/+/69494 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8faa24239505d808d09c00d825344edc7c4b7d9 Gerrit-Change-Number: 69494 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022