Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
mb/supermicro/x11: fix cmos layout and add a default config
This fixes the error that power_on_after_fail could not be found, adds the missing nmi option and adds a default config.
Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35526/1
diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig b/src/mainboard/supermicro/x11-lga1151-series/Kconfig index 3aaf1d3..68a3c94 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/Kconfig +++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig @@ -4,6 +4,7 @@ select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE + select HAVE_CMOS_DEFAULT select SOC_INTEL_KABYLAKE select SKYLAKE_SOC_PCH_H select MAINBOARD_HAS_LPC_TPM diff --git a/src/mainboard/supermicro/x11-lga1151-series/cmos.default b/src/mainboard/supermicro/x11-lga1151-series/cmos.default new file mode 100644 index 0000000..45a860b --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/cmos.default @@ -0,0 +1,4 @@ +boot_option=Fallback +debug_level=Debug +power_on_after_fail=Enable +nmi=Enable diff --git a/src/mainboard/supermicro/x11-lga1151-series/cmos.layout b/src/mainboard/supermicro/x11-lga1151-series/cmos.layout index 201ca33..e1c6aed 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/cmos.layout +++ b/src/mainboard/supermicro/x11-lga1151-series/cmos.layout @@ -30,6 +30,10 @@ 395 4 e 6 debug_level 448 128 r 0 vbnv
+# coreboot config options: southbridge +408 1 e 1 nmi +409 2 e 7 power_on_after_fail + # coreboot config options: check sums 984 16 h 0 check_sum
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35526
to look at the new patch set (#3).
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
mb/supermicro/x11: fix cmos layout and add a default config
This fixes the error that power_on_after_fail could not be found, adds the missing nmi option and adds a default config.
Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35526/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35526
to look at the new patch set (#4).
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
mb/supermicro/x11: fix cmos layout and add a default config
This fixes the error that power_on_after_fail could not be found, adds the missing nmi option and adds a default config.
Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35526/4
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
Patch Set 4: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35526/7/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/cmos.layout:
https://review.coreboot.org/c/coreboot/+/35526/7/src/mainboard/supermicro/x1... PS7, Line 34: 408 1 e 1 nmi This is not an option in the Skylake port.
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35526
to look at the new patch set (#9).
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
mb/supermicro/x11: fix cmos layout and add a default config
This fixes the error that power_on_after_fail could not be found, adds the missing nmi option and adds a default config.
Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35526/9
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35526
to look at the new patch set (#10).
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
mb/supermicro/x11: fix cmos layout and add a default config
This fixes the error that power_on_after_fail could not be found, adds the missing nmi option and adds a default config.
Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35526/10
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35526
to look at the new patch set (#11).
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
mb/supermicro/x11: fix cmos layout and add a default config
This fixes the error that power_on_after_fail could not be found, adds the missing nmi option and adds a default config.
Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35526/11
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35526/7/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/cmos.layout:
https://review.coreboot.org/c/coreboot/+/35526/7/src/mainboard/supermicro/x1... PS7, Line 34: 408 1 e 1 nmi
This is not an option in the Skylake port.
Done
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35526
to look at the new patch set (#13).
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
mb/supermicro/x11: fix cmos layout and add a default config
This fixes the error that power_on_after_fail could not be found, adds the missing nmi option and adds a default config.
Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35526/13
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35526
to look at the new patch set (#14).
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
mb/supermicro/x11: fix cmos layout and add a default config
This fixes the error that power_on_after_fail could not be found, adds the missing nmi option and adds a default config.
Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35526/14
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
Patch Set 14: Code-Review+2
(2 comments)
Uploaded patch set 14: New patch set was added with same tree, parent, and commit message as Patch Set 13.
These ^ seem to throw Gerrit's score retention off. Usually, if you either change commit message or rebase, a +2 should stick. I guess something in your workflow unnecessarily amends commits *shrug*.
Anyway, for the future, please place such tiny fixes before the bigger, controversial ones on you branch. Then they can be faster submitted without too much rebasing noise.
https://review.coreboot.org/c/coreboot/+/35526/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35526/14//COMMIT_MSG@9 PS14, Line 9: error Is this really reported as an error somewhere? in that case that should change, a missing option in cmos.layout is not an error, more an integration choice, which options to expose.
https://review.coreboot.org/c/coreboot/+/35526/14//COMMIT_MSG@10 PS14, Line 10: missing nmi option ... update, please
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
Patch Set 14:
Patch Set 14: Code-Review+2
(2 comments)
Uploaded patch set 14: New patch set was added with same tree, parent, and commit message as Patch Set 13.
These ^ seem to throw Gerrit's score retention off. Usually, if you either change commit message or rebase, a +2 should stick. I guess something in your workflow unnecessarily amends commits *shrug*.
Anyway, for the future, please place such tiny fixes before the bigger, controversial ones on you branch. Then they can be faster submitted without too much rebasing noise.
I guess this happened, because of amendments to the parent commits... this depends on the x11 restructuring..
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35526/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35526/14//COMMIT_MSG@9 PS14, Line 9: error
Is this really reported as an error somewhere? in that case that […]
you are right, it's not reported as error but as warning
Hello Paul Menzel, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35526
to look at the new patch set (#15).
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
mb/supermicro/x11-lga1151-series: fix cmos layout and add default config
This fixes the warning that power_on_after_fail could not be found and adds a default config.
Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35526/15
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
Patch Set 15: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35526/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35526/14//COMMIT_MSG@10 PS14, Line 10: missing nmi option
... […]
Done
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
Patch Set 15: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35526/14/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/cmos.layout:
https://review.coreboot.org/c/coreboot/+/35526/14/src/mainboard/supermicro/x... PS14, Line 34: 409 2 e 7 power_on_after_fail out of order, has to be placed before 448
Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35526
to look at the new patch set (#16).
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
mb/supermicro/x11-lga1151-series: fix cmos layout and add default config
This fixes the warning that power_on_after_fail could not be found and adds a default config.
Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35526/16
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35526/14/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/cmos.layout:
https://review.coreboot.org/c/coreboot/+/35526/14/src/mainboard/supermicro/x... PS14, Line 34: 409 2 e 7 power_on_after_fail
out of order, has to be placed before 448
Done
Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35526
to look at the new patch set (#17).
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
mb/supermicro/x11-lga1151-series: fix cmos layout and add default config
This fixes the warning that power_on_after_fail could not be found, adds a default config and adds the parameter hyper_threading.
Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35526/17
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
Patch Set 17: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
mb/supermicro/x11-lga1151-series: fix cmos layout and add default config
This fixes the warning that power_on_after_fail could not be found, adds a default config and adds the parameter hyper_threading.
Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4 Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/35526 Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 3 files changed, 16 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig b/src/mainboard/supermicro/x11-lga1151-series/Kconfig index 6fc9aed..541b23d 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/Kconfig +++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig @@ -4,6 +4,7 @@ select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE + select HAVE_CMOS_DEFAULT select SOC_INTEL_KABYLAKE select SKYLAKE_SOC_PCH_H select MAINBOARD_HAS_LPC_TPM diff --git a/src/mainboard/supermicro/x11-lga1151-series/cmos.default b/src/mainboard/supermicro/x11-lga1151-series/cmos.default new file mode 100644 index 0000000..d564953 --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/cmos.default @@ -0,0 +1,3 @@ +boot_option=Fallback +debug_level=Debug +power_on_after_fail=Enable diff --git a/src/mainboard/supermicro/x11-lga1151-series/cmos.layout b/src/mainboard/supermicro/x11-lga1151-series/cmos.layout index 201ca33..03aea17 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/cmos.layout +++ b/src/mainboard/supermicro/x11-lga1151-series/cmos.layout @@ -17,7 +17,6 @@ entries
#start-bit length config config-ID name - 0 120 r 0 reserved_memory
# ----------------------------------------------------------------- @@ -28,8 +27,20 @@ # ----------------------------------------------------------------- # coreboot config options: console 395 4 e 6 debug_level + +# ----------------------------------------------------------------- +# coreboot config options: cpu +400 1 e 2 hyper_threading + +# ----------------------------------------------------------------- +# coreboot config options: southbridge +409 2 e 7 power_on_after_fail + +# ----------------------------------------------------------------- +# coreboot config options: bootloader 448 128 r 0 vbnv
+# ----------------------------------------------------------------- # coreboot config options: check sums 984 16 h 0 check_sum
Attention is currently required from: Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
Patch Set 18:
(1 comment)
File src/mainboard/supermicro/x11-lga1151-series/cmos.layout:
https://review.coreboot.org/c/coreboot/+/35526/comment/de5c7224_e9c3f722 PS18, Line 33: 400 1 e 2 hyper_threading So, hyper_threading uses enum 2, which means `0 = Enable` and `1 = Disable`. This is backwards.
Also, no CMOS defaults were provided.
Also, this conflicts with the century byte.
Will try to fix.
Attention is currently required from: Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
Patch Set 18:
(1 comment)
File src/mainboard/supermicro/x11-lga1151-series/cmos.layout:
https://review.coreboot.org/c/coreboot/+/35526/comment/42287130_289b2900 PS18, Line 33: 400 1 e 2 hyper_threading
So, hyper_threading uses enum 2, which means `0 = Enable` and `1 = Disable`. This is backwards. […]
CB:69491
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
Patch Set 18:
(1 comment)
File src/mainboard/supermicro/x11-lga1151-series/cmos.layout:
https://review.coreboot.org/c/coreboot/+/35526/comment/70d21e32_803b375d PS18, Line 33: 400 1 e 2 hyper_threading
CB:69491
The idea was to have it reversed, so ht is enabled, when the setting is not set/found. Having a default is way better, though. Thanks
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)