Patch Set 14: Code-Review+2

(2 comments)

Uploaded patch set 14: New patch set was added with same tree, parent, and commit message as Patch Set 13.

These ^ seem to throw Gerrit's score retention off. Usually, if
you either change commit message or rebase, a +2 should stick.
I guess something in your workflow unnecessarily amends commits
*shrug*.

Anyway, for the future, please place such tiny fixes before
the bigger, controversial ones on you branch. Then they can be
faster submitted without too much rebasing noise.

I guess this happened, because of amendments to the parent commits... this depends on the x11 restructuring..

View Change

To view, visit change 35526. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4
Gerrit-Change-Number: 35526
Gerrit-PatchSet: 14
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 24 Sep 2019 11:09:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment