coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: mb/clevo/cml-u: Fix CMOS options
by Sean Rhodes (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Felix Singer, Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69521 ) Change subject: mb/clevo/cml-u: Fix CMOS options ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56b0320f9210cde8ff58db176d2b7d2207c98aa9 Gerrit-Change-Number: 69521 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 20:07:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mainboard: Drop invalid `hyper_threading` option
by Sean Rhodes (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69523 ) Change subject: mainboard: Drop invalid `hyper_threading` option ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8980a951f4751bc2e1a5d0e88835f578259b256 Gerrit-Change-Number: 69523 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 20:07:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: IASL: Ignore IASL's "Missing dependency" warning
by Arthur Heymans (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Michał Żygowski, Michał Kopeć, Elyes Haouas. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68936 ) Change subject: IASL: Ignore IASL's "Missing dependency" warning ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > https://review.coreboot.org/64218 will not fix the issue > please see https://qa.coreboot.org/job/coreboot-toolchain/1274/ That just means there are other issues too -- To view, visit https://review.coreboot.org/c/coreboot/+/68936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17d4f7ad4e3a9cb7d94263080d9d14fe6c9380d9 Gerrit-Change-Number: 68936 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 13 Nov 2022 19:43:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Makefile.inc: Remove workaround ACPI warnings
by Arthur Heymans (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Martin L Roth, Angel Pons. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69514 ) Change subject: Makefile.inc: Remove workaround ACPI warnings ...................................................................... Makefile.inc: Remove workaround ACPI warnings No boards now have a missing dependency so remove the workaround. Change-Id: I787f6aa588175ba620a068918c42edc9d257c3ef Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile.inc M src/mainboard/acer/g43t-am3/Kconfig M src/mainboard/asrock/h81m-hds/Kconfig M src/mainboard/asus/h61-series/Kconfig M src/mainboard/asus/p5qpl-am/Kconfig M src/mainboard/foxconn/d41s/Kconfig M src/mainboard/foxconn/g41s-k/Kconfig M src/mainboard/gigabyte/ga-d510ud/Kconfig M src/mainboard/intel/dcp847ske/Kconfig M src/mainboard/intel/dg41wv/Kconfig M src/mainboard/intel/dg43gt/Kconfig M src/mainboard/intel/emeraldlake2/Kconfig M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x9scl/Kconfig 14 files changed, 12 insertions(+), 56 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/69514/1 diff --git a/Makefile.inc b/Makefile.inc index 563a2bc..b4c2cdf 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -265,26 +265,9 @@ # ResourceTemplate is the correct code. # As it's valid ASL, disable the warning. EMPTY_RESOURCE_TEMPLATE_WARNING = 3150 -# IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects: -# 1) If _PRS is present, must have _CRS and _SRS -# 2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS) -# 3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS requires _CRS and _SRS) -# 4) If _SRS is present, probably should have a _DIS (Remark only) -# A warning will be issued for each of these cases. -# For existing ASL code, ignore this warnings -IASL_MISSING_DEPENDENCY = 3141 IASL_WARNINGS_LIST = $(EMPTY_RESOURCE_TEMPLATE_WARNING) -ifeq ($(CONFIG_IGNORE_IASL_MISSING_DEPENDENCY),y) - IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) -build_complete:: - printf "*** WARNING: The ASL code for this platform is incomplete. Please fix it. ***\n" - printf "*** If _PRS is present, must have _CRS and _SRS ***\n" - printf "*** If _SRS is present, must have _PRS and _CRS ***\n" - printf "*** If _DIS is present, must have _SRS, _PRS and _CRS ***\n" -endif - IGNORED_IASL_WARNINGS = $(addprefix -vw , $(IASL_WARNINGS_LIST)) define asl_template diff --git a/src/mainboard/acer/g43t-am3/Kconfig b/src/mainboard/acer/g43t-am3/Kconfig index dd2bf3f..1d4fd53 100644 --- a/src/mainboard/acer/g43t-am3/Kconfig +++ b/src/mainboard/acer/g43t-am3/Kconfig @@ -2,9 +2,6 @@ if BOARD_ACER_G43T_AM3 -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_LGA775 diff --git a/src/mainboard/asrock/h81m-hds/Kconfig b/src/mainboard/asrock/h81m-hds/Kconfig index 4b21ec5..4edd2bc 100644 --- a/src/mainboard/asrock/h81m-hds/Kconfig +++ b/src/mainboard/asrock/h81m-hds/Kconfig @@ -2,9 +2,6 @@ if BOARD_ASROCK_H81M_HDS -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_4096 diff --git a/src/mainboard/asus/h61-series/Kconfig b/src/mainboard/asus/h61-series/Kconfig index 48e4220..eeec4e7 100644 --- a/src/mainboard/asus/h61-series/Kconfig +++ b/src/mainboard/asus/h61-series/Kconfig @@ -14,9 +14,6 @@ if BOARD_ASUS_H61_SERIES -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config MAINBOARD_DIR default "asus/h61-series" diff --git a/src/mainboard/asus/p5qpl-am/Kconfig b/src/mainboard/asus/p5qpl-am/Kconfig index 100f591..2359e32 100644 --- a/src/mainboard/asus/p5qpl-am/Kconfig +++ b/src/mainboard/asus/p5qpl-am/Kconfig @@ -2,9 +2,6 @@ if BOARD_ASUS_P5QPL_AM || BOARD_ASUS_P5G41T_M_LX -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_LGA775 diff --git a/src/mainboard/foxconn/d41s/Kconfig b/src/mainboard/foxconn/d41s/Kconfig index 33d5e6d..6ddc7df 100644 --- a/src/mainboard/foxconn/d41s/Kconfig +++ b/src/mainboard/foxconn/d41s/Kconfig @@ -2,9 +2,6 @@ if BOARD_FOXCONN_D41S -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_FCBGA559 diff --git a/src/mainboard/foxconn/g41s-k/Kconfig b/src/mainboard/foxconn/g41s-k/Kconfig index a98a47a..b223759 100644 --- a/src/mainboard/foxconn/g41s-k/Kconfig +++ b/src/mainboard/foxconn/g41s-k/Kconfig @@ -2,9 +2,6 @@ if BOARD_FOXCONN_G41S_K || BOARD_FOXCONN_G41M -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_LGA775 diff --git a/src/mainboard/gigabyte/ga-d510ud/Kconfig b/src/mainboard/gigabyte/ga-d510ud/Kconfig index 4739f81..731b9f4 100644 --- a/src/mainboard/gigabyte/ga-d510ud/Kconfig +++ b/src/mainboard/gigabyte/ga-d510ud/Kconfig @@ -2,9 +2,6 @@ if BOARD_GIGABYTE_GA_D510UD -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_512 diff --git a/src/mainboard/intel/dcp847ske/Kconfig b/src/mainboard/intel/dcp847ske/Kconfig index c5e5afd..ebc172b 100644 --- a/src/mainboard/intel/dcp847ske/Kconfig +++ b/src/mainboard/intel/dcp847ske/Kconfig @@ -1,8 +1,5 @@ if BOARD_INTEL_DCP847SKE -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 diff --git a/src/mainboard/intel/dg41wv/Kconfig b/src/mainboard/intel/dg41wv/Kconfig index 8c5a5d6..bb201bc 100644 --- a/src/mainboard/intel/dg41wv/Kconfig +++ b/src/mainboard/intel/dg41wv/Kconfig @@ -2,9 +2,6 @@ if BOARD_INTEL_DG41WV -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_LGA775 diff --git a/src/mainboard/intel/dg43gt/Kconfig b/src/mainboard/intel/dg43gt/Kconfig index 55b5cd0..c3c853c 100644 --- a/src/mainboard/intel/dg43gt/Kconfig +++ b/src/mainboard/intel/dg43gt/Kconfig @@ -2,9 +2,6 @@ if BOARD_INTEL_DG43GT -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_LGA775 diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig index 0220d73..86fe98a 100644 --- a/src/mainboard/intel/emeraldlake2/Kconfig +++ b/src/mainboard/intel/emeraldlake2/Kconfig @@ -1,8 +1,5 @@ if BOARD_INTEL_EMERALDLAKE2 -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select NORTHBRIDGE_INTEL_SANDYBRIDGE diff --git a/src/mainboard/supermicro/x10slm-f/Kconfig b/src/mainboard/supermicro/x10slm-f/Kconfig index 24e67c7..28c7c1a 100644 --- a/src/mainboard/supermicro/x10slm-f/Kconfig +++ b/src/mainboard/supermicro/x10slm-f/Kconfig @@ -2,9 +2,6 @@ if BOARD_SUPERMICRO_X10SLM_PLUS_F -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 diff --git a/src/mainboard/supermicro/x9scl/Kconfig b/src/mainboard/supermicro/x9scl/Kconfig index 469b791..40b4213 100644 --- a/src/mainboard/supermicro/x9scl/Kconfig +++ b/src/mainboard/supermicro/x9scl/Kconfig @@ -1,8 +1,5 @@ if BOARD_SUPERMICRO_X9SCL -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 -- To view, visit https://review.coreboot.org/c/coreboot/+/69514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I787f6aa588175ba620a068918c42edc9d257c3ef Gerrit-Change-Number: 69514 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: superio/acpi/pnp_generic.asl: Add _PRS for each device
by Arthur Heymans (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Martin L Roth, Tristan Corrick, Angel Pons, Arthur Heymans, Felix Held. Hello build bot (Jenkins), Nico Huber, Martin L Roth, Tristan Corrick, Angel Pons, Elyes Haouas, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64218 to look at the new patch set (#8). Change subject: superio/acpi/pnp_generic.asl: Add _PRS for each device ...................................................................... superio/acpi/pnp_generic.asl: Add _PRS for each device Simply return the current resource settings in the _PRS method. This means that coreboot has to correctly set up the resources on the device. This won't result in any regression as without _PRS the ACPI OS would not know what resources settings are valid, so it would never use _SRS. Change-Id: I2726714cbe076fc7c772c06883d8551400ff2baa Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/superio/acpi/pnp_generic.asl 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/64218/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/64218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2726714cbe076fc7c772c06883d8551400ff2baa Gerrit-Change-Number: 64218 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/starlabs/*: Reserve the century byte in CMOS
by build bot (Jenkins) (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Angel Pons, Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69323 ) Change subject: mb/starlabs/*: Reserve the century byte in CMOS ...................................................................... Patch Set 11: Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69323 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0237772fb2f705065c833dc721184295c75884ea Gerrit-Change-Number: 69323 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 13 Nov 2022 19:35:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented
by Arthur Heymans (Code Review) 13 Nov '22

13 Nov '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69513 ) Change subject: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented ...................................................................... {ec/superio}/acpi: Remove _PRS if no _SRS is implemented _PRS only makes sense if _SRS is implemented. Change-Id: I030bd716215b5ac5738e00ebf6ed991d9d6c5ca0 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/ec/google/wilco/acpi/superio.asl M src/ec/quanta/ene_kb3940q/acpi/superio.asl M src/ec/quanta/it8518/acpi/superio.asl M src/superio/ite/it8772f/acpi/superio.asl M src/superio/smsc/sio1007/acpi/superio.asl 5 files changed, 12 insertions(+), 130 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/69513/1 diff --git a/src/ec/google/wilco/acpi/superio.asl b/src/ec/google/wilco/acpi/superio.asl index b2737c3..3cec006 100644 --- a/src/ec/google/wilco/acpi/superio.asl +++ b/src/ec/google/wilco/acpi/superio.asl @@ -26,15 +26,6 @@ IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) IRQNoFlags () {4} }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) - IRQNoFlags () {4} - } - EndDependentFn () - }) } } @@ -61,16 +52,6 @@ IO (Decode16, 0x64, 0x64, 0x01, 0x01) IRQ (Edge, ActiveHigh, Exclusive) {1} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQ (Edge, ActiveHigh, Exclusive) {1} - } - EndDependentFn () - }) } Device (PS2M) @@ -91,13 +72,5 @@ { IRQ (Edge, ActiveHigh, Exclusive) {12} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - IRQ (Edge, ActiveHigh, Exclusive) {12} - } - EndDependentFn () - }) } } diff --git a/src/ec/quanta/ene_kb3940q/acpi/superio.asl b/src/ec/quanta/ene_kb3940q/acpi/superio.asl index 008f573f..b5962f0 100644 --- a/src/ec/quanta/ene_kb3940q/acpi/superio.asl +++ b/src/ec/quanta/ene_kb3940q/acpi/superio.asl @@ -24,16 +24,6 @@ FixedIO (0x64, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - FixedIO (0x60, 0x01) - FixedIO (0x64, 0x01) - IRQNoFlags () {1} - } - EndDependentFn () - }) } #endif } diff --git a/src/ec/quanta/it8518/acpi/superio.asl b/src/ec/quanta/it8518/acpi/superio.asl index 9cdf265..b91324d 100644 --- a/src/ec/quanta/it8518/acpi/superio.asl +++ b/src/ec/quanta/it8518/acpi/superio.asl @@ -25,17 +25,6 @@ FixedIO (0x64, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) - { - FixedIO (0x60, 0x01) - FixedIO (0x64, 0x01) - IRQNoFlags () {1} - } - EndDependentFn () - }) } #endif @@ -55,17 +44,6 @@ FixedIO (0x64, 0x01) IRQNoFlags () {12} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) - { - FixedIO (0x60, 0x01) - FixedIO (0x64, 0x01) - IRQNoFlags () {12} - } - EndDependentFn () - }) } #endif diff --git a/src/superio/ite/it8772f/acpi/superio.asl b/src/superio/ite/it8772f/acpi/superio.asl index 5132df0..963ec32 100644 --- a/src/superio/ite/it8772f/acpi/superio.asl +++ b/src/superio/ite/it8772f/acpi/superio.asl @@ -151,12 +151,6 @@ IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) - IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) - }) } #endif @@ -175,11 +169,6 @@ IRQNoFlags () {4} }) - Name (_PRS, ResourceTemplate () - { - IO (Decode16, 0x03F8, 0x03F8, 0x08, 0x08) - IRQNoFlags () {4} - }) } #endif @@ -200,12 +189,6 @@ IRQNoFlags () {1} }) - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQNoFlags () {1} - }) } #endif @@ -223,10 +206,6 @@ IRQNoFlags () {12} }) - Name (_PRS, ResourceTemplate() - { - IRQNoFlags () {12} - }) } #endif @@ -247,13 +226,6 @@ DMA (Compatibility, NotBusMaster, Transfer8) {2} }) - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x03F0, 0x03F0, 0x01, 0x06) - IO (Decode16, 0x03F7, 0x03F7, 0x01, 0x01) - IRQNoFlags () {6} - DMA (Compatibility, NotBusMaster, Transfer8) {2} - }) } #endif @@ -272,11 +244,6 @@ IRQNoFlags () { SIO_INFR_IRQ } }) - Name (_PRS, ResourceTemplate() - { - IO (Decode16, SIO_INFR_IO0, SIO_INFR_IO0, 0x08, 0x08) - IRQNoFlags () { SIO_INFR_IRQ } - }) } #endif } diff --git a/src/superio/smsc/sio1007/acpi/superio.asl b/src/superio/smsc/sio1007/acpi/superio.asl index 5132df0..385a121 100644 --- a/src/superio/smsc/sio1007/acpi/superio.asl +++ b/src/superio/smsc/sio1007/acpi/superio.asl @@ -151,12 +151,6 @@ IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) - IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) - }) } #endif @@ -174,12 +168,6 @@ IO (Decode16, 0x03F8, 0x03F8, 0x08, 0x08) IRQNoFlags () {4} }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, 0x03F8, 0x03F8, 0x08, 0x08) - IRQNoFlags () {4} - }) } #endif @@ -199,13 +187,6 @@ IO (Decode16, 0x64, 0x64, 0x01, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQNoFlags () {1} - }) } #endif @@ -222,11 +203,6 @@ { IRQNoFlags () {12} }) - - Name (_PRS, ResourceTemplate() - { - IRQNoFlags () {12} - }) } #endif @@ -246,14 +222,6 @@ IRQNoFlags () {6} DMA (Compatibility, NotBusMaster, Transfer8) {2} }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x03F0, 0x03F0, 0x01, 0x06) - IO (Decode16, 0x03F7, 0x03F7, 0x01, 0x01) - IRQNoFlags () {6} - DMA (Compatibility, NotBusMaster, Transfer8) {2} - }) } #endif @@ -271,12 +239,6 @@ IO (Decode16, SIO_INFR_IO0, SIO_INFR_IO0, 0x08, 0x08) IRQNoFlags () { SIO_INFR_IRQ } }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, SIO_INFR_IO0, SIO_INFR_IO0, 0x08, 0x08) - IRQNoFlags () { SIO_INFR_IRQ } - }) } #endif } -- To view, visit https://review.coreboot.org/c/coreboot/+/69513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I030bd716215b5ac5738e00ebf6ed991d9d6c5ca0 Gerrit-Change-Number: 69513 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: Documentation/mb/starlabs: De-duplicate the building instructions
by build bot (Jenkins) (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Sean Rhodes. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68585 ) Change subject: Documentation/mb/starlabs: De-duplicate the building instructions ...................................................................... Patch Set 12: Verified-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20301b3041a62eb416ed61a84544ec4e5cc66c1e Gerrit-Change-Number: 68585 Gerrit-PatchSet: 12 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Sun, 13 Nov 2022 19:33:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/adl: Set thermal trip based on power profile
by Sean Rhodes (Code Review) 13 Nov '22

13 Nov '22

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69492 ) Change subject: mb/starlabs/starbook/adl: Set thermal trip based on power profile ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/69492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07be0aa2144b7718e28f1f675978b4b4b92752ae Gerrit-Change-Number: 69492 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Nov 2022 19:32:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/tigerlake: Drop superfluous HyperThreadingDisable option
by Angel Pons (Code Review) 13 Nov '22

13 Nov '22

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69533 ) Change subject: soc/intel/tigerlake: Drop superfluous HyperThreadingDisable option ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: See CB:69534 -- To view, visit https://review.coreboot.org/c/coreboot/+/69533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76c36ea5c40221521eb9b79068baedc78dd34d90 Gerrit-Change-Number: 69533 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 19:30:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022