Attention is currently required from: Elyes Haouas.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69496 )
Change subject: mb/google: Fix log messages
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69496
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id31c25f5b8686f951ab4f331682b82ff327d5e78
Gerrit-Change-Number: 69496
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 14 Nov 2022 00:39:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Kangheui Won, Tyler Wang, Nick Vaccaro.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69466 )
Change subject: mb/google/nissa/var/craask: Remove RFIM settings for Craask
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69466
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1eb4d93c2821cb067628dc1228c6c522d292c739
Gerrit-Change-Number: 69466
Gerrit-PatchSet: 4
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cathy Chen <cathy_chen(a)quanta.corp-partner.google.com>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Mon, 14 Nov 2022 00:25:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Kangheui Won, Tyler Wang, Nick Vaccaro.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69466 )
Change subject: mb/google/nissa/var/craask: Remove RFIM settings for Craask
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69466
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1eb4d93c2821cb067628dc1228c6c522d292c739
Gerrit-Change-Number: 69466
Gerrit-PatchSet: 4
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cathy Chen <cathy_chen(a)quanta.corp-partner.google.com>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Mon, 14 Nov 2022 00:19:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69536 )
Change subject: util/kconfig: Move Kconfig deps back into build/config
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163560):
https://review.coreboot.org/c/coreboot/+/69536/comment/8da3a2bb_bcdd33d1
PS1, Line 14:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/69536
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2904f69a5d85337ad0a6b48590ccd4b4a6e38b70
Gerrit-Change-Number: 69536
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 13 Nov 2022 22:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69536 )
Change subject: util/kconfig: Move Kconfig deps back into build/config
......................................................................
util/kconfig: Move Kconfig deps back into build/config
revert commit 1b9e740a8 (kconfig: fix failing to generate auto.conf) [1]
The above change caused all of the enabled kconfig options to be written
into the top level build directory. We don't want that, so go back to
the old behavior for the coreboot tree.
[1] https://web.archive.org/web/20220316120807/https://github.com/torvalds/linu…
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I2904f69a5d85337ad0a6b48590ccd4b4a6e38b70
---
M util/kconfig/confdata.c
1 file changed, 29 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/69536/1
diff --git a/util/kconfig/confdata.c b/util/kconfig/confdata.c
index 95fb960..3da9e8b 100644
--- a/util/kconfig/confdata.c
+++ b/util/kconfig/confdata.c
@@ -230,6 +230,13 @@
return name ? name : "include/generated/autoconf.h";
}
+static const char *conf_get_autobase_name(void)
+{
+ char *name = getenv("KCONFIG_SPLITCONFIG");
+
+ return name ? name : "include/config/";
+}
+
static int conf_set_sym_val(struct symbol *sym, int def, int def_flags, char *p)
{
char *p2;
@@ -1024,19 +1031,14 @@
static int conf_touch_deps(void)
{
- const char *name, *tmp;
+ const char *name;
struct symbol *sym;
int res, i;
+ strcpy(depfile_path, conf_get_autobase_name());
+ depfile_prefix_len = strlen(depfile_path);
+
name = conf_get_autoconfig_name();
- tmp = strrchr(name, '/');
- depfile_prefix_len = tmp ? tmp - name + 1 : 0;
- if (depfile_prefix_len + 1 > sizeof(depfile_path))
- return -1;
-
- strncpy(depfile_path, name, depfile_prefix_len);
- depfile_path[depfile_prefix_len] = 0;
-
conf_read_simple(name, S_DEF_AUTO);
sym_calc_value(modules_sym);
--
To view, visit https://review.coreboot.org/c/coreboot/+/69536
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2904f69a5d85337ad0a6b48590ccd4b4a6e38b70
Gerrit-Change-Number: 69536
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Martin L Roth has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/69535 )
Change subject: util/kconfig: Add patch to move Kconfig deps to build/config
......................................................................
util/kconfig: Add patch to move Kconfig deps to build/config
The change being reverted [1] caused all the Kconfig dependency files
to be generated at the top level of coreboot's build directory.
This reverts that behavior and puts the dependencies back where we're
used to them being.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ic4b48831705c3206e7c2e09f01d072d1cde9c9c4
---
A util/kconfig/patches/0014-util-kconfig-Move-Kconfig-deps-back-into-build-confi.patch
M util/kconfig/patches/series
2 files changed, 81 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/69535/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69535
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4b48831705c3206e7c2e09f01d072d1cde9c9c4
Gerrit-Change-Number: 69535
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Lance Zhao, Michał Żygowski, Christian Walter, Tim Wawrzynczak, Julius Werner, Krystian Hebel, Yu-Ping Wu.
Hello Lance Zhao, Michał Żygowski, Tim Wawrzynczak, Christian Walter, Julius Werner, Krystian Hebel, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69161
to look at the new patch set (#5).
Change subject: security/tpm: replace CONFIG(TPMx) checks with runtime check
......................................................................
security/tpm: replace CONFIG(TPMx) checks with runtime check
This prepares the code to enabling both CONFIG_TPM1 and CONFIT_TPM2
during compilation, in which case actual TPM family in use will be
determined at runtime.
In some places both compile time and runtime checks are necessary.
Change-Id: Id9cc25aad8d1d7bfad12b7a92059b1b3641bbfa9
Ticket: https://ticket.coreboot.org/issues/433
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M src/acpi/acpi.c
M src/drivers/crb/tis.c
M src/drivers/pc80/tpm/tis.c
M src/drivers/tpm/ppi.c
M src/security/tpm/tspi/crtm.h
M src/security/tpm/tspi/tspi.c
M src/security/tpm/tss.h
M src/security/tpm/tss/tss.c
M src/security/vboot/secdata_tpm.c
M src/security/vboot/tpm_common.c
M src/vendorcode/google/chromeos/cse_board_reset.c
M src/vendorcode/google/chromeos/tpm2.c
12 files changed, 136 insertions(+), 63 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/69161/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/69161
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9cc25aad8d1d7bfad12b7a92059b1b3641bbfa9
Gerrit-Change-Number: 69161
Gerrit-PatchSet: 5
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jonathan Zhang, Angel Pons, Arthur Heymans, Shuming Chu (Shuming), TangYiwei.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69222 )
Change subject: cpu/x86/topology: Add code to fill in topology on struct path
......................................................................
Patch Set 6:
(4 comments)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/69222/comment/35f08c0d_4bb20de0
PS6, Line 198: dev->path.apic.apic_id = lapicid();
Already assumes dev->path.type as APIC here.
File src/cpu/x86/topology.c:
https://review.coreboot.org/c/coreboot/+/69222/comment/f74c3626_2a8d02be
PS6, Line 67: if (cpu->path.type != DEVICE_PATH_APIC)
Should be done earlier.
https://review.coreboot.org/c/coreboot/+/69222/comment/4dfdb925_8d1d9875
PS6, Line 84: cpu->path.apic.thread_id = apicid & ((1 << thread_bits) - 1);
Bring set_cpu_topology() into this file?
File src/include/cpu/x86/topology.h:
https://review.coreboot.org/c/coreboot/+/69222/comment/6a9db898_ecca05da
PS6, Line 9: */
Tests for .thread_id will fail after cb:69225 if no topology is filled in.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69222
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2210eb9b663dd90941a64132aa7154440dc7e5a9
Gerrit-Change-Number: 69222
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Sun, 13 Nov 2022 21:49:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Angel Pons.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64342 )
Change subject: cpu/x86/mp_init.c: Keep track of initial lapic ID inside device_path
......................................................................
Patch Set 15:
(2 comments)
File src/device/cpu_device.c:
https://review.coreboot.org/c/coreboot/+/64342/comment/7f23f1fb_a58f0df6
PS15, Line 10: struct device_path cpu_path;
The structure is not zero-initialized? Unrelated to this commit, separate fix?
https://review.coreboot.org/c/coreboot/+/64342/comment/18815461_3d2dd841
PS15, Line 33: void set_cpu_topology(struct device *cpu, unsigned int node,
Currently nobody calls this to address the uninitialized fields from above.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64342
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d9f8d23c0b0e5c142f6907593428d8509e4e7bb
Gerrit-Change-Number: 64342
Gerrit-PatchSet: 15
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 13 Nov 2022 21:39:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment