coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: superio/acpi/pnp_generic.asl: Add _PRS for each device
by Elyes Haouas (Code Review) 14 Nov '22

14 Nov '22

Attention is currently required from: Martin L Roth, Tristan Corrick, Angel Pons, Arthur Heymans, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64218 ) Change subject: superio/acpi/pnp_generic.asl: Add _PRS for each device ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2726714cbe076fc7c772c06883d8551400ff2baa Gerrit-Change-Number: 64218 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 10:14:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented
by Arthur Heymans (Code Review) 14 Nov '22

14 Nov '22

Attention is currently required from: Caveh Jalali, Arthur Heymans, Boris Mittelberg, Felix Held. Hello build bot (Jenkins), Nico Huber, Caveh Jalali, Elyes Haouas, Boris Mittelberg, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69513 to look at the new patch set (#4). Change subject: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented ...................................................................... {ec/superio}/acpi: Remove _PRS if no _SRS is implemented _PRS only makes sense if _SRS is implemented. Change-Id: I030bd716215b5ac5738e00ebf6ed991d9d6c5ca0 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/ec/google/wilco/acpi/ec_dev.asl M src/ec/google/wilco/acpi/superio.asl M src/ec/quanta/ene_kb3940q/acpi/superio.asl M src/ec/quanta/it8518/acpi/superio.asl M src/superio/ite/it8772f/acpi/superio.asl M src/superio/smsc/sio1007/acpi/superio.asl 6 files changed, 12 insertions(+), 161 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/69513/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/69513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I030bd716215b5ac5738e00ebf6ed991d9d6c5ca0 Gerrit-Change-Number: 69513 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: security/tpm: support compiling in multiple TPM drivers
by build bot (Jenkins) (Code Review) 14 Nov '22

14 Nov '22

Attention is currently required from: Michał Żygowski, Christian Walter, Julius Werner, Krystian Hebel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69162 ) Change subject: security/tpm: support compiling in multiple TPM drivers ...................................................................... Patch Set 4: (2 comments) File src/security/tpm/tis.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163607): https://review.coreboot.org/c/coreboot/+/69162/comment/01e9bfc6_510f61e5 PS4, Line 110: #define __tis_driver __attribute__((used, section(".rodata.tis_driver"))) Prefer __used over __attribute__((used)) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163607): https://review.coreboot.org/c/coreboot/+/69162/comment/4ba1c502_3cc37f72 PS4, Line 110: #define __tis_driver __attribute__((used, section(".rodata.tis_driver"))) Prefer __section(".rodata.tis_driver") over __attribute__((section(".rodata.tis_driver"))) -- To view, visit https://review.coreboot.org/c/coreboot/+/69162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44c5a1d825afe414c2f5c2c90f4cfe41ba9bef5f Gerrit-Change-Number: 69162 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Mon, 14 Nov 2022 10:12:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: src/device + util/sconfig: Introduce new device 'mdio'
by Werner Zeh (Code Review) 14 Nov '22

14 Nov '22

Attention is currently required from: Martin L Roth, Subrata Banik, Mario Scheithauer, Angel Pons. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69382 ) Change subject: src/device + util/sconfig: Introduce new device 'mdio' ...................................................................... Patch Set 5: (1 comment) File src/include/device/path.h: https://review.coreboot.org/c/coreboot/+/69382/comment/db6dfb07_08dd5fa9 PS5, Line 117: struct mdio_path { : unsigned int addr; : }; > Just wondering: What would happen if you added ': 5' bitfield here? Would that somehow have the comp […] I will give it a try and let you know. -- To view, visit https://review.coreboot.org/c/coreboot/+/69382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6691f92c4233bc30afc9029840b06f74bb1eb4b2 Gerrit-Change-Number: 69382 Gerrit-PatchSet: 5 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 14 Nov 2022 10:10:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: src/device + util/sconfig: Introduce new device 'mdio'
by Arthur Heymans (Code Review) 14 Nov '22

14 Nov '22

Attention is currently required from: Martin L Roth, Subrata Banik, Mario Scheithauer, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69382 ) Change subject: src/device + util/sconfig: Introduce new device 'mdio' ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Patchset: PS5: Looks good to me. File src/include/device/path.h: https://review.coreboot.org/c/coreboot/+/69382/comment/b61bf413_2f4e5a0d PS5, Line 117: struct mdio_path { : unsigned int addr; : }; Just wondering: What would happen if you added ': 5' bitfield here? Would that somehow have the compiler warn you about overflows, if you set a too high value in DT? It's ofc fine like it is now, but it might worth a try. -- To view, visit https://review.coreboot.org/c/coreboot/+/69382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6691f92c4233bc30afc9029840b06f74bb1eb4b2 Gerrit-Change-Number: 69382 Gerrit-PatchSet: 5 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 14 Nov 2022 10:08:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented
by Elyes Haouas (Code Review) 14 Nov '22

14 Nov '22

Attention is currently required from: Caveh Jalali, Arthur Heymans, Boris Mittelberg, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69513 ) Change subject: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: I think that ec/google/wilco/acpi/ec_dev.asl is missing -- To view, visit https://review.coreboot.org/c/coreboot/+/69513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I030bd716215b5ac5738e00ebf6ed991d9d6c5ca0 Gerrit-Change-Number: 69513 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 10:08:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: IASL: Ignore IASL's "Missing dependency" warning
by Elyes Haouas (Code Review) 14 Nov '22

14 Nov '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68936 ) Change subject: IASL: Ignore IASL's "Missing dependency" warning ...................................................................... Abandoned Please see https://review.coreboot.org/c/coreboot/+/69514 -- To view, visit https://review.coreboot.org/c/coreboot/+/68936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17d4f7ad4e3a9cb7d94263080d9d14fe6c9380d9 Gerrit-Change-Number: 68936 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented
by Arthur Heymans (Code Review) 14 Nov '22

14 Nov '22

Attention is currently required from: Caveh Jalali, Arthur Heymans, Boris Mittelberg, Felix Held. Hello build bot (Jenkins), Nico Huber, Caveh Jalali, Boris Mittelberg, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69513 to look at the new patch set (#3). Change subject: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented ...................................................................... {ec/superio}/acpi: Remove _PRS if no _SRS is implemented _PRS only makes sense if _SRS is implemented. Change-Id: I030bd716215b5ac5738e00ebf6ed991d9d6c5ca0 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/ec/google/wilco/acpi/superio.asl M src/ec/quanta/ene_kb3940q/acpi/superio.asl M src/ec/quanta/it8518/acpi/superio.asl M src/superio/ite/it8772f/acpi/superio.asl M src/superio/smsc/sio1007/acpi/superio.asl 5 files changed, 12 insertions(+), 142 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/69513/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I030bd716215b5ac5738e00ebf6ed991d9d6c5ca0 Gerrit-Change-Number: 69513 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/frostflow: Set DPTC Electrical Parameters
by John Su (Code Review) 14 Nov '22

14 Nov '22

Attention is currently required from: Jason Nien, Matt DeVillier, Chris Wang, Martin Roth, Karthik Ramasubramanian. John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69565 ) Change subject: mb/google/skyrim/var/frostflow: Set DPTC Electrical Parameters ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/skyrim/variants/frostflow/overridetree.cb: https://review.coreboot.org/c/coreboot/+/69565/comment/889707c4_3d8661d7 PS1, Line 8: register "slow_ppt_limit_mW" = "15000" > Sorry, I committed an error. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15a69df1436aba05bc19eaffd79394e5ca9bdb3a Gerrit-Change-Number: 69565 Gerrit-PatchSet: 2 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 14 Nov 2022 09:41:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: John Su <john_su(a)compal.corp-partner.google.com> Comment-In-Reply-To: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/frostflow: Set DPTC Electrical Parameters
by John Su (Code Review) 14 Nov '22

14 Nov '22

Attention is currently required from: Jason Nien, Matt DeVillier, Chris Wang, Martin Roth, Karthik Ramasubramanian. John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69565 ) Change subject: mb/google/skyrim/var/frostflow: Set DPTC Electrical Parameters ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/skyrim/variants/frostflow/overridetree.cb: https://review.coreboot.org/c/coreboot/+/69565/comment/f9e93088_fe8ea731 PS1, Line 8: register "slow_ppt_limit_mW" = "15000" > In IRM doc#57136, the sPPT is 25w and fPPT is 30w. it doesn't match IRM for 15w configuration. […] Sorry, I committed an error. And re-upload for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/69565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15a69df1436aba05bc19eaffd79394e5ca9bdb3a Gerrit-Change-Number: 69565 Gerrit-PatchSet: 2 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 14 Nov 2022 09:41:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022