coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: drivers/wifi: Fix DSM parsing issue
by Ronak Kanabar (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Reka Norman, Martin L Roth, Dinesh Sharma, Kangheui Won, Haribalaraman Ramasubramanian, Rizwan Qureshi, Meera Ravindranath, Felix Held. Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69427 ) Change subject: drivers/wifi: Fix DSM parsing issue ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88782b0b7dde1fca0230472a38628e82dfd9c26c Gerrit-Change-Number: 69427 Gerrit-PatchSet: 4 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 04:51:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/testing: Allow jenkins builders to skip testing areas
by build bot (Jenkins) (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Martin L Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69495 ) Change subject: util/testing: Allow jenkins builders to skip testing areas ...................................................................... Patch Set 3: (1 comment) File util/testing/Makefile.inc: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163666): https://review.coreboot.org/c/coreboot/+/69495/comment/515f686e_8ae701b5 PS3, Line 10: @echo ' test-basic - Run stardard build tests. All expected to pass.' 'stardard' may be misspelled - perhaps 'standard'? -- To view, visit https://review.coreboot.org/c/coreboot/+/69495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f8ac68c1bc8f8ff9be62d80db850355e742ee74 Gerrit-Change-Number: 69495 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Tue, 15 Nov 2022 04:42:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/testing: Allow jenkins builders to skip testing areas
by Martin L Roth (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Martin L Roth. Hello build bot (Jenkins), Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69495 to look at the new patch set (#3). Change subject: util/testing: Allow jenkins builders to skip testing areas ...................................................................... util/testing: Allow jenkins builders to skip testing areas With the addition of the clang tests, the jenkins builds are taking a really long time to run the tests. This change allows the "what-jenkins-does" build to be split into separate builds on jenkins. Additionally, some jenkins builds like coverity don't need (or want) to build clang or even the linters. Update help with the variables. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I0f8ac68c1bc8f8ff9be62d80db850355e742ee74 --- M util/testing/Makefile.inc 1 file changed, 43 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/69495/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f8ac68c1bc8f8ff9be62d80db850355e742ee74 Gerrit-Change-Number: 69495 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/alderlake: Check MANUF_LOCK when logging manufacturing mode
by Kangheui Won (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Michał Żygowski, Reka Norman, Paul Menzel, Rizwan Qureshi, Sridhar Siricilla. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69324 ) Change subject: soc/intel/alderlake: Check MANUF_LOCK when logging manufacturing mode ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac605baa291ab5cc5f28464006f4828c12c748fe Gerrit-Change-Number: 69324 Gerrit-PatchSet: 3 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Tue, 15 Nov 2022 04:28:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Check MANUF_LOCK when logging manufacturing mode
by Kapil Porwal (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Jamie Ryu, Subrata Banik, Ravishankar Sarawadi, Sridhar Siricilla. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69578 ) Change subject: soc/intel/meteorlake: Check MANUF_LOCK when logging manufacturing mode ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I495a7d8730716fc92e8c57b2caef73e8bb44d30b Gerrit-Change-Number: 69578 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Tue, 15 Nov 2022 04:22:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Update ME HFSTS register definition
by Martin L Roth (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Rizwan Qureshi, Paul Menzel. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69286 ) Change subject: soc/intel/alderlake: Update ME HFSTS register definition ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69286/comment/2e0a8d19_a3604544 PS2, Line 10: https://cdrdv2.intel.com/v1/dl/getContent/627331 Is this public? If so, please archive it at archive.org. If it's not public, it probably shouldn't be in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/69286 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9aeee7a3b41ad59c03391207930a253ffff19ae5 Gerrit-Change-Number: 69286 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 15 Nov 2022 04:22:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/wifi: Fix DSM parsing issue
by Henry Sun (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Reka Norman, Martin L Roth, Dinesh Sharma, Kangheui Won, Haribalaraman Ramasubramanian, Rizwan Qureshi, Meera Ravindranath, Ronak Kanabar, Felix Held. Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69427 ) Change subject: drivers/wifi: Fix DSM parsing issue ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: Hi Kangheui, Reka, we need your help to merge this CL for craask, it could improve the final FW. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/69427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88782b0b7dde1fca0230472a38628e82dfd9c26c Gerrit-Change-Number: 69427 Gerrit-PatchSet: 4 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 04:19:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google: Fix log messages
by Martin L Roth (Code Review) 15 Nov '22

15 Nov '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69496 ) Change subject: mb/google: Fix log messages ...................................................................... mb/google: Fix log messages Change 'printk(BIOS_DEBUG, "ERROR:' to printk(BIOS_ERR, "'. Change-Id: Id31c25f5b8686f951ab4f331682b82ff327d5e78 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69496 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/auron/variants/buddy/variant.c M src/mainboard/google/beltino/lan.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/jecht/lan.c M src/mainboard/google/rambi/variants/ninja/lan.c M src/mainboard/google/rambi/variants/sumo/lan.c 6 files changed, 28 insertions(+), 24 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/auron/variants/buddy/variant.c b/src/mainboard/google/auron/variants/buddy/variant.c index 397b541..5af2502 100644 --- a/src/mainboard/google/auron/variants/buddy/variant.c +++ b/src/mainboard/google/auron/variants/buddy/variant.c @@ -55,8 +55,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; } @@ -72,8 +71,7 @@ offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); diff --git a/src/mainboard/google/beltino/lan.c b/src/mainboard/google/beltino/lan.c index 1104ea7..baadf15 100644 --- a/src/mainboard/google/beltino/lan.c +++ b/src/mainboard/google/beltino/lan.c @@ -36,8 +36,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; } @@ -53,8 +52,7 @@ offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c index f428e69..67f371c 100644 --- a/src/mainboard/google/butterfly/mainboard.c +++ b/src/mainboard/google/butterfly/mainboard.c @@ -40,7 +40,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, (unsigned char)*offset); retval = 0; } @@ -58,8 +58,7 @@ offset = search(key, (char *)search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); @@ -149,7 +148,7 @@ kbd_type = EC_KBD_JP; } } else { - printk(BIOS_DEBUG, "Error: Could not locate VPD area\n"); + printk(BIOS_ERR, "Could not locate VPD area\n"); } printk(BIOS_DEBUG, "Setting Keyboard type in EC to "); diff --git a/src/mainboard/google/jecht/lan.c b/src/mainboard/google/jecht/lan.c index a431393..1f90aa7 100644 --- a/src/mainboard/google/jecht/lan.c +++ b/src/mainboard/google/jecht/lan.c @@ -36,8 +36,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; } @@ -53,8 +52,7 @@ offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); diff --git a/src/mainboard/google/rambi/variants/ninja/lan.c b/src/mainboard/google/rambi/variants/ninja/lan.c index 0abbffe..8dfdb08 100644 --- a/src/mainboard/google/rambi/variants/ninja/lan.c +++ b/src/mainboard/google/rambi/variants/ninja/lan.c @@ -35,8 +35,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; } @@ -52,8 +51,7 @@ offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); diff --git a/src/mainboard/google/rambi/variants/sumo/lan.c b/src/mainboard/google/rambi/variants/sumo/lan.c index 66083ae..168f8b5 100644 --- a/src/mainboard/google/rambi/variants/sumo/lan.c +++ b/src/mainboard/google/rambi/variants/sumo/lan.c @@ -35,8 +35,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; } @@ -52,8 +51,7 @@ offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); -- To view, visit https://review.coreboot.org/c/coreboot/+/69496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id31c25f5b8686f951ab4f331682b82ff327d5e78 Gerrit-Change-Number: 69496 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/craask: Remove RFIM settings for Craask
by Martin L Roth (Code Review) 15 Nov '22

15 Nov '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69466 ) Change subject: mb/google/nissa/var/craask: Remove RFIM settings for Craask ...................................................................... mb/google/nissa/var/craask: Remove RFIM settings for Craask Request by RF team, remove RFIM related settings to disable it. BUG=b:239657092 Test=RF team test on DUT and check it's disable Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Change-Id: I1eb4d93c2821cb067628dc1228c6c522d292c739 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69466 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Reka Norman <rekanorman(a)chromium.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/craask/overridetree.cb 1 file changed, 19 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Reka Norman: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/craask/overridetree.cb b/src/mainboard/google/brya/variants/craask/overridetree.cb index 57f4306e..cd34d71 100644 --- a/src/mainboard/google/brya/variants/craask/overridetree.cb +++ b/src/mainboard/google/brya/variants/craask/overridetree.cb @@ -190,12 +190,6 @@ probe WFC WFC_MIPI_OVTI5675 probe WFC WFC_MIPI_OVTI8856 end - device ref cnvi_wifi on - chip drivers/wifi/generic - register "enable_cnvi_ddr_rfim" = "true" - device generic 0 on end - end - end device ref i2c1 on chip drivers/i2c/hid register "generic.hid" = ""GTCH7503"" -- To view, visit https://review.coreboot.org/c/coreboot/+/69466 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1eb4d93c2821cb067628dc1228c6c522d292c739 Gerrit-Change-Number: 69466 Gerrit-PatchSet: 5 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cathy Chen <cathy_chen(a)quanta.corp-partner.google.com> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: testing/Makefile.inc: Fix removing clang builds
by Martin L Roth (Code Review) 15 Nov '22

15 Nov '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69568 ) Change subject: testing/Makefile.inc: Fix removing clang builds ...................................................................... testing/Makefile.inc: Fix removing clang builds The directory names were wrong. Change-Id: Ia52ca92f22f02a3b91244093ac6a769e6b3b2eb3 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69568 Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/testing/Makefile.inc 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index ad01ac1..dc135fb 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -97,8 +97,8 @@ cd util/goswid ; go mod vendor util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/chromeos $(ABUILD_OPTIONS) -x -X $(top)/abuild-chromeos.xml util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/default $(ABUILD_OPTIONS) - util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/chromeos_clang $(ABUILD_OPTIONS) -x -X $(top)/abuild-chromeos_clang.xml -L - util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/default_clang $(ABUILD_OPTIONS) -L + util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/chromeos-clang $(ABUILD_OPTIONS) -x -X $(top)/abuild-chromeos_clang.xml -L + util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/default-clang $(ABUILD_OPTIONS) -L $(foreach tool, $(TOOLLIST), $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR="util/$(tool)" BLD="$(tool)" MFLAGS= MAKEFLAGS= MAKETARGET= junit.xml; ) unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/nvramcui BLD=nvramcui MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/coreinfo BLD=coreinfo MFLAGS= MAKEFLAGS= MAKETARGET=defaultbuild junit.xml -- To view, visit https://review.coreboot.org/c/coreboot/+/69568 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia52ca92f22f02a3b91244093ac6a769e6b3b2eb3 Gerrit-Change-Number: 69568 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022