coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: mb/google/rex: Add `disable_gpio_export_in_crs` for rex
by Ivy Jian (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69612 ) Change subject: mb/google/rex: Add `disable_gpio_export_in_crs` for rex ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @Ivy, can you please check if Touch Screen is functional with this CL. […] @Subrata, TouchScreen is functional after applied this patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/69612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I578a60eff27f94d6dc94b900604bc7560337d60b Gerrit-Change-Number: 69612 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 04:04:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: security/tpm: add TPM log format as per 2.0 spec
by Julius Werner (Code Review) 15 Nov '22

15 Nov '22

1 0

[L] Change in coreboot[master]: security/tpm: add TPM log format as per 1.2 spec
by Julius Werner (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Krystian Hebel, Sergii Dmytruk. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68747 ) Change subject: security/tpm: add TPM log format as per 1.2 spec ...................................................................... Patch Set 5: (7 comments) File src/commonlib/include/commonlib/tpm_log_defs.h: https://review.coreboot.org/c/coreboot/+/68747/comment/cf0905e8_71058367 PS5, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ Note that licensing this as GPLv2 would make it hard to share with libpayload in the future. So if you think having a payload display the log table or add further entries from files it loaded could become useful in the future, I'd maybe consider moving this to commonlib/bsd (and licensing as BSD). (Of course this is assuming you have the rights to all of this code, if you copied it from another GPL source then you cannot do that.) File src/security/tpm/Kconfig: https://review.coreboot.org/c/coreboot/+/68747/comment/734f2d0a_8cf33b3e PS5, Line 107: TPM_LOG_TPM12 We generally use "TPM1", not "TPM12" in the code, so I would suggest calling this TPM_LOG_TPM1 as well (and the same in all other identifiers). https://review.coreboot.org/c/coreboot/+/68747/comment/64d39a2f_b66101a4 PS5, Line 108: bool "TPM 1.2 format" Can this log format be used with 2.0 TPMs? Otherwise, this should probably have a `depends on TPM1`. File src/security/tpm/tspi.h: https://review.coreboot.org/c/coreboot/+/68747/comment/4c36d568_1148f85d PS5, Line 11: #include "tpm12_log_serialized.h" Please use angled brackets notation (i.e. <security/tpm/tpm1_log_serialized.h>) and alphabetize with the other headers above (well, I guess they aren't alphabetized in the first place in this case, but... idk just group with the other security/tpm #include). File src/security/tpm/tspi/log-tpm12.c: https://review.coreboot.org/c/coreboot/+/68747/comment/b47ebaea_b76607aa PS5, Line 115: strncpy((char *)tce->data, name, sizeof(tce->data) - 1); This needs to guarantee that tce->data gets null-terminated (your other functions rely on that), so you should have an explicit `tce->data[sizeof(tce->data) - 1] = '\0'` here. (In fact, it looks like the old coreboot format doesn't do that correctly either, would be good to fix that.) https://review.coreboot.org/c/coreboot/+/68747/comment/7720e959_d29b220e PS5, Line 123: tclt->spec_id.num_entries = 0; So this means that the pre-RAM version of the log table will never be fully initialized (e.g. fields like spec_version_xxx will not be filled out). I guess that's fine since it will be migrated to CBMEM eventually anyway, but it is a bit weird. Maybe explain that in a comment somewhere (if it is intentional)? https://review.coreboot.org/c/coreboot/+/68747/comment/553a2a2e_d0c940b5 PS5, Line 161: struct tpm_12_log_entry *tce = &to_log->entries[to_log->spec_id.num_entries++]; Why not just memcpy() the whole entry? -- To view, visit https://review.coreboot.org/c/coreboot/+/68747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89720615a75573d44dd0a39ad3d7faa78f125843 Gerrit-Change-Number: 68747 Gerrit-PatchSet: 5 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 04:02:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm: make tspi/crtm.c agnostic to log format
by Julius Werner (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Christian Walter, Sergii Dmytruk. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69445 ) Change subject: security/tpm: make tspi/crtm.c agnostic to log format ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/security/tpm/tspi/log.c: https://review.coreboot.org/c/coreboot/+/69445/comment/41e235e6_c0375498 PS1, Line 126: break; What if the algorithm is not found? -- To view, visit https://review.coreboot.org/c/coreboot/+/69445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3013bd5f29f1412fbe646dc74d8946704b750a66 Gerrit-Change-Number: 69445 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 04:02:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm: make log format configurable via Kconfig
by Julius Werner (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Michał Żygowski, Maciej Pijanowski, Jason Nien, Subrata Banik, Christian Walter, Kapil Porwal, Tim Wawrzynczak, Nick Vaccaro, Krystian Hebel, Martin Roth, Sergii Dmytruk. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68746 ) Change subject: security/tpm: make log format configurable via Kconfig ...................................................................... Patch Set 6: (1 comment) File src/security/tpm/tspi.h: https://review.coreboot.org/c/coreboot/+/68746/comment/ec118b55_56e62fb3 PS6, Line 10: #include <commonlib/tcpa_log_serialized.h> Why is this moving around? -- To view, visit https://review.coreboot.org/c/coreboot/+/68746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3903aff54e01093bc9ea75862bbf5989cc6e6c55 Gerrit-Change-Number: 68746 Gerrit-PatchSet: 6 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 04:01:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: treewide: stop calling custom TPM log "TCPA"
by Julius Werner (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Xi Chen, Hung-Te Lin, Christian Walter, Sergii Dmytruk. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69444 ) Change subject: treewide: stop calling custom TPM log "TCPA" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I896bd94f18b34d6c4b280f58b011d704df3d4022 Gerrit-Change-Number: 69444 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 04:00:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm: make log format configurable via Kconfig
by Julius Werner (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Michał Żygowski, Maciej Pijanowski, Jason Nien, Subrata Banik, Christian Walter, Kapil Porwal, Tim Wawrzynczak, Nick Vaccaro, Krystian Hebel, Martin Roth, Sergii Dmytruk. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68746 ) Change subject: security/tpm: make log format configurable via Kconfig ...................................................................... Patch Set 6: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68746/comment/787bd9f9_475039f4 PS5, Line 15: format as they are likely to depend on it. > Thanks for the clarification. Keeping the old log format available for now. Ack File src/security/tpm/tspi/crtm.h: https://review.coreboot.org/c/coreboot/+/68746/comment/8232816b_323259a9 PS6, Line 26: # if CONFIG(NO_TPM) || !CONFIG(TPM_MEASURED_BOOT) NO_TPM should imply !TPM_MEASURED_BOOT, right? -- To view, visit https://review.coreboot.org/c/coreboot/+/68746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3903aff54e01093bc9ea75862bbf5989cc6e6c55 Gerrit-Change-Number: 68746 Gerrit-PatchSet: 6 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 04:00:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/arm/armv7: Don't set gcc specific options for clang builds
by Martin L Roth (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Julius Werner. Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69672 ) Change subject: arch/arm/armv7: Don't set gcc specific options for clang builds ...................................................................... arch/arm/armv7: Don't set gcc specific options for clang builds Clang doesn't understand the -Wa,-mno-warn-deprecated option. Remove it for now. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I9f91d6ec2db247e901ba9bc41bc4b888bbe43236 --- M src/arch/arm/armv7/Makefile.inc 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/69672/1 diff --git a/src/arch/arm/armv7/Makefile.inc b/src/arch/arm/armv7/Makefile.inc index 66ddc98..5675a26 100644 --- a/src/arch/arm/armv7/Makefile.inc +++ b/src/arch/arm/armv7/Makefile.inc @@ -5,7 +5,10 @@ armv7-m_flags = -march=armv7-m $(armv7_flags) -D__COREBOOT_ARM_V7_M__ armv7-r_flags = -march=armv7-r $(armv7_flags) -D__COREBOOT_ARM_V7_R__ -armv7_asm_flags = -Wa,-mthumb -Wa,-mimplicit-it=always -Wa,-mno-warn-deprecated +armv7_asm_flags = -Wa,-mthumb -Wa,-mimplicit-it=always +ifeq ($(CONFIG_COMPILER_GCC),y) +armv7_asm_flags += -Wa,-mno-warn-deprecated +endif armv7-r_asm_flags = $(armv7-r_flags) $(armv7_asm_flags) ############################################################################### -- To view, visit https://review.coreboot.org/c/coreboot/+/69672 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f91d6ec2db247e901ba9bc41bc4b888bbe43236 Gerrit-Change-Number: 69672 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/amd/common: Don't set gcc specific options for clang builds
by Martin L Roth (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Matt DeVillier, Paul Fagerburg, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69662 to look at the new patch set (#2). Change subject: soc/amd/common: Don't set gcc specific options for clang builds ...................................................................... soc/amd/common: Don't set gcc specific options for clang builds Clang doesn't understand the -Wstack-usage=40960 option. Replace it with -Wframe-larger-than=40960. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I7d8b9c26d3fc861615a8553332ed1070974b751b --- M src/soc/amd/common/psp_verstage/Makefile.inc 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/69662/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d8b9c26d3fc861615a8553332ed1070974b751b Gerrit-Change-Number: 69662 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: [Code Migration] Boot time cache information prints
by Kapil Porwal (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69615 ) Change subject: [Code Migration] Boot time cache information prints ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/69615/comment/a260d75e_0cc2ca5b PS1, Line 7: [Code Migration] Boot time cache information prints Use the commit message from the original CL (replace Alderlake with Meteorlake). Also add reference to the original CL here. Patchset: PS1: Use `backporting_from_adl` as a topic/hashtag. -- To view, visit https://review.coreboot.org/c/coreboot/+/69615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7039a44f5f6ca0f9771bcc701f6cd21ca70ee9f Gerrit-Change-Number: 69615 Gerrit-PatchSet: 1 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 03:49:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022