coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: src/lib: Clean up includes
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68208 ) Change subject: src/lib: Clean up includes ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/68208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I729959f6ba4b48f58d4e4e3a1fb1e4c33cb57dbb Gerrit-Change-Number: 68208 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: src/acpi: Clean up includes
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68199 ) Change subject: src/acpi: Clean up includes ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/68199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0ba40a671dfb804231419450036c15f480f1749 Gerrit-Change-Number: 68199 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: include/spd.h: Fix comment module type information
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69271 to look at the new patch set (#2). Change subject: include/spd.h: Fix comment module type information ...................................................................... include/spd.h: Fix comment module type information Change-Id: I7af61404d11f7e0ff5f30c42958c4dd9318538fa Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/include/spd.h 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/69271/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7af61404d11f7e0ff5f30c42958c4dd9318538fa Gerrit-Change-Number: 69271 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: Makefile.inc: Reorganize CFLAGS_common
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/67755 ) Change subject: Makefile.inc: Reorganize CFLAGS_common ...................................................................... Abandoned unnecessary -- To view, visit https://review.coreboot.org/c/coreboot/+/67755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iefbcbb65766c555ecd56f1d5655a4cba5d4a2faf Gerrit-Change-Number: 67755 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: drivers/intel/fsp1_1/raminit.c: Use PRIxPTR macro
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Lee Leahy, Paul Menzel, Angel Pons, Huang Jin, Patrick Rudolph. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61333 ) Change subject: drivers/intel/fsp1_1/raminit.c: Use PRIxPTR macro ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/61333/comment/132889ce_e945358d PS3, Line 8: > What warning/error is shown by the compiler? 'smm_base' is a uintptr_t, it needs the PRIxPTR format. File src/drivers/intel/fsp1_1/raminit.c: https://review.coreboot.org/c/coreboot/+/61333/comment/111290a8_11abdd95 PS3, Line 139: %" PRIxPTR " > Maybe %zx ? Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/61333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06cb882d55299568844cfc9bd04e288d453cd61c Gerrit-Change-Number: 61333 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Huang Jin Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Huang Jin Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 20 Nov 2022 06:56:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream master
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/69699 ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Abandoned let Wait for "T996" -- To view, visit https://review.coreboot.org/c/coreboot/+/69699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I795607cda36588ef26f955b1d1e832a4ae2de749 Gerrit-Change-Number: 69699 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: crossgcc: Upgrade IASL from 20220331 to 20221020
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Martin L Roth, Paul Menzel, Arthur Heymans, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68929 ) Change subject: crossgcc: Upgrade IASL from 20220331 to 20221020 ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: There is a regression in version 20220331. So we probably need to use 20211217 (see https://review.coreboot.org/c/coreboot/+/64103 ) or upgrade to 20221020 (current patch) Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/68929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I386a6757a318336bc616091afe0c4ed88cd89583 Gerrit-Change-Number: 68929 Gerrit-PatchSet: 11 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 20 Nov 2022 06:31:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: include/memlayout.h: update comment about VBOOT2 work buffer size
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Martin Roth, Karthik Ramasubramanian, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69797 ) Change subject: include/memlayout.h: update comment about VBOOT2 work buffer size ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7c9a5476ae06d4bac762da1729aff878b7d0965 Gerrit-Change-Number: 69797 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 20 Nov 2022 06:02:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/cavium/common: Don't use "Wstack-usage" for llvm
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Paul Menzel. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69833 ) Change subject: soc/cavium/common: Don't use "Wstack-usage" for llvm ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: Thx File src/soc/cavium/common/Makefile.inc: https://review.coreboot.org/c/coreboot/+/69833/comment/3c5789b1_c1524e07 PS1, Line 11: -Wframe-larger-than > Please mention the name in the commit message. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/69833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I285dc2287fdb1c20a526b1ccd3da1e20242ba9fe Gerrit-Change-Number: 69833 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 20 Nov 2022 05:58:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/cavium/common: Don't use "Wstack-usage" for llvm
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69833 to look at the new patch set (#2). Change subject: soc/cavium/common: Don't use "Wstack-usage" for llvm ...................................................................... soc/cavium/common: Don't use "Wstack-usage" for llvm Use "Wframe-larger-than" instead of "Wstack-usage" for llvm. Change-Id: I285dc2287fdb1c20a526b1ccd3da1e20242ba9fe Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/cavium/common/Makefile.inc 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/69833/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I285dc2287fdb1c20a526b1ccd3da1e20242ba9fe Gerrit-Change-Number: 69833 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022