Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69837 )
Change subject: util/testing: Update ABUILD_OPTIONS with long option names
......................................................................
util/testing: Update ABUILD_OPTIONS with long option names
It's hard to tell what is what with the short option names, so use the
long options here.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I1371e098bba1077dedfaffa56287a28656197b40
---
M util/testing/Makefile.inc
1 file changed, 16 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/69837/1
diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc
index ab0dff6..5952393 100644
--- a/util/testing/Makefile.inc
+++ b/util/testing/Makefile.inc
@@ -74,9 +74,9 @@
lint lint-stable lint-extended:
util/lint/lint $@
-ABUILD_OPTIONS=-B -J -c $(CPUS) -Z -p $(JENKINS_PAYLOAD)
-ABUILD_OPTIONS+=$(if $(V),-v,)
-ABUILD_OPTIONS+=$(if $(JENKINS_NOCCACHE),,-y)
+ABUILD_OPTIONS=--blobs --junit --cpus $(CPUS) --clean-somewhat --payloads $(JENKINS_PAYLOAD)
+ABUILD_OPTIONS+=$(if $(V),--verbose,)
+ABUILD_OPTIONS+=$(if $(JENKINS_NOCCACHE),,--ccache)
ABUILD_OPTIONS+=$(JENKINS_ABUILD_OPT)
COREBOOT_BUILD_DIR?=coreboot-builds
--
To view, visit https://review.coreboot.org/c/coreboot/+/69837
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1371e098bba1077dedfaffa56287a28656197b40
Gerrit-Change-Number: 69837
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69835 )
Change subject: util/testing: Call test-lint target from what-jenkins-does
......................................................................
util/testing: Call test-lint target from what-jenkins-does
Instead of having duplicate lines in the what-jenkins-does target and
the test-lint target, make test-lint with the --junit argument from
what-jenkins-does.
Now there's only one place to update when changing the the call.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I2f90df76126f453fbcd91f4c4af5d784ac2dbe88
---
M util/testing/Makefile.inc
1 file changed, 20 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/69835/1
diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc
index dfb66be..652adc4 100644
--- a/util/testing/Makefile.inc
+++ b/util/testing/Makefile.inc
@@ -88,10 +88,9 @@
exit 1; \
fi
-ifneq ($(JENKINS_SKIP_UNIT_TESTS),y)
- util/lint/lint lint-stable --junit
- util/lint/lint lint-extended --junit
what-jenkins-does: test-cleanup validate_sec_tools
+ifneq ($(JENKINS_SKIP_LINT_TESTS),y)
+ JUNIT=--junit $(MAKE) test-lint
endif
cd 3rdparty/intel-sec-tools/ ; go mod vendor
cd util/goswid ; go mod vendor
@@ -116,8 +115,8 @@
test-basic: test-lint test-tools test-abuild test-payloads test-cleanup
test-lint:
- util/lint/lint lint-stable
- util/lint/lint lint-extended
+ util/lint/lint lint-stable $(JUNIT)
+ util/lint/lint lint-extended $(JUNIT)
test-abuild:
util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/chromeos -B -e $(if $(TEST_NOCCACHE),,-y) -c $(CPUS) -p $(TEST_PAYLOAD) -x
--
To view, visit https://review.coreboot.org/c/coreboot/+/69835
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f90df76126f453fbcd91f4c4af5d784ac2dbe88
Gerrit-Change-Number: 69835
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer, Nico Huber, Angel Pons.
Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, Elyes Haouas,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69495
to look at the new patch set (#4).
Change subject: util/testing: Allow jenkins builders to skip testing areas
......................................................................
util/testing: Allow jenkins builders to skip testing areas
With the addition of the clang tests, the jenkins builds are taking a
really long time to run the tests. This change allows the
"what-jenkins-does" build to be split into separate builds on jenkins.
Additionally, some jenkins builds like coverity don't need (or want)
to build clang or even the linters.
Update help with the variables.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I0f8ac68c1bc8f8ff9be62d80db850355e742ee74
---
M util/testing/Makefile.inc
1 file changed, 37 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/69495/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/69495
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f8ac68c1bc8f8ff9be62d80db850355e742ee74
Gerrit-Change-Number: 69495
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Martin L Roth, Patrick Georgi.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69841 )
Change subject: util/crossgcc: Limit LLVM targets to the needed ones
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69841
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9938bf176b5fe2b0a631c3b1ae858f988898a196
Gerrit-Change-Number: 69841
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Comment-Date: Sun, 20 Nov 2022 16:47:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Paul Menzel, Arthur Heymans, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69700 )
Change subject: crossgcc: Upgrade LLVM from 15.0.0 to 15.0.5
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
Please use the topic `coreboot-toolchain` for related patches
--
To view, visit https://review.coreboot.org/c/coreboot/+/69700
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e6c23c6552eded92e706bc21bb162a66767572e
Gerrit-Change-Number: 69700
Gerrit-PatchSet: 9
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sun, 20 Nov 2022 15:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Paul Menzel, Arthur Heymans.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69700 )
Change subject: crossgcc: Upgrade LLVM from 15.0.0 to 15.0.5
......................................................................
Patch Set 9:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69700/comment/e79eb8c1_c1361bf9
PS7, Line 8:
> Did you make a test build of emulation/qemu-i440fx or another board, and compare the generated code?
Ack
Patchset:
PS9:
Thx
--
To view, visit https://review.coreboot.org/c/coreboot/+/69700
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e6c23c6552eded92e706bc21bb162a66767572e
Gerrit-Change-Number: 69700
Gerrit-PatchSet: 9
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 20 Nov 2022 15:35:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Arthur Heymans, Elyes Haouas.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69700
to look at the new patch set (#9).
Change subject: crossgcc: Upgrade LLVM from 15.0.0 to 15.0.5
......................................................................
crossgcc: Upgrade LLVM from 15.0.0 to 15.0.5
Tested with BUILD_TIMELESS=1: binaries stay the same for qemu-i440fx.
Change-Id: I9e6c23c6552eded92e706bc21bb162a66767572e
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/clang-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/clang-15.0.5.src.tar.xz.cksum
D util/crossgcc/sum/clang-tools-extra-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/clang-tools-extra-15.0.5.src.tar.xz.cksum
D util/crossgcc/sum/cmake-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/cmake-15.0.5.src.tar.xz.cksum
D util/crossgcc/sum/compiler-rt-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/compiler-rt-15.0.5.src.tar.xz.cksum
D util/crossgcc/sum/llvm-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/llvm-15.0.5.src.tar.xz.cksum
11 files changed, 18 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/69700/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/69700
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e6c23c6552eded92e706bc21bb162a66767572e
Gerrit-Change-Number: 69700
Gerrit-PatchSet: 9
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Arthur Heymans, Elyes Haouas.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69700
to look at the new patch set (#8).
Change subject: crossgcc: Upgrade LLVM from 15.0.0 to 15.0.5
......................................................................
crossgcc: Upgrade LLVM from 15.0.0 to 15.0.5
Tested with BUILD_TIMELESS=1: binaries stay the same for qemu-i440fx
Change-Id: I9e6c23c6552eded92e706bc21bb162a66767572e
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/clang-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/clang-15.0.5.src.tar.xz.cksum
D util/crossgcc/sum/clang-tools-extra-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/clang-tools-extra-15.0.5.src.tar.xz.cksum
D util/crossgcc/sum/cmake-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/cmake-15.0.5.src.tar.xz.cksum
D util/crossgcc/sum/compiler-rt-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/compiler-rt-15.0.5.src.tar.xz.cksum
D util/crossgcc/sum/llvm-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/llvm-15.0.5.src.tar.xz.cksum
11 files changed, 17 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/69700/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/69700
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e6c23c6552eded92e706bc21bb162a66767572e
Gerrit-Change-Number: 69700
Gerrit-PatchSet: 8
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset