coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: util/kconfig: Re-add KCONFIG_SPLITCONFIG functionality
by Martin L Roth (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Nico Huber, Kyösti Mälkki, Nicholas Chin. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69450 ) Change subject: util/kconfig: Re-add KCONFIG_SPLITCONFIG functionality ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hey, I'm sorry, I didn't see this and pushed my own patch - it's pretty much identical to yours. CB:69535 Even then, I would have merged your over my patch, but I'd split mine into 2 patches, and the first half was merged before I was aware of yours. Thanks for doing this though. It was very annoying. Martin -- To view, visit https://review.coreboot.org/c/coreboot/+/69450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4dd36edb0c36d7679896fde6f84e8471589d83a1 Gerrit-Change-Number: 69450 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 20 Nov 2022 17:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/kconfig: Add patch to move Kconfig deps to build/config
by Martin L Roth (Code Review) 20 Nov '22

20 Nov '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69535 ) Change subject: util/kconfig: Add patch to move Kconfig deps to build/config ...................................................................... util/kconfig: Add patch to move Kconfig deps to build/config The change being reverted [1] caused all the Kconfig dependency files to be generated at the top level of coreboot's build directory. This reverts that behavior and puts the dependencies back where we're used to them being. [1] https://web.archive.org/web/20220316120807/https://github.com/torvalds/linu… Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ic4b48831705c3206e7c2e09f01d072d1cde9c9c4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69535 Reviewed-by: Fred Reitberger <reitbergerfred(a)gmail.com> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- A util/kconfig/patches/0014-util-kconfig-Move-Kconfig-deps-back-into-build-confi.patch M util/kconfig/patches/series 2 files changed, 87 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved Fred Reitberger: Looks good to me, approved diff --git a/util/kconfig/patches/0014-util-kconfig-Move-Kconfig-deps-back-into-build-confi.patch b/util/kconfig/patches/0014-util-kconfig-Move-Kconfig-deps-back-into-build-confi.patch new file mode 100644 index 0000000..fb85035 --- /dev/null +++ b/util/kconfig/patches/0014-util-kconfig-Move-Kconfig-deps-back-into-build-confi.patch @@ -0,0 +1,64 @@ +From 2a44aa33d6506a29b14d9c429410ad582d1d6636 Mon Sep 17 00:00:00 2001 +From: Martin Roth <gaumless(a)gmail.com> +Date: Sun, 13 Nov 2022 15:20:57 -0700 +Subject: [PATCH] util/kconfig: Move Kconfig deps back into build/config + +revert commit 1b9e740a8 (kconfig: fix failing to generate auto.conf) [1] + +The above change caused all of the enabled kconfig options to be written +into the top level build directory. We don't want that, so go back to +the old behavior for the coreboot tree. + +[1] https://web.archive.org/web/20220316120807/https://github.com/torvalds/linu… + +Signed-off-by: Martin Roth <gaumless(a)gmail.com> +Change-Id: I2904f69a5d85337ad0a6b48590ccd4b4a6e38b70 +--- + util/kconfig/confdata.c | 20 +++++++++++--------- + 1 file changed, 11 insertions(+), 9 deletions(-) + +diff --git a/util/kconfig/confdata.c b/util/kconfig/confdata.c +index 95fb960179..3da9e8b38d 100644 +--- a/util/kconfig/confdata.c ++++ b/util/kconfig/confdata.c +@@ -230,6 +230,13 @@ static const char *conf_get_autoheader_name(void) + return name ? name : "include/generated/autoconf.h"; + } + ++static const char *conf_get_autobase_name(void) ++{ ++ char *name = getenv("KCONFIG_SPLITCONFIG"); ++ ++ return name ? name : "include/config/"; ++} ++ + static int conf_set_sym_val(struct symbol *sym, int def, int def_flags, char *p) + { + char *p2; +@@ -1024,19 +1031,14 @@ static int conf_write_autoconf_cmd(const char *autoconf_name) + + static int conf_touch_deps(void) + { +- const char *name, *tmp; ++ const char *name; + struct symbol *sym; + int res, i; + +- name = conf_get_autoconfig_name(); +- tmp = strrchr(name, '/'); +- depfile_prefix_len = tmp ? tmp - name + 1 : 0; +- if (depfile_prefix_len + 1 > sizeof(depfile_path)) +- return -1; +- +- strncpy(depfile_path, name, depfile_prefix_len); +- depfile_path[depfile_prefix_len] = 0; ++ strcpy(depfile_path, conf_get_autobase_name()); ++ depfile_prefix_len = strlen(depfile_path); + ++ name = conf_get_autoconfig_name(); + conf_read_simple(name, S_DEF_AUTO); + sym_calc_value(modules_sym); + +-- +2.30.2 + diff --git a/util/kconfig/patches/series b/util/kconfig/patches/series index 13b684b..655c493 100644 --- a/util/kconfig/patches/series +++ b/util/kconfig/patches/series @@ -9,3 +9,4 @@ 0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch 0010-reenable-source-in-choice.patch 0013-util-kconfig-detect-ncurses-on-FreeBSD.patch +0014-util-kconfig-Move-Kconfig-deps-back-into-build-confi.patch -- To view, visit https://review.coreboot.org/c/coreboot/+/69535 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4b48831705c3206e7c2e09f01d072d1cde9c9c4 Gerrit-Change-Number: 69535 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: util/kconfig: Add patch to move Kconfig deps to build/config
by Martin L Roth (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Nico Huber. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69535 ) Change subject: util/kconfig: Add patch to move Kconfig deps to build/config ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Duplicate of CB:69450? Looks like it is. Obviously I didn't see his when I did mine or I would have just merged his. :( Now, because my first patch is already merged, I can't just merge his, so I'm going to go ahead and merge this one. -- To view, visit https://review.coreboot.org/c/coreboot/+/69535 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4b48831705c3206e7c2e09f01d072d1cde9c9c4 Gerrit-Change-Number: 69535 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 20 Nov 2022 17:29:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/abuild: Add --name option to set name of abuild run
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69859 ) Change subject: util/abuild: Add --name option to set name of abuild run ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f52779b92d213386a3eb371d1f30ee32ed48b85 Gerrit-Change-Number: 69859 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 20 Nov 2022 17:23:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/testing: Update ABUILD_OPTIONS with long option names
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69837 ) Change subject: util/testing: Update ABUILD_OPTIONS with long option names ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1371e098bba1077dedfaffa56287a28656197b40 Gerrit-Change-Number: 69837 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 20 Nov 2022 17:22:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/abuild: check for PASSED_BOARDS before trying to show it
by Elyes Haouas (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Martin L Roth, Angel Pons. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69520 ) Change subject: util/abuild: check for PASSED_BOARDS before trying to show it ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69520 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I097d3c728ca1acc652d5a1b7b49e57d01b0e513b Gerrit-Change-Number: 69520 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 20 Nov 2022 17:19:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: RFC: Unify PSP section of cezanne & picasso makefiles
by Martin L Roth (Code Review) 20 Nov '22

20 Nov '22

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/59337 ) Change subject: RFC: Unify PSP section of cezanne & picasso makefiles ...................................................................... Abandoned lack of interest -- To view, visit https://review.coreboot.org/c/coreboot/+/59337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00a8a3d34afeeee08fdcec52c7fa35c885ffc7a6 Gerrit-Change-Number: 59337 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Bao Zheng <zheng.bao(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XL] Change in coreboot[master]: RFC: Kconfig: Show current test run from board-status
by Martin L Roth (Code Review) 20 Nov '22

20 Nov '22

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/63764 ) Change subject: RFC: Kconfig: Show current test run from board-status ...................................................................... Abandoned lack of interest -- To view, visit https://review.coreboot.org/c/coreboot/+/63764 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I248e2d4ba59cc63f9b21c27ab32432b24216d3ca Gerrit-Change-Number: 63764 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: RFC: Kconfig - show boards supported on 4.11 branch (POC)
by Martin L Roth (Code Review) 20 Nov '22

20 Nov '22

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/63754 ) Change subject: RFC: Kconfig - show boards supported on 4.11 branch (POC) ...................................................................... Abandoned lack of interest -- To view, visit https://review.coreboot.org/c/coreboot/+/63754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fe1c508e97b52a6b70b33107c6e17cc7d7faeb2 Gerrit-Change-Number: 63754 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[4.16_branch]: util/crossgcc: Update tools to point to the coreboot archive
by Martin L Roth (Code Review) 20 Nov '22

20 Nov '22

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/64874 ) Change subject: util/crossgcc: Update tools to point to the coreboot archive ...................................................................... Abandoned didn't work. May get back to this at some point -- To view, visit https://review.coreboot.org/c/coreboot/+/64874 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.16_branch Gerrit-Change-Id: I920370a43f820203b5a2d21aa70d62bd53186926 Gerrit-Change-Number: 64874 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022