coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: drivers/net/phy/m88e1512: Add new driver for Marvell PHY 88E1512
by Werner Zeh (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Mario Scheithauer, Arthur Heymans. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69384 ) Change subject: drivers/net/phy/m88e1512: Add new driver for Marvell PHY 88E1512 ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24011860caa7bb206770f9779eb34b689293db10 Gerrit-Change-Number: 69384 Gerrit-PatchSet: 11 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 21 Nov 2022 07:12:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/ehl: Add MDIO operation to TSN GbE device
by Werner Zeh (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Mario Scheithauer, Angel Pons, Arthur Heymans, Lean Sheng Tan. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69383 ) Change subject: soc/intel/ehl: Add MDIO operation to TSN GbE device ...................................................................... Patch Set 10: Code-Review+1 (4 comments) File src/soc/intel/elkhartlake/tsn_gbe.c: https://review.coreboot.org/c/coreboot/+/69383/comment/5e27aa9a_6abc6ff1 PS10, Line 42: printk(BIOS_ALERT, "MDIO bus operations not available for %s.\n", : dev_path(dev)); There is a message on ERROR level already in dev_get_mdio_ops() (see https://review.coreboot.org/c/coreboot/+/69382/6/src/device/mdio.c) for this case. Does it make sense to print yet another one with a different log level? https://review.coreboot.org/c/coreboot/+/69383/comment/ea90f55c_18c35624 PS10, Line 94: Add a mdelay(1); here so that this time can be used elsewhere if needed? See src/lib/thread.c for the thread_yield-functions. https://review.coreboot.org/c/coreboot/+/69383/comment/eda6eeb5_2605ad2f PS10, Line 128: static void tsn_mdio_write(struct device *dev, uint8_t phy_adr, uint8_t reg_adr, : uint16_t data) Looks like this could fit on one line (95 chars). https://review.coreboot.org/c/coreboot/+/69383/comment/2b6f5069_a63ebae1 PS10, Line 143: do next exit -- To view, visit https://review.coreboot.org/c/coreboot/+/69383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d1b9dd2f2ba8c18291fff314c13f0c3851784aa Gerrit-Change-Number: 69383 Gerrit-PatchSet: 10 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 07:10:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: src/device + util/sconfig: Introduce new device 'mdio'
by Werner Zeh (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Martin L Roth, Subrata Banik, Mario Scheithauer, Angel Pons, Arthur Heymans. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69382 ) Change subject: src/device + util/sconfig: Introduce new device 'mdio' ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Patchset: PS6: I'll +1 this patch since I am a co-author. Someone else needs to +2 it. -- To view, visit https://review.coreboot.org/c/coreboot/+/69382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6691f92c4233bc30afc9029840b06f74bb1eb4b2 Gerrit-Change-Number: 69382 Gerrit-PatchSet: 6 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 21 Nov 2022 06:49:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common: Define post codes
by Subrata Banik (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Martin L Roth. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69865 ) Change subject: soc/intel/common: Define post codes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82a34960ae73fc263359e4519234ee78e7e3daab Gerrit-Change-Number: 69865 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 06:46:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common: Define post codes
by Eric Lai (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Martin L Roth. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69865 ) Change subject: soc/intel/common: Define post codes ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/common/block/include/intelblocks/post_codes.h: https://review.coreboot.org/c/coreboot/+/69865/comment/30cdd5ae_b01406bf PS1, Line 17: A 0x2a? -- To view, visit https://review.coreboot.org/c/coreboot/+/69865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82a34960ae73fc263359e4519234ee78e7e3daab Gerrit-Change-Number: 69865 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 06:44:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/intel/car: Define post codes
by Eric Lai (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Martin L Roth, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69866 ) Change subject: cpu/intel/car: Define post codes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @Subrata, could you add some Intel folks here. -- To view, visit https://review.coreboot.org/c/coreboot/+/69866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If13e40b700a41d56bca85510d68da0ab31a235a9 Gerrit-Change-Number: 69866 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 06:42:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ACPI: Flag boards with ACPI_NO_MADT
by Eric Lai (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Kyösti Mälkki. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69777 ) Change subject: ACPI: Flag boards with ACPI_NO_MADT ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69777 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie61e4e4b03c9b7fcd70aba7a2bd71eadd6f4dab1 Gerrit-Change-Number: 69777 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 06:41:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common: Define post codes
by Subrata Banik (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Martin L Roth. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69865 ) Change subject: soc/intel/common: Define post codes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82a34960ae73fc263359e4519234ee78e7e3daab Gerrit-Change-Number: 69865 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 06:35:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/nivviks,yaviks: Remove ISH firmware-name
by Eric Lai (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69868 ) Change subject: mb/google/nissa/var/nivviks,yaviks: Remove ISH firmware-name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68f963e17bc0dbf9db9adaaa3f96f06b8737523b Gerrit-Change-Number: 69868 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Mon, 21 Nov 2022 06:33:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common: Define post codes
by Eric Lai (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Martin L Roth, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69865 ) Change subject: soc/intel/common: Define post codes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82a34960ae73fc263359e4519234ee78e7e3daab Gerrit-Change-Number: 69865 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 06:31:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022