coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: UPSTREAM: mb/google/dedede/variants/sasukette: Disable PCIE RP8 and C...
by Rui Zhou (Code Review) 21 Nov '22

21 Nov '22

Rui Zhou has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/69845 ) Change subject: UPSTREAM: mb/google/dedede/variants/sasukette: Disable PCIE RP8 and CLKSRC4 ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/69845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1eb22c8c767006d0c2f8601c94705af9f4a61370 Gerrit-Change-Number: 69845 Gerrit-PatchSet: 1 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: UPSTREAM: mb/google/dedede/variants/sasukette: Disable PCIE RP8 and C...
by Kevin Chiu (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Rui Zhou. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69845 ) Change subject: UPSTREAM: mb/google/dedede/variants/sasukette: Disable PCIE RP8 and CLKSRC4 ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69845/comment/60848bf5_34c9af9c PS1, Line 7: UPSTREAM: mb/google/dedede/variants/sasukette mb/google/dedede/var/sasukette -- To view, visit https://review.coreboot.org/c/coreboot/+/69845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1eb22c8c767006d0c2f8601c94705af9f4a61370 Gerrit-Change-Number: 69845 Gerrit-PatchSet: 1 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 08:30:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: UPSTREAM: mb/google/dedede/variants/sasukette: Disable PCIE RP8 and C...
by Rui Zhou (Code Review) 21 Nov '22

21 Nov '22

Rui Zhou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69845 ) Change subject: UPSTREAM: mb/google/dedede/variants/sasukette: Disable PCIE RP8 and CLKSRC4 ...................................................................... UPSTREAM: mb/google/dedede/variants/sasukette: Disable PCIE RP8 and CLKSRC4 This change disables unused PCIE RP8 and CLKSRC4. Without this change sasukette cannot enter into s0ix properly. BUG=b:259891452 TEST=Build and verified in sasukette Change-Id: I1eb22c8c767006d0c2f8601c94705af9f4a61370 Signed-off-by: zhourui <zhourui(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/sasukette/overridetree.cb 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/69845/1 diff --git a/src/mainboard/google/dedede/variants/sasukette/overridetree.cb b/src/mainboard/google/dedede/variants/sasukette/overridetree.cb index 1cda193..43a68db 100644 --- a/src/mainboard/google/dedede/variants/sasukette/overridetree.cb +++ b/src/mainboard/google/dedede/variants/sasukette/overridetree.cb @@ -8,6 +8,10 @@ end chip soc/intel/jasperlake + # Disable PCIe Root Port 8 (index 7) + register "PcieRpEnable[7]" = "0" + # Disable PCIe Clock Source 4 (index 3) + register "PcieClkSrcUsage[3]" = "0xff" # Intel Common SoC Config #+-------------------+---------------------------+ -- To view, visit https://review.coreboot.org/c/coreboot/+/69845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1eb22c8c767006d0c2f8601c94705af9f4a61370 Gerrit-Change-Number: 69845 Gerrit-PatchSet: 1 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: drivers/net/phy/m88e1512: Provide functionality to customize LED status
by build bot (Jenkins) (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Arthur Heymans, Werner Zeh. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 ) Change subject: drivers/net/phy/m88e1512: Provide functionality to customize LED status ...................................................................... Patch Set 16: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164128): https://review.coreboot.org/c/coreboot/+/69386/comment/38f2a449_a64512f2 PS16, Line 14: https://web.archive.org/web/20221109080111/https://www.marvell.com/content/… Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/69386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia71c43f4286f9201f03cb759252ebb405ab81904 Gerrit-Change-Number: 69386 Gerrit-PatchSet: 16 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 08:14:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/net/phy/m88e1512: Provide functionality to customize LED status
by build bot (Jenkins) (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Arthur Heymans, Werner Zeh. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 ) Change subject: drivers/net/phy/m88e1512: Provide functionality to customize LED status ...................................................................... Patch Set 15: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164124): https://review.coreboot.org/c/coreboot/+/69386/comment/0f6f70e6_ff4387b4 PS15, Line 14: https://web.archive.org/web/20221109080111/https://www.marvell.com/content/… Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/69386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia71c43f4286f9201f03cb759252ebb405ab81904 Gerrit-Change-Number: 69386 Gerrit-PatchSet: 15 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 08:12:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/net/phy/m88e1512: Provide functionality to customize LED status
by Mario Scheithauer (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Arthur Heymans, Werner Zeh. Hello build bot (Jenkins), Arthur Heymans, Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69386 to look at the new patch set (#16). Change subject: drivers/net/phy/m88e1512: Provide functionality to customize LED status ...................................................................... drivers/net/phy/m88e1512: Provide functionality to customize LED status For Marvel PHY it could be necessary to customize the shown LED status at the connector. The LED status can be changed via Function Control Register on page 3. Link to the Marvell PHY 88E1512 datasheet: https://web.archive.org/web/20221109080111/https://www.marvell.com/content/… Change-Id: Ia71c43f4286f9201f03cb759252ebb405ab81904 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- A src/drivers/net/phy/m88e1512/chip.h M src/drivers/net/phy/m88e1512/m88e1512.c A src/drivers/net/phy/m88e1512/m88e1512.h 3 files changed, 68 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/69386/16 -- To view, visit https://review.coreboot.org/c/coreboot/+/69386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia71c43f4286f9201f03cb759252ebb405ab81904 Gerrit-Change-Number: 69386 Gerrit-PatchSet: 16 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: drivers/net/phy/m88e1512: Add interrupt enable
by Mario Scheithauer (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69433 ) Change subject: drivers/net/phy/m88e1512: Add interrupt enable ...................................................................... Patch Set 8: (1 comment) File src/drivers/net/phy/m88e1512/m88e1512.c: https://review.coreboot.org/c/coreboot/+/69433/comment/0b408e9b_31d7bad8 PS7, Line 46: page_reg > Just name it 'reg'? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida1efbb604c382676b9d13ac8bf14de768f93637 Gerrit-Change-Number: 69433 Gerrit-PatchSet: 8 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 08:04:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/net/phy/m88e1512: Provide functionality to customize LED status
by Mario Scheithauer (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Arthur Heymans, Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 ) Change subject: drivers/net/phy/m88e1512: Provide functionality to customize LED status ...................................................................... Patch Set 15: (1 comment) File src/drivers/net/phy/m88e1512/m88e1512.c: https://review.coreboot.org/c/coreboot/+/69386/comment/7b05b884_fef0fbc3 PS14, Line 18: page_reg > Is this still the 'page_reg'? This name can lead to confusions with the real PAGE_REG. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia71c43f4286f9201f03cb759252ebb405ab81904 Gerrit-Change-Number: 69386 Gerrit-PatchSet: 15 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 08:04:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/ehl: Add MDIO operation to TSN GbE device
by Mario Scheithauer (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Angel Pons, Arthur Heymans, Lean Sheng Tan, Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69383 ) Change subject: soc/intel/ehl: Add MDIO operation to TSN GbE device ...................................................................... Patch Set 11: (4 comments) File src/soc/intel/elkhartlake/tsn_gbe.c: https://review.coreboot.org/c/coreboot/+/69383/comment/d65bdc5e_7055e202 PS10, Line 42: printk(BIOS_ALERT, "MDIO bus operations not available for %s.\n", : dev_path(dev)); > There is a message on ERROR level already in dev_get_mdio_ops() (see https://review.coreboot. […] I think we can do without this message. The reference to the PCI device is recognizable via log. https://review.coreboot.org/c/coreboot/+/69383/comment/35150ee4_40246c9c PS10, Line 94: > Add a mdelay(1); here so that this time can be used elsewhere if needed? See src/lib/thread. […] Done https://review.coreboot.org/c/coreboot/+/69383/comment/7d915d2f_ad9c9eb7 PS10, Line 128: static void tsn_mdio_write(struct device *dev, uint8_t phy_adr, uint8_t reg_adr, : uint16_t data) > Looks like this could fit on one line (95 chars). Done https://review.coreboot.org/c/coreboot/+/69383/comment/d52c804c_0d58521f PS10, Line 143: do next > exit Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d1b9dd2f2ba8c18291fff314c13f0c3851784aa Gerrit-Change-Number: 69383 Gerrit-PatchSet: 11 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 08:04:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/net/phy/m88e1512: Add interrupt enable
by Mario Scheithauer (Code Review) 21 Nov '22

21 Nov '22

Attention is currently required from: Mario Scheithauer. Hello build bot (Jenkins), Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69433 to look at the new patch set (#8). Change subject: drivers/net/phy/m88e1512: Add interrupt enable ...................................................................... drivers/net/phy/m88e1512: Add interrupt enable INTn on Marvell PHY can be routed to LED[2] pin. This setting must be made via LED Timer Control Register on page 3. Change-Id: Ida1efbb604c382676b9d13ac8bf14de768f93637 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/drivers/net/phy/m88e1512/chip.h M src/drivers/net/phy/m88e1512/m88e1512.c M src/drivers/net/phy/m88e1512/m88e1512.h 3 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/69433/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/69433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida1efbb604c382676b9d13ac8bf14de768f93637 Gerrit-Change-Number: 69433 Gerrit-PatchSet: 8 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022