coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: build: Keep non-default "no" lines in CBFS `config` file
by Julius Werner (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Martin Roth. Hello Martin Roth, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/69955 to review the following change. Change subject: build: Keep non-default "no" lines in CBFS `config` file ...................................................................... build: Keep non-default "no" lines in CBFS `config` file The intention of CB:69710 was that the expanded config file introduced there would be a strict superset of the old version and could be used in all the same cases. This is generally true except for a small oversight: if a boolean Kconfig is `default y`, but was manually set to `n` by the user, the new `config` file does not include a line for it. Running `make olddefconfig` on such a file will again introduce the option as `y`. It turns out that `make olddefconfig` actually parses those "load-bearing comments" in that case. This patch fixes the problem by also generating the minimal defconfig (like before CB:69710), but then only extracting the comment lines from that and adding them to the new config file. This achieves all the goals of generating a config that will do the right thing for `make oldconfig`, can be trivially used to check for the setting of any config, but still keeps the file size down by avoiding a ton of extra boilerplate for forced-off options from other boards. Also eliminate that random backslash in the recipe that doesn't seem to have any good reason to exist and was probably a typo to begin with. Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: I52ba5d20d3536498fae79d529acf7135f97ef1a8 --- M Makefile.inc 1 file changed, 35 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/69955/1 diff --git a/Makefile.inc b/Makefile.inc index ef565c2..dd809c3 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -305,7 +305,7 @@ mv $(2).tmp $(2)) ####################################################################### -# Reduce a .config file by removing lines about unset booleans +# Reduce a .config file by removing lines about default unset booleans # arg1: input # arg2: output define cbfs-files-processor-config @@ -313,8 +313,11 @@ +printf " CREATE $(2) (from $(1))\n"; \ printf "# This image was built using coreboot " > $(2).tmp && \ grep "\<COREBOOT_VERSION\>" $(obj)/build.h |cut -d\" -f2 >> $(2).tmp && \ + $(MAKE) DOTCONFIG=$(1) DEFCONFIG=$(2).tmp2 savedefconfig && \ + grep "^# CONFIG" $(2).tmp2 >> $(2).tmp ; \ + rm -f $(2).tmp2 && \ sed -e '/^CONFIG/!d' $(1) >> $(2).tmp && \ - \mv -f $(2).tmp $(2)) + mv -f $(2).tmp $(2)) endef ####################################################################### -- To view, visit https://review.coreboot.org/c/coreboot/+/69955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52ba5d20d3536498fae79d529acf7135f97ef1a8 Gerrit-Change-Number: 69955 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal para...
by Chris Wang (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, EricKY Cheng, Matt DeVillier, Martin Roth, Tim Van Patten, Fred Reitberger, Felix Held. Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68649 ) Change subject: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal parameters ...................................................................... Patch Set 31: (1 comment) File src/soc/amd/mendocino/root_complex.c: https://review.coreboot.org/c/coreboot/+/68649/comment/7b0b0231_4285d71f PS16, Line 393: #else > I don't fully understand what this means. What is "AMD IRM"? The document name is "Infrastructure Roadmap (IRM) for FT6 Processors" (doc#57316) You can find the details about the thermal/power parameter informations in that document. DPTC is to change the those settings to SMU via ALIB. so it will only change the value which you input. Keep setting alignment will be good. -- To view, visit https://review.coreboot.org/c/coreboot/+/68649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d6a00f0eca0b0941860b9bc75da41d7a10d60e8 Gerrit-Change-Number: 68649 Gerrit-PatchSet: 31 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nelson Ye <nelson_ye(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 24 Nov 2022 02:24:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Comment-In-Reply-To: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [RFC] Pull libgfxinit in early romstage
by Jérémy Compostella (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Nico Huber, Martin L Roth, Jérémy Compostella, Angel Pons, Arthur Heymans, Kyösti Mälkki, Andrey Petrov. Hello build bot (Jenkins), Tarun Tuli, Martin L Roth, Subrata Banik, Angel Pons, Arthur Heymans, Kyösti Mälkki, Andrey Petrov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69757 to look at the new patch set (#6). Change subject: [RFC] Pull libgfxinit in early romstage ...................................................................... [RFC] Pull libgfxinit in early romstage The goal is to display a text message while memory training is in progress. Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M Makefile M src/arch/x86/car.ld M src/console/Makefile.inc M src/cpu/intel/car/romstage.c M src/device/Kconfig M src/drivers/intel/fsp2_0/Kconfig M src/drivers/intel/fsp2_0/memory_init.c M src/drivers/intel/gma/Kconfig M src/drivers/intel/gma/Makefile.inc M src/drivers/intel/gma/gma-gfx_init.ads M src/drivers/intel/gma/libgfxinit.h M src/drivers/intel/gma/text_fb/gma-gfx_init.adb M src/drivers/pc80/vga/Kconfig M src/drivers/pc80/vga/Makefile.inc M src/drivers/pc80/vga/vga.c M src/include/adainit.h M src/include/pc80/vga.h M src/lib/Kconfig M src/lib/Makefile.inc M src/lib/gnat/Makefile.inc M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/gma-mainboard.ads M src/mainboard/google/brya/variants/skolas/overridetree.cb M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/chip.h M src/soc/intel/alderlake/romstage/Makefile.inc A src/soc/intel/alderlake/romstage/graphics.c M src/soc/intel/common/block/graphics/Makefile.inc A src/soc/intel/common/block/graphics/romstage.c M src/soc/intel/common/block/include/intelblocks/graphics.h 31 files changed, 432 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/69757/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/69757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718 Gerrit-Change-Number: 69757 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/brask/variants/brask: remove fan setting
by Eric Lai (Code Review) 24 Nov '22

24 Nov '22

Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69791 ) Change subject: mb/google/brask/variants/brask: remove fan setting ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > could we merge this code? rule is wait 24hrs after first +2, but almost 24hrs so merge it. -- To view, visit https://review.coreboot.org/c/coreboot/+/69791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6075b6171ca4d7b907679efd0ce7e355759385bc Gerrit-Change-Number: 69791 Gerrit-PatchSet: 2 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 01:48:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: gma: add a Turn_Off procedure to clear the graphic configuration
by Jérémy Compostella (Code Review) 24 Nov '22

24 Nov '22

Jérémy Compostella has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/69938 ) Change subject: gma: add a Turn_Off procedure to clear the graphic configuration ...................................................................... gma: add a Turn_Off procedure to clear the graphic configuration It turns out that the FSP GOP graphic driver does not expect to face any previously setup graphic initialization. For some configuration it may be suitable to run the FSP GOP driver during romstage even if libgfxinit has been used in romstage. This new procedure offers coreboot a way to clear the graphic configuration if needed. Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> Change-Id: Ida65bf3303d4dbf956d6fc9340f935e6c4e6b447 --- M common/hw-gfx-gma.adb M common/hw-gfx-gma.ads 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/38/69938/1 diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index 146b53b..60ebeb1 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -622,6 +622,19 @@ end Initialize; + procedure Turn_Off + is + begin + Debug.Put_Line("J2M: Turning off"); + Power_And_Clocks.Pre_All_Off; + Connectors.Pre_All_Off; + Display_Controller.All_Off; + Connectors.Post_All_Off; + PLLs.All_Off; + Power_And_Clocks.Post_All_Off; + Registers.Clear_Fences; + end Turn_Off; + function Is_Initialized return Boolean with Refined_Post => Is_Initialized'Result = Initialized diff --git a/common/hw-gfx-gma.ads b/common/hw-gfx-gma.ads index 1c589d0..470fa9f 100644 --- a/common/hw-gfx-gma.ads +++ b/common/hw-gfx-gma.ads @@ -142,6 +142,8 @@ Global => (Input => Init_State); pragma Warnings (GNATprove, On, "unused variable ""Write_Delay"""); + procedure Turn_Off; + procedure Power_Up_VGA with Global => -- To view, visit https://review.coreboot.org/c/libgfxinit/+/69938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ida65bf3303d4dbf956d6fc9340f935e6c4e6b447 Gerrit-Change-Number: 69938 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/brask/variants/brask: remove fan setting
by Eric Lai (Code Review) 24 Nov '22

24 Nov '22

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69791 ) Change subject: mb/google/brask/variants/brask: remove fan setting ...................................................................... mb/google/brask/variants/brask: remove fan setting The brask doesn't include a real chassis so we don't need to configure the fan setting in the overridetree.cb. Instead, we can leave the fan running at full speed after the device boot up. BUG=b:259643676 BRANCH=firmware-brya-14505.B TEST=flashed the bios to the device and make sure the fan spinned at full speed. Change-Id: I6075b6171ca4d7b907679efd0ce7e355759385bc Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69791 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Derek Huang <derekhuang(a)google.com> Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/brask/overridetree.cb 1 file changed, 24 insertions(+), 18 deletions(-) Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Eric Lai: Looks good to me, approved Derek Huang: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/brya/variants/brask/overridetree.cb b/src/mainboard/google/brya/variants/brask/overridetree.cb index 6c66d79..b967b53 100644 --- a/src/mainboard/google/brya/variants/brask/overridetree.cb +++ b/src/mainboard/google/brya/variants/brask/overridetree.cb @@ -67,24 +67,6 @@ [3] = { 8, 500 } }" - ## Fan Performance Control (Percent, Speed, Noise, Power) - register "controls.fan_perf" = "{ - [0] = { 90, 6700, 220, 2200, }, - [1] = { 80, 5800, 180, 1800, }, - [2] = { 70, 5000, 145, 1450, }, - [3] = { 60, 4900, 115, 1150, }, - [4] = { 50, 3838, 90, 900, }, - [5] = { 40, 2904, 55, 550, }, - [6] = { 30, 2337, 30, 300, }, - [7] = { 20, 1608, 15, 150, }, - [8] = { 10, 800, 10, 100, }, - [9] = { 0, 0, 0, 50, } - }" - - ## Fan options - register "options.fan.fine_grained_control" = "1" - register "options.fan.step_size" = "2" - device generic 0 alias dptf_policy on end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/69791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6075b6171ca4d7b907679efd0ce7e355759385bc Gerrit-Change-Number: 69791 Gerrit-PatchSet: 2 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/brask/variants/brask: remove fan setting
by Zhuohao Lee (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Tarun Tuli, Zhuohao Lee. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69791 ) Change subject: mb/google/brask/variants/brask: remove fan setting ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: could we merge this code? -- To view, visit https://review.coreboot.org/c/coreboot/+/69791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6075b6171ca4d7b907679efd0ce7e355759385bc Gerrit-Change-Number: 69791 Gerrit-PatchSet: 1 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Thu, 24 Nov 2022 01:44:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: vboot: Allow for comparison of hash without zero-padding
by Julius Werner (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Jakub Czapiga, Caveh Jalali, Yu-Ping Wu, Boris Mittelberg. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69762 ) Change subject: vboot: Allow for comparison of hash without zero-padding ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6d46e0b58dbca86af56221b7ff2606ab2d1799a Gerrit-Change-Number: 69762 Gerrit-PatchSet: 6 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 01:39:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/intel/mipi_camera: Remove IPU ES support entry for RPL
by Eric Lai (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Jim Lai. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69929 ) Change subject: drivers/intel/mipi_camera: Remove IPU ES support entry for RPL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fd8ea0dd6ffdb16961bb017ba4388bf99e4d5bc Gerrit-Change-Number: 69929 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Lai <jim.lai(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jim Lai <jim.lai(a)intel.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 00:46:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/frostflow: Enable DPTC support
by Tim Van Patten (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: John Su, Jason Nien, Chris Wang, Martin Roth, Karthik Ramasubramanian. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69931 ) Change subject: mb/google/skyrim/var/frostflow: Enable DPTC support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac7b8789a5189827fe98cb06328d666300841a5c Gerrit-Change-Number: 69931 Gerrit-PatchSet: 1 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 00:31:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022