Attention is currently required from: Harsha B R, Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Usha P.
Hello build bot (Jenkins), Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Ronak Kanabar, Usha P,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69971
to look at the new patch set (#6).
Change subject: mb/intel/mtlrvp: Create baseboard structure for mtlrvp
......................................................................
mb/intel/mtlrvp: Create baseboard structure for mtlrvp
This patch will create the baseboard structure for mtlrvp. Changes
include,
1. Adding Baseboard config for mtlrvp in Kconfig
2. Move gpio.h to corresponding baseboard directory
3. Append header reference to CPPFLAGS_common in Makefile.inc
BUG=none
TEST=FW_NAME=mtlrvp_p emerge-rex coreboot chromeos-bootimage
Signed-off-by: Harsha B R <harsha.b.r(a)intel.com>
Change-Id: I82acb6879fecb242014258f2c358804d5abbbd48
---
M src/mainboard/intel/mtlrvp/Kconfig
M src/mainboard/intel/mtlrvp/Makefile.inc
R src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp/include/baseboard/gpio.h
3 files changed, 28 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/69971/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/69971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82acb6879fecb242014258f2c358804d5abbbd48
Gerrit-Change-Number: 69971
Gerrit-PatchSet: 6
Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Elyes Haouas.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69980 )
Change subject: sb/intel: Use "sb/intel/common/tco.h" macros
......................................................................
Patch Set 5: Code-Review-2
(1 comment)
Patchset:
PS5:
https://review.coreboot.org/c/coreboot/+/69760
There was some agreement that {read/write}_pmbaseX() are bad names. They have further problems too -- not having them inlined makes creating useful tracing debug output difficult and increases binary sizes (not much).
--
To view, visit https://review.coreboot.org/c/coreboot/+/69980
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8e6d4817ea706fc7058ec15893afb0168c1a2cb
Gerrit-Change-Number: 69980
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 25 Nov 2022 07:18:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Kyösti Mälkki.
Hello build bot (Jenkins), Angel Pons, Kyösti Mälkki,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69980
to look at the new patch set (#5).
Change subject: sb/intel: Use "sb/intel/common/tco.h" macros
......................................................................
sb/intel: Use "sb/intel/common/tco.h" macros
Also use read_pmbase{16,32}() in bd82x6x/elog.c and i82801ix/early_init.c files.
Change-Id: Ie8e6d4817ea706fc7058ec15893afb0168c1a2cb
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/northbridge/intel/haswell/gma.c
M src/northbridge/intel/sandybridge/gma.c
M src/southbridge/intel/bd82x6x/early_pch.c
M src/southbridge/intel/bd82x6x/elog.c
M src/southbridge/intel/bd82x6x/pch.h
M src/southbridge/intel/common/finalize.c
M src/southbridge/intel/common/pmutil.c
M src/southbridge/intel/common/pmutil.h
M src/southbridge/intel/common/tco.h
M src/southbridge/intel/i82801ix/early_init.c
M src/southbridge/intel/i82801jx/early_init.c
M src/southbridge/intel/lynxpoint/elog.c
M src/southbridge/intel/lynxpoint/pch.h
M src/southbridge/intel/lynxpoint/pmutil.c
14 files changed, 86 insertions(+), 72 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/69980/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/69980
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8e6d4817ea706fc7058ec15893afb0168c1a2cb
Gerrit-Change-Number: 69980
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Harsha B R, Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Usha P.
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69971 )
Change subject: mb/intel/mtlrvp: align directory structure to chrome project
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69971/comment/3d4ad602_79acc0d3
PS5, Line 7: align
Align
https://review.coreboot.org/c/coreboot/+/69971/comment/d312d3d0_67cf42d9
PS5, Line 9: This patch will align the directory structure of mtlrvp
: for chrome project. Header files specific to variants
: shall be moved under variants directory.
Use full width
--
To view, visit https://review.coreboot.org/c/coreboot/+/69971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82acb6879fecb242014258f2c358804d5abbbd48
Gerrit-Change-Number: 69971
Gerrit-PatchSet: 5
Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Comment-Date: Fri, 25 Nov 2022 06:47:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment