Attention is currently required from: Raul Rangel, Jason Nien, Chris Wang, Martin Roth, Eric Peers, Tim Van Patten, Karthikeyan Ramasubramanian.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68472 )
Change subject: mb/google/skyrim/var/winterhold: update thermal config
......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS13:
Based on b/232946420 comment#116 and comment#129, update the Dynamic Thermal Tables.
Based on Google previous suggests, update the comments for the tables.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68472
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0740cb5bb16cd53c2ee6937e32a974346012823
Gerrit-Change-Number: 68472
Gerrit-PatchSet: 13
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nelson Ye <nelson_ye(a)compal.corp-partner.google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Comment-Date: Mon, 31 Oct 2022 09:44:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Nien, Martin Roth, Tim Van Patten.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68472 )
Change subject: mb/google/skyrim/var/winterhold: update thermal config
......................................................................
Patch Set 13:
(1 comment)
File src/mainboard/google/skyrim/variants/winterhold/overridetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161755):
https://review.coreboot.org/c/coreboot/+/68472/comment/56cb03a2_4f0c5895
PS13, Line 8: # Set system_configuration to 4 for 15W
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/68472
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0740cb5bb16cd53c2ee6937e32a974346012823
Gerrit-Change-Number: 68472
Gerrit-PatchSet: 13
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-CC: Eric Peers <epeers(a)google.com>
Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-CC: Raul Rangel <rrangel(a)chromium.org>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 09:40:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Nien, Martin Roth, Tim Van Patten.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68472 )
Change subject: mb/google/skyrim/var/winterhold: update thermal config
......................................................................
Patch Set 12:
(3 comments)
File src/mainboard/google/skyrim/variants/winterhold/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68472/comment/48bbbc53_653f8d77
PS7, Line 8: Set STAPM confiuration
> STAPM is different from DPTC. These comments should indicate these are for DPTC.
Done
https://review.coreboot.org/c/coreboot/+/68472/comment/e51a1c86_c269a306
PS7, Line 23: # Set STAPM confiuration. Table C
: register "thermctl_limit_degreeC_C" = "97"
: register "fast_ppt_limit_mW_C" = "30000"
: register "slow_ppt_limit_mW_C" = "15000"
: register "slow_ppt_time_constant_s_C" = "5"
: register "sustained_power_limit_mW_C" = "15000"
> Remove, since it matches table A.
Done
https://review.coreboot.org/c/coreboot/+/68472/comment/c3b781d0_e8b758d1
PS7, Line 30: # Set STAPM confiuration. Table D
: register "thermctl_limit_degreeC_D" = "97"
: register "fast_ppt_limit_mW_D" = "30000"
: register "slow_ppt_limit_mW_D" = "10000"
: register "slow_ppt_time_constant_s_D" = "5"
: register "sustained_power_limit_mW_D" = "10000"
> Remove, since it matches table B.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68472
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0740cb5bb16cd53c2ee6937e32a974346012823
Gerrit-Change-Number: 68472
Gerrit-PatchSet: 12
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-CC: Eric Peers <epeers(a)google.com>
Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-CC: Raul Rangel <rrangel(a)chromium.org>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 09:38:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jason Nien, EricKY Cheng, Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68472 )
Change subject: mb/google/skyrim/var/winterhold: update thermal config
......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/google/skyrim/variants/winterhold/overridetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161754):
https://review.coreboot.org/c/coreboot/+/68472/comment/d934ffd5_5401fcaa
PS12, Line 8: # Set system_configuration to 4 for 15W
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/68472
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0740cb5bb16cd53c2ee6937e32a974346012823
Gerrit-Change-Number: 68472
Gerrit-PatchSet: 12
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-CC: Eric Peers <epeers(a)google.com>
Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-CC: Raul Rangel <rrangel(a)chromium.org>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 09:37:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć.
Hello build bot (Jenkins), Michał Żygowski, Michał Kopeć,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68936
to look at the new patch set (#5).
Change subject: IASL: Ignore IASL's "Missing dependency" warning
......................................................................
IASL: Ignore IASL's "Missing dependency" warning
IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects:
1) If _PRS is present, must have _CRS and _SRS
2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS)
3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS
requires _CRS and _SRS)
4) If _SRS is present, probably should have a _DIS (Remark only)
IASL will issue a warning for each missing dependency.
Ignore this warnings for existing ASL code and issue a message when the
build is complete.
This patch is needed to upgrade IASL from 20220331 to 20221020.
Change-Id: I17d4f7ad4e3a9cb7d94263080d9d14fe6c9380d9
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/mainboard/google/beltino/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/drallion/Kconfig
M src/mainboard/google/jecht/Kconfig
M src/mainboard/google/sarien/Kconfig
M src/mainboard/google/stout/Kconfig
M src/mainboard/intel/baskingridge/Kconfig
M src/mainboard/msi/ms7d25/Kconfig
M src/mainboard/samsung/stumpy/Kconfig
M src/mainboard/supermicro/x9sae/Kconfig
10 files changed, 52 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/68936/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/68936
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17d4f7ad4e3a9cb7d94263080d9d14fe6c9380d9
Gerrit-Change-Number: 68936
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Michał Żygowski, Michał Kopeć.
Hello build bot (Jenkins), Michał Żygowski, Michał Kopeć,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68936
to look at the new patch set (#4).
Change subject: IASL: Ignore IASL's "Missing dependency" warning
......................................................................
IASL: Ignore IASL's "Missing dependency" warning
IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects:
1) If _PRS is present, must have _CRS and _SRS
2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS)
3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS
requires _CRS and _SRS)
4) If _SRS is present, probably should have a _DIS (Remark only)
IASL will issue a warning for each missing dependency.
Ignore this warnings for existing ASL code and issue a message when the
build is complete.
This patch is neede to upgrade IASL from 20220331 to 20221020.
Change-Id: I17d4f7ad4e3a9cb7d94263080d9d14fe6c9380d9
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/mainboard/google/beltino/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/drallion/Kconfig
M src/mainboard/google/jecht/Kconfig
M src/mainboard/google/sarien/Kconfig
M src/mainboard/google/stout/Kconfig
M src/mainboard/intel/baskingridge/Kconfig
M src/mainboard/msi/ms7d25/Kconfig
M src/mainboard/samsung/stumpy/Kconfig
M src/mainboard/supermicro/x9sae/Kconfig
10 files changed, 52 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/68936/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/68936
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17d4f7ad4e3a9cb7d94263080d9d14fe6c9380d9
Gerrit-Change-Number: 68936
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Nien, EricKY Cheng, Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68472 )
Change subject: mb/google/skyrim/var/winterhold: update thermal config
......................................................................
Patch Set 10:
(2 comments)
File src/mainboard/google/skyrim/variants/winterhold/overridetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161750):
https://review.coreboot.org/c/coreboot/+/68472/comment/ef55bc44_dc1a2d68
PS10, Line 5: # Set DPTC multi-profile common parameters.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161750):
https://review.coreboot.org/c/coreboot/+/68472/comment/e6b90d20_19ad6a53
PS10, Line 30:
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/68472
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0740cb5bb16cd53c2ee6937e32a974346012823
Gerrit-Change-Number: 68472
Gerrit-PatchSet: 10
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-CC: Eric Peers <epeers(a)google.com>
Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-CC: Raul Rangel <rrangel(a)chromium.org>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 09:21:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Nien, EricKY Cheng, Martin Roth.
Hello build bot (Jenkins), Jason Nien, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68472
to look at the new patch set (#10).
Change subject: mb/google/skyrim/var/winterhold: update thermal config
......................................................................
mb/google/skyrim/var/winterhold: update thermal config
Enable STT and set 6 thermal table profiles for
Dynamic Thermal Table Switching Proposal support
BUG=b:232946420
BRANCH=none
TEST=emerge-skyrim coreboot
Signed-off-by: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Change-Id: Ie0740cb5bb16cd53c2ee6937e32a974346012823
---
M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb
1 file changed, 106 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/68472/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/68472
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0740cb5bb16cd53c2ee6937e32a974346012823
Gerrit-Change-Number: 68472
Gerrit-PatchSet: 10
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-CC: Eric Peers <epeers(a)google.com>
Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-CC: Raul Rangel <rrangel(a)chromium.org>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Raul Rangel, Kangheui Won, Julius Werner, Karthik Ramasubramanian.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68953 )
Change subject: security/vboot: Update build rules using x86 SHA extension
......................................................................
Patch Set 1:
(1 comment)
File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68953/comment/689bcd7f_6c851782
PS1, Line 26: ifeq ($(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),y)
> I don't know much about Kconfig so not sure if we can select different options for different stages
No, the Kconfig options are shared for all stages.
In that case, I agree that we should change the condition to what you suggested above.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68953
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f388e963eb82990cda41d3880e66ad937334908
Gerrit-Change-Number: 68953
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 09:17:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment