Attention is currently required from: Andrey Petrov.
Hello Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69038
to look at the new patch set (#2).
Change subject: {device,drivers}: Include <cpu/cpu.h> instead of <arch/cpu.h>
......................................................................
{device,drivers}: Include <cpu/cpu.h> instead of <arch/cpu.h>
Also sort includes.
Change-Id: I1727bf56b4090d040aab413006dec7aca0587d44
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/device/oprom/realmode/x86.h
M src/drivers/amd/agesa/romstage.c
M src/drivers/intel/fsp1_1/include/fsp/util.h
M src/drivers/intel/fsp2_0/include/fsp/util.h
M src/drivers/intel/mipi_camera/camera.c
5 files changed, 21 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/69038/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69038
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1727bf56b4090d040aab413006dec7aca0587d44
Gerrit-Change-Number: 69038
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Raul Rangel, Matt DeVillier, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68954 )
Change subject: soc/amd/mendocino: Enable x86 SHA accelerator
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68954/comment/8372334b_245a4b4f
PS1, Line 11:
What speed improvement do you see?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14efe7be66f28f348330580d2e5733e11603a023
Gerrit-Change-Number: 68954
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 31 Oct 2022 13:10:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Jon Murphy, Fred Reitberger.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68928 )
Change subject: configs: Build test STB features on google skyrim
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/68928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idddcf2441b91b79575e5dfed1cc56d207234205b
Gerrit-Change-Number: 68928
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Fred Reitberger <fred.reitberger(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Fred Reitberger <fred.reitberger(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 13:04:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Nick Vaccaro.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69013 )
Change subject: mb/google/brya/var/lisbon: Enable SaGv
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69013/comment/137a62eb_31dcbebf
PS1, Line 12: TEST=FW_NAME=lisbon emerge-brask coreboot
Can we add any details on how we confirmed SaGv is operating as we expect (freq/volt change)?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d3203bfe06973b023a38d1aa3d69cce5c3a60c
Gerrit-Change-Number: 69013
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 12:58:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment