Attention is currently required from: Marc Jones, Patrick Rudolph, Johnny Lin, Rocky Phagura, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang, Kyösti Mälkki.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49460 )
Change subject: cpu/x86/smm: Enable setting SMM console log level from mainboard
......................................................................
Patch Set 21: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/49460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81722a4f1bf75ec942cc06e403ad702dfe938e71
Gerrit-Change-Number: 49460
Gerrit-PatchSet: 21
Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Rocky Phagura <rphagura(a)fb.com>
Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 16:47:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Christian Walter, Arthur Heymans, Shuming Chu (Shuming), TangYiwei.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68912 )
Change subject: soc/intel/xeon_sp: Don't sort struct device cpus for numa
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/xeon_sp/include/soc/util.h:
https://review.coreboot.org/c/coreboot/+/68912/comment/56b86f4a_69fd10be
PS3, Line 15: uint8_t get_cpu_package(const uint32_t apic_id);
Should we name it get_cpu_socket()?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I372bcea1932d28e9bf712cc712f19a76fe3199b1
Gerrit-Change-Number: 68912
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Mon, 31 Oct 2022 16:41:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Shuming Chu (Shuming), Arthur Heymans, TangYiwei.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68910 )
Change subject: drivers/ocp/dmi: Fix smbios type 11 get wrong ppin value for second socket
......................................................................
Patch Set 4:
(3 comments)
File src/drivers/ocp/dmi/smbios.c:
https://review.coreboot.org/c/coreboot/+/68910/comment/9433eca6_7f875a79
PS4, Line 205: static int get_logic_cpu(int node)
Should we name the variable as socket instead of node?
https://review.coreboot.org/c/coreboot/+/68910/comment/b2a3cc04_7672b97f
PS4, Line 207: for (int logic_cpu = 0; logic_cpu < CONFIG_MAX_CPUS; logic_cpu++) {
Should we loop through all logical cpus, instead of all sockets (CPUs)?
https://review.coreboot.org/c/coreboot/+/68910/comment/b3594729_4babde77
PS4, Line 259: get_logic_cpu(1), 100 * USECS_PER_MSEC) !=
what if the return value of get_logic_cpu() is -1?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68910
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9174522c57680a57e6e4629b4e81fd837c38d47a
Gerrit-Change-Number: 68910
Gerrit-PatchSet: 4
Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Mon, 31 Oct 2022 16:40:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Hello build bot (Jenkins), Martin L Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69021
to look at the new patch set (#2).
Change subject: util/cbfstool: fix memory leak in compress.c
......................................................................
util/cbfstool: fix memory leak in compress.c
free the memory allocated in lz4_compress
function before returning from it.
Reported-by: Coverity (CID:1469433)
Signed-off-by: Solomon Alan-Dei <alandei.solomon(a)gmail.com>
Change-Id: I8698090d519964348e51fc3b6f2023d06d81fcd5
---
M util/cbfstool/compress.c
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/69021/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8698090d519964348e51fc3b6f2023d06d81fcd5
Gerrit-Change-Number: 69021
Gerrit-PatchSet: 2
Gerrit-Owner: Solomon Alan-Dei <alandei.solomon(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Elyes Haouas.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68996 )
Change subject: nb/intel/i945: Specify supported memory type
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Wow! Thanks so much for picking this up on non-AMD platforms. I totally didn't expect that anyone would do it, so I was planning on circling back after getting the original patches merged.
Very much appreciated.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68996
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cc2a9786dfb1f8fb1ec8e78bde7c46c07f8da48
Gerrit-Change-Number: 68996
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 31 Oct 2022 16:35:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford, Tim Wawrzynczak, Martin Roth, Tim Van Patten, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60174 )
Change subject: drivers/i2c/generic: Print error when using _CRS and PowerResource
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> This patch now needs a manual rebase before it can be merged. […]
If someone wants to rebase it I would appreciate it :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/60174
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcc42ed81fff295fb168a0b343e96b3a650b1c84
Gerrit-Change-Number: 60174
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 16:34:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67319 )
Change subject: util/release/build-release: Fix style issues
......................................................................
Patch Set 1: Code-Review+2
(3 comments)
File util/release/build-release:
https://review.coreboot.org/c/coreboot/+/67319/comment/c2387570_f6b75a69
PS1, Line 12: set -e
If you wanted to make it even more robust:
```
set -eu -o pipefail
```
https://review.coreboot.org/c/coreboot/+/67319/comment/403b8333_4a642bc4
PS1, Line 65: --
Why the `--`?
https://review.coreboot.org/c/coreboot/+/67319/comment/e9f1172d_81f37caf
PS1, Line 80: cat "coreboot-${VERSION_NAME}/.coreboot-version" | tr "-" " "
nit: `tr "-" " " < "coreboot-${VERSION_NAME}/.coreboot-version"`
--
To view, visit https://review.coreboot.org/c/coreboot/+/67319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e79afc8d725e86ddbf7f4eb4685bed190c20738
Gerrit-Change-Number: 67319
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 16:33:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67318 )
Change subject: util/release/build-release: Use bash arrays for params
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/67318
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c96d5072b98523af4e407cfff8f4d1d28ec3297
Gerrit-Change-Number: 67318
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 16:29:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Christian Walter, Arthur Heymans, Shuming Chu (Shuming), TangYiwei.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68912 )
Change subject: soc/intel/xeon_sp: Don't sort struct device cpus for numa
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68912/comment/70f8bc4f_77b81874
PS3, Line 15: This moves the sorting to of the lapic_ids to the srat table generation
This moves the sorting to of --> This moves the sorting of ?
File src/soc/intel/xeon_sp/util.c:
https://review.coreboot.org/c/coreboot/+/68912/comment/278e9fa6_e67f1491
PS3, Line 161: uint8_t get_cpu_package(const uint32_t apic_id)
Could we add some comments here? Such as what it means by a "package" in this context?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I372bcea1932d28e9bf712cc712f19a76fe3199b1
Gerrit-Change-Number: 68912
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Mon, 31 Oct 2022 16:24:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: John Zhao, Kapil Porwal, Ivy Jian, Eric Lai.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68854 )
Change subject: mb/google/rex: Disable TBT PCIe rp1 and rp3 root ports
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68854
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5c1d657c0ad0482619d739f8949bc9168eac25b
Gerrit-Change-Number: 68854
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 16:09:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment