Attention is currently required from: Raul Rangel, Kangheui Won, Julius Werner, Karthik Ramasubramanian.
Hello build bot (Jenkins), Raul Rangel, Kangheui Won, Julius Werner, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68953
to look at the new patch set (#2).
Change subject: security/vboot: Update build rules using x86 SHA extension
......................................................................
security/vboot: Update build rules using x86 SHA extension
Currently build rules allow using x86 SHA extensions for all coreboot
stages when enabled. On some SoCs where verstage can run in non-x86
environment, x86 SHA extension cannot be used. Update build rules
accordingly such that x86 SHA extensions can be used in AMD SoCs. This
is particularly useful when CBFS verificiation is enabled which verifies
the hash of the CBFS file being loaded.
BUG=b:227809919
TEST=Build and boot to OS in Skyrim. Observe that hardware acceleration
is used when a CBFS file is loaded and observe an overall improvement of
10 ms.
Change-Id: I4f388e963eb82990cda41d3880e66ad937334908
Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com>
---
M src/security/vboot/Makefile.inc
1 file changed, 35 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/68953/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68953
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f388e963eb82990cda41d3880e66ad937334908
Gerrit-Change-Number: 68953
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Fred Reitberger, Felix Held.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66909 )
Change subject: vboot: Add VBOOT_CBFS_INTEGRATION support
......................................................................
Patch Set 18:
(4 comments)
File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66909/comment/e143c530_9bde7199
PS15, Line 104: bootblock-y += secdata_mock.c
> I built firmware with this change, but with CBFS_VERIFICATION=y and VBOOT_CBFS_INTEGRATION=n. […]
The parentheses aren't right, that's why you get that error. You're running on a board with early EC sync enabled, so the TPM code should be built into romstage. You wrote `!verstage && !(romstage && ec_sync && (secdata change))` but it should be `!verstage && !(romstage && ec_sync) && (secdata change)`.
Not sure what you mean with your question. vboot_save_data() can be called in the cbfs_file_hash_mismatch() path from any stage, but when called in that path we know that no TPM updates will be necessary (because that path just calls vb2api_fail() which only touches NVRAM, not secdata).
File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66909/comment/d8ace9d4_0e4fa898
PS18, Line 40: postcar-y += i2c.c
I think you should no longer need this
File src/soc/qualcomm/ipq40xx/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66909/comment/6b493d69_b06e0c67
PS18, Line 7: bootblock-y += i2c.c
and this
File src/soc/qualcomm/ipq806x/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66909/comment/db3b9dac_a7a4107a
PS18, Line 7: bootblock-y += i2c.c
and this
--
To view, visit https://review.coreboot.org/c/coreboot/+/66909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40ae01c477c4e4f7a1c90e4026a8a868ae64b5ca
Gerrit-Change-Number: 66909
Gerrit-PatchSet: 18
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 31 Oct 2022 21:54:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Jason Nien, Matt DeVillier.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67779 )
Change subject: mb/google/skyrim: Use detect vs probed flag for touchscreens
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/67779
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9e3089decf0f94a1358929684ce248e52cbe41f
Gerrit-Change-Number: 67779
Gerrit-PatchSet: 6
Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 21:21:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69062 )
Change subject: drivers/i2c/generic: Tweak error text for missing HID
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69062
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1795aee240a5383b21108c697e930a2e4972a0b4
Gerrit-Change-Number: 69062
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 21:12:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Hello build bot (Jenkins), Raul Rangel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69062
to look at the new patch set (#2).
Change subject: drivers/i2c/generic: Tweak error text for missing HID
......................................................................
drivers/i2c/generic: Tweak error text for missing HID
- drop ERROR prefix since already provided by cbmem log
- make error text more clear about cause of error
BUG=none
Change-Id: I1795aee240a5383b21108c697e930a2e4972a0b4
Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
---
M src/drivers/i2c/generic/generic.c
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/69062/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69062
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1795aee240a5383b21108c697e930a2e4972a0b4
Gerrit-Change-Number: 69062
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kevin Chiu.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68888 )
Change subject: mb/google/brya/var/lisbon: Include driver for GL9763E for eMMC boot disk
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68888
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe579a913225b5241412bbb1b8ea995a5102a3bb
Gerrit-Change-Number: 68888
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 20:50:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford, Matt DeVillier, Tim Wawrzynczak, Martin Roth, Tim Van Patten, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60174 )
Change subject: drivers/i2c/generic: Print error when using _CRS and PowerResource
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
Only +1 since I can't +2 a CL I originally authored, at least I think so.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60174
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcc42ed81fff295fb168a0b343e96b3a650b1c84
Gerrit-Change-Number: 60174
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 20:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69062 )
Change subject: drivers/i2c/generic: Tweak error text for missing HID
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/69062/comment/e9c7e7e3_956b4269
PS1, Line 65: found
`not set`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69062
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1795aee240a5383b21108c697e930a2e4972a0b4
Gerrit-Change-Number: 69062
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 20:47:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Martin L Roth, Paul Menzel, Angel Pons.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62830 )
Change subject: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62830/comment/382826fd_0886dfc9
PS1, Line 9: ```
: $ make V=1 # emulation/qemu-i440fx
: […]
: CC ramstage/arch/x86/ebda.o
: x86_64-linux-gnu-gcc-12 -MMD -Isrc -Isrc/include -Isrc/commonlib/include -Isrc/commonlib/bsd/include -Ibuild -I3rdparty/vboot/firmware/include -include src/include/kconfig.h -include src/include/rules.h -include src/commonlib/bsd/include/commonlib/bsd/compiler.h -I3rdparty -D__BUILD_DIR__=\"build\" -Isrc/arch/x86/include -D__ARCH_x86_32__ -pipe -g -nostdinc -std=gnu11 -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough -Wshadow -Wdate-time -Wtype-limits -Wvla -Wdangling-else -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie -Wno-packed-not-aligned -fconserve-stack -Wnull-dereference -Wreturn-type -Wlogical-op -Wduplicated-cond -Wno-unused-but-set-variable -Werror -Os -Wno-address-of-packed-member -m32 -Wl,-b,elf32-i386 -Wl,-melf_i386 -m32 -fuse-ld=bfd -fno-stack-protector -Wl,--build-id=none -fno-delete-null-pointer-checks -Wlogical-op -march=i686 -mno-mmx -MT build/ramstage/arch/x86/ebda.o -D__RAMSTAGE__ -c -o build/ramstage/arch/x86/ebda.o src/arch/x86/ebda.c
: In file included from src/arch/x86/ebda.c:6:
: In function 'write_ble8',
: inlined from 'write_le8' at src/commonlib/include/commonlib/endian.h:155:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:178:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:35:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 0 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_at_ble8' at src/commonlib/include/commonlib/endian.h:34:2,
: inlined from 'write_at_le8' at src/commonlib/include/commonlib/endian.h:160:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:179:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:35:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 1 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_le8' at src/commonlib/include/commonlib/endian.h:155:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:178:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:36:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 0 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_at_ble8' at src/commonlib/include/commonlib/endian.h:34:2,
: inlined from 'write_at_le8' at src/commonlib/include/commonlib/endian.h:160:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:179:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:36:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 1 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_le8' at src/commonlib/include/commonlib/endian.h:155:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:178:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:40:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 0 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_at_ble8' at src/commonlib/include/commonlib/endian.h:34:2,
: inlined from 'write_at_le8' at src/commonlib/include/commonlib/endian.h:160:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:179:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:40:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 1 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: cc1: all warnings being treated as errors
: ```
> (Hmm, Gerrit missed the rest of my comment, and the check box. Again:) […]
Still needs to pass Jenkins, too.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62830
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e36633f42cb4dc5af53212c10c919a86e451ee0
Gerrit-Change-Number: 62830
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 20:37:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment