coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: MAINTAINERS: Update mainboards
by Martin L Roth (Code Review) 23 Oct '22

23 Oct '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68707 ) Change subject: MAINTAINERS: Update mainboards ...................................................................... MAINTAINERS: Update mainboards - AMD reference boards are maintained at least for odd fixes. - Google panther has become a variant of Beltino, so remove it. - Remove people whose email addresses are bouncing email. - Alphabetize list Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ic6ecaae77df2f2edaf724160bce04c038cbd115e --- M MAINTAINERS 1 file changed, 24 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/68707/1 diff --git a/MAINTAINERS b/MAINTAINERS index c17b521..9c688e8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -149,6 +149,7 @@ F: src/mainboard/amd/mandolin/ AMD reference boards outside of family 17h and 19h +S: Odd Fixes L: amd_coreboot_org_changes(a)googlegroups.com F: src/mainboard/amd/gardenia/ F: src/mainboard/amd/inagua/ @@ -359,11 +360,6 @@ S: Maintained F: src/mainboard/google/hatch/ -GOOGLE PANTHER MAINBOARD -M: Stefan Reinauer <stefan.reinauer(a)coreboot.org> -S: Supported -F: src/mainboard/google/panther/ - GOOGLE VOLTEER MAINBOARDS M: Nick Vaccaro <nvaccaro(a)chromium.org> S: Maintained @@ -416,13 +412,11 @@ INTEL HARCUVAR_CRB MAINBOARD M: Jeff Daly <jeffd(a)silicom-usa.com> M: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> -M: Suresh Bellampalli <suresh.bellampalli(a)intel.com> M: Mariusz Szafranski <mariuszx.szafranski(a)intel.com> S: Maintained F: src/mainboard/intel/harcuvar/ INTEL STRAGO MAINBOARD -M: Hannah Williams <hannah.williams(a)intel.com> S: Supported F: /src/mainboard/intel/strago/ @@ -508,7 +502,6 @@ OCP TIOGAPASS MAINBOARD M: Jonathan Zhang <jonzhang(a)fb.com> -M: Reddy Chagam <anjaneya.chagam(a)intel.com> M: Johnny Lin <Johnny_Lin(a)wiwynn.com> M: Morgan Jang <Morgan_Jang(a)wiwynn.com> M: Ryback Hung <<Ryback.Hung(a)quantatw.com> @@ -637,14 +630,6 @@ -SYSTEM76 MAINBOARDS -M: Jeremy Soller <jeremy(a)system76.com> -M: Tim Crawford <tcrawford(a)system76.com> -S: Maintained -F: src/mainboard/system76/ - - - SUPERMICRO X10SLM+-F MAINBOARD M: Tristan Corrick <tristan(a)corrick.kiwi> S: Maintained @@ -657,6 +642,14 @@ +SYSTEM76 MAINBOARDS +M: Jeremy Soller <jeremy(a)system76.com> +M: Tim Crawford <tcrawford(a)system76.com> +S: Maintained +F: src/mainboard/system76/ + + + TI MAINBOARDS S: Orphan F: src/mainboard/ti/ -- To view, visit https://review.coreboot.org/c/coreboot/+/68707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6ecaae77df2f2edaf724160bce04c038cbd115e Gerrit-Change-Number: 68707 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: MAINTAINERS: Add orphaned mainboards
by Martin L Roth (Code Review) 23 Oct '22

23 Oct '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68706 ) Change subject: MAINTAINERS: Add orphaned mainboards ...................................................................... MAINTAINERS: Add orphaned mainboards The mainboards are broken out into individual entries in hopes that it will be easier for someone to claim ownership than if they were lumped into a single "Orphaned Mainboards" group. The theory behind this is that a single mainboard is really the easiest piece of coreboot to maintain. Hopefully some less-experienced people will be interested in stepping up to take over ownership of a mainboard. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I9542b3a7cd87fa8656bc0982c08061e9d0513745 --- M MAINTAINERS 1 file changed, 184 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/68706/1 diff --git a/MAINTAINERS b/MAINTAINERS index 093604d..c17b521 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -118,6 +118,24 @@ # Mainboards ################################################################################ +51NB MAINBOARDS +S: Orphan +F: src/mainboard/51nb/ + + + +ACER MAINBOARDS +S: Orphan +F: src/mainboard/acer/ + + + +ADLINK MAINBOARDS +S: Orphan +F: src/mainboard/adlink/ + + + AMD family 17h and 19h reference boards M: Felix Held <felix-coreboot(a)felixheld.de> M: Jason Glenesk <jason.glenesk(a)gmail.com> @@ -144,6 +162,12 @@ +AOPEN MAINBOARDS +S: Orphan +F: src/mainboard/aopen/ + + + APPLE MAINBOARDS M: Evgeny Zinoviev <me(a)ch1p.io> S: Maintained @@ -208,6 +232,30 @@ +BAP MAINBOARDS +S: Orphan +F: src/mainboard/bap/ + + + +BIOSTAR MAINBOARDS +S: Orphan +F: src/mainboard/biostar/ + + + +BOSTENTECH MAINBOARDS +S: Orphan +F: src/mainboard/bostentech/ + + + +CAVIUM MAINBOARDS +S: Orphan +F: src/mainboard/cavium/ + + + CLEVO MAINBOARDS M: Felix Singer <felixsinger(a)posteo.net> M: Michael Niewöhner <foss(a)mniewoehner.de> @@ -215,6 +263,35 @@ F: src/mainboard/clevo/ +COMPULAB MAINBOARDS +S: Orphan +F: src/mainboard/compulab/ + + + +DELL MAINBOARDS +S: Orphan +F: src/mainboard/dell/ + + + +ELMEX MAINBOARDS +S: Orphan +F: src/mainboard/elmex/ + + + +EMULATION MAINBOARDS +S: Orphan +F: src/mainboard/emulation/ + + + +EXAMPLE MAINBOARDS +S: Orphan +F: src/mainboard/example/ + + FACEBOOK FBG1701 MAINBOARD M: Frans Hendriks <fhendriks(a)eltan.com> @@ -230,6 +307,18 @@ +FOXCONN MAINBOARDS +S: Orphan +F: src/mainboard/foxconn/ + + + +GETAC MAINBOARDS +S: Orphan +F: src/mainboard/getac/ + + + GIGABYTE GA-D510UD MAINBOARD M: Angel Pons <th3fanbus(a)gmail.com> S: Maintained @@ -245,6 +334,14 @@ S: Maintained F: src/mainboard/gigabyte/ga-h61m-series/ + + +GIZMOSPHERE MAINBOARDS +S: Orphan +F: src/mainboard/gizmosphere/ + + + GOOGLE REX MAINBOARDS M: Subrata Banik <subratabanik(a)google.com> M: Tarun Tuli <taruntuli(a)google.com> @@ -297,6 +394,7 @@ F: src/mainboard/google/skyrim/ + HP 280 G2 MAINBOARD M: Angel Pons <th3fanbus(a)gmail.com> S: Maintained @@ -304,6 +402,12 @@ +IBASE MAINBOARDS +S: Orphan +F: src/mainboard/ibase/ + + + INTEL D510MO MAINBOARD M: Damien Zammit <damien(a)zamaudio.com> S: Odd Fixes @@ -323,6 +427,11 @@ F: /src/mainboard/intel/strago/ +JETWAY MAINBOARDS +S: Orphan +F: src/mainboard/jetway/ + + KONTRON BSL6 MAINBOARD M: Felix Singer <felixsinger(a)posteo.net> @@ -360,6 +469,7 @@ F: src/mainboard/lenovo/x201/ + LIBRETREND LT1000 MAINBOARD M: Piotr Król <piotr.krol(a)3mdeb.com> M: Michał Żygowski <michal.zygowski(a)3mdeb.com> @@ -368,6 +478,12 @@ +LIPPERT MAINBOARDS (acqyired by Adlink) +S: Orphan +F: src/mainboard/lippert/ + + + MSI H81M-P33 MAINBOARD M: Angel Pons <th3fanbus(a)gmail.com> S: Maintained @@ -379,6 +495,8 @@ S: Maintained F: src/mainboard/msi/ms7d25/ + + OCP DELTALAKE MAINBOARD M: Arthur Heymans <arthur(a)aheymans.xyz> M: Christian Walter <christian.walter(a)9elements.com> @@ -416,6 +534,12 @@ +PINE64 MAINBOARDS +S: Orphan +F: src/mainboard/pine64/ + + + PORTWELL PQ-M107 MAINBOARD M: Frans Hendriks <fhendriks(a)eltan.com> M: Erik van den Bogaert <ebogaert(a)eltan.com> @@ -454,6 +578,18 @@ +RAZER MAINBOARDS +S: Orphan +F: src/mainboard/razer/ + + + +RODA MAINBOARDS +S: Orphan +F: src/mainboard/roda/ + + + SAMSUNG CHROMEOS MAINBOARDS M: Matt DeVillier <MrChromebox(a)gmail.com> S: Maintained @@ -462,6 +598,18 @@ +SAPPHIRE MAINBOARDS +S: Orphan +F: src/mainboard/sapphire/ + + + +SCALEWAY MAINBOARDS +S: Orphan +F: src/mainboard/scaleway/ + + + SIEMENS CHILI MAINBAORD M: Felix Singer <felixsinger(a)posteo.net> M: Nico Huber <nico.h(a)gmx.de> @@ -476,6 +624,12 @@ +SIFIVE MAINBOARDS +S: Orphan +F: src/mainboard/sifive/ + + + STAR LABS MAINBOARDS M: Sean Rhodes <sean(a)starlabs.systems> S: Maintained @@ -501,6 +655,18 @@ S: Maintained F: src/mainboard/supermicro/x11-lga1151-series/ + + +TI MAINBOARDS +S: Orphan +F: src/mainboard/ti/ + + + +UP MAINBOARDS +S: Orphan +F: src/mainboard/up/ + ################################################################################ # Architectures ################################################################################ -- To view, visit https://review.coreboot.org/c/coreboot/+/68706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9542b3a7cd87fa8656bc0982c08061e9d0513745 Gerrit-Change-Number: 68706 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: MAINTAINERS: Update instructions
by Martin L Roth (Code Review) 23 Oct '22

23 Oct '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68705 ) Change subject: MAINTAINERS: Update instructions ...................................................................... MAINTAINERS: Update instructions Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I0e06ac5f92109757143897f3d331aeea0cefe4b9 --- M MAINTAINERS 1 file changed, 21 insertions(+), 30 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/68705/1 diff --git a/MAINTAINERS b/MAINTAINERS index 131aea6..093604d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14,27 +14,17 @@ easier on the maintainers. Not all of these guidelines matter for every trivial patch so apply some common sense. -1. Always _test_ your changes, however small, on at least 1 or - 2 people, preferably many more. -2. Try to release a few ALPHA test versions to gerrit. Announce - them onto the coreboot mailing list and IRC channel and await - results. This is especially important on coreboot core changes, - but also for device drivers, because often that's the only way - you will find things like the fact revision 3 chipset needs - a magic fix you didn't know about, or some clown changed the - chips on a board and not its name. (Don't laugh!) +1. Make sure your changes compile correctly in multiple configurations. In + particular check that changes work for various boards in the tree that + it affects: -3. Make sure your changes compile correctly in multiple - configurations. In particular check that changes work for all - boards in the tree (use abuild!) + Test with: `util/abuild/abuild -c $(nproc) -t vendor/boardname` -4. When you are happy with a change make it generally available for +2. When you are happy with a change make it generally available for testing in gerrit and await feedback. -5. Make your patch available through coreboot's gerrit code review - system, and add the relevant maintainer from this list as a code - reviewer. Be prepared to get your changes sent back with seemingly +3. Be prepared to get your changes sent back with seemingly silly requests about formatting and variable names. These aren't as silly as they seem. One job the maintainers do is to keep things looking the same. Sometimes this means that the clever @@ -45,36 +35,27 @@ (util/lint/checkpatch.pl) to catch trival style violations. See https://www.coreboot.org/Coding_Style for guidance here. - PLEASE add the maintainers that are generated by - util/scripts/get_maintainer.pl as reviewers. The results returned - by the script will be best if you have git installed and are - making your changes in a branch derived from coreboot.org's latest - git tree. - - PLEASE try to include any credit lines you want added with the - patch. It avoids people being missed off by mistake and makes - it easier to know who wants adding and who doesn't. - PLEASE document known bugs. If it doesn't work for everything or does something very odd once a month document it. - PLEASE remember that submissions must be made under the terms + ALWAYS remember that submissions are be made under the terms of the OSDL certificate of contribution and should include a Signed-off-by: line. The current version of this "Developer's Certificate of Origin" (DCO) is listed at https://www.coreboot.org/Development_Guidelines#Sign-off_Procedure. -6. Make sure you have the right to send any changes you make. If you +4. Make sure you have the right to send any changes you make. If you do changes at work you may find your employer owns the patch not you. -7. Happy hacking. +5. Happy hacking. Descriptions of section entries: M: Maintainer: FullName <address@domain> Must be registered to Gerrit (https://review.coreboot.org/). - Should have experience with upstream coreboot development. + Should have experience with upstream coreboot development and + +2 rights. R: Designated reviewer: FullName <address@domain> These reviewers should be CCed on patches. L: Mailing list that is relevant to this area -- To view, visit https://review.coreboot.org/c/coreboot/+/68705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e06ac5f92109757143897f3d331aeea0cefe4b9 Gerrit-Change-Number: 68705 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/brya: Enable SaGv for brask variants
by 9elements QA (Code Review) 23 Oct '22

23 Oct '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68646 ) Change subject: mb/google/brya: Enable SaGv for brask variants ...................................................................... Patch Set 3: Automatic boot test returned (PASS/FAIL/TOTAL): 14 / 2 / 16 FAIL: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/130321 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/130320 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/130319 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/130318 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/130317 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/130316 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/130315 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/130314 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/130313 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/130312 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/130311 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/130310 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/130309 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/130308 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/130307 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/130306 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/68646 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib5d1e39b3f901606e2f1449e4ed40d53696562ed Gerrit-Change-Number: 68646 Gerrit-PatchSet: 3 Gerrit-Owner: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sun, 23 Oct 2022 01:25:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Set the correct serial settings for AMD SOCs
by Matt DeVillier (Code Review) 23 Oct '22

23 Oct '22

Attention is currently required from: Sean Rhodes, Martin L Roth, Stefan Reinauer. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68596 ) Change subject: payloads/edk2: Set the correct serial settings for AMD SOCs ...................................................................... Patch Set 1: (2 comments) File payloads/external/edk2/Makefile: https://review.coreboot.org/c/coreboot/+/68596/comment/68236ea7_fddc9c10 PS1, Line 103: CONFIG_SOC_AMD_COMMON there's a handful of pre-Zen platforms that select this Kconfig, do they use MMIO for serial as well? https://review.coreboot.org/c/coreboot/+/68596/comment/34e9152b_8368a042 PS1, Line 105: 0xfedc9000 should probably pass this in as a Kconfig -- To view, visit https://review.coreboot.org/c/coreboot/+/68596 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70630d21bbdb21f2aa8cbaeb3e842629b97af3ba Gerrit-Change-Number: 68596 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 23 Oct 2022 00:47:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/siemens/mc_apl*: Enable early PCI bridge before FSP-M
by 9elements QA (Code Review) 23 Oct '22

23 Oct '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68223 ) Change subject: mb/siemens/mc_apl*: Enable early PCI bridge before FSP-M ...................................................................... Patch Set 5: Automatic boot test returned (PASS/FAIL/TOTAL): 14 / 2 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/130304 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/130303 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/130302 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/130301 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/130300 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/130299 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/130298 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/130297 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/130296 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/130295 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/130294 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/130293 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/130292 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/130291 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/130290 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/130289 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/68223 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If782bfdd5f499dd47c085a0a16b4b15832bc040e Gerrit-Change-Number: 68223 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sun, 23 Oct 2022 00:25:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/baseboard: Update gpio setting for touchscreen IRQ
by 9elements QA (Code Review) 23 Oct '22

23 Oct '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68638 ) Change subject: mb/google/skyrim/var/baseboard: Update gpio setting for touchscreen IRQ ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 12 / 4 / 16 FAIL: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/130287 FAIL: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/130286 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/130285 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/130284 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/130283 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/130282 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/130281 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/130280 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/130279 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/130278 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/130277 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/130276 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/130275 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/130274 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/130273 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/130272 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/68638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iccfe5b01f10899c43151762e4730a05990afa602 Gerrit-Change-Number: 68638 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chao Gui <chaogui(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sun, 23 Oct 2022 00:11:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: MAINTAINERS: Add Matt DeVillier to the release team
by Martin L Roth (Code Review) 23 Oct '22

23 Oct '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68704 ) Change subject: MAINTAINERS: Add Matt DeVillier to the release team ...................................................................... MAINTAINERS: Add Matt DeVillier to the release team Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I6f5c10618edb87d2dc12c14187c4620d8675a443 --- M MAINTAINERS 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/68704/1 diff --git a/MAINTAINERS b/MAINTAINERS index dc4c3af..131aea6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -992,6 +992,7 @@ M: Jason Glenesk <jason.glenesk(a)gmail.com> M: Angel Pons <th3fanbus(a)gmail.com> M: Martin Roth <gaumless(a)gmail.com> +M: Matt DeVillier <MrChromebox(a)gmail.com> S: Maintained F: Documentation/releases/ F: util/release/ -- To view, visit https://review.coreboot.org/c/coreboot/+/68704 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f5c10618edb87d2dc12c14187c4620d8675a443 Gerrit-Change-Number: 68704 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: configs: Add skyrim config with binaries
by Martin L Roth (Code Review) 23 Oct '22

23 Oct '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68320 ) Change subject: configs: Add skyrim config with binaries ...................................................................... configs: Add skyrim config with binaries We've seen failures because the binaries were not being built into the image. In particular, the APCB is modified by the coreboot build process, so if the APCB isn't built correctly to support the correct number of SPDs, the build can fail. The mendocino FSP binaries are not yet pushed, so the build is currently pointing at the cezanne binaries. The mendocino FSP will be pushed when the mendocino chips are released for sale. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I31d11c5327416f4339930373c447531ae9f79d28 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68320 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jon Murphy <jpmurphy(a)google.com> --- A configs/config.google_skyrim.with_binaries 1 file changed, 51 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Jon Murphy: Looks good to me, approved diff --git a/configs/config.google_skyrim.with_binaries b/configs/config.google_skyrim.with_binaries new file mode 100644 index 0000000..d0227af --- /dev/null +++ b/configs/config.google_skyrim.with_binaries @@ -0,0 +1,29 @@ +CONFIG_TIMESTAMPS_ON_CONSOLE=y +CONFIG_USE_AMD_BLOBS=y +CONFIG_VENDOR_GOOGLE=y +CONFIG_VGA_BIOS_ID="1002,1506" +CONFIG_AMD_FWM_POSITION_INDEX=3 +CONFIG_VGA_BIOS=y +CONFIG_CONSOLE_POST=y +CONFIG_BOARD_GOOGLE_SKYRIM=y +CONFIG_CONSOLE_CBMEM_BUFFER_SIZE=0x20000 +CONFIG_SPL_TABLE_FILE="3rdparty/amd_blobs/mendocino/PSP/TypeId0x55_SplTableBl_MDN.sbin" +CONFIG_VGA_BIOS_FILE="3rdparty/amd_blobs/mendocino/MdnGenericVbios.bin" +CONFIG_FSP_M_FILE="3rdparty/amd_blobs/cezanne/CEZANNE_M.fd" +CONFIG_FSP_S_FILE="3rdparty/amd_blobs/cezanne/CEZANNE_S.fd" +CONFIG_ASYNC_FILE_LOADING=y +CONFIG_PSP_SOFTFUSE_BITS="34 28" +CONFIG_UART_PCI_ADDR=0x0 +CONFIG_RUN_FSP_GOP=y +CONFIG_SUBSYSTEM_VENDOR_ID=0x0000 +CONFIG_SUBSYSTEM_DEVICE_ID=0x0000 +CONFIG_I2C_TRANSFER_TIMEOUT_US=500000 +CONFIG_DISPLAY_HOBS=y +CONFIG_DISPLAY_UPD_DATA=y +CONFIG_ADD_FSP_BINARIES=y +CONFIG_POST_IO_PORT=0x80 +CONFIG_PAYLOAD_NONE=y +CONFIG_DISPLAY_FSP_CALLS_AND_STATUS=y +CONFIG_DISPLAY_FSP_HEADER=y +CONFIG_FATAL_ASSERTS=y +CONFIG_DEBUG_SMI=y -- To view, visit https://review.coreboot.org/c/coreboot/+/68320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31d11c5327416f4339930373c447531ae9f79d28 Gerrit-Change-Number: 68320 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: Docs/releases: Update release checklist document
by Martin L Roth (Code Review) 23 Oct '22

23 Oct '22

Attention is currently required from: Felix Singer, Jason Glenesk, Angel Pons. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68500 ) Change subject: Docs/releases: Update release checklist document ...................................................................... Patch Set 1: (3 comments) File Documentation/releases/checklist.md: https://review.coreboot.org/c/coreboot/+/68500/comment/1086952f_0120f63c PS1, Line 29: > Hmmm, this file seems to use single spaces after periods. […] That seems very nitpicky. Personally I don't think it matters much. If someone wants to go back through later and change it, that's fine. https://review.coreboot.org/c/coreboot/+/68500/comment/2cbc470d_ce71b101 PS1, Line 12: Our releases aren't primarily a vehicle for code that is stable across : all boards: The logistics of testing the more than 100 boards that are : spread out all continents (except Antarctica, probably) on a given tree : state are prohibitive for project of our size. : : Instead, the releases are regular breakpoints that serve multiple : purposes: They support cooperation between multiple groups (corporations : or otherwise) in that it's easier to keep source trees synchronized : based on a limited set of commits. They allow a quick assessment of the : age of any given build or source tree based on its git version (4.8-1234 : was merged into master a few months after 4.8, which came out in April : of 2018. 4.0-21718's age is harder to guess). : : And finally we use releases to as points in time where we remove old : code: Once we decide that a certain part of coreboot gets in the way of : future development, we announce on the next release that we intend to : remove that part - and everything that depends on it - after the : following release. So removing feature FOO will be announced in release : X for release X+1. The first commit after X+1 is fair game for such : removal. > So this section was reflowed. I reflowed a bunch of sections because they weren't under 72 characters. https://review.coreboot.org/c/coreboot/+/68500/comment/248edbbf_f5b0beaf PS1, Line 73: - [ ] Run `util/vboot_list/vboot_list.sh` script to update the list of : boards supported by vboot. > Shouldn't we do this when doing the release? Sorry, what do you mean "when doing the release"? Everything in this list is done as part part of doing the release. Do you mean closer to the day of the release? -- To view, visit https://review.coreboot.org/c/coreboot/+/68500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a79cf92620755e19266faaf593dc2657acdb16f Gerrit-Change-Number: 68500 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 22 Oct 2022 22:43:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022