coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[M] Change in coreboot[master]: mb/google/geralt: Configure firmware display for eDP panel
by Rex-BC Chen (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68490 ) Change subject: mb/google/geralt: Configure firmware display for eDP panel ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/geralt/display.h: https://review.coreboot.org/c/coreboot/+/68490/comment/9d25fa6d_16311717 PS5, Line 8: bool > If there's no good reason, please use `int` as the return type. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67e0699c976c6f85e69d40d77154420c983b715e Gerrit-Change-Number: 68490 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 24 Oct 2022 03:39:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/geralt: Configure firmware display for eDP panel
by Rex-BC Chen (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68490 ) Change subject: mb/google/geralt: Configure firmware display for eDP panel ...................................................................... Patch Set 6: (3 comments) File src/mainboard/google/geralt/display.c: https://review.coreboot.org/c/coreboot/+/68490/comment/b453f199_d4671336 PS5, Line 47: false > -1 Done https://review.coreboot.org/c/coreboot/+/68490/comment/95061ba6_665ae39e PS5, Line 63: true > 0 Done File src/mainboard/google/geralt/mainboard.c: https://review.coreboot.org/c/coreboot/+/68490/comment/8c7d77e3_cdc2f4a6 PS5, Line 15: ! > And here Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67e0699c976c6f85e69d40d77154420c983b715e Gerrit-Change-Number: 68490 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 24 Oct 2022 03:39:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Update mtcmos settings for display and audio
by Rex-BC Chen (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68489 ) Change subject: soc/mediatek/mt8188: Update mtcmos settings for display and audio ...................................................................... Patch Set 6: (2 comments) File src/soc/mediatek/common/mtcmos.c: https://review.coreboot.org/c/coreboot/+/68489/comment/446cf4f1_8bb910bc PS5, Line 17: { > Move to next line […] removed https://review.coreboot.org/c/coreboot/+/68489/comment/01494d0d_2631cce2 PS5, Line 24: mtcmos_set_scpd_ext_buck_iso(pd); > If this is controlled by `SCPD_EXT_BUCK_ISO`, why do we need the weak function? Can't we write […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f00bda0cc5c7f8dea55a564a0ff10ae601115b3 Gerrit-Change-Number: 68489 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 24 Oct 2022 03:39:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: Add eDP support for firmware display
by Rex-BC Chen (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68488 ) Change subject: soc/mediatek/mt8188: Add eDP support for firmware display ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68488/comment/8d038ed5_13770247 PS5, Line 9: Geralt > MT8188 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6441a36557b097e041bc081b907eb60b56c9fbe6 Gerrit-Change-Number: 68488 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 24 Oct 2022 03:39:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/mediatek/mt8188: Add ddp driver to support eDP output
by Rex-BC Chen (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68487 ) Change subject: soc/mediatek/mt8188: Add ddp driver to support eDP output ...................................................................... Patch Set 6: (8 comments) File src/soc/mediatek/mt8188/ddp.c: https://review.coreboot.org/c/coreboot/+/68487/comment/f8b07a04_26bacc13 PS5, Line 1: > `OR MIT`? […] Done see CB:68759 https://review.coreboot.org/c/coreboot/+/68487/comment/273863a6_3edea540 PS5, Line 82: write32(&regs->size, width << 16 | height); > Blank line above. Done https://review.coreboot.org/c/coreboot/+/68487/comment/40a71b4a_4d3f24ab PS5, Line 90: write32(&regs->size, width << 16 | height); > Same Done https://review.coreboot.org/c/coreboot/+/68487/comment/a5c71b96_4f99a176 PS5, Line 97: = 0 > No need to initialize. Done https://review.coreboot.org/c/coreboot/+/68487/comment/bc287819_27e2a4f0 PS5, Line 98: u32 pixel_clk = width * height * vrefresh; > const Done https://review.coreboot.org/c/coreboot/+/68487/comment/036d7fd8_70f160a5 PS5, Line 131: write32 > write32p Done File src/soc/mediatek/mt8188/include/soc/ddp.h: https://review.coreboot.org/c/coreboot/+/68487/comment/5f958cdb_d2f4f3bf PS5, Line 54: static struct mmsys_cfg_regs *const mmsys_cfg = (void *)VDOSYS0_BASE; > Blank line above. Done https://review.coreboot.org/c/coreboot/+/68487/comment/9b8c1877_1c132565 PS5, Line 167: static struct disp_mutex_regs *const disp_mutex = (void *)DISP_MUTEX_BASE; > Blank line above. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc0a878c609818fedd298c141bb39469fd2f6388 Gerrit-Change-Number: 68487 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 24 Oct 2022 03:38:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek: Add support for input 1P mode of dp_intf
by Rex-BC Chen (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68485 ) Change subject: soc/mediatek: Add support for input 1P mode of dp_intf ...................................................................... Patch Set 4: (1 comment) File src/soc/mediatek/common/dp/include/soc/dp_intf.h: https://review.coreboot.org/c/coreboot/+/68485/comment/ac8a4077_255c22b4 PS3, Line 263: extern struct mtk_dpintf dpintf_data; > Can this be `const` (also for the first argument of `mtk_dpintf_` functions)? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68485 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d138b0ff75e005518bc8fcce06df20924b2a6ba Gerrit-Change-Number: 68485 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 24 Oct 2022 03:37:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: replace SPDX identifiers to GPL-2.0-only OR MIT
by Rex-BC Chen (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin. Rex-BC Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68759 ) Change subject: soc/mediatek/mt8188: replace SPDX identifiers to GPL-2.0-only OR MIT ...................................................................... soc/mediatek/mt8188: replace SPDX identifiers to GPL-2.0-only OR MIT For MT8188, the SPDX identifiers are all GPL-2.0-only OR MIT, so replace "GPL-2.0-only" with "GPL-2.0-only OR MIT". Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com> Change-Id: I5ef6c488b7ef937f6e298670ea75d306b9fe7491 --- M src/soc/mediatek/mt8188/include/soc/tracker.h 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/68759/1 diff --git a/src/soc/mediatek/mt8188/include/soc/tracker.h b/src/soc/mediatek/mt8188/include/soc/tracker.h index 6555d70..3534dd5 100644 --- a/src/soc/mediatek/mt8188/include/soc/tracker.h +++ b/src/soc/mediatek/mt8188/include/soc/tracker.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ #ifndef SOC_MEDIATEK_MT8188_TRACKER_H #define SOC_MEDIATEK_MT8188_TRACKER_H -- To view, visit https://review.coreboot.org/c/coreboot/+/68759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ef6c488b7ef937f6e298670ea75d306b9fe7491 Gerrit-Change-Number: 68759 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: mb/google/geralt: Configure firmware display for eDP panel
by Rex-BC Chen (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Hello Hung-Te Lin, build bot (Jenkins), Angel Pons, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68490 to look at the new patch set (#6). Change subject: mb/google/geralt: Configure firmware display for eDP panel ...................................................................... mb/google/geralt: Configure firmware display for eDP panel Add eDP panel power-on sequences and initialize the display in the ramstage. BUG=b:244208960 TEST=see firmware display using eDP panel in MT8188 EVB. Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com> Change-Id: I67e0699c976c6f85e69d40d77154420c983b715e --- M src/mainboard/google/geralt/Kconfig M src/mainboard/google/geralt/Makefile.inc A src/mainboard/google/geralt/display.c A src/mainboard/google/geralt/display.h M src/mainboard/google/geralt/gpio.h M src/mainboard/google/geralt/mainboard.c 6 files changed, 107 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/68490/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/68490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67e0699c976c6f85e69d40d77154420c983b715e Gerrit-Change-Number: 68490 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8188: Update mtcmos settings for display and audio
by Rex-BC Chen (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Hello Hung-Te Lin, build bot (Jenkins), Angel Pons, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68489 to look at the new patch set (#6). Change subject: soc/mediatek/mt8188: Update mtcmos settings for display and audio ...................................................................... soc/mediatek/mt8188: Update mtcmos settings for display and audio - For display, only vdosys0_pwr_con and edp_tx_pwr_con settings are required. - For audio, it requires powering on adsp_ao_pwr_con, adsp_infra_pwr_con and audio_pwr_con. - Add new power domain data `ext_buck_iso_bits` for buck isolation control. BUG=b:244208960 TEST=access display registers successfully. Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com> Change-Id: I7f00bda0cc5c7f8dea55a564a0ff10ae601115b3 --- M src/soc/mediatek/common/include/soc/mtcmos.h M src/soc/mediatek/common/mtcmos.c M src/soc/mediatek/mt8188/Makefile.inc M src/soc/mediatek/mt8188/include/soc/spm.h 4 files changed, 36 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/68489/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/68489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f00bda0cc5c7f8dea55a564a0ff10ae601115b3 Gerrit-Change-Number: 68489 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: Add eDP support for firmware display
by Rex-BC Chen (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Hello Hung-Te Lin, build bot (Jenkins), Angel Pons, Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68488 to look at the new patch set (#6). Change subject: soc/mediatek/mt8188: Add eDP support for firmware display ...................................................................... soc/mediatek/mt8188: Add eDP support for firmware display MT8188 supports eDP as internal display interface. BUG=b:244208960 TEST=emerge-geralt coreboot. Signed-off-by: Bo-Chen Chen <rex-bc.chen(a)mediatek.com> Change-Id: I6441a36557b097e041bc081b907eb60b56c9fbe6 --- M src/soc/mediatek/mt8188/Makefile.inc A src/soc/mediatek/mt8188/dp_intf.c M src/soc/mediatek/mt8188/include/soc/addressmap.h 3 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/68488/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/68488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6441a36557b097e041bc081b907eb60b56c9fbe6 Gerrit-Change-Number: 68488 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022