Attention is currently required from: Solomon Alan-Dei.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68941
to look at the new patch set (#3).
Change subject: arch/x86: fix copying beyond eos in smbios struct
......................................................................
arch/x86: fix copying beyond eos in smbios struct
Coverity scan indicated there may be a copy beyond
eos in smbios struct declared in smbios.h but the
code is intentional.
This type of issue is fixed by assigning
the source for the text string to a
const pointer, and passing the pointer
to smbios_add_string calls in smbios_defaults.c.
Found-by: Coverity(CID: 1487449)
Signed-off-by: Solomon Alan-Dei <alandei.solomon(a)gmail.com>
Change-Id: I48c5903a2a3b59c9f0e89cd96ef1580b3a229771
---
M src/arch/x86/smbios_defaults.c
1 file changed, 24 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/68941/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/68941
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48c5903a2a3b59c9f0e89cd96ef1580b3a229771
Gerrit-Change-Number: 68941
Gerrit-PatchSet: 3
Gerrit-Owner: Solomon Alan-Dei <alandei.solomon(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Solomon Alan-Dei <alandei.solomon(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Solomon Alan-Dei.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68941 )
Change subject: src/arch/x86: fix copying beyond eos in smbios struct
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68941/comment/c3222fb4_7a96ca9d
PS2, Line 7: src/
Please remove.
https://review.coreboot.org/c/coreboot/+/68941/comment/3f74529b_97c7be9d
PS2, Line 9: Coverity scan indicated there may be a copy beyond eos in
: smbios struct declared in smbios.h but the code is intentional.
: This type of issue is fixed by assigning the source for the text string
: to a const pointer, and passing the pointer to smbios_add_string calls
: in smbios_defaults.c
Please reflow for 72 characters per line, and add exactly one blank line between paragraphs.
Please also add a dot/period at the end of sentences.
https://review.coreboot.org/c/coreboot/+/68941/comment/42b650b3_21ca1406
PS2, Line 14: CID: 1487449
Found-by: Coverity (CID 1487449: …)
Patchset:
PS2:
Thank you for the update.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68941
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48c5903a2a3b59c9f0e89cd96ef1580b3a229771
Gerrit-Change-Number: 68941
Gerrit-PatchSet: 2
Gerrit-Owner: Solomon Alan-Dei <alandei.solomon(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Solomon Alan-Dei <alandei.solomon(a)gmail.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 11:09:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Maxim Polyakov, ron minnich.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59958 )
Change subject: util/docker/coreboot.org-status: Rewrite parser
......................................................................
Patch Set 16:
(6 comments)
Patchset:
PS16:
Maxim, thanks for the review!
File util/docker/coreboot.org-status/board-status.html/boards.go:
https://review.coreboot.org/c/coreboot/+/59958/comment/8822dc76_55515e75
PS11, Line 20: if len(spl) != 2 {
> An empty line, or one without a colon returns an array with less than 2 elements. […]
Clarified in a comment.
File util/docker/coreboot.org-status/board-status.html/logs.go:
https://review.coreboot.org/c/coreboot/+/59958/comment/0b8c8f17_c5bdae45
PS15, Line 26: _
> logging of this error is not required? […]
It's put on os.Stderr now.
https://review.coreboot.org/c/coreboot/+/59958/comment/568e5f5c_5b697f75
PS15, Line 61: item
> What happens if the string doesn't contain the ":" character? […]
It's caught now.
https://review.coreboot.org/c/coreboot/+/59958/comment/fcc73231_ea53173e
PS15, Line 93: [3]
> check len(pieces) needed?
Done
File util/docker/coreboot.org-status/board-status.html/status-to-html.go:
https://review.coreboot.org/c/coreboot/+/59958/comment/17f5ded2_67989795
PS15, Line 71: dirs
> Why are you using the channel here? Why not a slice? In my opinion, it would be better to abandon mu […]
I used it more as a structuring mechanism, akin to unix pipes. I don't see how it's easier if I collect everything in an array and pass that one around.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59958
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4fab86d24088e4f9eff434c21ce9caa077f3f9e2
Gerrit-Change-Number: 59958
Gerrit-PatchSet: 16
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 10:55:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org>
Comment-In-Reply-To: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Comment-In-Reply-To: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Georgi, Martin L Roth, ron minnich.
Hello build bot (Jenkins), Martin L Roth, Maxim Polyakov, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59958
to look at the new patch set (#16).
Change subject: util/docker/coreboot.org-status: Rewrite parser
......................................................................
util/docker/coreboot.org-status: Rewrite parser
The current tool is a shell script that mixes data collection and HTML
generation and is generally a pain to work with. It takes 15 minutes to
run.
The new tool is written in go, collects all data first, then generates
the output HTML from the data and a single template, and finishes in
10 seconds.
The goal in this version is to produce output as similar as possible to
the output of the shell script. Some difference will remain because the
shell script returns some trash data whose reproduction would require
more effort than is worth.
Change-Id: I4fab86d24088e4f9eff434c21ce9caa077f3f9e2
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
---
A util/docker/coreboot.org-status/board-status.html/boards.go
A util/docker/coreboot.org-status/board-status.html/go.mod
A util/docker/coreboot.org-status/board-status.html/go.sum
A util/docker/coreboot.org-status/board-status.html/logs.go
A util/docker/coreboot.org-status/board-status.html/status-to-html.go
A util/docker/coreboot.org-status/board-status.html/templates/board-status.html
A util/docker/coreboot.org-status/board-status.html/types.go
7 files changed, 1,179 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/59958/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/59958
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4fab86d24088e4f9eff434c21ce9caa077f3f9e2
Gerrit-Change-Number: 59958
Gerrit-PatchSet: 16
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Tim Van Patten, Fred Reitberger, Felix Held.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68649 )
Change subject: soc/amd/mendocino: Enhance DPTC_INPUT to support 16 DPTC thermal parameters
......................................................................
Patch Set 9:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68649/comment/9ebccf38_dde54aeb
PS6, Line 7: Enhence
> typo
Done
File src/soc/amd/mendocino/root_complex.c:
https://review.coreboot.org/c/coreboot/+/68649/comment/6cdf0aa8_3bc3e629
PS6, Line 32: stt_AlphaApu
> nit: `_sttAlphaApu`
Done
https://review.coreboot.org/c/coreboot/+/68649/comment/ac79a874_29a9ec4a
PS6, Line 46: _sustained
> `_spptTimeConst`
Done
https://review.coreboot.org/c/coreboot/+/68649/comment/229413ec_1c6f8463
PS6, Line 86: _sttSkinTempLimit
> nit: `_sttSkinTempLimitApu`
Done
File src/soc/amd/mendocino/root_complex.c:
https://review.coreboot.org/c/coreboot/+/68649/comment/61028162_ac985dc0
PS9, Line 264: /* Profile B */
> We need to introduce a way to control filling out these tables only for supported variants, since no […]
I will submit a new CL for new config.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68649
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d6a00f0eca0b0941860b9bc75da41d7a10d60e8
Gerrit-Change-Number: 68649
Gerrit-PatchSet: 9
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 28 Oct 2022 10:45:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Solomon Alan-Dei.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68941
to look at the new patch set (#2).
Change subject: src/arch/x86: fix copying beyond eos in smbios struct
......................................................................
src/arch/x86: fix copying beyond eos in smbios struct
Coverity scan indicated there may be a copy beyond eos in
smbios struct declared in smbios.h but the code is intentional.
This type of issue is fixed by assigning the source for the text string
to a const pointer, and passing the pointer to smbios_add_string calls
in smbios_defaults.c
CID: 1487449
Signed-off-by: Solomon Alan-Dei <alandei.solomon(a)gmail.com>
Change-Id: I48c5903a2a3b59c9f0e89cd96ef1580b3a229771
---
M src/arch/x86/smbios_defaults.c
1 file changed, 22 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/68941/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68941
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48c5903a2a3b59c9f0e89cd96ef1580b3a229771
Gerrit-Change-Number: 68941
Gerrit-PatchSet: 2
Gerrit-Owner: Solomon Alan-Dei <alandei.solomon(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Solomon Alan-Dei <alandei.solomon(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Raul Rangel, Jason Nien, Caveh Jalali, Isaac Lee, Tim Wawrzynczak, Jon Murphy, Martin Roth, Tim Van Patten, Eric Peers, Moises Garcia, Karthik Ramasubramanian, Boris Mittelberg.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67793 )
Change subject: ec/google/chromec: Add DPTC support for host event 1/2/9
......................................................................
Patch Set 13:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67793/comment/078b77b2_10f1f3d1
PS11, Line 7: ec/google/chromec: Host event support of DTTS
> nit: This CL is adding DPTC calls to specific host events. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/67793
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I156a9d138ccac7f75cc0dd0d827f7a721fcbc782
Gerrit-Change-Number: 67793
Gerrit-PatchSet: 13
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Moises Garcia <moisesgarcia(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Attention: Moises Garcia <moisesgarcia(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 10:19:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com>
Gerrit-MessageType: comment