Attention is currently required from: Michał Żygowski, Piotr Król.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68920 )
Change subject: mb/protectli/vault_cml: Disable PTT and SPI TPM
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/68920
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3764e085f2eb5ae957b9087d150320def7af4fc6
Gerrit-Change-Number: 68920
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 09:51:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68919 )
Change subject: intelblocks/cse: Add functions to check and change PTT state
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/68919/comment/6851dd96_1ad9090d
PS1, Line 1223: printk(BIOS_DEBUG, "HECI: FW FEATURE SHIPMENT TIME STATE OVERRIDE success\n");
Shouldn't this be before the `do_global_reset()`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68919
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8426c46eada2d503d6ee72324c5d0025da3f2028
Gerrit-Change-Number: 68919
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 09:49:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons.
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68938
to look at the new patch set (#4).
Change subject: ec/starlabs/merlin: Add support for enabling the mirror flag
......................................................................
ec/starlabs/merlin: Add support for enabling the mirror flag
When enabled, the EC will mirror the firmware contained inside the
coreboot ROM. This allows it to be updated at the same time as
coreboot.
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Ief088e012b65be32648f581fc3190e1000bca241
---
M src/ec/starlabs/merlin/Kconfig
M src/ec/starlabs/merlin/ec.h
M src/ec/starlabs/merlin/ite.c
M src/ec/starlabs/merlin/variants/adl/ecdefs.h
M src/ec/starlabs/merlin/variants/apl/ecdefs.h
M src/ec/starlabs/merlin/variants/cezanne/ecdefs.h
M src/ec/starlabs/merlin/variants/cml/ecdefs.h
M src/ec/starlabs/merlin/variants/glk/ecdefs.h
M src/ec/starlabs/merlin/variants/glkr/ecdefs.h
M src/ec/starlabs/merlin/variants/kbl/ecdefs.h
M src/ec/starlabs/merlin/variants/merlin/ecdefs.h
M src/ec/starlabs/merlin/variants/tgl/ecdefs.h
12 files changed, 54 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/68938/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/68938
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief088e012b65be32648f581fc3190e1000bca241
Gerrit-Change-Number: 68938
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Raul Rangel, Jason Nien, Paul Menzel, Jon Murphy, Nelson Ye, Martin Roth, Tim Van Patten, Karthik Ramasubramanian.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68742 )
Change subject: mb/google/skyrim/var/winterhold: Update DPTC setting for EVT-SMT
......................................................................
Patch Set 3:
(11 comments)
Patchset:
PS3:
Thanks for the reminder, I have update the table follow b/232946420 comment#116 and #129. Some items need AMD help to encode and AMD help to provide on b/232946420 #129.
File src/mainboard/google/skyrim/variants/winterhold/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68742/comment/515585fa_15b4ed4b
PS2, Line 9: 30000
> Looking at: https://b.corp.google.com/issues/232946420#comment116 […]
Done
https://review.coreboot.org/c/coreboot/+/68742/comment/3eccaea4_ecd5ef9a
PS2, Line 10: 12000
> This should be `15000`.
Thanks for the reminder, I have update the table follow b/232946420 comment#116 and #129. Some items need AMD help to encode and AMD help to provide on b/232946420 #129.
https://review.coreboot.org/c/coreboot/+/68742/comment/98bf3207_319b39f6
PS2, Line 11: 5
> `4`
Done
https://review.coreboot.org/c/coreboot/+/68742/comment/42299b87_1f501b30
PS2, Line 18: 0
> `0. […]
Done
https://review.coreboot.org/c/coreboot/+/68742/comment/1576fe99_c55a397d
PS2, Line 19: 0
> `0. […]
Done
https://review.coreboot.org/c/coreboot/+/68742/comment/5600b799_9056ad5b
PS2, Line 20: 0
> `-0. […]
Thanks for the reminder, I have update the table follow b/232946420 comment#116 and #129. Some items need AMD help to encode and AMD help to provide on b/232946420 #129.
https://review.coreboot.org/c/coreboot/+/68742/comment/0c481819_6218a900
PS2, Line 21: 0x6666
> `0. […]
Done
https://review.coreboot.org/c/coreboot/+/68742/comment/e495c46b_8ae538e5
PS2, Line 22: 0x3200
> `48`
Done
https://review.coreboot.org/c/coreboot/+/68742/comment/d9c68222_b126ae26
PS2, Line 23: 0x21
> `0. […]
Done
https://review.coreboot.org/c/coreboot/+/68742/comment/5d9fc5ea_c3f61074
PS2, Line 24: 0xCCD
> `0. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68742
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4aa90304e1e7bda7d580de2582129191e9eb0e76
Gerrit-Change-Number: 68742
Gerrit-PatchSet: 3
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Isaac Lee <isaaclee(a)google.com>
Gerrit-CC: Nelson Ye <nelson_ye(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Nelson Ye <nelson_ye(a)compal.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 09:15:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68937 )
Change subject: mb/starlabs/*: Change the local version to Kconfig
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68937
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib11ddd04c44f47b94f4fc9eaed278d554d581b0f
Gerrit-Change-Number: 68937
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Fri, 28 Oct 2022 09:13:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Mario Scheithauer, Angel Pons, Werner Zeh, Jan Samek.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68908 )
Change subject: mb/siemens/mc_ehl: Remove spd.bin from CBFS
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68908
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6091b655ba7ff2e01b684266ce34b85593b8623
Gerrit-Change-Number: 68908
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 09:12:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Jason Nien, EricKY Cheng, Paul Menzel, Jon Murphy, Nelson Ye, Martin Roth, Karthik Ramasubramanian.
Hello build bot (Jenkins), Raul Rangel, Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68742
to look at the new patch set (#3).
Change subject: mb/google/skyrim/var/winterhold: Update DPTC setting for EVT-SMT
......................................................................
mb/google/skyrim/var/winterhold: Update DPTC setting for EVT-SMT
Follow Dynamic Thermal Table Switching proposal to initialize
thermal table config E as default table for EVT-SMT.
Since the dynamic thermal table switching mechanism is still
under cooking, after discussing with thermal team, suggest
adopting config E(limit Soc not reach to max power) as default
thermal config to avoid any thermal-related issue during
EVT build. Once the dynamic thermal table switching mechanism
is finished, will change the default value to config A.
BUG=b:232946420
TEST=emerge-skyrim coreboot
Signed-off-by: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Change-Id: I4aa90304e1e7bda7d580de2582129191e9eb0e76
---
M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb
1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/68742/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/68742
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4aa90304e1e7bda7d580de2582129191e9eb0e76
Gerrit-Change-Number: 68742
Gerrit-PatchSet: 3
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Isaac Lee <isaaclee(a)google.com>
Gerrit-CC: Nelson Ye <nelson_ye(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Nelson Ye <nelson_ye(a)compal.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Erik van den Bogaert, Frans Hendriks.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68922 )
Change subject: mb/facebook: Clean up includes
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/facebook/fbg1701/com_init.c:
https://review.coreboot.org/c/coreboot/+/68922/comment/7cc08500_3ff9445f
PS1, Line 5: #include <device/pnp_type.h>
> Has this PNP_DEV been removed using pnp_ops. […]
here you are using indirect include:
pnp_ops will include device/pnp.h, and then device/pnp.h will include pnp_type.h
File src/mainboard/facebook/monolith/ramstage.c:
https://review.coreboot.org/c/coreboot/+/68922/comment/60b8bcf2_11db46cb
PS1, Line 9: #include <tring.h>
> Reason of this change is still not clear to me. […]
to avoid indirect includes
--
To view, visit https://review.coreboot.org/c/coreboot/+/68922
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I259928f82368fbcf92f2dad77aa1ed966ff6dd58
Gerrit-Change-Number: 68922
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 08:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks <fhendriks(a)eltan.com>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment