Attention is currently required from: Raul Rangel, Jason Nien, Caveh Jalali, Isaac Lee, Tim Wawrzynczak, Jon Murphy, Martin Roth, Tim Van Patten, Eric Peers, Moises Garcia, Karthik Ramasubramanian, Boris Mittelberg.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67793 )
Change subject: ec/google/chromec: Add DPTC support for host event 1/2/9
......................................................................
Patch Set 13: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67793/comment/3fb9cfc4_66da3d31
PS11, Line 10: 1/2/9
> Instead of magic numbers, can you please add human-readable event description like lid close, lid op […]
Done
https://review.coreboot.org/c/coreboot/+/67793/comment/ae59a74a_3d5c6fa8
PS11, Line 10: 29
> Event 29 is not handled by this CL.
Done
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/67793/comment/4b379d12_a13bdf42
PS11, Line 20: #if CONFIG(SOC_AMD_COMMON_BLOCK_ACPI_DPTC)
> Do we really need this conditional check? Same for all the places that we introduced. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/67793
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I156a9d138ccac7f75cc0dd0d827f7a721fcbc782
Gerrit-Change-Number: 67793
Gerrit-PatchSet: 13
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Moises Garcia <moisesgarcia(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Attention: Moises Garcia <moisesgarcia(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 10:19:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Jason Nien, Caveh Jalali, Isaac Lee, Tim Wawrzynczak, Jon Murphy, Martin Roth, Eric Peers, Moises Garcia, Boris Mittelberg.
Hello build bot (Jenkins), Raul Rangel, Jason Nien, Martin Roth, Eric Peers, Tim Van Patten, Caveh Jalali, Isaac Lee, Tim Wawrzynczak, Jon Murphy, Moises Garcia, Karthik Ramasubramanian, Boris Mittelberg,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67793
to look at the new patch set (#13).
Change subject: ec/google/chromec: Add DPTC support for host event 1/2/9
......................................................................
ec/google/chromec: Add DPTC support for host event 1/2/9
DTTS is Dynamic Thermal Table Switching Proposal.
Add DPTC support for host event
lid-open/lid-close/Thermal Threshold.
BUG=b:232946420
TEST=emerge-skyrim coreboot
Signed-off-by: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Change-Id: I156a9d138ccac7f75cc0dd0d827f7a721fcbc782
---
M src/ec/google/chromeec/acpi/ec.asl
1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/67793/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/67793
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I156a9d138ccac7f75cc0dd0d827f7a721fcbc782
Gerrit-Change-Number: 67793
Gerrit-PatchSet: 13
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Moises Garcia <moisesgarcia(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Attention: Moises Garcia <moisesgarcia(a)google.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Raul Rangel, Jason Nien, Caveh Jalali, Isaac Lee, Tim Wawrzynczak, Jon Murphy, Martin Roth, Eric Peers, Moises Garcia, Boris Mittelberg.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67793 )
Change subject: ec/google/chromec: Add DPTC support for host event 1/2/9
......................................................................
Patch Set 12: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/67793
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I156a9d138ccac7f75cc0dd0d827f7a721fcbc782
Gerrit-Change-Number: 67793
Gerrit-PatchSet: 12
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Moises Garcia <moisesgarcia(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Attention: Moises Garcia <moisesgarcia(a)google.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 10:17:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Jason Nien, EricKY Cheng, Isaac Lee, Tim Wawrzynczak, Jon Murphy, Martin Roth, Moises Garcia, Eric Peers.
Hello build bot (Jenkins), Raul Rangel, Jason Nien, Isaac Lee, Tim Wawrzynczak, Jon Murphy, Martin Roth, Moises Garcia, Eric Peers, Tim Van Patten, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67793
to look at the new patch set (#12).
Change subject: ec/google/chromec: Add DPTC support for host event 1/2/9
......................................................................
ec/google/chromec: Add DPTC support for host event 1/2/9
DTTS is Dynamic Thermal Table Switching Proposal.
Add DPTC support for host event 1/2/9.
BUG=b:232946420
TEST=emerge-skyrim coreboot
Signed-off-by: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Change-Id: I156a9d138ccac7f75cc0dd0d827f7a721fcbc782
---
M src/ec/google/chromeec/acpi/ec.asl
1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/67793/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/67793
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I156a9d138ccac7f75cc0dd0d827f7a721fcbc782
Gerrit-Change-Number: 67793
Gerrit-PatchSet: 12
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Moises Garcia <moisesgarcia(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Moises Garcia <moisesgarcia(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Martin L Roth, Julius Werner, Angel Pons.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62830 )
Change subject: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62830/comment/91f1e221_17b2528d
PS1, Line 9: ```
: $ make V=1 # emulation/qemu-i440fx
: […]
: CC ramstage/arch/x86/ebda.o
: x86_64-linux-gnu-gcc-12 -MMD -Isrc -Isrc/include -Isrc/commonlib/include -Isrc/commonlib/bsd/include -Ibuild -I3rdparty/vboot/firmware/include -include src/include/kconfig.h -include src/include/rules.h -include src/commonlib/bsd/include/commonlib/bsd/compiler.h -I3rdparty -D__BUILD_DIR__=\"build\" -Isrc/arch/x86/include -D__ARCH_x86_32__ -pipe -g -nostdinc -std=gnu11 -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough -Wshadow -Wdate-time -Wtype-limits -Wvla -Wdangling-else -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie -Wno-packed-not-aligned -fconserve-stack -Wnull-dereference -Wreturn-type -Wlogical-op -Wduplicated-cond -Wno-unused-but-set-variable -Werror -Os -Wno-address-of-packed-member -m32 -Wl,-b,elf32-i386 -Wl,-melf_i386 -m32 -fuse-ld=bfd -fno-stack-protector -Wl,--build-id=none -fno-delete-null-pointer-checks -Wlogical-op -march=i686 -mno-mmx -MT build/ramstage/arch/x86/ebda.o -D__RAMSTAGE__ -c -o build/ramstage/arch/x86/ebda.o src/arch/x86/ebda.c
: In file included from src/arch/x86/ebda.c:6:
: In function 'write_ble8',
: inlined from 'write_le8' at src/commonlib/include/commonlib/endian.h:155:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:178:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:35:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 0 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_at_ble8' at src/commonlib/include/commonlib/endian.h:34:2,
: inlined from 'write_at_le8' at src/commonlib/include/commonlib/endian.h:160:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:179:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:35:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 1 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_le8' at src/commonlib/include/commonlib/endian.h:155:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:178:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:36:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 0 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_at_ble8' at src/commonlib/include/commonlib/endian.h:34:2,
: inlined from 'write_at_le8' at src/commonlib/include/commonlib/endian.h:160:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:179:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:36:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 1 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_le8' at src/commonlib/include/commonlib/endian.h:155:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:178:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:40:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 0 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_at_ble8' at src/commonlib/include/commonlib/endian.h:34:2,
: inlined from 'write_at_le8' at src/commonlib/include/commonlib/endian.h:160:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:179:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:40:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 1 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: cc1: all warnings being treated as errors
: ```
> No idea, how I missed that. Thank you for the pointer. […]
(Hmm, Gerrit missed the rest of my comment, and the check box. Again:)
I trimmed the paste in later patchsets, and seeing Angel’s +2 I am marking this comment as resolved.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62830
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e36633f42cb4dc5af53212c10c919a86e451ee0
Gerrit-Change-Number: 62830
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 10:15:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Martin L Roth, Julius Werner, Angel Pons.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62830 )
Change subject: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62830/comment/d34352a3_047c9cfc
PS1, Line 9: ```
: $ make V=1 # emulation/qemu-i440fx
: […]
: CC ramstage/arch/x86/ebda.o
: x86_64-linux-gnu-gcc-12 -MMD -Isrc -Isrc/include -Isrc/commonlib/include -Isrc/commonlib/bsd/include -Ibuild -I3rdparty/vboot/firmware/include -include src/include/kconfig.h -include src/include/rules.h -include src/commonlib/bsd/include/commonlib/bsd/compiler.h -I3rdparty -D__BUILD_DIR__=\"build\" -Isrc/arch/x86/include -D__ARCH_x86_32__ -pipe -g -nostdinc -std=gnu11 -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough -Wshadow -Wdate-time -Wtype-limits -Wvla -Wdangling-else -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie -Wno-packed-not-aligned -fconserve-stack -Wnull-dereference -Wreturn-type -Wlogical-op -Wduplicated-cond -Wno-unused-but-set-variable -Werror -Os -Wno-address-of-packed-member -m32 -Wl,-b,elf32-i386 -Wl,-melf_i386 -m32 -fuse-ld=bfd -fno-stack-protector -Wl,--build-id=none -fno-delete-null-pointer-checks -Wlogical-op -march=i686 -mno-mmx -MT build/ramstage/arch/x86/ebda.o -D__RAMSTAGE__ -c -o build/ramstage/arch/x86/ebda.o src/arch/x86/ebda.c
: In file included from src/arch/x86/ebda.c:6:
: In function 'write_ble8',
: inlined from 'write_le8' at src/commonlib/include/commonlib/endian.h:155:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:178:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:35:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 0 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_at_ble8' at src/commonlib/include/commonlib/endian.h:34:2,
: inlined from 'write_at_le8' at src/commonlib/include/commonlib/endian.h:160:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:179:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:35:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 1 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_le8' at src/commonlib/include/commonlib/endian.h:155:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:178:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:36:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 0 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_at_ble8' at src/commonlib/include/commonlib/endian.h:34:2,
: inlined from 'write_at_le8' at src/commonlib/include/commonlib/endian.h:160:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:179:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:36:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 1 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_le8' at src/commonlib/include/commonlib/endian.h:155:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:178:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:40:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 0 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: In function 'write_ble8',
: inlined from 'write_at_ble8' at src/commonlib/include/commonlib/endian.h:34:2,
: inlined from 'write_at_le8' at src/commonlib/include/commonlib/endian.h:160:2,
: inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:179:2,
: inlined from 'setup_ebda' at src/arch/x86/ebda.c:40:2,
: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 1 is outside array bounds of 'void[0]' [-Werror=array-bounds]
: 27 | *(uint8_t *)dest = val;
: | ~~~~~~~~~~~~~~~~~^~~~~
: cc1: all warnings being treated as errors
: ```
> All comments on a patch need to be resolved before it can be submitted. This one is still open.
No idea, how I missed that. Thank you for the pointer.
I trimmed the paste
--
To view, visit https://review.coreboot.org/c/coreboot/+/62830
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e36633f42cb4dc5af53212c10c919a86e451ee0
Gerrit-Change-Number: 62830
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 10:13:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68319
to look at the new patch set (#4).
Change subject: ec/starlabs/merlin: Rename the Cezanne EC code
......................................................................
ec/starlabs/merlin: Rename the Cezanne EC code
This EC code is for the Byte, a Cezanne Mini PC. The EC is different
to the Cezanne StarBook Mk VI. Rename it to `-desktop`, so the laptop
variant becomes the primary.
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: I25f812cb1c6cefca1ebbe3bee5d20cf521dd60af
---
R src/ec/starlabs/merlin/variants/cezanne-desktop/ecdefs.h
R src/ec/starlabs/merlin/variants/cezanne-desktop/emem.asl
R src/ec/starlabs/merlin/variants/cezanne-desktop/events.asl
3 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/68319/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/68319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25f812cb1c6cefca1ebbe3bee5d20cf521dd60af
Gerrit-Change-Number: 68319
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68585 )
Change subject: Documentation/mb/starlabs: De-deplicate the building instructions
......................................................................
Patch Set 6: Verified+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/68585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20301b3041a62eb416ed61a84544ec4e5cc66c1e
Gerrit-Change-Number: 68585
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 28 Oct 2022 10:02:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Angel Pons.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68449 )
Change subject: intelblocks/vtd: Add VT-d block with DMA protection API
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/soc/intel/common/block/vtd/vtd.c:
https://review.coreboot.org/c/coreboot/+/68449/comment/e6d4c245_1d8e1543
PS7, Line 158: if (vtd_read32(vtd_base, PMEN_REG) & PMEN_PRS) {
Looks like these `if`s don't need to be nested
--
To view, visit https://review.coreboot.org/c/coreboot/+/68449
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7edf982457c1139624e5cd383788eda41d6a948
Gerrit-Change-Number: 68449
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 10:01:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68939 )
Change subject: mb/starlabs/*: Enable the Mirror flag for boards that support it
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/68939
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51678bdb8d876d238076e12c6315a53c5da59628
Gerrit-Change-Number: 68939
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 28 Oct 2022 10:00:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment