coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: soc/intel/xeon_sp: Remove unused madt setup function
by Martin Roth (Code Review) 28 Oct '22

28 Oct '22

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68907 ) Change subject: soc/intel/xeon_sp: Remove unused madt setup function ...................................................................... soc/intel/xeon_sp: Remove unused madt setup function Change-Id: I248974c5a88768ee12f63fa77f3fa67a72ea510e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/68907 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jonathan Zhang <jonzhang(a)fb.com> --- M src/soc/intel/xeon_sp/cpx/soc_acpi.c M src/soc/intel/xeon_sp/include/soc/acpi.h M src/soc/intel/xeon_sp/skx/soc_acpi.c 3 files changed, 13 insertions(+), 33 deletions(-) Approvals: build bot (Jenkins): Verified Jonathan Zhang: Looks good to me, approved diff --git a/src/soc/intel/xeon_sp/cpx/soc_acpi.c b/src/soc/intel/xeon_sp/cpx/soc_acpi.c index d6e7cf0..0da827d 100644 --- a/src/soc/intel/xeon_sp/cpx/soc_acpi.c +++ b/src/soc/intel/xeon_sp/cpx/soc_acpi.c @@ -217,19 +217,3 @@ /* Fix package length */ acpigen_pop_len(); } - -unsigned long xeonsp_acpi_create_madt_lapics(unsigned long current) -{ - struct device *cpu; - uint8_t num_cpus = 0; - - for (cpu = all_devices; cpu; cpu = cpu->next) { - if (!is_enabled_cpu(cpu)) - continue; - current += acpi_create_madt_lapic((acpi_madt_lapic_t *)current, - num_cpus, cpu->path.apic.apic_id); - num_cpus++; - } - - return current; -} diff --git a/src/soc/intel/xeon_sp/include/soc/acpi.h b/src/soc/intel/xeon_sp/include/soc/acpi.h index c2b815d..cc9f2d1 100644 --- a/src/soc/intel/xeon_sp/include/soc/acpi.h +++ b/src/soc/intel/xeon_sp/include/soc/acpi.h @@ -21,6 +21,5 @@ unsigned long northbridge_write_acpi_tables(const struct device *device, unsigned long current, struct acpi_rsdp *rsdp); void uncore_inject_dsdt(const struct device *device); -unsigned long xeonsp_acpi_create_madt_lapics(unsigned long current); #endif /* _SOC_ACPI_H_ */ diff --git a/src/soc/intel/xeon_sp/skx/soc_acpi.c b/src/soc/intel/xeon_sp/skx/soc_acpi.c index 73459c7..88f24d4 100644 --- a/src/soc/intel/xeon_sp/skx/soc_acpi.c +++ b/src/soc/intel/xeon_sp/skx/soc_acpi.c @@ -148,19 +148,3 @@ void soc_power_states_generation(int core, int cores_per_package) { } - -unsigned long xeonsp_acpi_create_madt_lapics(unsigned long current) -{ - struct device *cpu; - uint8_t num_cpus = 0; - - for (cpu = all_devices; cpu; cpu = cpu->next) { - if (!is_enabled_cpu(cpu)) - continue; - current += acpi_create_madt_lapic((acpi_madt_lapic_t *)current, - num_cpus, cpu->path.apic.apic_id); - num_cpus++; - } - - return current; -} -- To view, visit https://review.coreboot.org/c/coreboot/+/68907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I248974c5a88768ee12f63fa77f3fa67a72ea510e Gerrit-Change-Number: 68907 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: cpu/x86/mp_init.c: Use linked list data structures
by Martin Roth (Code Review) 28 Oct '22

28 Oct '22

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/64340 ) Change subject: cpu/x86/mp_init.c: Use linked list data structures ...................................................................... cpu/x86/mp_init.c: Use linked list data structures There is no need to keep track of device structures separately. Change-Id: Ie728110fc8c60fec94ae4bedf74e17740cf78f67 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/64340 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <inforichland(a)gmail.com> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/cpu/x86/mp_init.c 1 file changed, 26 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Eric Lai: Looks good to me, but someone else must approve diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index dd9deda..e3b294f 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -107,7 +107,7 @@ /* The sipi vector rmodule is included in the ramstage using 'objdump -B'. */ extern char _binary_sipi_vector_start[]; -/* The SIPI vector is loaded at the SMM_DEFAULT_BASE. The reason is at the +/* The SIPI vector is loaded at the SMM_DEFAULT_BASE. The reason is that the * memory range is already reserved so the OS cannot use it. That region is * free to use for AP bringup before SMM is initialized. */ static const uintptr_t sipi_vector_location = SMM_DEFAULT_BASE; @@ -121,9 +121,6 @@ static int global_num_aps; static struct mp_flight_plan mp_info; -/* Keep track of device structure for each CPU. */ -static struct device *cpus_dev[CONFIG_MAX_CPUS]; - static inline void barrier_wait(atomic_t *b) { while (atomic_read(b) == 0) @@ -175,6 +172,8 @@ stop_this_cpu(); } +static struct bus *g_cpu_bus; + /* By the time APs call ap_init() caching has been setup, and microcode has * been loaded. */ static void asmlinkage ap_init(void) @@ -185,7 +184,11 @@ enable_lapic(); setup_lapic_interrupts(); - info->cpu = cpus_dev[info->index]; + struct device *dev = g_cpu_bus->children; + for (unsigned int i = info->index; i > 0; i--) + dev = dev->sibling; + + info->cpu = dev; cpu_add_map_entry(info->index); @@ -384,7 +387,6 @@ continue; } new->name = processor_name; - cpus_dev[i] = new; } return max_cpus; @@ -579,6 +581,8 @@ int num_cpus; atomic_t *ap_count; + g_cpu_bus = cpu_bus; + init_bsp(cpu_bus); if (p == NULL || p->flight_plan == NULL || p->num_records < 1) { -- To view, visit https://review.coreboot.org/c/coreboot/+/64340 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie728110fc8c60fec94ae4bedf74e17740cf78f67 Gerrit-Change-Number: 64340 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: fix for orphaned mainboards.
by Martin L Roth (Code Review) 28 Oct '22

28 Oct '22

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68951 ) Change subject: fix for orphaned mainboards. ...................................................................... Abandoned oops -- To view, visit https://review.coreboot.org/c/coreboot/+/68951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7588d91098e6d6d9064e3197f490172bad94ac0 Gerrit-Change-Number: 68951 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: fix for orphaned mainboards.
by build bot (Jenkins) (Code Review) 28 Oct '22

28 Oct '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68951 ) Change subject: fix for orphaned mainboards. ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161600): https://review.coreboot.org/c/coreboot/+/68951/comment/f881e2aa_938d4311 PS1, Line 6: Subject line should not end with a period. -- To view, visit https://review.coreboot.org/c/coreboot/+/68951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7588d91098e6d6d9064e3197f490172bad94ac0 Gerrit-Change-Number: 68951 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Oct 2022 21:25:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: MAINTAINERS: Make Misc Fixes
by Martin L Roth (Code Review) 28 Oct '22

28 Oct '22

Attention is currently required from: Martin L Roth, Paul Menzel, Angel Pons. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68709 to look at the new patch set (#4). Change subject: MAINTAINERS: Make Misc Fixes ...................................................................... MAINTAINERS: Make Misc Fixes - X86 architecture is maintained, so mark it as such. - Legacy AMD chips are supported for odd fixes. - Remove maintainers whose emails are bouncing. - Remove maintainers who don't have +2 rights in gerrit. - According to the instructions, we should use S: Orphan, not Orphaned. - Update incorrect email addresses. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ib6d47a8c34482c81ff96dbeec760852cba01dabc --- M MAINTAINERS 1 file changed, 21 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/68709/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/68709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6d47a8c34482c81ff96dbeec760852cba01dabc Gerrit-Change-Number: 68709 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: MAINTAINERS: Add orphaned mainboards
by Martin L Roth (Code Review) 28 Oct '22

28 Oct '22

Attention is currently required from: Martin L Roth, Angel Pons. Hello Felix Singer, build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68706 to look at the new patch set (#3). Change subject: MAINTAINERS: Add orphaned mainboards ...................................................................... MAINTAINERS: Add orphaned mainboards The mainboards are broken out into individual entries in hopes that it will be easier for someone to claim ownership than if they were lumped into a single "Orphaned Mainboards" group. The theory behind this is that a single mainboard is really the easiest piece of coreboot to maintain. Hopefully some less-experienced people will be interested in stepping up to take over ownership of a mainboard. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I9542b3a7cd87fa8656bc0982c08061e9d0513745 --- M MAINTAINERS 1 file changed, 186 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/68706/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9542b3a7cd87fa8656bc0982c08061e9d0513745 Gerrit-Change-Number: 68706 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: fix for orphaned mainboards.
by Martin L Roth (Code Review) 28 Oct '22

28 Oct '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68951 ) Change subject: fix for orphaned mainboards. ...................................................................... fix for orphaned mainboards. Change-Id: Id7588d91098e6d6d9064e3197f490172bad94ac0 --- M MAINTAINERS 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/68951/1 diff --git a/MAINTAINERS b/MAINTAINERS index 0ac03e8..e109c42 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -448,7 +448,7 @@ -LIPPERT MAINBOARDS (acqyired by Adlink) +LIPPERT MAINBOARDS (acquired by Adlink) S: Orphan F: src/mainboard/lippert/ -- To view, visit https://review.coreboot.org/c/coreboot/+/68951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7588d91098e6d6d9064e3197f490172bad94ac0 Gerrit-Change-Number: 68951 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: MAINTAINERS: Make Misc Fixes
by Martin L Roth (Code Review) 28 Oct '22

28 Oct '22

Attention is currently required from: Martin L Roth, Paul Menzel, Angel Pons. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68709 to look at the new patch set (#3). Change subject: MAINTAINERS: Make Misc Fixes ...................................................................... MAINTAINERS: Make Misc Fixes - X86 architecture is maintained, so mark it as such. - Legacy AMD chips are supported for odd fixes. - Remove maintainers whose emails are bouncing. - Remove maintainers who don't have +2 rights in gerrit. - According to the instructions, we should use S: Orphan, not Orphaned. - Update incorrect email addresses. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ib6d47a8c34482c81ff96dbeec760852cba01dabc --- M MAINTAINERS 1 file changed, 21 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/68709/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6d47a8c34482c81ff96dbeec760852cba01dabc Gerrit-Change-Number: 68709 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: MAINTAINERS: Update EC section
by Martin L Roth (Code Review) 28 Oct '22

28 Oct '22

Attention is currently required from: Martin L Roth, Martin Roth. Hello build bot (Jenkins), Angel Pons, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68708 to look at the new patch set (#2). Change subject: MAINTAINERS: Update EC section ...................................................................... MAINTAINERS: Update EC section - Presumably all of the ec/google subdirectory is maintained - Add list of Orphan ECs Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ia93e8da9898903ae92873a07fb0af2a2aa76e8b4 --- M MAINTAINERS 1 file changed, 27 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/68708/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68708 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia93e8da9898903ae92873a07fb0af2a2aa76e8b4 Gerrit-Change-Number: 68708 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: MAINTAINERS: Update mainboards
by Martin L Roth (Code Review) 28 Oct '22

28 Oct '22

Attention is currently required from: Martin L Roth. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68707 to look at the new patch set (#3). Change subject: MAINTAINERS: Update mainboards ...................................................................... MAINTAINERS: Update mainboards - AMD reference boards are maintained at least for odd fixes. - Google panther has become a variant of Beltino, so remove it. - Remove people whose email addresses are bouncing email. - Remove people who responded to my email about being a maintainer and asked to be removed. - Alphabetize list Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ic6ecaae77df2f2edaf724160bce04c038cbd115e --- M MAINTAINERS 1 file changed, 25 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/68707/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6ecaae77df2f2edaf724160bce04c038cbd115e Gerrit-Change-Number: 68707 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022