Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/68952 )
Change subject: mainboard/starlabs/cezanne/starbook: Add EC binary 1.02
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/blobs/+/68952
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I557fd5cd3b987fb4d9a1fb0eaa0e442d94c848fe
Gerrit-Change-Number: 68952
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Fri, 28 Oct 2022 22:18:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Nicholas Chin.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67330 )
Change subject: Documentation: Add some more acronyms to the list
......................................................................
Patch Set 4:
(2 comments)
File Documentation/acronyms.md:
https://review.coreboot.org/c/coreboot/+/67330/comment/8da38ff1_af68b0bd
PS1, Line 50: ]
> Probably should have worded this more clearly, what I meant was replace the extra "]" with the secon […]
Done
File Documentation/acronyms.md:
https://review.coreboot.org/c/coreboot/+/67330/comment/ffeadb2b_67139ed1
PS2, Line 603: been
> Remove the first "been", should be "This has generally been superseded by" instead of "This has been […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/67330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I417bb151afcb3e996d9a12b2274ef02f2126bc7d
Gerrit-Change-Number: 67330
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 22:16:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Hello Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/68586
to look at the new patch set (#2).
Change subject: mainboard/starlabs/starbook/adl: Update the EC binary to 1.01
......................................................................
mainboard/starlabs/starbook/adl: Update the EC binary to 1.01
[ADL] 1.01:
Enable hybrid power - when the battery has more than 15% power, support
chargers that don't output the required 40W.
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: If2c6311af7744b6bd708c2084ce18fcfe13b8f5d
---
M mainboard/starlabs/starbook/adl/README.md
M mainboard/starlabs/starbook/adl/ec.bin
2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/86/68586/2
--
To view, visit https://review.coreboot.org/c/blobs/+/68586
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: If2c6311af7744b6bd708c2084ce18fcfe13b8f5d
Gerrit-Change-Number: 68586
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth.
Martin Roth has uploaded a new patch set (#4) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/67330 )
Change subject: Documentation: Add some more acronyms to the list
......................................................................
Documentation: Add some more acronyms to the list
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I417bb151afcb3e996d9a12b2274ef02f2126bc7d
---
M Documentation/acronyms.md
1 file changed, 55 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/67330/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/67330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I417bb151afcb3e996d9a12b2274ef02f2126bc7d
Gerrit-Change-Number: 67330
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67330 )
Change subject: Documentation: Add some more acronyms to the list.
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161608):
https://review.coreboot.org/c/coreboot/+/67330/comment/e066d709_f66759f7
PS3, Line 6:
Subject line should not end with a period.
--
To view, visit https://review.coreboot.org/c/coreboot/+/67330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I417bb151afcb3e996d9a12b2274ef02f2126bc7d
Gerrit-Change-Number: 67330
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 22:12:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Hello build bot (Jenkins), Nicholas Chin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67330
to look at the new patch set (#3).
Change subject: Documentation: Add some more acronyms to the list.
......................................................................
Documentation: Add some more acronyms to the list.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I417bb151afcb3e996d9a12b2274ef02f2126bc7d
---
M Documentation/acronyms.md
1 file changed, 55 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/67330/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/67330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I417bb151afcb3e996d9a12b2274ef02f2126bc7d
Gerrit-Change-Number: 67330
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nikolai Vyssotski, Fred Reitberger, Felix Held.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68802 )
Change subject: mainboard/amd/chausie: Don't use APCB_FT6_Updatable
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d317ae31cf226b5481619f1539abb6237033f7c
Gerrit-Change-Number: 68802
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 28 Oct 2022 22:00:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Matt DeVillier, Nikolai Vyssotski, Fred Reitberger, Felix Held.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68801 )
Change subject: src/soc/amd/mendocino: Enable override of MAINBOARD_BLOBS_DIR
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/68801
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I028042b947887d1182642ad4482dd1bba7ad8e23
Gerrit-Change-Number: 68801
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 28 Oct 2022 21:59:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth, Angel Pons.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68500 )
Change subject: Docs/releases: Update release checklist document
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68500
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a79cf92620755e19266faaf593dc2657acdb16f
Gerrit-Change-Number: 68500
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 21:56:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Eric Lai.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66992 )
Change subject: mb/google/rex: Add fingerprint SPI
......................................................................
Patch Set 14:
(1 comment)
File src/mainboard/google/rex/variants/rex0/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161607):
https://review.coreboot.org/c/coreboot/+/66992/comment/e3bfa1ec_b8024a20
PS14, Line 443: /* GPP_C23 : [] ==> FP_RST_ODL */
code indent should use tabs where possible
--
To view, visit https://review.coreboot.org/c/coreboot/+/66992
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e6be24e72a8232ae2c958a01cf8ea9a272d7365
Gerrit-Change-Number: 66992
Gerrit-PatchSet: 14
Gerrit-Owner: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 28 Oct 2022 21:54:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment