coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: util/cbfstool: Port elogtool to libflashrom
by Edward O'Callaghan (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Felix Singer, Hsuan-ting Chen, Jack Rosenthal, Nikolai Artemiev. Hello build bot (Jenkins), Hsuan-ting Chen, Jack Rosenthal, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59714 to look at the new patch set (#9). Change subject: util/cbfstool: Port elogtool to libflashrom ...................................................................... util/cbfstool: Port elogtool to libflashrom This also uncouples cbfstool from being overly Chromium specific. However the main objective is to not subprocess flashrom any more and instead use the programmatic API. BUG=b:207808292 TEST=built and ran `elogtool list`. Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M util/cbfstool/Makefile.inc M util/cbfstool/elogtool.c A util/cbfstool/uflashrom.c A util/cbfstool/uflashrom.h 4 files changed, 209 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/59714/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/59714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231 Gerrit-Change-Number: 59714 Gerrit-PatchSet: 9 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sam McNally <sammc(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Create agah variant
by Tony Huang (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Tim Wawrzynczak, Wisley Chen. Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60785 ) Change subject: mb/google/brya: Create agah variant ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/Kconfig.name: https://review.coreboot.org/c/coreboot/+/60785/comment/bbe61c10_5cc1f90e PS2, Line 146: config BOARD_GOOGLE_AGAH > nit: blank line between config options Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6adcf4e8010969cf185513d68bb1b76ea08194c7 Gerrit-Change-Number: 60785 Gerrit-PatchSet: 3 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 23:22:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Create agah variant
by Tony Huang (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Tony Huang, Wisley Chen. Hello Tim Wawrzynczak, Wisley Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60785 to look at the new patch set (#3). Change subject: mb/google/brya: Create agah variant ...................................................................... mb/google/brya: Create agah variant Create the agah variant of the brya0 reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0). BUG=b:210970640 BRANCH=None TEST=util/abuild/abuild -p none -t google/brya -x -a make sure the build includes GOOGLE_AGAH Change-Id: I6adcf4e8010969cf185513d68bb1b76ea08194c7 Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/agah/include/variant/ec.h A src/mainboard/google/brya/variants/agah/include/variant/gpio.h A src/mainboard/google/brya/variants/agah/memory/Makefile.inc A src/mainboard/google/brya/variants/agah/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/agah/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/agah/overridetree.cb 8 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/60785/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6adcf4e8010969cf185513d68bb1b76ea08194c7 Gerrit-Change-Number: 60785 Gerrit-PatchSet: 3 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/ifdtool: Add additional regions for platforms that support them.
by Paul Menzel (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Jeff Daly, Stefan Reinauer, Angel Pons, Kyösti Mälkki. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60736 ) Change subject: util/ifdtool: Add additional regions for platforms that support them. ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60736/comment/974a4101_3b90df44 PS1, Line 7: util/ifdtool: Add additional regions for platforms that support them. > Done It came back. ;-) Patchset: PS5: > i seem to be missing the trick to fixing the (indirect ancestor) issue. […] Please paste the comments you used. In this case, it probably means, that CB:60737 was once a parent in the same branch. Now you only pushed this change-set/commit and rebased it somehow, and you didn’t push the other one in the same branch. Due to the Change-Ids Gerrit knows, that they were once in the same branch, and, therefore, related. -- To view, visit https://review.coreboot.org/c/coreboot/+/60736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64cc1d787f15a01dff7db89218410228fd0082a6 Gerrit-Change-Number: 60736 Gerrit-PatchSet: 5 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 22:54:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jeff Daly <jeffd(a)silicom-usa.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add additional regions for platforms that support them.
by Jeff Daly (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Paul Menzel, Stefan Reinauer, Angel Pons, Kyösti Mälkki. Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60736 ) Change subject: util/ifdtool: Add additional regions for platforms that support them. ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: i seem to be missing the trick to fixing the (indirect ancestor) issue. what's the bkm for fixing this? is it because i made a mistake by forgetting to fetch before the push or is it something else? -- To view, visit https://review.coreboot.org/c/coreboot/+/60736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64cc1d787f15a01dff7db89218410228fd0082a6 Gerrit-Change-Number: 60736 Gerrit-PatchSet: 5 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 22:43:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add support for Denverton platforms.
by Jeff Daly (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Paul Menzel, Stefan Reinauer, Angel Pons, Kyösti Mälkki. Hello build bot (Jenkins), Stefan Reinauer, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60737 to look at the new patch set (#4). Change subject: util/ifdtool: Add support for Denverton platforms. ...................................................................... util/ifdtool: Add support for Denverton platforms. Signed-off-by: Jeff Daly <jeffd(a)silicom-usa.com> Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 30 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/60737/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced Gerrit-Change-Number: 60737 Gerrit-PatchSet: 4 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: payloads/tianocore: Add option to use F7 as Boot Manager key
by Sean Rhodes (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Martin Roth, Paul Menzel. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60761 ) Change subject: payloads/tianocore: Add option to use F7 as Boot Manager key ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60761/comment/f3efc42e_1ecf9304 PS3, Line 11: This option can : be used to use F7 to replace Escape > Please add a dot/period at the end. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ided23e82161488768aa3b7d54ab17e9c922d6d11 Gerrit-Change-Number: 60761 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 22:26:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/tianocore: Add option to use F7 as Boot Manager key
by Sean Rhodes (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Sean Rhodes, Martin Roth. Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60761 to look at the new patch set (#4). Change subject: payloads/tianocore: Add option to use F7 as Boot Manager key ...................................................................... payloads/tianocore: Add option to use F7 as Boot Manager key The coreboot version of Tianocore maps Escape to the boot menu. This is problematic for many Linux distributions that use GRUB, as this also maps Escape to access its menu. This option can be used to use F7 to replace Escape. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ided23e82161488768aa3b7d54ab17e9c922d6d11 --- M payloads/external/Makefile.inc M payloads/external/tianocore/Kconfig M payloads/external/tianocore/Makefile 3 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/60761/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ided23e82161488768aa3b7d54ab17e9c922d6d11 Gerrit-Change-Number: 60761 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/herobrine: Fix board id
by Paul Menzel (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Shelley Chen, mturney mturney, Ravi Kumar Bokka, Sudheer Amrabadi, Julius Werner, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60805 ) Change subject: mb/google/herobrine: Fix board id ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60805/comment/03320dc2_1c3cb756 PS2, Line 9: The board id assignment CL (CB:56642) Please mention the commit hash and commit message summary. https://review.coreboot.org/c/coreboot/+/60805/comment/1c920f2e_cf047f70 PS2, Line 11: Fixing Maybe: Fix it https://review.coreboot.org/c/coreboot/+/60805/comment/97de8237_91878431 PS2, Line 9: The board id assignment CL (CB:56642) landed after : BOARD_GOOGLE_HEROBRINE has been deprecated to : BOARD_GOOGLE_HEROBRINE_REV0 … in commit <hash> (<commit message summary>) https://review.coreboot.org/c/coreboot/+/60805/comment/7c9045d9_21043eae PS2, Line 12: Also fixed a couple of variables : that were declared static when they didn't need to be (they are being : reinitialized at the beginning of each function anyway). Please make that a separate commit. -- To view, visit https://review.coreboot.org/c/coreboot/+/60805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dab994e65eadff303eb88a63b8dd81e19694678 Gerrit-Change-Number: 60805 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 22:25:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/tianocore: Add option to use F7 as Boot Manager key
by Paul Menzel (Code Review) 05 Jan '22

05 Jan '22

Attention is currently required from: Sean Rhodes, Martin Roth. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60761 ) Change subject: payloads/tianocore: Add option to use F7 as Boot Manager key ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60761/comment/5228d1a4_94930de7 PS3, Line 11: This option can : be used to use F7 to replace Escape Please add a dot/period at the end. -- To view, visit https://review.coreboot.org/c/coreboot/+/60761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ided23e82161488768aa3b7d54ab17e9c922d6d11 Gerrit-Change-Number: 60761 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 05 Jan 2022 22:21:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022