Attention is currently required from: Mac Chiang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61404 )
Change subject: mb/google/brya/variants/brask: Enable Bluetooth offload support
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61404/comment/99aabe6e_dfaec89c
PS1, Line 16:
Missing `Signed-off-by` tag
File src/mainboard/google/brya/variants/brask/fw_config.c:
https://review.coreboot.org/c/coreboot/+/61404/comment/46aa99b5_ba187d07
PS1, Line 32: if (!fw_config_is_provisioned() || fw_config_probe(FW_CONFIG(AUDIO, AUDIO_UNKNOWN))) {
> braces {} are not necessary for single statement blocks
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61404
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2
Gerrit-Change-Number: 61404
Gerrit-PatchSet: 1
Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Comment-Date: Thu, 27 Jan 2022 16:59:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Frans Hendriks, Tristan Corrick, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro, Angel Pons, HAOUAS Elyes, Piotr Król, Wim Vervoorn.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59880 )
Change subject: IASL: Ignore IASL's "Missing dependency" warning
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS5:
> Indeed it’d be great to only silence the warning for known problematic boards.
I think that version 5 is the right way to go. If all of the boards get fixed ad Tim suggested, that's great too, but I think we should continue forward with this until it's not needed anymore.
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/59880/comment/e05b6f9e_9ff5089c
PS6, Line 265: REDUNDANT_OFFSET_REMARK = 2158
> out of topic: […]
Awesome.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59880
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28b437194f08232727623009372327fec15215dd
Gerrit-Change-Number: 59880
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-Comment-Date: Thu, 27 Jan 2022 16:59:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Rory Liu, Paul Menzel, Zhuohao Lee, Alan Huang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61267 )
Change subject: drivers/net/r8168: Add ASPM control mechanism
......................................................................
Patch Set 2:
(2 comments)
File src/drivers/net/chip.h:
https://review.coreboot.org/c/coreboot/+/61267/comment/9e9fb85e_7f662bdb
PS2, Line 35: /* Allow kernel driver to enable ASPM L1.2. */
: bool enable_aspm;
So coreboot already has a Kconfig option to enable ASPM on PCIe links (PCIEXP_ASPM, see https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/sr… .
Should we just use that instead in the driver code?
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/61267/comment/8ca0c553_1e5b57d1
PS2, Line 252: struct drivers_net_config *config = dev->chip_info;
: if (!config || !config->enable_aspm)
: return;
Should we just change this to
```
if (!CONFIG(PCIEXP_ASPM))
return;
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/61267
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I944dbf04d3ca19df4de224540bee538bff4d1f12
Gerrit-Change-Number: 61267
Gerrit-PatchSet: 2
Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rory Liu <rory.liu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 27 Jan 2022 16:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59415 )
Change subject: Makefile.inc: Don't ignore IASL's "multiple types" warning
......................................................................
Makefile.inc: Don't ignore IASL's "multiple types" warning
Intel Lynx Point ASL code is fixed. So don't ignore
"Multiple types (Device object requires either a _HID or _ADR, but not both)"
warning.
Change-Id: Ie9398879a76ad3d36454772a1c23da083af14b59
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59415
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Martin Roth <martinroth(a)google.com>
---
M Makefile.inc
1 file changed, 0 insertions(+), 8 deletions(-)
Approvals:
build bot (Jenkins): Verified
Martin Roth: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc
index 1c76a91..beb7f0e 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -263,17 +263,9 @@
# Redundant offset remarks are not useful in any way and are masking useful
# ones that might indicate an issue so it is better to hide them.
REDUNDANT_OFFSET_REMARK = 2158
-# Ignore _HID & _ADR coexisting in Intel Lynxpoint ASL code.
-# See cb:38802
-# "Multiple types (Device object requires either a _HID or _ADR, but not both)"
-MULTIPLE_TYPES_WARNING = 3073
IASL_WARNINGS_LIST = $(EMPTY_RESOURCE_TEMPLATE_WARNING) $(REDUNDANT_OFFSET_REMARK)
-ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_LYNXPOINT),y)
-IASL_WARNINGS_LIST += $(MULTIPLE_TYPES_WARNING)
-endif
-
IGNORED_IASL_WARNINGS = $(addprefix -vw , $(IASL_WARNINGS_LIST))
define asl_template
--
To view, visit https://review.coreboot.org/c/coreboot/+/59415
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9398879a76ad3d36454772a1c23da083af14b59
Gerrit-Change-Number: 59415
Gerrit-PatchSet: 11
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Rory Liu, Paul Menzel, Zhuohao Lee, Alan Huang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61267 )
Change subject: drivers/net/r8168: Add ASPM control mechanism
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
You will need to rebase CB:61268 on top of this one in order for the other to compile
--
To view, visit https://review.coreboot.org/c/coreboot/+/61267
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I944dbf04d3ca19df4de224540bee538bff4d1f12
Gerrit-Change-Number: 61267
Gerrit-PatchSet: 2
Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rory Liu <rory.liu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 27 Jan 2022 16:52:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Patrick Georgi.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61427 )
Change subject: libpayload: Refer to vboot source consistently
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61427
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I503c69a593dd68b3a974fbdbb64d7bb25d6c7f63
Gerrit-Change-Number: 61427
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Comment-Date: Thu, 27 Jan 2022 16:49:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Patrick Georgi.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61427 )
Change subject: libpayload: Refer to vboot source consistently
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61427
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I503c69a593dd68b3a974fbdbb64d7bb25d6c7f63
Gerrit-Change-Number: 61427
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Comment-Date: Thu, 27 Jan 2022 16:37:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59257 )
Change subject: util/coreboot-configurator: Add contrib files
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/59257
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9f0193ed28c0842661426204fc88ec00091fbae
Gerrit-Change-Number: 59257
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Thu, 27 Jan 2022 16:17:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment