Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Julius Werner.
mturney mturney has uploaded a new patch set (#13) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/55951 )
Change subject: soc/qualcomm/common/qup: Add support for QUP common driver
......................................................................
soc/qualcomm/common/qup: Add support for QUP common driver
copy existing QUP driver from /soc/qualcomm/sc7180 to common folder.
This QUP common driver provide QUP configurations, GPI and SE
firmware loading and initializations.
BUG=b:182963902
TEST=Validated on qualcomm sc7180 and sc7280 development board.
Signed-off-by: Rajesh Patil <rajpat(a)codeaurora.org>
Change-Id: I95a0fcf97b3b3a6ed26e62b3084feb4a2369cdc9
---
A src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h
R src/soc/qualcomm/common/include/soc/qupv3_config_common.h
A src/soc/qualcomm/common/qup_se_handler.c
R src/soc/qualcomm/common/qupv3_config.c
M src/soc/qualcomm/sc7180/Makefile.inc
M src/soc/qualcomm/sc7180/bootblock.c
M src/soc/qualcomm/sc7180/include/soc/qcom_qup_se.h
M src/soc/qualcomm/sc7180/qcom_qup_se.c
M src/soc/qualcomm/sc7180/qupv3_i2c.c
M src/soc/qualcomm/sc7180/qupv3_spi.c
M src/soc/qualcomm/sc7180/qupv3_uart.c
11 files changed, 763 insertions(+), 608 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/55951/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/55951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95a0fcf97b3b3a6ed26e62b3084feb4a2369cdc9
Gerrit-Change-Number: 55951
Gerrit-PatchSet: 13
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, mturney mturney, Julius Werner.
mturney mturney has uploaded a new patch set (#13) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/55953 )
Change subject: soc/qualcomm/common/spi: Add support for SPI common driver
......................................................................
soc/qualcomm/common/spi: Add support for SPI common driver
This implements qup spi driver for qualcomm chipsets
BUG=b:182963902
TEST=Validated on qualcomm sc7180 and sc7280 development board.
Signed-off-by: Rajesh Patil <rajpat(a)codeaurora.org>
Change-Id: I2f2b25b6661fcd518f70383da0c7788c5269c97b
---
R src/soc/qualcomm/common/include/soc/qupv3_spi_common.h
R src/soc/qualcomm/common/qupv3_spi.c
M src/soc/qualcomm/sc7180/Makefile.inc
3 files changed, 3 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/55953/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/55953
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f2b25b6661fcd518f70383da0c7788c5269c97b
Gerrit-Change-Number: 55953
Gerrit-PatchSet: 13
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Shelley Chen, Sandeep Maheswaram, mturney mturney, Julius Werner.
mturney mturney has uploaded a new patch set (#10) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/56091 )
Change subject: soc/qualcomm/common/usb: Add support for common USB driver
......................................................................
soc/qualcomm/common/usb: Add support for common USB driver
Add common USB driver for qualcomm soc sc7180 and sc7280.
This includes dwc3 controller, qmp ss phy, qusb hs phy and snsp hs phy.
BUG=b:182963902
TEST=Validated USB enumeration on qcom sc7180 and
sc7280 development board
Signed-off-by: Sandeep Maheswaram <sanm(a)codeaurora.org>
Change-Id: I1013ded22855286220cfa747cb25418070fe85a7
---
M src/mainboard/google/trogdor/mainboard.c
M src/mainboard/google/trogdor/romstage.c
M src/soc/qualcomm/common/Kconfig
A src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h
A src/soc/qualcomm/common/include/soc/usb/qusb_phy.h
A src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h
A src/soc/qualcomm/common/include/soc/usb/usb_common.h
A src/soc/qualcomm/common/usb/qmp_usb_phy.c
A src/soc/qualcomm/common/usb/qusb_phy.c
A src/soc/qualcomm/common/usb/snps_usb_phy.c
A src/soc/qualcomm/common/usb/usb.c
M src/soc/qualcomm/sc7180/Kconfig
M src/soc/qualcomm/sc7180/Makefile.inc
D src/soc/qualcomm/sc7180/include/soc/usb.h
D src/soc/qualcomm/sc7180/usb.c
15 files changed, 1,411 insertions(+), 815 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/56091/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/56091
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1013ded22855286220cfa747cb25418070fe85a7
Gerrit-Change-Number: 56091
Gerrit-PatchSet: 10
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Sandeep Maheswaram <sanm(a)codeaurora.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Sandeep Maheswaram <sanm(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Jakub Czapiga, mturney mturney.
mturney mturney has uploaded a new patch set (#3) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/56591 )
Change subject: Revert "util/kconfig: Uprev to Linux 5.13's kconfig"
......................................................................
Revert "util/kconfig: Uprev to Linux 5.13's kconfig"
This reverts commit 53ea1d44f0435ca419de04e275e08b1bd296922c.
Change-Id: I212366a7b56ead9e05bc095cf276776c8f7a2a26
---
M Documentation/getting_started/kconfig.md
M Makefile
M payloads/coreinfo/Makefile
M payloads/libpayload/Makefile
M payloads/libpayload/Makefile.payload
M tests/Makefile.inc
M util/abuild/abuild
D util/kconfig/.gitignore
M util/kconfig/Makefile
M util/kconfig/Makefile.inc
A util/kconfig/POTFILES.in
A util/kconfig/check.sh
M util/kconfig/conf.c
M util/kconfig/confdata.c
M util/kconfig/expr.c
M util/kconfig/expr.h
D util/kconfig/gconf-cfg.sh
M util/kconfig/gconf.c
M util/kconfig/images.c
D util/kconfig/images.h
D util/kconfig/internal.h
A util/kconfig/kxgettext.c
D util/kconfig/lexer.l
M util/kconfig/list.h
M util/kconfig/lkc.h
M util/kconfig/lkc_proto.h
A util/kconfig/lxdialog/.gitignore
A util/kconfig/lxdialog/check-lxdialog.sh
M util/kconfig/lxdialog/checklist.c
M util/kconfig/lxdialog/dialog.h
M util/kconfig/lxdialog/inputbox.c
M util/kconfig/lxdialog/menubox.c
M util/kconfig/lxdialog/textbox.c
M util/kconfig/lxdialog/util.c
M util/kconfig/lxdialog/yesno.c
D util/kconfig/mconf-cfg.sh
M util/kconfig/mconf.c
M util/kconfig/menu.c
D util/kconfig/merge_config.sh
D util/kconfig/nconf-cfg.sh
M util/kconfig/nconf.c
M util/kconfig/nconf.gui.c
M util/kconfig/nconf.h
D util/kconfig/patches/0001-Kconfig-Add-KCONFIG_STRICT-mode.patch
D util/kconfig/patches/0002-Kconfig-Change-symbol-override-from-warning-to-notic.patch
D util/kconfig/patches/0003-util-kconfig-conf.c-Fix-newline-in-error-printf.patch
D util/kconfig/patches/0004-src-util-Use-NULL-instead-of-0-for-pointer.patch
D util/kconfig/patches/0005-util-kconfig-Ignore-extra-symbols-in-configs-instead.patch
D util/kconfig/patches/0006-util-kconfig-Set-parameter-of-mkdir-to-only-one-for-.patch
D util/kconfig/patches/0007-kconfig-Allow-KCONFIG_STRICT-outside-of-confdata.c.patch
D util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch
D util/kconfig/patches/0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch
D util/kconfig/patches/0010-reenable-source-in-choice.patch
D util/kconfig/patches/0011-remove-include-config-hardcodes.patch
D util/kconfig/patches/0012-safer-tmpfiles.patch
D util/kconfig/patches/series
D util/kconfig/preprocess.c
D util/kconfig/qconf-cfg.sh
M util/kconfig/qconf.cc
M util/kconfig/qconf.h
D util/kconfig/streamline_config.pl
M util/kconfig/symbol.c
M util/kconfig/util.c
A util/kconfig/zconf.gperf
A util/kconfig/zconf.hash.c_shipped
A util/kconfig/zconf.l
A util/kconfig/zconf.lex.c_shipped
A util/kconfig/zconf.tab.c_shipped
R util/kconfig/zconf.y
69 files changed, 9,477 insertions(+), 6,411 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/56591/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56591
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I212366a7b56ead9e05bc095cf276776c8f7a2a26
Gerrit-Change-Number: 56591
Gerrit-PatchSet: 3
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56818 )
Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/56818/comment/9fd2a7f6_87fc0c00
PS2, Line 25: spi_speed_offset
Can this be offset be defined as a config item i.e. CONFIG_EFS_SPI_SPEED_OFFSET with default as -1.
Then this offset can be configured for individual SOCs. That way we can avoid SOC specific check here and simplify the logic as:
if (CONFIG_EFS_SPI_SPEED_OFFSET == -1)
return CONFIG_EFS_SPI_SPEED
return read8((uint8_t *)(EVS_ADDRESS + CONFIG_EFS_SPI_SPEED_OFFSET));
--
To view, visit https://review.coreboot.org/c/coreboot/+/56818
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278768e361499919666d07e1dd92d83c2390035e
Gerrit-Change-Number: 56818
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 17:53:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56818 )
Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
haven't checked the details yet, but i do like the approach.
i'd say that it would be good to print that the SPI speed init got skipped in some later point in the boot when the console is available
--
To view, visit https://review.coreboot.org/c/coreboot/+/56818
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278768e361499919666d07e1dd92d83c2390035e
Gerrit-Change-Number: 56818
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 16:18:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56759 )
Change subject: mb/*/jslrvp/dedede: Remove hardcoding of BSP APIC ID
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56759
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I726d70b4ffc35a28a654abbd20c866f1410e1aee
Gerrit-Change-Number: 56759
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Thu, 05 Aug 2021 16:14:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56758 )
Change subject: soc/intel/common/cpu: Handle non-zero BSP APIC ID in init_cpus
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56758
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib14a5c31b3afb0d773284c684bd1994a78b94445
Gerrit-Change-Number: 56758
Gerrit-PatchSet: 9
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 05 Aug 2021 16:14:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Evan Green, Sumeet R Pawnikar, Tao Xia.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56828 )
Change subject: mb/google/dedede/var/storo: Fixed iasl can not run on Dut
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56828
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I524255c79d3c71573d122944da5058389f79d95d
Gerrit-Change-Number: 56828
Gerrit-PatchSet: 1
Gerrit-Owner: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-CC: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Evan Green <evgreen(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 16:10:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment