Attention is currently required from: Kedar J. Karanje, Furquan Shaikh, vagdevi.p(a)intel.com, Tim Wawrzynczak, Subrata Banik, Vinay Kumar, Balaji Manigandan, Kane Chen, Patrick Rudolph, Baieswara Reddy Sagili.
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56325 )
Change subject: soc/intel/alderlake: Configure the SKU specific parameters for VR domains
......................................................................
Patch Set 13:
(2 comments)
File src/soc/intel/alderlake/include/soc/vr_config.h:
https://review.coreboot.org/c/coreboot/+/56325/comment/6ab9792c_aa8a5ba8
PS13, Line 70: void fill_vr_domain_config(FSP_S_CONFIG *s_cfg, int domain, const struct vr_config *cfg);
> need consistent spacing around '*' (ctx:WxV)
Please fix.
File src/soc/intel/alderlake/include/soc/vr_config.h:
https://review.coreboot.org/c/coreboot/+/56325/comment/9bbf21e1_fc3958ad
PS12, Line 24: /* Thermal Design Current (TDC) enable/disable.
: Time window and current limit will take effect when this is set to 1. */
: uint8_t tdc_enable;
> You could do the same thing in the `vr_config_enable` case too (line 89 in vr_config. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56325
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I434fd30b5bce3bfab5a5800a30317aaa04d9926a
Gerrit-Change-Number: 56325
Gerrit-PatchSet: 13
Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Baieswara Reddy Sagili <baieswara.reddy.sagili(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Kedar J. Karanje <kedar.j.karanje(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Vinay Kumar <vinay.kumar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: vagdevi.p(a)intel.com
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kedar J. Karanje <kedar.j.karanje(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: vagdevi.p(a)intel.com
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Vinay Kumar <vinay.kumar(a)intel.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Baieswara Reddy Sagili <baieswara.reddy.sagili(a)intel.com>
Gerrit-Comment-Date: Fri, 06 Aug 2021 08:34:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Furquan Shaikh, Marshall Dawson, Tim Wawrzynczak, Julius Werner, Felix Held.
Hello Lance Zhao, build bot (Jenkins), Jason Glenesk, Furquan Shaikh, Marshall Dawson, Tim Wawrzynczak, Julius Werner, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55502
to look at the new patch set (#7).
Change subject: [RFC,WIP] ChromeOS: Create pseudo-device ACPI NVS
......................................................................
[RFC,WIP] ChromeOS: Create pseudo-device ACPI NVS
Treate allocation and initialisation of ChromeOS related
NVS as a device and move related calls into device-model.
Move the CNVS OperationRegion from \CNVS to \CRHW.CNVS
with local scope reference.
Change-Id: Id79af96bb6c038d273ac9c4afc723437fc1f3fc9
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
M src/acpi/acpi.c
M src/acpi/acpigen_extern.asl
M src/acpi/dsdt_top.asl
M src/include/acpi/acpi.h
M src/lib/hardwaremain.c
M src/mainboard/amd/majolica/mainboard.c
M src/mainboard/google/auron/mainboard.c
M src/mainboard/google/beltino/mainboard.c
M src/mainboard/google/brya/mainboard.c
M src/mainboard/google/butterfly/mainboard.c
M src/mainboard/google/cyan/mainboard.c
M src/mainboard/google/dedede/mainboard.c
M src/mainboard/google/deltaur/mainboard.c
M src/mainboard/google/drallion/ramstage.c
M src/mainboard/google/eve/mainboard.c
M src/mainboard/google/fizz/mainboard.c
M src/mainboard/google/glados/mainboard.c
M src/mainboard/google/guybrush/mainboard.c
M src/mainboard/google/hatch/ramstage.c
M src/mainboard/google/jecht/mainboard.c
M src/mainboard/google/kahlee/mainboard.c
M src/mainboard/google/link/mainboard.c
M src/mainboard/google/mancomb/mainboard.c
M src/mainboard/google/octopus/mainboard.c
M src/mainboard/google/parrot/mainboard.c
M src/mainboard/google/poppy/mainboard.c
M src/mainboard/google/rambi/mainboard.c
M src/mainboard/google/reef/mainboard.c
M src/mainboard/google/sarien/ramstage.c
M src/mainboard/google/slippy/mainboard.c
M src/mainboard/google/stout/mainboard.c
M src/mainboard/google/volteer/mainboard.c
M src/mainboard/google/zork/mainboard.c
M src/mainboard/intel/adlrvp/mainboard.c
M src/mainboard/intel/baskingridge/mainboard.c
M src/mainboard/intel/coffeelake_rvp/mainboard.c
M src/mainboard/intel/emeraldlake2/mainboard.c
M src/mainboard/intel/glkrvp/mainboard.c
M src/mainboard/intel/icelake_rvp/mainboard.c
M src/mainboard/intel/jasperlake_rvp/mainboard.c
M src/mainboard/intel/kblrvp/mainboard.c
M src/mainboard/intel/kunimitsu/mainboard.c
M src/mainboard/intel/shadowmountain/mainboard.c
M src/mainboard/intel/strago/mainboard.c
M src/mainboard/intel/tglrvp/mainboard.c
M src/mainboard/intel/wtm2/mainboard.c
M src/mainboard/samsung/lumpy/mainboard.c
M src/mainboard/samsung/stumpy/mainboard.c
M src/vendorcode/google/chromeos/acpi.c
M src/vendorcode/google/chromeos/acpi/chromeos.asl
M src/vendorcode/google/chromeos/acpi/gnvs.asl
M src/vendorcode/google/chromeos/acpi/ramoops.asl
M src/vendorcode/google/chromeos/chromeos.h
M src/vendorcode/google/chromeos/gnvs.c
M src/vendorcode/google/chromeos/gnvs.h
55 files changed, 46 insertions(+), 156 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/55502/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/55502
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id79af96bb6c038d273ac9c4afc723437fc1f3fc9
Gerrit-Change-Number: 55502
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset