coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: mb/google/brya/variants/gimble: Update GPIO for PP1800 DMIC enable
by Mark Hsieh (Code Review) 10 Aug '21

10 Aug '21

Attention is currently required from: YH Lin, Paul Menzel, Tim Wawrzynczak, Paul Fagerburg, Nick Vaccaro, Zhuohao Lee. Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56889 ) Change subject: mb/google/brya/variants/gimble: Update GPIO for PP1800 DMIC enable ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56889/comment/a27cf309_a5341917 PS1, Line 9: added > Add Updated. -- To view, visit https://review.coreboot.org/c/coreboot/+/56889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0639162e2c3f02f622470fa16c21fe8a067cf7c Gerrit-Change-Number: 56889 Gerrit-PatchSet: 2 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Tue, 10 Aug 2021 08:35:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Update A17 GPIO for USB UFC power
by EricR Lai (Code Review) 10 Aug '21

10 Aug '21

Attention is currently required from: Varshit B Pandya, Maulik V Vaghela, Tim Wawrzynczak. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56882 ) Change subject: mb/google/brya: Update A17 GPIO for USB UFC power ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > It was detected during internal testing Do you want to create an issue for this? And you can open this for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/56882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88c204ec07b1f7511f0d88074e336cfc9116a7d2 Gerrit-Change-Number: 56882 Gerrit-PatchSet: 1 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Tue, 10 Aug 2021 08:26:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit B Pandya <varshit.b.pandya(a)intel.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Update A17 GPIO for USB UFC power
by Varshit B Pandya (Code Review) 10 Aug '21

10 Aug '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak. Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56882 ) Change subject: mb/google/brya: Update A17 GPIO for USB UFC power ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > any bug? It was detected during internal testing -- To view, visit https://review.coreboot.org/c/coreboot/+/56882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88c204ec07b1f7511f0d88074e336cfc9116a7d2 Gerrit-Change-Number: 56882 Gerrit-PatchSet: 1 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Tue, 10 Aug 2021 08:22:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "util/kconfig: Uprev to Linux 5.13's kconfig"
by Yu-Ping Wu (Code Review) 10 Aug '21

10 Aug '21

Attention is currently required from: Ravi kumar, Martin Roth, Jakub Czapiga, mturney mturney. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56591 ) Change subject: Revert "util/kconfig: Uprev to Linux 5.13's kconfig" ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > What is the rationale behind the request to revert this commit? […] Yeah, please explain the reason in the commit message. Or, is this a patch for testing only? -- To view, visit https://review.coreboot.org/c/coreboot/+/56591 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I212366a7b56ead9e05bc095cf276776c8f7a2a26 Gerrit-Change-Number: 56591 Gerrit-PatchSet: 3 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Comment-Date: Tue, 10 Aug 2021 07:40:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Idwer Vollering <vidwer(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/galtic: Add charger throttling function
by Sumeet R Pawnikar (Code Review) 10 Aug '21

10 Aug '21

Attention is currently required from: Henry Sun, Frank Chu, Paul Menzel, Paul F Yang, Karthik Ramasubramanian. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54673 ) Change subject: mb/google/dedede/var/galtic: Add charger throttling function ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e1849551ff051bca591f19f9e40da4c89ab74e7 Gerrit-Change-Number: 54673 Gerrit-PatchSet: 6 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Yang <paul.f.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul F Yang <paul.f.yang(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul F Yang <paul.f.yang(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 10 Aug 2021 07:25:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/galtic: Add charger throttling function
by Paul Yang (Code Review) 10 Aug '21

10 Aug '21

Attention is currently required from: Henry Sun, Frank Chu, Paul Menzel, Paul F Yang, Karthik Ramasubramanian. Paul Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54673 ) Change subject: mb/google/dedede/var/galtic: Add charger throttling function ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Patchset: PS6: Looks good to me. -- To view, visit https://review.coreboot.org/c/coreboot/+/54673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e1849551ff051bca591f19f9e40da4c89ab74e7 Gerrit-Change-Number: 54673 Gerrit-PatchSet: 6 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Yang <paul.f.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul F Yang <paul.f.yang(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul F Yang <paul.f.yang(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 10 Aug 2021 07:20:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
by Zhi7 Li (Code Review) 10 Aug '21

10 Aug '21

Attention is currently required from: Paul Menzel, Weimin Wu, Zhi7 Li. Hello build bot (Jenkins), Henry Sun, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56804 to look at the new patch set (#7). Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR ...................................................................... mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR commit df520855 (soc/intel/jsl: Add disable_external_bypass_vr config) Add fw_config probe for don't stuffing ANPEC APW8738BQBI IC. BUG=b:190727416 BRANCH=dedede TEST=test for enter S0ix and resume normally by powerd_dbus_suspend Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com> Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188 --- M src/mainboard/google/dedede/variants/sasukette/Makefile.inc M src/mainboard/google/dedede/variants/sasukette/overridetree.cb A src/mainboard/google/dedede/variants/sasukette/ramstage.c 3 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/56804/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/56804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188 Gerrit-Change-Number: 56804 Gerrit-PatchSet: 7 Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
by build bot (Jenkins) (Code Review) 10 Aug '21

10 Aug '21

Attention is currently required from: Paul Menzel, Weimin Wu. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56804 ) Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/dedede/variants/sasukette/ramstage.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125955): https://review.coreboot.org/c/coreboot/+/56804/comment/3a3739a1_3983000f PS6, Line 25: #else trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/56804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188 Gerrit-Change-Number: 56804 Gerrit-PatchSet: 6 Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 10 Aug 2021 07:01:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
by Zhi7 Li (Code Review) 10 Aug '21

10 Aug '21

Attention is currently required from: Paul Menzel, Weimin Wu. Hello build bot (Jenkins), Henry Sun, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56804 to look at the new patch set (#6). Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR ...................................................................... mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR commit df520855 (soc/intel/jsl: Add disable_external_bypass_vr config) Add fw_config probe for don't stuffing ANPEC APW8738BQBI IC. BUG=b:190727416 BRANCH=dedede TEST=test for enter S0ix and resume normally by powerd_dbus_suspend Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com> Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188 --- M src/mainboard/google/dedede/variants/sasukette/Makefile.inc M src/mainboard/google/dedede/variants/sasukette/overridetree.cb A src/mainboard/google/dedede/variants/sasukette/ramstage.c 3 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/56804/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/56804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188 Gerrit-Change-Number: 56804 Gerrit-PatchSet: 6 Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ADL: Update c-states in CB
by Shaik Sameeruddin (Code Review) 10 Aug '21

10 Aug '21

Shaik Sameeruddin has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/56890 ) Change subject: ADL: Update c-states in CB ...................................................................... Removed reviewer Tim Wawrzynczak. -- To view, visit https://review.coreboot.org/c/coreboot/+/56890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27e83d56ec0d251078864a20200851fbd8e1de17 Gerrit-Change-Number: 56890 Gerrit-PatchSet: 1 Gerrit-Owner: Shaik Sameeruddin <shaik.sameeruddin(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021